55437 2011-02-28 18:52:28 -0800 [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp 2011-03-01 00:46:43 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 joone webkit-unassigned commit-queue mrobinson xan.lopez oldest_to_newest 359591 0 joone 2011-02-28 18:52:28 -0800 When we create a cairo context through gdk_cairo_create, we need to use RefPtr instead of raw pointer. 359606 1 84174 joone 2011-02-28 19:31:07 -0800 Created attachment 84174 Proposed Patch 359611 2 84174 mrobinson 2011-02-28 19:40:38 -0800 Comment on attachment 84174 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84174&action=review Great. Thanks! > Source/WebKit/gtk/ChangeLog:10 > + Convert use of cairo_t to RefPtr<cairo_t> > + > + [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp > + https://bugs.webkit.org/show_bug.cgi?id=55437 > + > + * webkit/webkitwebview.cpp: I'd move the first description to after webkit/webkitwebview.cpp: 359654 3 84187 joone 2011-02-28 22:06:31 -0800 Created attachment 84187 Updated ChangeLog Thanks, Martin! 359681 4 84187 commit-queue 2011-02-28 23:31:58 -0800 Comment on attachment 84187 Updated ChangeLog Rejecting attachment 84187 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1 Last 500 characters of output: Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 84187 from bug 55437. NOBODY (OOPS!) found in /mnt/git/webkit-commit-queue/Source/WebKit/gtk/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/gtk/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Full output: http://queues.webkit.org/results/8071550 359708 5 84197 joone 2011-03-01 00:26:29 -0800 Created attachment 84197 Updated ChangeLog with reviewer name I missed reviewer name. 359727 6 84197 commit-queue 2011-03-01 00:46:38 -0800 Comment on attachment 84197 Updated ChangeLog with reviewer name Clearing flags on attachment: 84197 Committed r79977: <http://trac.webkit.org/changeset/79977> 359728 7 commit-queue 2011-03-01 00:46:43 -0800 All reviewed patches have been landed. Closing bug. 84174 2011-02-28 19:31:07 -0800 2011-02-28 22:06:31 -0800 Proposed Patch cairo_t.patch text/plain 1371 joone ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCAwODU0NTA1Li4yYjBjNzg5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMDEgIEpvb25lIEh1ciAgPGpvb25lLmh1ckBjb2xsYWJv cmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ29udmVydCB1c2Ugb2YgY2Fpcm9fdCB0byBSZWZQdHI8Y2Fpcm9fdD4KKworICAgICAgICBb R1RLXSBDb252ZXJ0IHVzZSBvZiBjYWlyb190IHRvIFJlZlB0cjxjYWlyb190PiBpbiB3ZWJraXR3 ZWJpZXcuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NTQzNworCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAo d2Via2l0X3dlYl92aWV3X2V4cG9zZV9ldmVudCk6CisKIDIwMTEtMDItMjggIENoYW5nIFNodSAg PGNzaHVAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9T b3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggNGMwMGFjMC4u Nzk2NjVhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZp ZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApA QCAtNzA4LDkgKzcwOCw4IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfZXhwb3Nl X2V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEV4cG9zZSoKICAgICBpZiAoZnJhbWUt PmNvbnRlbnRSZW5kZXJlcigpICYmIGZyYW1lLT52aWV3KCkpIHsKICAgICAgICAgZnJhbWUtPnZp ZXcoKS0+dXBkYXRlTGF5b3V0QW5kU3R5bGVJZk5lZWRlZFJlY3Vyc2l2ZSgpOwogCi0gICAgICAg IGNhaXJvX3QqIGNyID0gZ2RrX2NhaXJvX2NyZWF0ZShldmVudC0+d2luZG93KTsKLSAgICAgICAg R3JhcGhpY3NDb250ZXh0IGN0eChjcik7Ci0gICAgICAgIGNhaXJvX2Rlc3Ryb3koY3IpOworICAg ICAgICBSZWZQdHI8Y2Fpcm9fdD4gY3IgPSBhZG9wdFJlZihnZGtfY2Fpcm9fY3JlYXRlKGV2ZW50 LT53aW5kb3cpKTsKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0IGN0eChjci5nZXQoKSk7CiAgICAg ICAgIGN0eC5zZXRHZGtFeHBvc2VFdmVudChldmVudCk7CiAKICAgICAgICAgaW50IHJlY3RDb3Vu dDsK 84187 2011-02-28 22:06:31 -0800 2011-03-01 00:26:29 -0800 Updated ChangeLog cairo_t.patch text/plain 1362 joone ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCAwODU0NTA1Li4yZmI2ZGMxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMDEgIEpvb25lIEh1ciAgPGpvb25lLmh1ckBjb2xsYWJv cmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gQ29udmVydCB1c2Ugb2YgY2Fpcm9fdCB0byBSZWZQdHI8Y2Fpcm9fdD4gaW4gd2Vi a2l0d2ViaWV3LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTU0MzcKKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDogQ29udmVy dCB1c2Ugb2YgY2Fpcm9fdCB0byBSZWZQdHI8Y2Fpcm9fdD4uCisgICAgICAgICh3ZWJraXRfd2Vi X3ZpZXdfZXhwb3NlX2V2ZW50KTogCisKIDIwMTEtMDItMjggIENoYW5nIFNodSAgPGNzaHVAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggNGMwMGFjMC4uNzk2NjVhOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtNzA4LDkg KzcwOCw4IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfZXhwb3NlX2V2ZW50KEd0 a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEV4cG9zZSoKICAgICBpZiAoZnJhbWUtPmNvbnRlbnRS ZW5kZXJlcigpICYmIGZyYW1lLT52aWV3KCkpIHsKICAgICAgICAgZnJhbWUtPnZpZXcoKS0+dXBk YXRlTGF5b3V0QW5kU3R5bGVJZk5lZWRlZFJlY3Vyc2l2ZSgpOwogCi0gICAgICAgIGNhaXJvX3Qq IGNyID0gZ2RrX2NhaXJvX2NyZWF0ZShldmVudC0+d2luZG93KTsKLSAgICAgICAgR3JhcGhpY3ND b250ZXh0IGN0eChjcik7Ci0gICAgICAgIGNhaXJvX2Rlc3Ryb3koY3IpOworICAgICAgICBSZWZQ dHI8Y2Fpcm9fdD4gY3IgPSBhZG9wdFJlZihnZGtfY2Fpcm9fY3JlYXRlKGV2ZW50LT53aW5kb3cp KTsKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0IGN0eChjci5nZXQoKSk7CiAgICAgICAgIGN0eC5z ZXRHZGtFeHBvc2VFdmVudChldmVudCk7CiAKICAgICAgICAgaW50IHJlY3RDb3VudDsK 84197 2011-03-01 00:26:29 -0800 2011-03-01 00:46:38 -0800 Updated ChangeLog with reviewer name cairo_t.patch text/plain 1363 joone ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCAwODU0NTA1Li5mZDQ0YzAxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMDEgIEpvb25lIEh1ciAgPGpvb25lLmh1ckBjb2xsYWJv cmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgorCisgICAg ICAgIFtHVEtdIENvbnZlcnQgdXNlIG9mIGNhaXJvX3QgdG8gUmVmUHRyPGNhaXJvX3Q+IGluIHdl YmtpdHdlYmlldy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU1NDM3CisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6IENvbnZl cnQgdXNlIG9mIGNhaXJvX3QgdG8gUmVmUHRyPGNhaXJvX3Q+LgorICAgICAgICAod2Via2l0X3dl Yl92aWV3X2V4cG9zZV9ldmVudCk6IAorCiAyMDExLTAyLTI4ICBDaGFuZyBTaHUgIDxjc2h1QHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvU291cmNlL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDRjMDBhYzAuLjc5NjY1YTkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTcwOCw5 ICs3MDgsOCBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0X3dlYl92aWV3X2V4cG9zZV9ldmVudChH dGtXaWRnZXQqIHdpZGdldCwgR2RrRXZlbnRFeHBvc2UqCiAgICAgaWYgKGZyYW1lLT5jb250ZW50 UmVuZGVyZXIoKSAmJiBmcmFtZS0+dmlldygpKSB7CiAgICAgICAgIGZyYW1lLT52aWV3KCktPnVw ZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNpdmUoKTsKIAotICAgICAgICBjYWlyb190 KiBjciA9IGdka19jYWlyb19jcmVhdGUoZXZlbnQtPndpbmRvdyk7Ci0gICAgICAgIEdyYXBoaWNz Q29udGV4dCBjdHgoY3IpOwotICAgICAgICBjYWlyb19kZXN0cm95KGNyKTsKKyAgICAgICAgUmVm UHRyPGNhaXJvX3Q+IGNyID0gYWRvcHRSZWYoZ2RrX2NhaXJvX2NyZWF0ZShldmVudC0+d2luZG93 KSk7CisgICAgICAgIEdyYXBoaWNzQ29udGV4dCBjdHgoY3IuZ2V0KCkpOwogICAgICAgICBjdHgu c2V0R2RrRXhwb3NlRXZlbnQoZXZlbnQpOwogCiAgICAgICAgIGludCByZWN0Q291bnQ7Cg==