55415 2011-02-28 14:58:30 -0800 KURL should expose a referrer property. 2011-02-28 18:11:07 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 24683 1 levin levin abarth darin dglazkov webkit.review.bot oldest_to_newest 359386 0 levin 2011-02-28 14:58:30 -0800 This is done to allow re-use of this algorithm which is currently only in FrameLoader::setOutgoingReferrer. 359390 1 84128 levin 2011-02-28 15:00:00 -0800 Created attachment 84128 Patch 359400 2 84128 darin 2011-02-28 15:11:04 -0800 Comment on attachment 84128 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84128&action=review > Source/WebCore/platform/KURL.cpp:1772 > +KURL KURL::referrer() const I don’t think referrer is the right name for this. A function of this name makes it seem like URLs have referrers, and this returns the referrer of a URL. We could also consider having this return a string rather than a URL. 359405 3 84128 levin 2011-02-28 15:15:04 -0800 Comment on attachment 84128 Patch r- based on Darin's comment. 359417 4 webkit.review.bot 2011-02-28 15:21:46 -0800 Attachment 84128 did not build on chromium: Build output: http://queues.webkit.org/results/8075404 359508 5 84156 levin 2011-02-28 17:01:59 -0800 Created attachment 84156 Patch 359518 6 84156 darin 2011-02-28 17:10:43 -0800 Comment on attachment 84156 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84156&action=review > Source/WebCore/platform/KURL.cpp:1772 > +String KURL::toReferrer() const Certainly better than just referrer. Maybe strippedForUseAsReferrer would be even better even though it’s wordy. 359527 7 levin 2011-02-28 17:19:36 -0800 (In reply to comment #6) > (From update of attachment 84156 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84156&action=review > > > Source/WebCore/platform/KURL.cpp:1772 > > +String KURL::toReferrer() const > > Certainly better than just referrer. Maybe strippedForUseAsReferrer would be even better even though it’s wordy. Best of two: What about toStrippedReferrer vs strippedForUseAsReferrer? I'll go with whatever you think it better. 359534 8 darin 2011-02-28 17:31:47 -0800 (In reply to comment #7) > Best of two: What about toStrippedReferrer vs strippedForUseAsReferrer? > > I'll go with whatever you think it better. Despite using it myself for things like typecasts, I am not big on the “to” prefix, so I think I prefer the “stripped” version I suggested. I wish I liked yours better because I don’t want to be accused of bias ;-) Another way to go is to have it mutate a URL and call it stripForUseAsReferrer. 359544 9 levin 2011-02-28 17:41:00 -0800 (In reply to comment #8) > Despite using it myself for things like typecasts, I am not big on the “to” prefix, ha, I mentally (create, generate) tried a few different names and settled on "to" because it seemed like common WebKit nomenclature. > I wish I liked yours better because I don’t want to be accused of bias ;-) Bias is fine. Mine was simply an attempt to wordsmith a shorter name. (I'm not sure I liked it -- it felt like it may cut out too much.) > Another way to go is to have it mutate a URL and call it stripForUseAsReferrer. I like not mutating KURL, and this method would simply result in more (boilerplate) code at the calling site anyway. I'll go with: strippedForUseAsReferrer Thanks! 359577 10 levin 2011-02-28 18:11:07 -0800 Commited as http://trac.webkit.org/changeset/79956 84128 2011-02-28 15:00:00 -0800 2011-02-28 15:22:21 -0800 Patch bug-55415-20110228145959.patch text/plain 2932 levin U3VidmVyc2lvbiBSZXZpc2lvbjogNzk5MjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNDQyNzI2ZjhhMWVkZWQ2 OWVlNzk4NTA4NWQwNGMwODA3ZWM4MTAzLi5hNDJjOGQ1ZDU4NmU3OWEyYjdhOTQ2NWUxNmFlNmQ2 MmNiMDkwN2ZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDItMjggIERhdmlk IExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEtVUkwgc2hvdWxkIGV4cG9zZSBhIHJlZmVycmVyIHByb3Bl cnR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU0 MTUKKworICAgICAgICBObyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eSBzbyBubyBuZXcgdGVzdHMu CisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RnJhbWVMb2FkZXI6OnNldE91dGdvaW5nUmVmZXJyZXIpOiBSZWZhY3RvciB0byBwdXQgdGhlIG1h am9yaXR5CisgICAgICAgIG9mIGZ1bmN0aW9uYWxpdHkgaW4gS1VSTDo6cmVmZXJyZXIoKSBzbyB0 aGF0IHRoaXMgY29kZSBjYW4gYmUgbW9yZSBlYXNpbHkKKyAgICAgICAgcmV1c2VkLgorICAgICAg ICAqIHBsYXRmb3JtL0tVUkwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6S1VSTDo6cmVmZXJyZXIp OiBDcmVhdGVzIGEgdXJsIHdoaWNoIGlzIHN1aXRhYmxlCisgICAgICAgIHRvIHVzZSBhcyBhIHJl ZmVycmVyLgorICAgICAgICAqIHBsYXRmb3JtL0tVUkwuaDoKKwogMjAxMS0wMi0yOCAgRGVhbiBK YWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJs c29uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggMGZjYmYwYWMzOTcy ZmJiMzc3MDYwOTYzZGNlNWYyY2E1NDMyNWQ2Mi4uNTZlMTZlZTJjZjMwMGZmYTEyMjJkYzk2Mzc4 YjRlNDU5N2EwNjVlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC02 MzQsMTEgKzYzNCw3IEBAIHZvaWQgRnJhbWVMb2FkZXI6OnJlY2VpdmVkRmlyc3REYXRhKCkKIAog dm9pZCBGcmFtZUxvYWRlcjo6c2V0T3V0Z29pbmdSZWZlcnJlcihjb25zdCBLVVJMJiB1cmwpCiB7 Ci0gICAgS1VSTCBvdXRnb2luZ1JlZmVycmVyKHVybCk7Ci0gICAgb3V0Z29pbmdSZWZlcnJlci5z ZXRVc2VyKFN0cmluZygpKTsKLSAgICBvdXRnb2luZ1JlZmVycmVyLnNldFBhc3MoU3RyaW5nKCkp OwotICAgIG91dGdvaW5nUmVmZXJyZXIucmVtb3ZlRnJhZ21lbnRJZGVudGlmaWVyKCk7Ci0gICAg bV9vdXRnb2luZ1JlZmVycmVyID0gb3V0Z29pbmdSZWZlcnJlci5zdHJpbmcoKTsKKyAgICBtX291 dGdvaW5nUmVmZXJyZXIgPSB1cmwucmVmZXJyZXIoKS5zdHJpbmcoKTsKIH0KIAogdm9pZCBGcmFt ZUxvYWRlcjo6ZGlkQmVnaW5Eb2N1bWVudChib29sIGRpc3BhdGNoKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9L VVJMLmNwcAppbmRleCAzNjEzOGZmMzFhNjBjNzI0MmQ2N2VlZGQzZmFkNzUzNmQ4YzQ1NTM0Li41 ZGUzMTNkMDE0ZDRmNzk5ZTZmNWFmNDQ2OWEzMTAyN2IyZWZmMDUwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9LVVJMLmNwcApAQCAtMTc2OSw2ICsxNzY5LDE1IEBAIHZvaWQgS1VSTDo6cHJpbnQoKSBjb25z dAogCiAjZW5kaWYgLy8gIVVTRShHT09HTEVVUkwpCiAKK0tVUkwgS1VSTDo6cmVmZXJyZXIoKSBj b25zdAoreworICAgIEtVUkwgb3V0Z29pbmdSZWZlcnJlcih0aGlzKTsKKyAgICBvdXRnb2luZ1Jl ZmVycmVyLnNldFVzZXIoU3RyaW5nKCkpOworICAgIG91dGdvaW5nUmVmZXJyZXIuc2V0UGFzcyhT dHJpbmcoKSk7CisgICAgb3V0Z29pbmdSZWZlcnJlci5yZW1vdmVGcmFnbWVudElkZW50aWZpZXIo KTsKKyAgICByZXR1cm4gb3V0Z29pbmdSZWZlcnJlcjsKK30KKwogYm9vbCBLVVJMOjppc0xvY2Fs RmlsZSgpIGNvbnN0CiB7CiAgICAgLy8gSW5jbHVkaW5nIGZlZWQgaGVyZSBtaWdodCBiZSBhIGJh ZCBpZGVhIHNpbmNlIGRyYWcgYW5kIGRyb3AgdXNlcyB0aGlzIGNoZWNrCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9L VVJMLmgKaW5kZXggNjFlYTA5NjA3NzZkNDIyOGY5ZDlkNDZjY2EzNGZjMzY0NTE2NDllZi4uZTQ4 ZDAwNGZiN2NmNDQ1MGQwNGUyM2ExNjI0YTU4YzYyYTI2ZDIyOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tV UkwuaApAQCAtOTYsNiArOTYsOCBAQCBwdWJsaWM6CiAgICAgICAgICBjb25zdCB1cmxfcGFyc2U6 OlBhcnNlZCYgcGFyc2VkLCBib29sIGlzVmFsaWQpOwogI2VuZGlmCiAKKyAgICBLVVJMIHJlZmVy cmVyKCkgY29uc3Q7CisKICAgICAvLyBGSVhNRTogVGhlIGFib3ZlIGZ1bmN0aW9ucyBzaG91bGQg YmUgaGFybW9uaXplZCBzbyB0aGF0IHBhc3NpbmcgYQogICAgIC8vIGJhc2Ugb2YgbnVsbCBvciB0 aGUgZW1wdHkgc3RyaW5nIGdpdmVzIHRoZSBzYW1lIHJlc3VsdCBhcyB0aGUKICAgICAvLyBzdGFu ZGFyZCBTdHJpbmcgY29uc3RydWN0b3IuCg== 84156 2011-02-28 17:01:59 -0800 2011-02-28 17:10:43 -0800 Patch bug-55415-20110228170158.patch text/plain 2923 levin U3VidmVyc2lvbiBSZXZpc2lvbjogNzk5MjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNDQyNzI2ZjhhMWVkZWQ2 OWVlNzk4NTA4NWQwNGMwODA3ZWM4MTAzLi5kMTg2NDUwNjBlNDUwMzJmMWJiZDc1MmE4NDU3Mjlj M2YxMjNkODM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDItMjggIERhdmlk IExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEtVUkwgc2hvdWxkIGV4cG9zZSBhIHJlZmVycmVyIHByb3Bl cnR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU0 MTUKKworICAgICAgICBObyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eSBzbyBubyBuZXcgdGVzdHMu CisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RnJhbWVMb2FkZXI6OnNldE91dGdvaW5nUmVmZXJyZXIpOiBSZWZhY3RvciB0byBwdXQgdGhlIG1h am9yaXR5CisgICAgICAgIG9mIGZ1bmN0aW9uYWxpdHkgaW4gS1VSTDo6dG9SZWZlcnJlcigpIHNv IHRoYXQgdGhpcyBjb2RlIGNhbiBiZSBtb3JlIGVhc2lseQorICAgICAgICByZXVzZWQuCisgICAg ICAgICogcGxhdGZvcm0vS1VSTC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpLVVJMOjp0b1JlZmVy cmVyKTogQ29udmVydHMgdGhlIHVybCB0byBhIHN0cmluZyB3aGljaCBpcyBzdWl0YWJsZQorICAg ICAgICBmb3IgdXNlIGFzIGEgcmVmZXJyZXIuCisgICAgICAgICogcGxhdGZvcm0vS1VSTC5oOgor CiAyMDExLTAyLTI4ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBFcmljIENhcmxzb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRnJhbWVMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNw cAppbmRleCAwZmNiZjBhYzM5NzJmYmIzNzcwNjA5NjNkY2U1ZjJjYTU0MzI1ZDYyLi5lODE2Mjcy YmQ1MWQwZTM0MGQzN2JjYmQxMWM1OWQxNzg0ZjYwNGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9G cmFtZUxvYWRlci5jcHAKQEAgLTYzNCwxMSArNjM0LDcgQEAgdm9pZCBGcmFtZUxvYWRlcjo6cmVj ZWl2ZWRGaXJzdERhdGEoKQogCiB2b2lkIEZyYW1lTG9hZGVyOjpzZXRPdXRnb2luZ1JlZmVycmVy KGNvbnN0IEtVUkwmIHVybCkKIHsKLSAgICBLVVJMIG91dGdvaW5nUmVmZXJyZXIodXJsKTsKLSAg ICBvdXRnb2luZ1JlZmVycmVyLnNldFVzZXIoU3RyaW5nKCkpOwotICAgIG91dGdvaW5nUmVmZXJy ZXIuc2V0UGFzcyhTdHJpbmcoKSk7Ci0gICAgb3V0Z29pbmdSZWZlcnJlci5yZW1vdmVGcmFnbWVu dElkZW50aWZpZXIoKTsKLSAgICBtX291dGdvaW5nUmVmZXJyZXIgPSBvdXRnb2luZ1JlZmVycmVy LnN0cmluZygpOworICAgIG1fb3V0Z29pbmdSZWZlcnJlciA9IHVybC50b1JlZmVycmVyKCk7CiB9 CiAKIHZvaWQgRnJhbWVMb2FkZXI6OmRpZEJlZ2luRG9jdW1lbnQoYm9vbCBkaXNwYXRjaCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vS1VSTC5jcHAKaW5kZXggMzYxMzhmZjMxYTYwYzcyNDJkNjdlZWRkM2ZhZDc1 MzZkOGM0NTUzNC4uYjU0YjMyMTAwMGFlZGE5NzMxMGU2MzU1MDg0MTA1YzVhZTI0ZTJlNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKQEAgLTE3NjksNiArMTc2OSwxNSBAQCB2b2lkIEtVUkw6 OnByaW50KCkgY29uc3QKIAogI2VuZGlmIC8vICFVU0UoR09PR0xFVVJMKQogCitTdHJpbmcgS1VS TDo6dG9SZWZlcnJlcigpIGNvbnN0Cit7CisgICAgS1VSTCByZWZlcnJlcigqdGhpcyk7CisgICAg cmVmZXJyZXIuc2V0VXNlcihTdHJpbmcoKSk7CisgICAgcmVmZXJyZXIuc2V0UGFzcyhTdHJpbmco KSk7CisgICAgcmVmZXJyZXIucmVtb3ZlRnJhZ21lbnRJZGVudGlmaWVyKCk7CisgICAgcmV0dXJu IHJlZmVycmVyLnN0cmluZygpOworfQorCiBib29sIEtVUkw6OmlzTG9jYWxGaWxlKCkgY29uc3QK IHsKICAgICAvLyBJbmNsdWRpbmcgZmVlZCBoZXJlIG1pZ2h0IGJlIGEgYmFkIGlkZWEgc2luY2Ug ZHJhZyBhbmQgZHJvcCB1c2VzIHRoaXMgY2hlY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL0tVUkwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuaAppbmRleCA2 MWVhMDk2MDc3NmQ0MjI4ZjlkOWQ0NmNjYTM0ZmMzNjQ1MTY0OWVmLi4xY2QzNWY4YTUxNTJjZDYz NDM4MDE0MDg4MjlmZmJmNmYwOWFhNDAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9LVVJMLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5oCkBAIC05Niw2 ICs5Niw4IEBAIHB1YmxpYzoKICAgICAgICAgIGNvbnN0IHVybF9wYXJzZTo6UGFyc2VkJiBwYXJz ZWQsIGJvb2wgaXNWYWxpZCk7CiAjZW5kaWYKIAorICAgIFN0cmluZyB0b1JlZmVycmVyKCkgY29u c3Q7CisKICAgICAvLyBGSVhNRTogVGhlIGFib3ZlIGZ1bmN0aW9ucyBzaG91bGQgYmUgaGFybW9u aXplZCBzbyB0aGF0IHBhc3NpbmcgYQogICAgIC8vIGJhc2Ugb2YgbnVsbCBvciB0aGUgZW1wdHkg c3RyaW5nIGdpdmVzIHRoZSBzYW1lIHJlc3VsdCBhcyB0aGUKICAgICAvLyBzdGFuZGFyZCBTdHJp bmcgY29uc3RydWN0b3IuCg==