55412 2011-02-28 14:32:22 -0800 Frequent crashes in CFURLCache code on Snow Leopard 2015-04-28 10:48:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=144339 InRadar P1 Normal --- 1 ap ap oldest_to_newest 359357 0 ap 2011-02-28 14:32:22 -0800 We're passing a wrong path when creating an NSURLCache, so it can't initialize an SQL database, and misbehaves. <rdar://problem/9063922> 359368 1 84125 ap 2011-02-28 14:40:30 -0800 Created attachment 84125 proposed fix 359379 2 84125 mitz 2011-02-28 14:50:05 -0800 Comment on attachment 84125 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=84125&action=review > Source/WebKit2/ChangeLog:18 > + like have liked trailing slash). extra “like” > Source/WebKit2/Shared/WebProcessCreationParameters.h:83 > + // FIXME: These should not be merged with CFURLCache counterparts below. not? > Source/WebKit2/UIProcess/mac/WebContextMac.mm:85 > + ASSERT(parameters.nsURLCachePath.data()[strlen(parameters.nsURLCachePath.data()) - 1] != '/'); // Necessary for NSURLCache to find the cache file. Should we assert that strlen(…) is > 0 first? > Source/WebKit2/UIProcess/win/WebContextWin.cpp:68 > + if (parameters.cfURLCachePath[parameters.cfURLCachePath.length() - 1] == '/') and here 359393 3 ap 2011-02-28 15:07:16 -0800 Fixed in http://trac.webkit.org/changeset/79927. Note that there is some controversy around whether it's really OK for CString length to not match strlen. But we already use strlen with -[NSFileManager stringWithFileSystemRepresentation:length:] elsewhere. 84125 2011-02-28 14:40:30 -0800 2011-02-28 14:50:05 -0800 proposed fix CFURLCache.txt text/plain 4922 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5OTIyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDItMjggIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRnJlcXVlbnQgY3Jhc2hlcyBpbiBDRlVSTENhY2hlIGNvZGUg b24gU25vdyBMZW9wYXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NTQxMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTA2MzkyMj4KKworICAgICAg ICBDU3RyaW5nIGlzIGV2aWwsIGl0IGhhcyB0d28gbGVuZ3RocyB3aGljaCBjYW4gYmUgZGlmZmVy ZW50IC0gc3BlY2lmaWNhbGx5LCBmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oKQorICAgICAgICBj cmVhdGVzIGEgc3RyaW5nIHdpdGggbWF4aW11bSBwb3NzaWJsZSBidWZmZXIgc2l6ZS4gQSBwYXRo IHdpdGggZ2FyYmFnZSBhdCB0aGUgZW5kIGNvbmZ1c2VkCisgICAgICAgIENGVVJMQ2FjaGUgaW50 byBjb3JydXB0aW5nIGl0cyBkYXRhIHN0cnVjdHVyZXMuCisKKyAgICAgICAgKiBTaGFyZWQvV2Vi UHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5oOiBBZGRlZCBhIEZJWE1FIGFib3V0IG1lcmdpbmcg TWFjIGFuZCBXaW5kb3dzIGNvZGUuCisgICAgICAgIFRoaXMgcHJvYmxlbSB3b3VsZG4ndCBoYXZl IG9jY3VyZWQgaWYgd2UgZGlkbid0IHVzZSBDU3RyaW5nIGluIHRoZSBmaXJzdCBwbGFjZS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1hYy5tbTogKFdlYktpdDo6V2ViQ29u dGV4dDo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6CisgICAgICAgIEFkZGVkIGFuIGFz c2VydGlvbiBtYXRjaGluZyBXaW5kb3dzIGJlaGF2aW9yIChzZWVtcyBsaWtlbHkgdGhhdCBOU1VS TENhY2hlIGFsc28gd291bGRuJ3QKKyAgICAgICAgbGlrZSBoYXZlIGxpa2VkIHRyYWlsaW5nIHNs YXNoKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy93aW4vV2ViQ29udGV4dFdpbi5jcHA6IChXZWJL aXQ6OldlYkNvbnRleHQ6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MpOgorICAgICAgICBN YWRlIHNsYXNoIHJlbW92YWwgY29uZGl0aW9uYWwgZm9yIHJvYnVzdG5lc3MuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL21hYy9XZWJQcm9jZXNzTWFjLm1tOiAoV2ViS2l0OjpXZWJQcm9jZXNzOjpw bGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzKToKKyAgICAgICAgVXNlIGFjdHVhbCBzdHJpbmcg bGVuZ3RoLCBub3QgQ1N0cmluZzo6bGVuZ3RoKCkuCisKIDIwMTEtMDItMjggIFNhbSBXZWluaWcg IDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBCcmFkeSBFaWRzb24uCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcm9jZXNzQ3JlYXRpb25Q YXJhbWV0ZXJzLmgJKHJldmlzaW9uIDc5NjkzKQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL1dl YlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaAkod29ya2luZyBjb3B5KQpAQCAtNzksMTAgKzc5 LDEyIEBAIHN0cnVjdCBXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzIHsKICAgICBTdHJpbmcg cGFyZW50UHJvY2Vzc05hbWU7CiAKICAgICBwaWRfdCBwcmVzZW50ZXJBcHBsaWNhdGlvblBpZDsK LSAgICBDU3RyaW5nIG5zVVJMQ2FjaGVQYXRoOwogCisgICAgLy8gRklYTUU6IFRoZXNlIHNob3Vs ZCBub3QgYmUgbWVyZ2VkIHdpdGggQ0ZVUkxDYWNoZSBjb3VudGVycGFydHMgYmVsb3cuCisgICAg Q1N0cmluZyBuc1VSTENhY2hlUGF0aDsKICAgICB1aW50NjRfdCBuc1VSTENhY2hlTWVtb3J5Q2Fw YWNpdHk7CiAgICAgdWludDY0X3QgbnNVUkxDYWNoZURpc2tDYXBhY2l0eTsKKwogICAgIENvcmVJ UEM6Ok1hY2hQb3J0IGFjY2VsZXJhdGVkQ29tcG9zaXRpbmdQb3J0OwogCiAgICAgQ1N0cmluZyB1 aVByb2Nlc3NCdW5kbGVSZXNvdXJjZVBhdGg7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvbWFjL1dlYkNvbnRleHRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL21hYy9XZWJDb250ZXh0TWFjLm1tCShyZXZpc2lvbiA3OTY5MykKKysrIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAt ODIsNiArODIsOCBAQCB2b2lkIFdlYkNvbnRleHQ6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByCiAg ICAgcGFyYW1ldGVycy5uc1VSTENhY2hlTWVtb3J5Q2FwYWNpdHkgPSBbdXJsQ2FjaGUgbWVtb3J5 Q2FwYWNpdHldOwogICAgIHBhcmFtZXRlcnMubnNVUkxDYWNoZURpc2tDYXBhY2l0eSA9IFt1cmxD YWNoZSBkaXNrQ2FwYWNpdHldOwogCisgICAgQVNTRVJUKHBhcmFtZXRlcnMubnNVUkxDYWNoZVBh dGguZGF0YSgpW3N0cmxlbihwYXJhbWV0ZXJzLm5zVVJMQ2FjaGVQYXRoLmRhdGEoKSkgLSAxXSAh PSAnLycpOyAvLyBOZWNlc3NhcnkgZm9yIE5TVVJMQ2FjaGUgdG8gZmluZCB0aGUgY2FjaGUgZmls ZS4KKwogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykgJiYgSEFWRShIT1NURURfQ09S RV9BTklNQVRJT04pCiAgICAgbWFjaF9wb3J0X3QgcmVuZGVyU2VydmVyUG9ydCA9IFdLSW5pdGlh bGl6ZVJlbmRlclNlcnZlcigpOwogICAgIGlmIChyZW5kZXJTZXJ2ZXJQb3J0ICE9IE1BQ0hfUE9S VF9OVUxMKQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJDb250ZXh0V2lu LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mvd2luL1dlYkNvbnRl eHRXaW4uY3BwCShyZXZpc2lvbiA3OTY5MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93 aW4vV2ViQ29udGV4dFdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1LDcgKzY1LDggQEAgdm9p ZCBXZWJDb250ZXh0OjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcgogICAgIFJldGFpblB0cjxDRlN0 cmluZ1JlZj4gY2ZVUkxDYWNoZVBhdGgoQWRvcHRDRiwgd2tDb3B5Rm91bmRhdGlvbkNhY2hlRGly ZWN0b3J5KCkpOwogICAgIHBhcmFtZXRlcnMuY2ZVUkxDYWNoZVBhdGggPSBTdHJpbmcoY2ZVUkxD YWNoZVBhdGguZ2V0KCkpOwogICAgIC8vIFJlbW92ZSB0aGUgZW5kaW5nICcvJyAobmVjZXNzYXJ5 IHRvIGhhdmUgQ0ZOZXR3b3JrIGZpbmQgdGhlIENhY2hlIGZpbGUpLgotICAgIHBhcmFtZXRlcnMu Y2ZVUkxDYWNoZVBhdGgucmVtb3ZlKHBhcmFtZXRlcnMuY2ZVUkxDYWNoZVBhdGgubGVuZ3RoKCkg LSAxKTsKKyAgICBpZiAocGFyYW1ldGVycy5jZlVSTENhY2hlUGF0aFtwYXJhbWV0ZXJzLmNmVVJM Q2FjaGVQYXRoLmxlbmd0aCgpIC0gMV0gPT0gJy8nKQorICAgICAgICBwYXJhbWV0ZXJzLmNmVVJM Q2FjaGVQYXRoLnJlbW92ZShwYXJhbWV0ZXJzLmNmVVJMQ2FjaGVQYXRoLmxlbmd0aCgpIC0gMSk7 CiAjZW5kaWYKIH0KIApJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9tYWMvV2ViUHJv Y2Vzc01hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL21hYy9X ZWJQcm9jZXNzTWFjLm1tCShyZXZpc2lvbiA3OTY5MykKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvbWFjL1dlYlByb2Nlc3NNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTE3OSw3ICsxNzks NyBAQCB2b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByCiAgICAgICAgIE5T VUludGVnZXIgY2FjaGVNZW1vcnlDYXBhY2l0eSA9IHBhcmFtZXRlcnMubnNVUkxDYWNoZU1lbW9y eUNhcGFjaXR5OwogICAgICAgICBOU1VJbnRlZ2VyIGNhY2hlRGlza0NhcGFjaXR5ID0gcGFyYW1l dGVycy5uc1VSTENhY2hlRGlza0NhcGFjaXR5OwogCi0gICAgICAgIE5TU3RyaW5nICpuc0NhY2hl UGF0aCA9IFtbTlNGaWxlTWFuYWdlciBkZWZhdWx0TWFuYWdlcl0gc3RyaW5nV2l0aEZpbGVTeXN0 ZW1SZXByZXNlbnRhdGlvbjpwYXJhbWV0ZXJzLm5zVVJMQ2FjaGVQYXRoLmRhdGEoKSBsZW5ndGg6 cGFyYW1ldGVycy5uc1VSTENhY2hlUGF0aC5sZW5ndGgoKV07CisgICAgICAgIE5TU3RyaW5nICpu c0NhY2hlUGF0aCA9IFtbTlNGaWxlTWFuYWdlciBkZWZhdWx0TWFuYWdlcl0gc3RyaW5nV2l0aEZp bGVTeXN0ZW1SZXByZXNlbnRhdGlvbjpwYXJhbWV0ZXJzLm5zVVJMQ2FjaGVQYXRoLmRhdGEoKSBs ZW5ndGg6c3RybGVuKHBhcmFtZXRlcnMubnNVUkxDYWNoZVBhdGguZGF0YSgpKV07CiAgICAgICAg IFJldGFpblB0cjxOU1VSTENhY2hlPiBwYXJlbnRQcm9jZXNzVVJMQ2FjaGUoQWRvcHROUywgW1tO U1VSTENhY2hlIGFsbG9jXSBpbml0V2l0aE1lbW9yeUNhcGFjaXR5OmNhY2hlTWVtb3J5Q2FwYWNp dHkgZGlza0NhcGFjaXR5OmNhY2hlRGlza0NhcGFjaXR5IGRpc2tQYXRoOm5zQ2FjaGVQYXRoXSk7 CiAgICAgICAgIFtOU1VSTENhY2hlIHNldFNoYXJlZFVSTENhY2hlOnBhcmVudFByb2Nlc3NVUkxD YWNoZS5nZXQoKV07CiAgICAgfQo=