55402 2011-02-28 13:20:39 -0800 loaderRunLoop() should use synchronization instead of while loop 2012-10-24 15:40:46 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 psolanki webkit-unassigned ap darin ddkilzer jaepark levin+threading psolanki webkit.review.bot oldest_to_newest 359280 0 psolanki 2011-02-28 13:20:39 -0800 loaderRunLoop() creates a thread and calls sleep in a loop until the thread has started and set the loaderRunLoopObject static variable. We should use a ThreadCondition for signaling instead of a Sleep(10) 745747 1 169508 jaepark 2012-10-18 16:53:08 -0700 Created attachment 169508 Patch 745753 2 webkit.review.bot 2012-10-18 16:57:05 -0700 Attachment 169508 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:52: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 745780 3 169508 psolanki 2012-10-18 17:36:28 -0700 Comment on attachment 169508 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169508&action=review Thanks for working on this bug. I don't think its quite right though. Have you tested on a platform that uses this file i.e. Windows? > Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:73 > - while (!loaderRunLoopObject) { > - // FIXME: <http://webkit.org/b/55402> - loaderRunLoop() should use synchronization instead of while loop > -#if PLATFORM(WIN) > - Sleep(10); > -#else > - struct timespec sleepTime = { 0, 10 * 1000 * 1000 }; > - nanosleep(&sleepTime, 0); > -#endif > - } > + m_threadCondition.wait(); Does this even compile? ThreadCondition::wait() takes a Mutex& as an argument. 745859 4 169528 jaepark 2012-10-18 18:33:13 -0700 Created attachment 169528 Patch 745863 5 jaepark 2012-10-18 18:36:00 -0700 (In reply to comment #3) Thanks for the review. > (From update of attachment 169508 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169508&action=review > > Thanks for working on this bug. I don't think its quite right though. Have you tested on a platform that uses this file i.e. Windows? No, I haven't. But is there a difference in using threading primitives according to the platforms? > > > Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:73 > > - while (!loaderRunLoopObject) { > > - // FIXME: <http://webkit.org/b/55402> - loaderRunLoop() should use synchronization instead of while loop > > -#if PLATFORM(WIN) > > - Sleep(10); > > -#else > > - struct timespec sleepTime = { 0, 10 * 1000 * 1000 }; > > - nanosleep(&sleepTime, 0); > > -#endif > > - } > > + m_threadCondition.wait(); > > Does this even compile? ThreadCondition::wait() takes a Mutex& as an argument. Fixed it. 745864 6 webkit.review.bot 2012-10-18 18:36:18 -0700 Attachment 169528 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:52: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 745921 7 psolanki 2012-10-18 19:58:53 -0700 (In reply to comment #5) > (In reply to comment #3) > Thanks for the review. > > > (From update of attachment 169508 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=169508&action=review > > > > Thanks for working on this bug. I don't think its quite right though. Have you tested on a platform that uses this file i.e. Windows? > No, I haven't. But is there a difference in using threading primitives according to the platforms? I only ask because this file is not compiled on all platforms. It's only compiled on Windows and iOS. So I would have more confidence in the patch if the code compiled and ran on Windows. 745951 8 169528 psolanki 2012-10-18 21:17:52 -0700 Comment on attachment 169528 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169528&action=review > Source/WebCore/platform/network/cf/LoaderRunLoopCF.h:39 > +Mutex m_mutex; > +ThreadCondition m_threadCondition; > + I think you can just make these static variables in LoaderRunLoopCF.cpp. 746112 9 169572 jaepark 2012-10-19 01:23:10 -0700 Created attachment 169572 Patch 746113 10 jaepark 2012-10-19 01:23:49 -0700 (In reply to comment #8) Thank you for your review. > (From update of attachment 169528 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169528&action=review > > > Source/WebCore/platform/network/cf/LoaderRunLoopCF.h:39 > > +Mutex m_mutex; > > +ThreadCondition m_threadCondition; > > + > > I think you can just make these static variables in LoaderRunLoopCF.cpp. Fixed it. 746117 11 webkit.review.bot 2012-10-19 01:25:18 -0700 Attachment 169572 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:54: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 746327 12 169572 ap 2012-10-19 08:42:06 -0700 Comment on attachment 169572 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169572&action=review > Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:41 > +static Mutex mutex; > +static ThreadCondition threadCondition; These have constructors and destructors, and would break Mac build if compiled it. I think that ports that use LoaderRunLoopCF.cpp also don't want that. 746475 13 psolanki 2012-10-19 11:21:10 -0700 (In reply to comment #12) > (From update of attachment 169572 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169572&action=review > > > Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:41 > > +static Mutex mutex; > > +static ThreadCondition threadCondition; > > These have constructors and destructors, and would break Mac build if compiled it. I think that ports that use LoaderRunLoopCF.cpp also don't want that. So is the solution to have static methods that return Mutex/ThreadCondition ? i.e. something like static Mutex& loaderRunLoopMutex() { static Mutex mutex; return mutex; } 746478 14 psolanki 2012-10-19 11:22:26 -0700 (In reply to comment #11) > Attachment 169572 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:54: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. I know this is in code that just moved around but you might as well fix this style error to keep the bot happy. 748461 15 170109 jaepark 2012-10-23 03:47:14 -0700 Created attachment 170109 Patch 748462 16 jaepark 2012-10-23 03:47:53 -0700 (In reply to comment #12) > (From update of attachment 169572 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169572&action=review > > > Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:41 > > +static Mutex mutex; > > +static ThreadCondition threadCondition; > > These have constructors and destructors, and would break Mac build if compiled it. I think that ports that use LoaderRunLoopCF.cpp also don't want that. Thanks for the review. I uploaded a new patch. Would this prevent the build break? 748463 17 jaepark 2012-10-23 03:48:17 -0700 (In reply to comment #14) > (In reply to comment #11) > > Attachment 169572 [details] [details] did not pass style-queue: > > > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > > Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:54: Use 0 or null instead of NULL (even in *comments*). [readability/null] [4] > > Total errors found: 1 in 2 files > > > > > > If any of these errors are false positives, please file a bug against check-webkit-style. > > I know this is in code that just moved around but you might as well fix this style error to keep the bot happy. Thanks for the review. I fixed it in the new patch. 749990 18 170109 psolanki 2012-10-24 13:39:36 -0700 Comment on attachment 170109 Patch This looks good to me, though I am not a reviewer so I can't r+. 750090 19 170109 webkit.review.bot 2012-10-24 15:05:40 -0700 Comment on attachment 170109 Patch Rejecting attachment 170109 from commit-queue. jae.park@company100.net does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 750133 20 170109 webkit.review.bot 2012-10-24 15:40:41 -0700 Comment on attachment 170109 Patch Clearing flags on attachment: 170109 Committed r132412: <http://trac.webkit.org/changeset/132412> 750134 21 webkit.review.bot 2012-10-24 15:40:46 -0700 All reviewed patches have been landed. Closing bug. 169508 2012-10-18 16:53:08 -0700 2012-10-18 18:33:09 -0700 Patch bug-55402-20121019085221.patch text/plain 3600 jaepark U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI5NTYxYmVlYjczYjRj ZGNlY2ZmMDFmZTIyNzExNzJjNzQ1ODQ1NS4uZDliYjZhZDM5NWMzMGViNzEwYTJjMjYyYzhmMjFk MzM1ZWJjZGY4MiAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTE4ICBKYWUg SHl1biBQYXJrICA8amFlLnBhcmtAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgbG9hZGVyUnVu TG9vcCgpIHNob3VsZCB1c2Ugc3luY2hyb25pemF0aW9uIGluc3RlYWQgb2Ygd2hpbGUgbG9vcAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU0MDIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPcmlnaW5hbGx5 LCBsb2FkZXJSdW5Mb29wKCkgc2xlZXBzIHVudGlsIGEgdGhyZWFkIGhhcyBzdGFydGVkIGFuZCBz ZXQKKyAgICAgICAgdGhlIGxvYWRlclJ1bkxvb3BPYmplY3Qgc3RhdGljIHZhcmlhYmxlLiBUaGlz IHBhdGNoIHVzZXMKKyAgICAgICAgVGhyZWFkQ29uZGl0aW9uIHRvIHN5bmNocm9uaXplIGluc3Rl YWQgb2YgYSB3aGlsZSBsb29wLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoTm8gYmVoYXZpb3Ig Y2hhbmdlKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENG LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJ1bkxvYWRlclRocmVhZCk6CisgICAgICAgIChXZWJD b3JlOjpsb2FkZXJSdW5Mb29wKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL0xvYWRl clJ1bkxvb3BDRi5oOgorICAgICAgICAoV2ViQ29yZSk6CisKIDIwMTItMTAtMTggIENsYXVkaW8g U2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBJbnZhbGlk IHJlYWQgZnJvbSBXZWJLaXQ6OkRPTU9iamVjdENhY2hlOjpjbGVhckJ5RnJhbWUKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENGLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENGLmNw cAppbmRleCAzMDg4ZWI0YzgyMzQzZDkxM2IwMGNkN2U5YjA4MDBhOWYyZjg5NmIzLi4yNmViZTY2 ZGI5YjU1M2M0MThiNzM4ZDQ1OTIxNzI4ZWI2NGIzNjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0xvYWRlclJ1bkxvb3BDRi5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Mb2FkZXJSdW5Mb29wQ0YuY3BwCkBAIC00NCwx MiArNDQsMTcgQEAgc3RhdGljIHZvaWQgZW1wdHlQZXJmb3JtKHZvaWQqKQogCiBzdGF0aWMgdm9p ZCBydW5Mb2FkZXJUaHJlYWQodm9pZCopCiB7Ci0gICAgbG9hZGVyUnVuTG9vcE9iamVjdCA9IENG UnVuTG9vcEdldEN1cnJlbnQoKTsKKyAgICB7CisgICAgICAgIE11dGV4TG9ja2VyIGxvY2sobV9t dXRleCk7CisgICAgICAgIGxvYWRlclJ1bkxvb3BPYmplY3QgPSBDRlJ1bkxvb3BHZXRDdXJyZW50 KCk7CiAKLSAgICAvLyBNdXN0IGFkZCBhIHNvdXJjZSB0byB0aGUgcnVuIGxvb3AgdG8gcHJldmVu dCBDRlJ1bkxvb3BSdW4oKSBmcm9tIGV4aXRpbmcuCi0gICAgQ0ZSdW5Mb29wU291cmNlQ29udGV4 dCBjdHh0ID0gezAsICh2b2lkKikxIC8qbXVzdCBiZSBub24tTlVMTCovLCAwLCAwLCAwLCAwLCAw LCAwLCAwLCBlbXB0eVBlcmZvcm19OwotICAgIENGUnVuTG9vcFNvdXJjZVJlZiBib2d1c1NvdXJj ZSA9IENGUnVuTG9vcFNvdXJjZUNyZWF0ZSgwLCAwLCAmY3R4dCk7Ci0gICAgQ0ZSdW5Mb29wQWRk U291cmNlKGxvYWRlclJ1bkxvb3BPYmplY3QsIGJvZ3VzU291cmNlLCBrQ0ZSdW5Mb29wRGVmYXVs dE1vZGUpOworICAgICAgICAvLyBNdXN0IGFkZCBhIHNvdXJjZSB0byB0aGUgcnVuIGxvb3AgdG8g cHJldmVudCBDRlJ1bkxvb3BSdW4oKSBmcm9tIGV4aXRpbmcuCisgICAgICAgIENGUnVuTG9vcFNv dXJjZUNvbnRleHQgY3R4dCA9IHswLCAodm9pZCopMSAvKm11c3QgYmUgbm9uLU5VTEwqLywgMCwg MCwgMCwgMCwgMCwgMCwgMCwgZW1wdHlQZXJmb3JtfTsKKyAgICAgICAgQ0ZSdW5Mb29wU291cmNl UmVmIGJvZ3VzU291cmNlID0gQ0ZSdW5Mb29wU291cmNlQ3JlYXRlKDAsIDAsICZjdHh0KTsKKyAg ICAgICAgQ0ZSdW5Mb29wQWRkU291cmNlKGxvYWRlclJ1bkxvb3BPYmplY3QsIGJvZ3VzU291cmNl LCBrQ0ZSdW5Mb29wRGVmYXVsdE1vZGUpOworCisgICAgICAgIG1fdGhyZWFkQ29uZGl0aW9uLnNp Z25hbCgpOworICAgIH0KIAogICAgIFNJbnQzMiByZXN1bHQ7CiAgICAgZG8gewpAQCAtNjEsMTcg KzY2LDExIEBAIHN0YXRpYyB2b2lkIHJ1bkxvYWRlclRocmVhZCh2b2lkKikKIENGUnVuTG9vcFJl ZiBsb2FkZXJSdW5Mb29wKCkKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOworCisgICAg TXV0ZXhMb2NrZXIgbG9jayhtX211dGV4KTsKICAgICBpZiAoIWxvYWRlclJ1bkxvb3BPYmplY3Qp IHsKICAgICAgICAgY3JlYXRlVGhyZWFkKHJ1bkxvYWRlclRocmVhZCwgMCwgIldlYkNvcmU6IENG TmV0d29yayBMb2FkZXIiKTsKLSAgICAgICAgd2hpbGUgKCFsb2FkZXJSdW5Mb29wT2JqZWN0KSB7 Ci0gICAgICAgICAgICAvLyBGSVhNRTogPGh0dHA6Ly93ZWJraXQub3JnL2IvNTU0MDI+IC0gbG9h ZGVyUnVuTG9vcCgpIHNob3VsZCB1c2Ugc3luY2hyb25pemF0aW9uIGluc3RlYWQgb2Ygd2hpbGUg bG9vcAotI2lmIFBMQVRGT1JNKFdJTikKLSAgICAgICAgICAgIFNsZWVwKDEwKTsKLSNlbHNlCi0g ICAgICAgICAgICBzdHJ1Y3QgdGltZXNwZWMgc2xlZXBUaW1lID0geyAwLCAxMCAqIDEwMDAgKiAx MDAwIH07Ci0gICAgICAgICAgICBuYW5vc2xlZXAoJnNsZWVwVGltZSwgMCk7Ci0jZW5kaWYKLSAg ICAgICAgfQorICAgICAgICBtX3RocmVhZENvbmRpdGlvbi53YWl0KCk7CiAgICAgfQogICAgIHJl dHVybiBsb2FkZXJSdW5Mb29wT2JqZWN0OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jZi9Mb2FkZXJSdW5Mb29wQ0YuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENGLmgKaW5kZXggNjdkZTU2YTJmZjA2NWVi MzhjZjFlN2NlMjg0OTJkNTYyNWJjZjUyMS4uZjExOWJkYzA5NjUyZWFkZTQyODA2ZTZkN2FhZTQ2 ZDhhOGRiNTUyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j Zi9Mb2FkZXJSdW5Mb29wQ0YuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2NmL0xvYWRlclJ1bkxvb3BDRi5oCkBAIC0zNCw2ICszNCw5IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogQ0ZSdW5Mb29wUmVmIGxvYWRlclJ1bkxvb3AoKTsKIAorTXV0ZXggbV9tdXRleDsKK1Ro cmVhZENvbmRpdGlvbiBtX3RocmVhZENvbmRpdGlvbjsKKwogfQogCiAjZW5kaWYgLy8gVVNFKENG TkVUV09SSykK 169528 2012-10-18 18:33:13 -0700 2012-10-19 01:23:06 -0700 Patch bug-55402-20121019103227.patch text/plain 3658 jaepark U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjRkOTk3NDcyOTMxYzMy ZmJiYWMwZmJmZjM1MDI4OTU1MmE3MDJkYi4uY2EyMzI4NDJjNGRhOWUxNDU0NzQ3ZDcxMWNlNDQ3 MWYyNDAwYjc2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTE4ICBKYWUg SHl1biBQYXJrICA8amFlLnBhcmtAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgbG9hZGVyUnVu TG9vcCgpIHNob3VsZCB1c2Ugc3luY2hyb25pemF0aW9uIGluc3RlYWQgb2Ygd2hpbGUgbG9vcAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU0MDIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPcmlnaW5hbGx5 LCBsb2FkZXJSdW5Mb29wKCkgc2xlZXBzIHVudGlsIGEgdGhyZWFkIGhhcyBzdGFydGVkIGFuZCBz ZXQKKyAgICAgICAgdGhlIGxvYWRlclJ1bkxvb3BPYmplY3Qgc3RhdGljIHZhcmlhYmxlLiBUaGlz IHBhdGNoIHVzZXMKKyAgICAgICAgVGhyZWFkQ29uZGl0aW9uIHRvIHN5bmNocm9uaXplIGluc3Rl YWQgb2YgYSB3aGlsZSBsb29wLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoTm8gYmVoYXZpb3Ig Y2hhbmdlKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENG LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJ1bkxvYWRlclRocmVhZCk6CisgICAgICAgIChXZWJD b3JlOjpsb2FkZXJSdW5Mb29wKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL0xvYWRl clJ1bkxvb3BDRi5oOgorICAgICAgICAoV2ViQ29yZSk6CisKIDIwMTItMTAtMTggIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQ3Jhc2hlcyBpbiBX ZWJQcm9jZXNzIGF0IGNvbS5hcHBsZS5XZWJDb3JlOiAtW0FjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVyIHJlbW90ZUFjY2Vzc2liaWxpdHlQYXJlbnRPYmplY3RdICsgNzgKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENGLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENGLmNwcAppbmRl eCAzMDg4ZWI0YzgyMzQzZDkxM2IwMGNkN2U5YjA4MDBhOWYyZjg5NmIzLi41YmZkMzE1MGQ1YmIx MGE5YjZmZTVhYmU0OTI3Y2EzYmZkZTA3MTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2NmL0xvYWRlclJ1bkxvb3BDRi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9jZi9Mb2FkZXJSdW5Mb29wQ0YuY3BwCkBAIC00NCwxMiArNDQs MTcgQEAgc3RhdGljIHZvaWQgZW1wdHlQZXJmb3JtKHZvaWQqKQogCiBzdGF0aWMgdm9pZCBydW5M b2FkZXJUaHJlYWQodm9pZCopCiB7Ci0gICAgbG9hZGVyUnVuTG9vcE9iamVjdCA9IENGUnVuTG9v cEdldEN1cnJlbnQoKTsKKyAgICB7CisgICAgICAgIE11dGV4TG9ja2VyIGxvY2sobV9tdXRleCk7 CisgICAgICAgIGxvYWRlclJ1bkxvb3BPYmplY3QgPSBDRlJ1bkxvb3BHZXRDdXJyZW50KCk7CiAK LSAgICAvLyBNdXN0IGFkZCBhIHNvdXJjZSB0byB0aGUgcnVuIGxvb3AgdG8gcHJldmVudCBDRlJ1 bkxvb3BSdW4oKSBmcm9tIGV4aXRpbmcuCi0gICAgQ0ZSdW5Mb29wU291cmNlQ29udGV4dCBjdHh0 ID0gezAsICh2b2lkKikxIC8qbXVzdCBiZSBub24tTlVMTCovLCAwLCAwLCAwLCAwLCAwLCAwLCAw LCBlbXB0eVBlcmZvcm19OwotICAgIENGUnVuTG9vcFNvdXJjZVJlZiBib2d1c1NvdXJjZSA9IENG UnVuTG9vcFNvdXJjZUNyZWF0ZSgwLCAwLCAmY3R4dCk7Ci0gICAgQ0ZSdW5Mb29wQWRkU291cmNl KGxvYWRlclJ1bkxvb3BPYmplY3QsIGJvZ3VzU291cmNlLCBrQ0ZSdW5Mb29wRGVmYXVsdE1vZGUp OworICAgICAgICAvLyBNdXN0IGFkZCBhIHNvdXJjZSB0byB0aGUgcnVuIGxvb3AgdG8gcHJldmVu dCBDRlJ1bkxvb3BSdW4oKSBmcm9tIGV4aXRpbmcuCisgICAgICAgIENGUnVuTG9vcFNvdXJjZUNv bnRleHQgY3R4dCA9IHswLCAodm9pZCopMSAvKm11c3QgYmUgbm9uLU5VTEwqLywgMCwgMCwgMCwg MCwgMCwgMCwgMCwgZW1wdHlQZXJmb3JtfTsKKyAgICAgICAgQ0ZSdW5Mb29wU291cmNlUmVmIGJv Z3VzU291cmNlID0gQ0ZSdW5Mb29wU291cmNlQ3JlYXRlKDAsIDAsICZjdHh0KTsKKyAgICAgICAg Q0ZSdW5Mb29wQWRkU291cmNlKGxvYWRlclJ1bkxvb3BPYmplY3QsIGJvZ3VzU291cmNlLCBrQ0ZS dW5Mb29wRGVmYXVsdE1vZGUpOworCisgICAgICAgIG1fdGhyZWFkQ29uZGl0aW9uLnNpZ25hbCgp OworICAgIH0KIAogICAgIFNJbnQzMiByZXN1bHQ7CiAgICAgZG8gewpAQCAtNjEsMTcgKzY2LDEx IEBAIHN0YXRpYyB2b2lkIHJ1bkxvYWRlclRocmVhZCh2b2lkKikKIENGUnVuTG9vcFJlZiBsb2Fk ZXJSdW5Mb29wKCkKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOworCisgICAgTXV0ZXhM b2NrZXIgbG9jayhtX211dGV4KTsKICAgICBpZiAoIWxvYWRlclJ1bkxvb3BPYmplY3QpIHsKICAg ICAgICAgY3JlYXRlVGhyZWFkKHJ1bkxvYWRlclRocmVhZCwgMCwgIldlYkNvcmU6IENGTmV0d29y ayBMb2FkZXIiKTsKLSAgICAgICAgd2hpbGUgKCFsb2FkZXJSdW5Mb29wT2JqZWN0KSB7Ci0gICAg ICAgICAgICAvLyBGSVhNRTogPGh0dHA6Ly93ZWJraXQub3JnL2IvNTU0MDI+IC0gbG9hZGVyUnVu TG9vcCgpIHNob3VsZCB1c2Ugc3luY2hyb25pemF0aW9uIGluc3RlYWQgb2Ygd2hpbGUgbG9vcAot I2lmIFBMQVRGT1JNKFdJTikKLSAgICAgICAgICAgIFNsZWVwKDEwKTsKLSNlbHNlCi0gICAgICAg ICAgICBzdHJ1Y3QgdGltZXNwZWMgc2xlZXBUaW1lID0geyAwLCAxMCAqIDEwMDAgKiAxMDAwIH07 Ci0gICAgICAgICAgICBuYW5vc2xlZXAoJnNsZWVwVGltZSwgMCk7Ci0jZW5kaWYKLSAgICAgICAg fQorICAgICAgICBtX3RocmVhZENvbmRpdGlvbi53YWl0KG1fbXV0ZXgpOwogICAgIH0KICAgICBy ZXR1cm4gbG9hZGVyUnVuTG9vcE9iamVjdDsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENGLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2NmL0xvYWRlclJ1bkxvb3BDRi5oCmluZGV4IDY3ZGU1NmEyZmYwNjVl YjM4Y2YxZTdjZTI4NDkyZDU2MjViY2Y1MjEuLmYxMTliZGMwOTY1MmVhZGU0MjgwNmU2ZDdhYWU0 NmQ4YThkYjU1MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y2YvTG9hZGVyUnVuTG9vcENGLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jZi9Mb2FkZXJSdW5Mb29wQ0YuaApAQCAtMzQsNiArMzQsOSBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKIENGUnVuTG9vcFJlZiBsb2FkZXJSdW5Mb29wKCk7CiAKK011dGV4IG1fbXV0ZXg7CitU aHJlYWRDb25kaXRpb24gbV90aHJlYWRDb25kaXRpb247CisKIH0KIAogI2VuZGlmIC8vIFVTRShD Rk5FVFdPUkspCg== 169572 2012-10-19 01:23:10 -0700 2012-10-23 03:47:09 -0700 Patch bug-55402-20121019172225.patch text/plain 3343 jaepark U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjRkOTk3NDcyOTMxYzMy ZmJiYWMwZmJmZjM1MDI4OTU1MmE3MDJkYi4uY2EyMzI4NDJjNGRhOWUxNDU0NzQ3ZDcxMWNlNDQ3 MWYyNDAwYjc2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTE4ICBKYWUg SHl1biBQYXJrICA8amFlLnBhcmtAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgbG9hZGVyUnVu TG9vcCgpIHNob3VsZCB1c2Ugc3luY2hyb25pemF0aW9uIGluc3RlYWQgb2Ygd2hpbGUgbG9vcAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU0MDIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPcmlnaW5hbGx5 LCBsb2FkZXJSdW5Mb29wKCkgc2xlZXBzIHVudGlsIGEgdGhyZWFkIGhhcyBzdGFydGVkIGFuZCBz ZXQKKyAgICAgICAgdGhlIGxvYWRlclJ1bkxvb3BPYmplY3Qgc3RhdGljIHZhcmlhYmxlLiBUaGlz IHBhdGNoIHVzZXMKKyAgICAgICAgVGhyZWFkQ29uZGl0aW9uIHRvIHN5bmNocm9uaXplIGluc3Rl YWQgb2YgYSB3aGlsZSBsb29wLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoTm8gYmVoYXZpb3Ig Y2hhbmdlKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENG LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJ1bkxvYWRlclRocmVhZCk6CisgICAgICAgIChXZWJD b3JlOjpsb2FkZXJSdW5Mb29wKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL0xvYWRl clJ1bkxvb3BDRi5oOgorICAgICAgICAoV2ViQ29yZSk6CisKIDIwMTItMTAtMTggIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQ3Jhc2hlcyBpbiBX ZWJQcm9jZXNzIGF0IGNvbS5hcHBsZS5XZWJDb3JlOiAtW0FjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVyIHJlbW90ZUFjY2Vzc2liaWxpdHlQYXJlbnRPYmplY3RdICsgNzgKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENGLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENGLmNwcAppbmRl eCAzMDg4ZWI0YzgyMzQzZDkxM2IwMGNkN2U5YjA4MDBhOWYyZjg5NmIzLi42YmZmMWMyZWU4M2Y3 NjVmMzRjNTk2NDAzNjFlOTM2YmYxMTk2NWU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2NmL0xvYWRlclJ1bkxvb3BDRi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9jZi9Mb2FkZXJSdW5Mb29wQ0YuY3BwCkBAIC0zNyw2ICszNyw4 IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHN0YXRpYyBDRlJ1bkxvb3BSZWYgbG9hZGVyUnVu TG9vcE9iamVjdCA9IDA7CitzdGF0aWMgTXV0ZXggbXV0ZXg7CitzdGF0aWMgVGhyZWFkQ29uZGl0 aW9uIHRocmVhZENvbmRpdGlvbjsKIAogc3RhdGljIHZvaWQgZW1wdHlQZXJmb3JtKHZvaWQqKSAK IHsKQEAgLTQ0LDEyICs0NiwxNyBAQCBzdGF0aWMgdm9pZCBlbXB0eVBlcmZvcm0odm9pZCopCiAK IHN0YXRpYyB2b2lkIHJ1bkxvYWRlclRocmVhZCh2b2lkKikKIHsKLSAgICBsb2FkZXJSdW5Mb29w T2JqZWN0ID0gQ0ZSdW5Mb29wR2V0Q3VycmVudCgpOworICAgIHsKKyAgICAgICAgTXV0ZXhMb2Nr ZXIgbG9jayhtdXRleCk7CisgICAgICAgIGxvYWRlclJ1bkxvb3BPYmplY3QgPSBDRlJ1bkxvb3BH ZXRDdXJyZW50KCk7CiAKLSAgICAvLyBNdXN0IGFkZCBhIHNvdXJjZSB0byB0aGUgcnVuIGxvb3Ag dG8gcHJldmVudCBDRlJ1bkxvb3BSdW4oKSBmcm9tIGV4aXRpbmcuCi0gICAgQ0ZSdW5Mb29wU291 cmNlQ29udGV4dCBjdHh0ID0gezAsICh2b2lkKikxIC8qbXVzdCBiZSBub24tTlVMTCovLCAwLCAw LCAwLCAwLCAwLCAwLCAwLCBlbXB0eVBlcmZvcm19OwotICAgIENGUnVuTG9vcFNvdXJjZVJlZiBi b2d1c1NvdXJjZSA9IENGUnVuTG9vcFNvdXJjZUNyZWF0ZSgwLCAwLCAmY3R4dCk7Ci0gICAgQ0ZS dW5Mb29wQWRkU291cmNlKGxvYWRlclJ1bkxvb3BPYmplY3QsIGJvZ3VzU291cmNlLCBrQ0ZSdW5M b29wRGVmYXVsdE1vZGUpOworICAgICAgICAvLyBNdXN0IGFkZCBhIHNvdXJjZSB0byB0aGUgcnVu IGxvb3AgdG8gcHJldmVudCBDRlJ1bkxvb3BSdW4oKSBmcm9tIGV4aXRpbmcuCisgICAgICAgIENG UnVuTG9vcFNvdXJjZUNvbnRleHQgY3R4dCA9IHswLCAodm9pZCopMSAvKm11c3QgYmUgbm9uLU5V TEwqLywgMCwgMCwgMCwgMCwgMCwgMCwgMCwgZW1wdHlQZXJmb3JtfTsKKyAgICAgICAgQ0ZSdW5M b29wU291cmNlUmVmIGJvZ3VzU291cmNlID0gQ0ZSdW5Mb29wU291cmNlQ3JlYXRlKDAsIDAsICZj dHh0KTsKKyAgICAgICAgQ0ZSdW5Mb29wQWRkU291cmNlKGxvYWRlclJ1bkxvb3BPYmplY3QsIGJv Z3VzU291cmNlLCBrQ0ZSdW5Mb29wRGVmYXVsdE1vZGUpOworCisgICAgICAgIHRocmVhZENvbmRp dGlvbi5zaWduYWwoKTsKKyAgICB9CiAKICAgICBTSW50MzIgcmVzdWx0OwogICAgIGRvIHsKQEAg LTYxLDE3ICs2OCwxMSBAQCBzdGF0aWMgdm9pZCBydW5Mb2FkZXJUaHJlYWQodm9pZCopCiBDRlJ1 bkxvb3BSZWYgbG9hZGVyUnVuTG9vcCgpCiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsK KworICAgIE11dGV4TG9ja2VyIGxvY2sobXV0ZXgpOwogICAgIGlmICghbG9hZGVyUnVuTG9vcE9i amVjdCkgewogICAgICAgICBjcmVhdGVUaHJlYWQocnVuTG9hZGVyVGhyZWFkLCAwLCAiV2ViQ29y ZTogQ0ZOZXR3b3JrIExvYWRlciIpOwotICAgICAgICB3aGlsZSAoIWxvYWRlclJ1bkxvb3BPYmpl Y3QpIHsKLSAgICAgICAgICAgIC8vIEZJWE1FOiA8aHR0cDovL3dlYmtpdC5vcmcvYi81NTQwMj4g LSBsb2FkZXJSdW5Mb29wKCkgc2hvdWxkIHVzZSBzeW5jaHJvbml6YXRpb24gaW5zdGVhZCBvZiB3 aGlsZSBsb29wCi0jaWYgUExBVEZPUk0oV0lOKQotICAgICAgICAgICAgU2xlZXAoMTApOwotI2Vs c2UKLSAgICAgICAgICAgIHN0cnVjdCB0aW1lc3BlYyBzbGVlcFRpbWUgPSB7IDAsIDEwICogMTAw MCAqIDEwMDAgfTsKLSAgICAgICAgICAgIG5hbm9zbGVlcCgmc2xlZXBUaW1lLCAwKTsKLSNlbmRp ZgotICAgICAgICB9CisgICAgICAgIHRocmVhZENvbmRpdGlvbi53YWl0KG11dGV4KTsKICAgICB9 CiAgICAgcmV0dXJuIGxvYWRlclJ1bkxvb3BPYmplY3Q7CiB9Cg== 170109 2012-10-23 03:47:14 -0700 2012-10-24 15:40:41 -0700 Patch bug-55402-20121023194642.patch text/plain 3475 jaepark U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjkyNjBkZWEzMGQwZGEy NjA2ZjNkNmM4YjQxN2VhMjAzZDdjOGUzMi4uN2QwOGRmNzJmMWIzNTVhNTBhODkxOGE3YzY3NDE2 M2YyMWJiMWJhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTIzICBKYWUg SHl1biBQYXJrICA8amFlLnBhcmtAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgbG9hZGVyUnVu TG9vcCgpIHNob3VsZCB1c2Ugc3luY2hyb25pemF0aW9uIGluc3RlYWQgb2Ygd2hpbGUgbG9vcAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTU0MDIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPcmlnaW5hbGx5 LCBsb2FkZXJSdW5Mb29wKCkgc2xlZXBzIHVudGlsIGEgdGhyZWFkIGhhcyBzdGFydGVkIGFuZCBz ZXQKKyAgICAgICAgdGhlIGxvYWRlclJ1bkxvb3BPYmplY3Qgc3RhdGljIHZhcmlhYmxlLiBUaGlz IHBhdGNoIHVzZXMKKyAgICAgICAgVGhyZWFkQ29uZGl0aW9uIHRvIHN5bmNocm9uaXplIGluc3Rl YWQgb2YgYSB3aGlsZSBsb29wLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoTm8gYmVoYXZpb3Ig Y2hhbmdlKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvTG9hZGVyUnVuTG9vcENG LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJ1bkxvYWRlclRocmVhZCk6CisgICAgICAgIChXZWJD b3JlOjpsb2FkZXJSdW5Mb29wKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL0xvYWRl clJ1bkxvb3BDRi5oOgorICAgICAgICAoV2ViQ29yZSk6CisKIDIwMTItMTAtMjMgIEtlbnQgVGFt dXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVwZGF0ZSBiaW5kaW5nIHRlc3Qg cmVzdWx0cyBmb3IgcjEzMjE5NApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jZi9Mb2FkZXJSdW5Mb29wQ0YuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jZi9Mb2FkZXJSdW5Mb29wQ0YuY3BwCmluZGV4IDMwODhlYjRjODIzNDNkOTEzYjAw Y2Q3ZTliMDgwMGE5ZjJmODk2YjMuLmVmMjIwODg0YzQ1NmZkYWM5YjkxNGM4ZmNlNTk0ZTUwYTA4 NTc1OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvTG9h ZGVyUnVuTG9vcENGLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nm L0xvYWRlclJ1bkxvb3BDRi5jcHAKQEAgLTM4LDE4ICszOCwzNSBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKIHN0YXRpYyBDRlJ1bkxvb3BSZWYgbG9hZGVyUnVuTG9vcE9iamVjdCA9IDA7CiAKK3N0 YXRpYyBNdXRleCYgbG9hZGVyUnVuTG9vcE11dGV4KCkKK3sKKyAgICBERUZJTkVfU1RBVElDX0xP Q0FMKE11dGV4LCBtdXRleCwgKCkpOworICAgIHJldHVybiBtdXRleDsKK30KKworc3RhdGljIFRo cmVhZENvbmRpdGlvbiYgbG9hZGVyUnVuTG9vcENvbmRpdGlvbigpCit7CisgICAgREVGSU5FX1NU QVRJQ19MT0NBTChUaHJlYWRDb25kaXRpb24sIHRocmVhZENvbmRpdGlvbiwgKCkpOworICAgIHJl dHVybiB0aHJlYWRDb25kaXRpb247Cit9CisKIHN0YXRpYyB2b2lkIGVtcHR5UGVyZm9ybSh2b2lk KikgCiB7CiB9CiAKIHN0YXRpYyB2b2lkIHJ1bkxvYWRlclRocmVhZCh2b2lkKikKIHsKLSAgICBs b2FkZXJSdW5Mb29wT2JqZWN0ID0gQ0ZSdW5Mb29wR2V0Q3VycmVudCgpOworICAgIHsKKyAgICAg ICAgTXV0ZXhMb2NrZXIgbG9jayhsb2FkZXJSdW5Mb29wTXV0ZXgoKSk7CisgICAgICAgIGxvYWRl clJ1bkxvb3BPYmplY3QgPSBDRlJ1bkxvb3BHZXRDdXJyZW50KCk7CisKKyAgICAgICAgLy8gTXVz dCBhZGQgYSBzb3VyY2UgdG8gdGhlIHJ1biBsb29wIHRvIHByZXZlbnQgQ0ZSdW5Mb29wUnVuKCkg ZnJvbSBleGl0aW5nLgorICAgICAgICBDRlJ1bkxvb3BTb3VyY2VDb250ZXh0IGN0eHQgPSB7MCwg KHZvaWQqKTEgLyptdXN0IGJlIG5vbi1udWxsKi8sIDAsIDAsIDAsIDAsIDAsIDAsIDAsIGVtcHR5 UGVyZm9ybX07CisgICAgICAgIENGUnVuTG9vcFNvdXJjZVJlZiBib2d1c1NvdXJjZSA9IENGUnVu TG9vcFNvdXJjZUNyZWF0ZSgwLCAwLCAmY3R4dCk7CisgICAgICAgIENGUnVuTG9vcEFkZFNvdXJj ZShsb2FkZXJSdW5Mb29wT2JqZWN0LCBib2d1c1NvdXJjZSwga0NGUnVuTG9vcERlZmF1bHRNb2Rl KTsKIAotICAgIC8vIE11c3QgYWRkIGEgc291cmNlIHRvIHRoZSBydW4gbG9vcCB0byBwcmV2ZW50 IENGUnVuTG9vcFJ1bigpIGZyb20gZXhpdGluZy4KLSAgICBDRlJ1bkxvb3BTb3VyY2VDb250ZXh0 IGN0eHQgPSB7MCwgKHZvaWQqKTEgLyptdXN0IGJlIG5vbi1OVUxMKi8sIDAsIDAsIDAsIDAsIDAs IDAsIDAsIGVtcHR5UGVyZm9ybX07Ci0gICAgQ0ZSdW5Mb29wU291cmNlUmVmIGJvZ3VzU291cmNl ID0gQ0ZSdW5Mb29wU291cmNlQ3JlYXRlKDAsIDAsICZjdHh0KTsKLSAgICBDRlJ1bkxvb3BBZGRT b3VyY2UobG9hZGVyUnVuTG9vcE9iamVjdCwgYm9ndXNTb3VyY2UsIGtDRlJ1bkxvb3BEZWZhdWx0 TW9kZSk7CisgICAgICAgIGxvYWRlclJ1bkxvb3BDb25kaXRpb24oKS5zaWduYWwoKTsKKyAgICB9 CiAKICAgICBTSW50MzIgcmVzdWx0OwogICAgIGRvIHsKQEAgLTYxLDE3ICs3OCwxMSBAQCBzdGF0 aWMgdm9pZCBydW5Mb2FkZXJUaHJlYWQodm9pZCopCiBDRlJ1bkxvb3BSZWYgbG9hZGVyUnVuTG9v cCgpCiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKKworICAgIE11dGV4TG9ja2VyIGxv Y2sobG9hZGVyUnVuTG9vcE11dGV4KCkpOwogICAgIGlmICghbG9hZGVyUnVuTG9vcE9iamVjdCkg ewogICAgICAgICBjcmVhdGVUaHJlYWQocnVuTG9hZGVyVGhyZWFkLCAwLCAiV2ViQ29yZTogQ0ZO ZXR3b3JrIExvYWRlciIpOwotICAgICAgICB3aGlsZSAoIWxvYWRlclJ1bkxvb3BPYmplY3QpIHsK LSAgICAgICAgICAgIC8vIEZJWE1FOiA8aHR0cDovL3dlYmtpdC5vcmcvYi81NTQwMj4gLSBsb2Fk ZXJSdW5Mb29wKCkgc2hvdWxkIHVzZSBzeW5jaHJvbml6YXRpb24gaW5zdGVhZCBvZiB3aGlsZSBs b29wCi0jaWYgUExBVEZPUk0oV0lOKQotICAgICAgICAgICAgU2xlZXAoMTApOwotI2Vsc2UKLSAg ICAgICAgICAgIHN0cnVjdCB0aW1lc3BlYyBzbGVlcFRpbWUgPSB7IDAsIDEwICogMTAwMCAqIDEw MDAgfTsKLSAgICAgICAgICAgIG5hbm9zbGVlcCgmc2xlZXBUaW1lLCAwKTsKLSNlbmRpZgotICAg ICAgICB9CisgICAgICAgIGxvYWRlclJ1bkxvb3BDb25kaXRpb24oKS53YWl0KGxvYWRlclJ1bkxv b3BNdXRleCgpKTsKICAgICB9CiAgICAgcmV0dXJuIGxvYWRlclJ1bkxvb3BPYmplY3Q7CiB9Cg==