55382 2011-02-28 08:23:53 -0800 DrawingAreaProxyImpl's state ID should be updated whenever its state changes, not just when we send an UpdateState message 2011-02-28 08:36:51 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 51262 1 aroben aroben andersca oldest_to_newest 359069 0 aroben 2011-02-28 08:23:53 -0800 DrawingAreaProxyImpl's state ID should be updated whenever its state changes, not just when we send an UpdateState message 359071 1 84065 aroben 2011-02-28 08:24:20 -0800 Created attachment 84065 Patch 359081 2 aroben 2011-02-28 08:36:51 -0800 Committed r79867: <http://trac.webkit.org/changeset/79867> 84065 2011-02-28 08:24:20 -0800 2011-02-28 08:29:26 -0800 Patch bug-55382-20110228112418.patch text/plain 6062 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogNzk4NjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1YTRjOWE0NTY4Y2QwNGNk ZmNkNGYyMmJhM2Y0M2VlM2VlYjhiYmZjLi43ODVkMzhhMzkwYTNhYjc2Njg4MzhhOTRlMTI4Nzc1 ZDA3YzAzMDIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzUgQEAKIDIwMTEtMDItMjggIEFkYW0g Um9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCisgICAgICAgIERlY291cGxlIHN0YXRlIGNoYW5n ZXMgZnJvbSBzZW5kaW5nIG9mIFVwZGF0ZVN0YXRlIG1lc3NhZ2VzIGluIERyYXdpbmdBcmVhUHJv eHlJbXBsCisKKyAgICAgICAgVGhlIG5ldyBEcmF3aW5nQXJlYVByb3h5SW1wbDo6c3RhdGVEaWRD aGFuZ2UgZnVuY3Rpb24gc2hvdWxkIGJlIGNhbGxlZCB3aGVuZXZlcgorICAgICAgICBEcmF3aW5n QXJlYVByb3h5SW1wbCdzIHN0YXRlIGNoYW5nZXMgaW4gYSB3YXkgdGhhdCB3aWxsIHJlcXVpcmUg YWxsb2NhdGluZyBhIG5ldyBiYWNraW5nCisgICAgICAgIHN0b3JlLiAoQ3VycmVudGx5LCB0aGlz IGlzIGp1c3Qgd2hlbiB0aGUgc2l6ZSBjaGFuZ2VzLikgVGhpcyBmdW5jdGlvbiB3aWxsIHNvbWV0 aW1lcyAoYnV0CisgICAgICAgIG5vdCBhbHdheXMsIGFzIHdoZW4gd2UncmUgd2FpdGluZyBmb3Ig YSBEaWRVcGRhdGVTdGF0ZSBtZXNzYWdlKSBzZW5kIGFuIFVwZGF0ZVN0YXRlIG1lc3NhZ2UKKyAg ICAgICAgdG8gdGhlIHdlYiBwcm9jZXNzLiBUaGlzIG1lYW5zIGl0J3Mgbm93IHBvc3NpYmxlIGZv ciB0aGUgc3RhdGUgSURzIHNlbnQgaW4gY29uc2VjdXRpdmUKKyAgICAgICAgVXBkYXRlU3RhdGUg bWVzc2FnZXMgdG8gaW5jcmVhc2UgYnkgbW9yZSB0aGFuIG9uZSwgYnV0IHRoYXQncyBPSy4KKwor ICAgICAgICBGaXhlcyA8aHR0cDovL3dlYmtpdC5vcmcvYi81NTM4Mj4gRHJhd2luZ0FyZWFQcm94 eUltcGwncyBzdGF0ZSBJRCBzaG91bGQgYmUgdXBkYXRlZCB3aGVuZXZlcgorICAgICAgICBpdHMg c3RhdGUgY2hhbmdlcywgbm90IGp1c3Qgd2hlbiB3ZSBzZW5kIGFuIFVwZGF0ZVN0YXRlIG1lc3Nh Z2UKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRyYXdp bmdBcmVhUHJveHlJbXBsOjpEcmF3aW5nQXJlYVByb3h5SW1wbCk6IFVwZGF0ZWQgZm9yIHJlbmFt ZS4KKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eUltcGw6OnNpemVEaWRDaGFuZ2Up OiBDaGFuZ2VkIHRvIGNhbGwgc3RhdGVEaWRDaGFuZ2UuCisgICAgICAgIChXZWJLaXQ6OkRyYXdp bmdBcmVhUHJveHlJbXBsOjpkaWRVcGRhdGVTdGF0ZSk6IFVwZGF0ZWQgZm9yIHJlbmFtZSwgYW5k IGNoYW5nZWQgdG8gY2FsbAorICAgICAgICBzZW5kVXBkYXRlU3RhdGUgd2hlbmV2ZXIgb3VyIHN0 YXRlIGhhcyBjaGFuZ2VkIGZvciBhbnkgcmVhc29uIHNpbmNlIHRoZSBsYXN0IFVwZGF0ZVN0YXRl CisgICAgICAgIG1lc3NhZ2Ugd2FzIHNlbnQuCisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVh UHJveHlJbXBsOjpzdGF0ZURpZENoYW5nZSk6IEFkZGVkLiBJbmNyZW1lbnRzIG1fbmV4dFN0YXRl SUQgYW5kIGNhbGxzCisgICAgICAgIHRocm91Z2ggdG8gc2VuZFVwZGF0ZVN0YXRlLgorICAgICAg ICAoV2ViS2l0OjpEcmF3aW5nQXJlYVByb3h5SW1wbDo6c2VuZFVwZGF0ZVN0YXRlKTogVXBkYXRl ZCBmb3IgcmVuYW1lLCBtb3ZlZCBpbmNyZW1lbnRpbmcgb2YKKyAgICAgICAgdGhlIHN0YXRlIElE IHdlIHNlbmQgdG8gdGhlIHdlYiBwcm9jZXNzIGZyb20gaGVyZSB0byBzdGF0ZURpZENoYW5nZSwg YW5kIGFkZGVkIGFuIGFzc2VydGlvbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9EcmF3aW5nQXJl YVByb3h5SW1wbC5oOiBSZW5hbWVkIG1fcmVxdWVzdGVkU3RhdGVJRCB0byBtX25leHRTdGF0ZUlE LCBhbmQgdXBkYXRlZAorICAgICAgICB0aGUgY29tbWVudCBleHBsYWluaW5nIGl0cyBtZWFuaW5n LgorCisyMDExLTAyLTI4ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKwogICAgICAg ICBQYXNzIHRoZSByaWdodCBkaXJ0eSByZWN0IHRvIFBsdWdpbjo6cGFpbnQKIAogICAgICAgICBB IHR5cG8gaW4gcjc5MDQwIGJyb2tlIHRoaXMuIE11Y2ggb2YgdGhpcyBwYXRjaCBpcyBqdXN0IHN1 cHBvcnQgZm9yIHRlc3RpbmcgdGhlIGZpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvRHJhd2luZ0FyZWFQcm94eUltcGwuY3BwCmluZGV4IGNhZjlmZThmYWM5OGZjOWJiYzJmYTVl N2ZiMTlhZThmNjI3YjRhOGUuLjhjYmZjNDc5N2ZhNzMyNjc3NGIxOTdjMmNhNDY5YjkzYTUwMmIx NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5 SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJ bXBsLmNwcApAQCAtNTAsNyArNTAsNyBAQCBQYXNzT3duUHRyPERyYXdpbmdBcmVhUHJveHlJbXBs PiBEcmF3aW5nQXJlYVByb3h5SW1wbDo6Y3JlYXRlKFdlYlBhZ2VQcm94eSogd2ViUAogRHJhd2lu Z0FyZWFQcm94eUltcGw6OkRyYXdpbmdBcmVhUHJveHlJbXBsKFdlYlBhZ2VQcm94eSogd2ViUGFn ZVByb3h5KQogICAgIDogRHJhd2luZ0FyZWFQcm94eShEcmF3aW5nQXJlYVR5cGVJbXBsLCB3ZWJQ YWdlUHJveHkpCiAgICAgLCBtX2N1cnJlbnRTdGF0ZUlEKDApCi0gICAgLCBtX3JlcXVlc3RlZFN0 YXRlSUQoMCkKKyAgICAsIG1fbmV4dFN0YXRlSUQoMCkKICAgICAsIG1faXNXYWl0aW5nRm9yRGlk VXBkYXRlU3RhdGUoZmFsc2UpCiB7CiB9CkBAIC0xMDMsNyArMTAzLDcgQEAgYm9vbCBEcmF3aW5n QXJlYVByb3h5SW1wbDo6cGFpbnQoY29uc3QgV2ViQ29yZTo6SW50UmVjdCYsIFBsYXRmb3JtRHJh d2luZ0NvbnRleHQKIAogdm9pZCBEcmF3aW5nQXJlYVByb3h5SW1wbDo6c2l6ZURpZENoYW5nZSgp CiB7Ci0gICAgc2VuZFVwZGF0ZVN0YXRlKCk7CisgICAgc3RhdGVEaWRDaGFuZ2UoKTsKIH0KIAog dm9pZCBEcmF3aW5nQXJlYVByb3h5SW1wbDo6dmlzaWJpbGl0eURpZENoYW5nZSgpCkBAIC0xMzYs MTQgKzEzNiwxNCBAQCB2b2lkIERyYXdpbmdBcmVhUHJveHlJbXBsOjp1cGRhdGUodWludDY0X3Qg c3RhdGVJRCwgY29uc3QgVXBkYXRlSW5mbyYgdXBkYXRlSW5mbwogCiB2b2lkIERyYXdpbmdBcmVh UHJveHlJbXBsOjpkaWRVcGRhdGVTdGF0ZSh1aW50NjRfdCBzdGF0ZUlELCBjb25zdCBVcGRhdGVJ bmZvJiB1cGRhdGVJbmZvLCBjb25zdCBMYXllclRyZWVDb250ZXh0JiBsYXllclRyZWVDb250ZXh0 KQogewotICAgIEFTU0VSVF9BUkcoc3RhdGVJRCwgc3RhdGVJRCA8PSBtX3JlcXVlc3RlZFN0YXRl SUQpOworICAgIEFTU0VSVF9BUkcoc3RhdGVJRCwgc3RhdGVJRCA8PSBtX25leHRTdGF0ZUlEKTsK ICAgICBBU1NFUlRfQVJHKHN0YXRlSUQsIHN0YXRlSUQgPiBtX2N1cnJlbnRTdGF0ZUlEKTsKICAg ICBtX2N1cnJlbnRTdGF0ZUlEID0gc3RhdGVJRDsKIAogICAgIEFTU0VSVChtX2lzV2FpdGluZ0Zv ckRpZFVwZGF0ZVN0YXRlKTsKICAgICBtX2lzV2FpdGluZ0ZvckRpZFVwZGF0ZVN0YXRlID0gZmFs c2U7CiAKLSAgICBpZiAobV9zaXplICE9IHVwZGF0ZUluZm8udmlld1NpemUpCisgICAgaWYgKG1f bmV4dFN0YXRlSUQgIT0gbV9jdXJyZW50U3RhdGVJRCkKICAgICAgICAgc2VuZFVwZGF0ZVN0YXRl KCk7CiAKICAgICBpZiAobGF5ZXJUcmVlQ29udGV4dCAhPSBtX2xheWVyVHJlZUNvbnRleHQpIHsK QEAgLTIxNCw4ICsyMTQsMTYgQEAgdm9pZCBEcmF3aW5nQXJlYVByb3h5SW1wbDo6aW5jb3Jwb3Jh dGVVcGRhdGUoY29uc3QgVXBkYXRlSW5mbyYgdXBkYXRlSW5mbykKICAgICAgICAgbV93ZWJQYWdl UHJveHktPmRpc3BsYXlWaWV3KCk7CiB9CiAKK3ZvaWQgRHJhd2luZ0FyZWFQcm94eUltcGw6OnN0 YXRlRGlkQ2hhbmdlKCkKK3sKKyAgICArK21fbmV4dFN0YXRlSUQ7CisgICAgc2VuZFVwZGF0ZVN0 YXRlKCk7Cit9CisKIHZvaWQgRHJhd2luZ0FyZWFQcm94eUltcGw6OnNlbmRVcGRhdGVTdGF0ZSgp CiB7CisgICAgQVNTRVJUKG1fY3VycmVudFN0YXRlSUQgPCBtX25leHRTdGF0ZUlEKTsKKwogICAg IGlmICghbV93ZWJQYWdlUHJveHktPmlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJuOwogCkBAIC0y MjMsNyArMjMxLDcgQEAgdm9pZCBEcmF3aW5nQXJlYVByb3h5SW1wbDo6c2VuZFVwZGF0ZVN0YXRl KCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9pc1dhaXRpbmdGb3JEaWRVcGRhdGVTdGF0ZSA9 IHRydWU7Ci0gICAgbV93ZWJQYWdlUHJveHktPnByb2Nlc3MoKS0+c2VuZChNZXNzYWdlczo6RHJh d2luZ0FyZWE6OlVwZGF0ZVN0YXRlKCsrbV9yZXF1ZXN0ZWRTdGF0ZUlELCBtX3NpemUsIG1fc2Ny b2xsT2Zmc2V0KSwgbV93ZWJQYWdlUHJveHktPnBhZ2VJRCgpKTsKKyAgICBtX3dlYlBhZ2VQcm94 eS0+cHJvY2VzcygpLT5zZW5kKE1lc3NhZ2VzOjpEcmF3aW5nQXJlYTo6VXBkYXRlU3RhdGUobV9u ZXh0U3RhdGVJRCwgbV9zaXplLCBtX3Njcm9sbE9mZnNldCksIG1fd2ViUGFnZVByb3h5LT5wYWdl SUQoKSk7CiAgICAgbV9zY3JvbGxPZmZzZXQgPSBJbnRTaXplKCk7CiAKICAgICBpZiAoIW1fbGF5 ZXJUcmVlQ29udGV4dC5pc0VtcHR5KCkpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1wbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0RyYXdpbmdBcmVhUHJveHlJbXBsLmgKaW5kZXggMDE1NzcyMWNiZWU2NDRmN2QxNjlkMmViOGIy OWE2ZGViOGVhMjA3Mi4uNzkxNGM0NjljMDkwYjYzNTU1MWNlNWIyZTA3ZGFkYWU4N2U1OTk3OSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBs LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBsLmgK QEAgLTYxLDYgKzYxLDggQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgZXhpdEFjY2VsZXJh dGVkQ29tcG9zaXRpbmdNb2RlKHVpbnQ2NF90IHN0YXRlSUQsIGNvbnN0IFVwZGF0ZUluZm8mKTsK IAogICAgIHZvaWQgaW5jb3Jwb3JhdGVVcGRhdGUoY29uc3QgVXBkYXRlSW5mbyYpOworCisgICAg dm9pZCBzdGF0ZURpZENoYW5nZSgpOwogICAgIHZvaWQgc2VuZFVwZGF0ZVN0YXRlKCk7CiAgICAg dm9pZCB3YWl0Rm9yQW5kRGlzcGF0Y2hEaWRVcGRhdGVTdGF0ZSgpOwogCkBAIC03NCwxMCArNzYs OSBAQCBwcml2YXRlOgogICAgIC8vIGFzIHRoZXkgZG9uJ3QgYXBwbHkgdG8gb3VyIGN1cnJlbnQg YmFja2luZyBzdG9yZS4KICAgICB1aW50NjRfdCBtX2N1cnJlbnRTdGF0ZUlEOwogCi0gICAgLy8g VGhlIHN0YXRlIElEIHdlIG1vc3QgcmVjZW50bHkgcmVxdWVzdGVkIHRoZSB3ZWIgcHJvY2VzcyB1 cGRhdGUgdG8uIEluY3JlbWVudGVkIHdoZW5ldmVyIHdlCi0gICAgLy8gc2VuZCBhbiBVcGRhdGVT dGF0ZSBtZXNzYWdlIHRvIHRoZSB3ZWIgcHJvY2VzcyB0byB0ZWxsIGl0IHdlIG5lZWQgdG8gYWxs b2NhdGUgYSBuZXcgYmFja2luZwotICAgIC8vIHN0b3JlLgotICAgIHVpbnQ2NF90IG1fcmVxdWVz dGVkU3RhdGVJRDsKKyAgICAvLyBUaGUgbmV4dCBzdGF0ZSBJRCB3ZSB3aWxsIHJlcXVlc3QgdGhl IHdlYiBwcm9jZXNzIHVwZGF0ZSB0by4gSW5jcmVtZW50ZWQgd2hlbmV2ZXIgb3VyIHN0YXRlCisg ICAgLy8gY2hhbmdlcyBpbiBhIHdheSB0aGF0IHdpbGwgcmVxdWlyZSBhIG5ldyBiYWNraW5nIHN0 b3JlIHRvIGJlIGFsbG9jYXRlZC4KKyAgICB1aW50NjRfdCBtX25leHRTdGF0ZUlEOwogCiAgICAg Ly8gVGhlIGN1cnJlbnQgbGF5ZXIgdHJlZSBjb250ZXh0LgogICAgIExheWVyVHJlZUNvbnRleHQg bV9sYXllclRyZWVDb250ZXh0Owo=