55366 2011-02-28 05:35:50 -0800 FrameLoader: Reorder early-returns in checkCompleted() 2011-02-28 05:46:54 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kling webkit-unassigned oldest_to_newest 358999 0 kling 2011-02-28 05:35:50 -0800 We should check allChildrenAreComplete() last, since it's [potentially] the most expensive. 359000 1 84044 kling 2011-02-28 05:36:43 -0800 Created attachment 84044 Proposed patch 359001 2 84044 kenneth 2011-02-28 05:37:51 -0800 Comment on attachment 84044 Proposed patch Seems fine. 359003 3 kling 2011-02-28 05:46:54 -0800 Committed r79855: <http://trac.webkit.org/changeset/79855> 84044 2011-02-28 05:36:43 -0800 2011-02-28 05:37:51 -0800 Proposed patch bug-55366.diff text/plain 1481 kling SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5ODU0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMjggIEFuZHJlYXMg S2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZyYW1lTG9hZGVyOiBSZW9yZGVyIGVhcmx5LXJldHVybnMgaW4g Y2hlY2tDb21wbGV0ZWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTUzNjYKKworICAgICAgICBDaGVjayBhbGxDaGlsZHJlbkFyZUNvbXBsZXRlKCkg bGFzdCwgc2luY2UgaXQncyB0aGUgbW9zdCBleHBlbnNpdmUuCisKKyAgICAgICAgKiBsb2FkZXIv RnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmNoZWNrQ29t cGxldGVkKToKKwogMjAxMS0wMi0yOCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2xvYWRlci9GcmFtZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9h ZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gNzk4NTQpCisrKyBTb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MTUsMTAgKzgxNSw2IEBA CiAgICAgaWYgKG1fZnJhbWUtPnZpZXcoKSkKICAgICAgICAgbV9mcmFtZS0+dmlldygpLT5jaGVj a1N0b3BEZWxheWluZ0RlZmVycmVkUmVwYWludHMoKTsKIAotICAgIC8vIEFueSBmcmFtZSB0aGF0 IGhhc24ndCBjb21wbGV0ZWQgeWV0PwotICAgIGlmICghYWxsQ2hpbGRyZW5BcmVDb21wbGV0ZSgp KQotICAgICAgICByZXR1cm47Ci0KICAgICAvLyBIYXZlIHdlIGNvbXBsZXRlZCBiZWZvcmU/CiAg ICAgaWYgKG1faXNDb21wbGV0ZSkKICAgICAgICAgcmV0dXJuOwpAQCAtODM1LDYgKzgzMSwxMCBA QAogICAgIGlmIChtX2ZyYW1lLT5kb2N1bWVudCgpLT5pc0RlbGF5aW5nTG9hZEV2ZW50KCkpCiAg ICAgICAgIHJldHVybjsKIAorICAgIC8vIEFueSBmcmFtZSB0aGF0IGhhc24ndCBjb21wbGV0ZWQg eWV0PworICAgIGlmICghYWxsQ2hpbGRyZW5BcmVDb21wbGV0ZSgpKQorICAgICAgICByZXR1cm47 CisKICAgICAvLyBPSywgY29tcGxldGVkLgogICAgIG1faXNDb21wbGV0ZSA9IHRydWU7CiAgICAg bV9mcmFtZS0+ZG9jdW1lbnQoKS0+c2V0UmVhZHlTdGF0ZShEb2N1bWVudDo6Q29tcGxldGUpOwo=