55362 2011-02-28 04:43:16 -0800 Clarify comment about potential memory leak in SVGImage 2011-03-04 13:28:30 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P4 Minor --- 0 ctruta webkit-unassigned commit-queue longsonr zimmermann oldest_to_newest 358982 0 ctruta 2011-02-28 04:43:16 -0800 There is the following comment at // FIXME: If this SVG ends up loading itself, we might leak the world. // The comment said that the Cache code does not know about CachedImages // holding Frames and won't know to break the cycle. But [code follows] I tested SVG images with various kinds of content, running testshell under valgrind, but I could not see any leak. I believe that comment is no longer applicable. (It was written in 2009.) 358984 1 84040 ctruta 2011-02-28 04:54:54 -0800 Created attachment 84040 Patch 359141 2 longsonr 2011-02-28 10:20:15 -0800 bug 15443 suggests that images loading images has not been implemented yet. If so the comment could be true when it is implemented couldn't it? 359595 3 ctruta 2011-02-28 19:07:20 -0800 (In reply to comment #2) > bug 15443 suggests that images loading images has not been implemented yet. If so the comment could be true when it is implemented couldn't it? SVG images loading other SVG images, via the <image> tag, is supported, albeit in a limited manner. You can see in the layout test that I submitted that it works. The layout test is, in fact, meant to be run under valgrind, to show that it does not leak memory. 359646 4 ctruta 2011-02-28 21:10:08 -0800 I wonder what happened, the bubbles have been purple for the whole day. 361931 5 84626 ctruta 2011-03-03 14:17:09 -0800 Created attachment 84626 Patch Forgot to use option --binary in git-diff last time. That explains why the previous patch failed to apply. 361969 6 ctruta 2011-03-03 14:53:04 -0800 Instead of removing that comment altogher, I will submit a patch explaining why it cannot currently happen, and when (i.e. at what event in the future) it will happen. 361984 7 84636 ctruta 2011-03-03 15:00:58 -0800 Created attachment 84636 Patch 362675 8 84636 commit-queue 2011-03-04 13:28:25 -0800 Comment on attachment 84636 Patch Clearing flags on attachment: 84636 Committed r80371: <http://trac.webkit.org/changeset/80371> 362676 9 commit-queue 2011-03-04 13:28:30 -0800 All reviewed patches have been landed. Closing bug. 84040 2011-02-28 04:54:54 -0800 2011-03-03 14:17:09 -0800 Patch wk33362.diff.submit text/plain 4028 ctruta ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkOGIwMDI2Li44MzU0N2QwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDIt MjggIENvc21pbiBUcnV0YSAgPGN0cnV0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGNvbW1lbnQgYWJvdXQgbWVt b3J5IGxlYWsgZnJvbSBTVkdJbWFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTUzNjIKKworICAgICAgICAqIHBsYXRmb3JtL21hYy9zdmcvY3VzdG9t L2NpcmN1bGFyLWltYWdlLXJlZmVyZW5jZS1leHBlY3RlZC5jaGVja3N1bTogQWRkZWQuCisgICAg ICAgICogcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2UtcmVmZXJlbmNlLWV4 cGVjdGVkLnBuZzogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vY2ly Y3VsYXItaW1hZ2UtcmVmZXJlbmNlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc3Zn L2N1c3RvbS9jaXJjdWxhci1pbWFnZS1yZWZlcmVuY2Uuc3ZnOiBBZGRlZC4KKwogMjAxMS0wMi0y OCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2UtcmVmZXJlbmNlLWV4cGVjdGVkLmNoZWNr c3VtIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2Ut cmVmZXJlbmNlLWV4cGVjdGVkLmNoZWNrc3VtCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLmU5ZjMzZGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvc3ZnL2N1c3RvbS9jaXJjdWxhci1pbWFnZS1yZWZlcmVuY2UtZXhwZWN0ZWQuY2hlY2tzdW0K QEAgLTAsMCArMSBAQAorNzhlYjNkMTM0OWYyZGZjZWE2ZmU4YmZjODZjOTI1NjYKXCBObyBuZXds aW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv c3ZnL2N1c3RvbS9jaXJjdWxhci1pbWFnZS1yZWZlcmVuY2UtZXhwZWN0ZWQucG5nIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2UtcmVmZXJlbmNlLWV4 cGVjdGVkLnBuZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi45OWNlN2U3CkJp bmFyeSBmaWxlcyAvZGV2L251bGwgYW5kIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9j dXN0b20vY2lyY3VsYXItaW1hZ2UtcmVmZXJlbmNlLWV4cGVjdGVkLnBuZyBkaWZmZXIKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9zdmcvY3VzdG9tL2NpcmN1bGFyLWltYWdl LXJlZmVyZW5jZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL2N1 c3RvbS9jaXJjdWxhci1pbWFnZS1yZWZlcmVuY2UtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAuLjllN2Q4ODUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL2N1c3RvbS9jaXJjdWxhci1pbWFnZS1yZWZlcmVuY2UtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEsNiBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisg IFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXplIDQw MHgxMDAKKyAgUmVuZGVyU1ZHUm9vdCB7c3ZnfSBhdCAoMCwwKSBzaXplIDQwMHgxMDAKKyAgICBS ZW5kZXJTVkdQYXRoIHtyZWN0fSBhdCAoMCwwKSBzaXplIDEwMHgxMDAgW2ZpbGw9e1t0eXBlPVNP TElEXSBbY29sb3I9IzAwODAwMF19XSBbeD0wLjAwXSBbeT0wLjAwXSBbd2lkdGg9MTAwLjAwXSBb aGVpZ2h0PTEwMC4wMF0KKyAgICBSZW5kZXJTVkdJbWFnZSB7aW1hZ2V9IGF0ICgyMDAsMCkgc2l6 ZSAyMDB4MTAwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2NpcmN1bGFyLWlt YWdlLXJlZmVyZW5jZS5zdmcgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2NpcmN1bGFyLWltYWdl LXJlZmVyZW5jZS5zdmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYTAzZDIy ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1h Z2UtcmVmZXJlbmNlLnN2ZwpAQCAtMCwwICsxLDQgQEAKKzxzdmcgd2lkdGg9IjQwMHB4IiBoZWln aHQ9IjEwMHB4IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5r PSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KKzxyZWN0IHg9IjAiIHk9IjAiIHdpZHRo PSIxMDAiIGhlaWdodD0iMTAwIiBmaWxsPSJncmVlbiIvPgorPGltYWdlIHg9IjIwMCIgeT0iMCIg d2lkdGg9IjIwMCIgaGVpZ2h0PSIxMDAiIHhsaW5rOmhyZWY9ImNpcmN1bGFyLWltYWdlLXJlZmVy ZW5jZS5zdmciLz4KKzwvc3ZnPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDZlYTg5OWYuLjZlOTFjNzggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMi0yOCAgQ29zbWluIFRydXRhICA8Y3RydXRh QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZW1vdmUgY29tbWVudCBhYm91dCBtZW1vcnkgbGVhayBmcm9tIFNWR0ltYWdlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTM2MgorCisg ICAgICAgIFRlc3Q6IHN2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2UtcmVmZXJlbmNlLnN2ZworCisg ICAgICAgICogc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNW R0ltYWdlOjpkYXRhQ2hhbmdlZCk6CisKIDIwMTEtMDItMjggIFBhdmVsIEZlbGRtYW4gIDxwZmVs ZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkLiBUZXN0IGhhcm5lc3Mg Y2hhbmdlIGZvbGxvdyB1cC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGlj cy9TVkdJbWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3Bw CmluZGV4IDJkNDAwYTQuLjE2NjAxMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9n cmFwaGljcy9TVkdJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NW R0ltYWdlLmNwcApAQCAtMjYyLDkgKzI2Miw2IEBAIGJvb2wgU1ZHSW1hZ2U6OmRhdGFDaGFuZ2Vk KGJvb2wgYWxsRGF0YVJlY2VpdmVkKQogICAgICAgICBwYWdlQ2xpZW50cy5kZXZpY2VPcmllbnRh dGlvbkNsaWVudCA9IGR1bW15RGV2aWNlT3JpZW50YXRpb25DbGllbnQ7CiAjZW5kaWYKIAotICAg ICAgICAvLyBGSVhNRTogSWYgdGhpcyBTVkcgZW5kcyB1cCBsb2FkaW5nIGl0c2VsZiwgd2UgbWln aHQgbGVhayB0aGUgd29ybGQuCi0gICAgICAgIC8vIFRoZSBjb21tZW50IHNhaWQgdGhhdCB0aGUg Q2FjaGUgY29kZSBkb2VzIG5vdCBrbm93IGFib3V0IENhY2hlZEltYWdlcwotICAgICAgICAvLyBo b2xkaW5nIEZyYW1lcyBhbmQgd29uJ3Qga25vdyB0byBicmVhayB0aGUgY3ljbGUuIEJ1dCAKICAg ICAgICAgbV9wYWdlLnNldChuZXcgUGFnZShwYWdlQ2xpZW50cykpOwogICAgICAgICBtX3BhZ2Ut PnNldHRpbmdzKCktPnNldE1lZGlhRW5hYmxlZChmYWxzZSk7CiAgICAgICAgIG1fcGFnZS0+c2V0 dGluZ3MoKS0+c2V0SmF2YVNjcmlwdEVuYWJsZWQoZmFsc2UpOwo= 84626 2011-03-03 14:17:09 -0800 2011-03-03 15:00:58 -0800 Patch wk33362.diff.submit text/plain 4306 ctruta ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkOGIwMDI2Li44MzU0N2QwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDIt MjggIENvc21pbiBUcnV0YSAgPGN0cnV0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGNvbW1lbnQgYWJvdXQgbWVt b3J5IGxlYWsgZnJvbSBTVkdJbWFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTUzNjIKKworICAgICAgICAqIHBsYXRmb3JtL21hYy9zdmcvY3VzdG9t L2NpcmN1bGFyLWltYWdlLXJlZmVyZW5jZS1leHBlY3RlZC5jaGVja3N1bTogQWRkZWQuCisgICAg ICAgICogcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2UtcmVmZXJlbmNlLWV4 cGVjdGVkLnBuZzogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vY2ly Y3VsYXItaW1hZ2UtcmVmZXJlbmNlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc3Zn L2N1c3RvbS9jaXJjdWxhci1pbWFnZS1yZWZlcmVuY2Uuc3ZnOiBBZGRlZC4KKwogMjAxMS0wMi0y OCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2UtcmVmZXJlbmNlLWV4cGVjdGVkLmNoZWNr c3VtIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2Ut cmVmZXJlbmNlLWV4cGVjdGVkLmNoZWNrc3VtCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLmU5ZjMzZGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvc3ZnL2N1c3RvbS9jaXJjdWxhci1pbWFnZS1yZWZlcmVuY2UtZXhwZWN0ZWQuY2hlY2tzdW0K QEAgLTAsMCArMSBAQAorNzhlYjNkMTM0OWYyZGZjZWE2ZmU4YmZjODZjOTI1NjYKXCBObyBuZXds aW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv c3ZnL2N1c3RvbS9jaXJjdWxhci1pbWFnZS1yZWZlcmVuY2UtZXhwZWN0ZWQucG5nIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2UtcmVmZXJlbmNlLWV4 cGVjdGVkLnBuZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45OWNlN2U3NWVlNmNmMDY0YTY5MGE0YjkzZGQ3Nzg3ZWNj ZmYzNmViCkdJVCBiaW5hcnkgcGF0Y2gKbGl0ZXJhbCAyODIzCnpjbWVBU0BOPyhvbEh5YHVWQnEh aWEweX55VXsrdllWMmE+aTAqWik9aF5qTCVhR21wWGFTVy1MXlkrRkAtYWB4bQp6RVJIPWRaVV85 bCUpb2ZpT2FGYHl0TjZOaUo4Ymk3R1NBKGQkSDRIWDtyQk5OaEtBTEc1ZXk4NWpqUmo7IVpjLVUK ekpwUFNnLU9DRXUrcm9BO2lucG1WZD1SJnhzZU4/dDUqe25TekotS3lIYS0xbW90OVMzJXkzfDcj UmRrM0JxbllLCnoxK2BKZVhkc05IZ3diM3VuaFFwQSFEdWNSJT5fZCM3dnhgJDcwP1FAeFRnYmI7 NCpsK2BuanhnTkB4TkEwRU5uTAoKbGl0ZXJhbCAwCkhjbVY/ZDAwMDAxCgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2UtcmVmZXJl bmNlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9zdmcvY3VzdG9tL2Np cmN1bGFyLWltYWdlLXJlZmVyZW5jZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uOWU3ZDg4NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9zdmcvY3VzdG9tL2NpcmN1bGFyLWltYWdlLXJlZmVyZW5jZS1leHBlY3RlZC50 eHQKQEAgLTAsMCArMSw2IEBACitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVy VmlldyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgNDAweDEwMAor ICBSZW5kZXJTVkdSb290IHtzdmd9IGF0ICgwLDApIHNpemUgNDAweDEwMAorICAgIFJlbmRlclNW R1BhdGgge3JlY3R9IGF0ICgwLDApIHNpemUgMTAweDEwMCBbZmlsbD17W3R5cGU9U09MSURdIFtj b2xvcj0jMDA4MDAwXX1dIFt4PTAuMDBdIFt5PTAuMDBdIFt3aWR0aD0xMDAuMDBdIFtoZWlnaHQ9 MTAwLjAwXQorICAgIFJlbmRlclNWR0ltYWdlIHtpbWFnZX0gYXQgKDIwMCwwKSBzaXplIDIwMHgx MDAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2UtcmVm ZXJlbmNlLnN2ZyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vY2lyY3VsYXItaW1hZ2UtcmVmZXJl bmNlLnN2ZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5hMDNkMjJkCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9jaXJjdWxhci1pbWFnZS1yZWZl cmVuY2Uuc3ZnCkBAIC0wLDAgKzEsNCBAQAorPHN2ZyB3aWR0aD0iNDAwcHgiIGhlaWdodD0iMTAw cHgiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6 Ly93d3cudzMub3JnLzE5OTkveGxpbmsiPgorPHJlY3QgeD0iMCIgeT0iMCIgd2lkdGg9IjEwMCIg aGVpZ2h0PSIxMDAiIGZpbGw9ImdyZWVuIi8+Cis8aW1hZ2UgeD0iMjAwIiB5PSIwIiB3aWR0aD0i MjAwIiBoZWlnaHQ9IjEwMCIgeGxpbms6aHJlZj0iY2lyY3VsYXItaW1hZ2UtcmVmZXJlbmNlLnN2 ZyIvPgorPC9zdmc+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmVhODk5Zi4uNmU5MWM3OCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDExLTAyLTI4ICBDb3NtaW4gVHJ1dGEgIDxjdHJ1dGFAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZSBjb21tZW50IGFib3V0IG1lbW9yeSBsZWFrIGZyb20gU1ZHSW1hZ2UKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MzYyCisKKyAgICAgICAg VGVzdDogc3ZnL2N1c3RvbS9jaXJjdWxhci1pbWFnZS1yZWZlcmVuY2Uuc3ZnCisKKyAgICAgICAg KiBzdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHSW1hZ2U6 OmRhdGFDaGFuZ2VkKToKKwogMjAxMS0wMi0yOCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQuIFRlc3QgaGFybmVzcyBjaGFuZ2Ug Zm9sbG93IHVwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0lt YWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAKaW5kZXgg MmQ0MDBhNC4uMTY2MDEyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNz L1NWR0ltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2Uu Y3BwCkBAIC0yNjIsOSArMjYyLDYgQEAgYm9vbCBTVkdJbWFnZTo6ZGF0YUNoYW5nZWQoYm9vbCBh bGxEYXRhUmVjZWl2ZWQpCiAgICAgICAgIHBhZ2VDbGllbnRzLmRldmljZU9yaWVudGF0aW9uQ2xp ZW50ID0gZHVtbXlEZXZpY2VPcmllbnRhdGlvbkNsaWVudDsKICNlbmRpZgogCi0gICAgICAgIC8v IEZJWE1FOiBJZiB0aGlzIFNWRyBlbmRzIHVwIGxvYWRpbmcgaXRzZWxmLCB3ZSBtaWdodCBsZWFr IHRoZSB3b3JsZC4KLSAgICAgICAgLy8gVGhlIGNvbW1lbnQgc2FpZCB0aGF0IHRoZSBDYWNoZSBj b2RlIGRvZXMgbm90IGtub3cgYWJvdXQgQ2FjaGVkSW1hZ2VzCi0gICAgICAgIC8vIGhvbGRpbmcg RnJhbWVzIGFuZCB3b24ndCBrbm93IHRvIGJyZWFrIHRoZSBjeWNsZS4gQnV0IAogICAgICAgICBt X3BhZ2Uuc2V0KG5ldyBQYWdlKHBhZ2VDbGllbnRzKSk7CiAgICAgICAgIG1fcGFnZS0+c2V0dGlu Z3MoKS0+c2V0TWVkaWFFbmFibGVkKGZhbHNlKTsKICAgICAgICAgbV9wYWdlLT5zZXR0aW5ncygp LT5zZXRKYXZhU2NyaXB0RW5hYmxlZChmYWxzZSk7Cg== 84636 2011-03-03 15:00:58 -0800 2011-03-04 13:28:25 -0800 Patch wk33362.diff.submit text/plain 1619 ctruta ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZmEzNWU5Li5hZTQwNWQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDMtMDMgIENvc21pbiBUcnV0YSAgPGN0cnV0YUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xhcmlmeSBjb21t ZW50IGFib3V0IHBvdGVudGlhbCBtZW1vcnkgbGVhayBpbiBTVkdJbWFnZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUzNjIKKworICAgICAgICBObyBm dW5jdGlvbmFsaXR5IGNoYW5nZS4gTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogc3ZnL2dyYXBo aWNzL1NWR0ltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR0ltYWdlOjpkYXRhQ2hhbmdl ZCk6CisKIDIwMTEtMDMtMDMgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvc3Zn L2dyYXBoaWNzL1NWR0ltYWdlLmNwcAppbmRleCAyZDQwMGE0Li5kNTJhN2VkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAKQEAgLTI2Myw4ICsyNjMsMTEgQEAgYm9v bCBTVkdJbWFnZTo6ZGF0YUNoYW5nZWQoYm9vbCBhbGxEYXRhUmVjZWl2ZWQpCiAjZW5kaWYKIAog ICAgICAgICAvLyBGSVhNRTogSWYgdGhpcyBTVkcgZW5kcyB1cCBsb2FkaW5nIGl0c2VsZiwgd2Ug bWlnaHQgbGVhayB0aGUgd29ybGQuCi0gICAgICAgIC8vIFRoZSBjb21tZW50IHNhaWQgdGhhdCB0 aGUgQ2FjaGUgY29kZSBkb2VzIG5vdCBrbm93IGFib3V0IENhY2hlZEltYWdlcwotICAgICAgICAv LyBob2xkaW5nIEZyYW1lcyBhbmQgd29uJ3Qga25vdyB0byBicmVhayB0aGUgY3ljbGUuIEJ1dCAK KyAgICAgICAgLy8gVGhlIENhY2hlIGNvZGUgZG9lcyBub3Qga25vdyBhYm91dCBDYWNoZWRJbWFn ZXMgaG9sZGluZyBGcmFtZXMgYW5kCisgICAgICAgIC8vIHdvbid0IGtub3cgdG8gYnJlYWsgdGhl IGN5Y2xlLgorICAgICAgICAvLyBUaGlzIHdpbGwgYmVjb21lIGFuIGlzc3VlIHdoZW4gU1ZHSW1h Z2Ugd2lsbCBiZSBhYmxlIHRvIGxvYWQgb3RoZXIKKyAgICAgICAgLy8gU1ZHSW1hZ2Ugb2JqZWN0 cywgYnV0IHdlJ3JlIHNhZmUgbm93LCBiZWNhdXNlIFNWR0ltYWdlIGNhbiBvbmx5IGJlCisgICAg ICAgIC8vIGxvYWRlZCBieSBhIHRvcC1sZXZlbCBkb2N1bWVudC4KICAgICAgICAgbV9wYWdlLnNl dChuZXcgUGFnZShwYWdlQ2xpZW50cykpOwogICAgICAgICBtX3BhZ2UtPnNldHRpbmdzKCktPnNl dE1lZGlhRW5hYmxlZChmYWxzZSk7CiAgICAgICAgIG1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0SmF2 YVNjcmlwdEVuYWJsZWQoZmFsc2UpOwo=