55355 2011-02-28 00:13:08 -0800 TextIterator should not be a friend of RenderTextControl 2011-02-28 00:45:45 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 54179 1 rolandsteiner webkit-unassigned commit-queue dglazkov dominicc morrita oldest_to_newest 358914 0 rolandsteiner 2011-02-28 00:13:08 -0800 TextIterator should use interface methods rather than being a friend. 358915 1 84024 rolandsteiner 2011-02-28 00:18:31 -0800 Created attachment 84024 Patch Simple patch: remove need for friend-clause by making innerTextElement() public. Even after the general new-shadow-DOM refactoring there will be a common inner text element, so the accessor will likely stay around. We might want to restrict visibility of the shadow DOM from RenderTextControl, but this is for yet another (larger) refactoring. 358916 2 84024 tkent 2011-02-28 00:23:10 -0800 Comment on attachment 84024 Patch looks good. 358921 3 84024 commit-queue 2011-02-28 00:45:40 -0800 Comment on attachment 84024 Patch Clearing flags on attachment: 84024 Committed r79845: <http://trac.webkit.org/changeset/79845> 358922 4 commit-queue 2011-02-28 00:45:45 -0800 All reviewed patches have been landed. Closing bug. 84024 2011-02-28 00:18:31 -0800 2011-02-28 00:45:39 -0800 Patch bug-55355-20110228171830.patch text/plain 1705 rolandsteiner U3VidmVyc2lvbiBSZXZpc2lvbjogNzk4MzQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYzg4NGNiYjA5N2E3NmY1 ZjA3OGNiNTc4ZDQ0ZDI0ZjFhZWNlNDA5Li5iNDZiZTgzYzNhNGJjYmYyOThjZjYxNWRhN2Y1ZmQw ZTg1YzQwMGViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMjggIFJvbGFu ZCBTdGVpbmVyICA8cm9sYW5kc3RlaW5lckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDU1MzU1IC0gVGV4dEl0ZXJhdG9y IHNob3VsZCBub3QgYmUgYSBmcmllbmQgb2YgUmVuZGVyVGV4dENvbnRyb2wKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MzU1CisKKyAgICAgICAgUmVt b3ZlIG5lZWQgZm9yICdmcmllbmQnIGNsYXVzZSBieSBtYWtpbmcgaW5uZXJUZXh0RWxlbWVudCgp IHB1YmxpYy4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChzaW1wbGUgcmVmYWN0b3JpbmcpCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuaDoKKwogMjAxMS0wMi0yNyAg QmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUZXh0Q29udHJvbC5oCmluZGV4IGZkYjdmZGMxNTFiNTMxZDFiNzdkMmM5NmU5MTIzMTY4NGQw ODIyODUuLmNkODgxMmU2ODY5N2ZmNTkzNzMyMjc5OGJkZTYzNjliMzUxYzEwYzAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5oCkBAIC0zNCw2ICszNCw4 IEBAIGNsYXNzIFJlbmRlclRleHRDb250cm9sIDogcHVibGljIFJlbmRlckJsb2NrIHsKIHB1Ymxp YzoKICAgICB2aXJ0dWFsIH5SZW5kZXJUZXh0Q29udHJvbCgpOwogCisgICAgSFRNTEVsZW1lbnQq IGlubmVyVGV4dEVsZW1lbnQoKSBjb25zdDsKKwogICAgIGJvb2wgd2FzQ2hhbmdlZFNpbmNlTGFz dENoYW5nZUV2ZW50KCkgY29uc3QgeyByZXR1cm4gbV93YXNDaGFuZ2VkU2luY2VMYXN0Q2hhbmdl RXZlbnQ7IH0KICAgICB2b2lkIHNldENoYW5nZWRTaW5jZUxhc3RDaGFuZ2VFdmVudChib29sIHdh c0NoYW5nZWRTaW5jZUxhc3RDaGFuZ2VFdmVudCkgeyBtX3dhc0NoYW5nZWRTaW5jZUxhc3RDaGFu Z2VFdmVudCA9IHdhc0NoYW5nZWRTaW5jZUxhc3RDaGFuZ2VFdmVudDsgfQogCkBAIC04Myw5ICs4 NSw2IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlRnJvbUVsZW1lbnQoKTsK ICAgICB2aXJ0dWFsIHZvaWQgY29tcHV0ZUxvZ2ljYWxIZWlnaHQoKTsKIAotICAgIGZyaWVuZCBj bGFzcyBUZXh0SXRlcmF0b3I7Ci0gICAgSFRNTEVsZW1lbnQqIGlubmVyVGV4dEVsZW1lbnQoKSBj b25zdDsKLQogICAgIGJvb2wgbV9wbGFjZWhvbGRlclZpc2libGU7CiAKIHByaXZhdGU6Cg==