55337 2011-02-27 17:24:18 -0800 Force dictionary popup to use overlay type 2011-02-27 20:35:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 358822 0 sam 2011-02-27 17:24:18 -0800 Force dictionary popup to use overlay type 358823 1 84006 sam 2011-02-27 17:26:28 -0800 Created attachment 84006 Patch 358832 2 84006 mitz 2011-02-27 18:34:40 -0800 Comment on attachment 84006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84006&action=review > Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm:430 > + [m_wkView showDefinitionForAttributedString:attributedString.get() > + range:NSMakeRange(0, [attributedString.get() length]) > + options:options > + baselineOriginProvider:^(NSRange adjustedRange) { return (NSPoint)textBaselineOrigin; }]; Aligning arguments this way is not WebKit style. Please fix. 358878 3 sam 2011-02-27 20:35:37 -0800 Landed in r79839. 84006 2011-02-27 17:26:28 -0800 2011-02-27 18:34:40 -0800 Patch bug-55337-20110227172625.patch text/plain 2028 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5ODMzKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMjcgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGb3JjZSBkaWN0aW9uYXJ5IHBvcHVwIHRvIHVzZSBvdmVybGF5IHR5cGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MzM3CisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1wbC5tbToKKyAgICAgICAg KFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmRpZFBlcmZvcm1EaWN0aW9uYXJ5TG9va3VwKTogQXMg dGhpcyBpcyBvbmx5CisgICAgICAgIHVzZWQgZm9yIHRoZSBob3Qga2V5IHZlcnNpb24gb2YgdGhl IGRpY3Rpb25hcnkgcG9wdXAsIGZvcmNlIHRoZSBvdmVybGF5CisgICAgICAgIHN0eWxlLgorCiAy MDExLTAyLTI3ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1wbC5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1w bC5tbQkocmV2aXNpb24gNzk4MjUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21h Yy9QYWdlQ2xpZW50SW1wbC5tbQkod29ya2luZyBjb3B5KQpAQCAtNDIxLDcgKzQyMSwxMyBAQCB2 b2lkIFBhZ2VDbGllbnRJbXBsOjpkaWRQZXJmb3JtRGljdGlvbmFyCiAgICAgUmV0YWluUHRyPE5T TXV0YWJsZUF0dHJpYnV0ZWRTdHJpbmc+IGF0dHJpYnV0ZWRTdHJpbmcoQWRvcHROUywgW1tOU011 dGFibGVBdHRyaWJ1dGVkU3RyaW5nIGFsbG9jXSBpbml0V2l0aFN0cmluZzpuc1N0cmluZ0Zyb21X ZWJDb3JlU3RyaW5nKHRleHQpXSk7CiAgICAgW2F0dHJpYnV0ZWRTdHJpbmcuZ2V0KCkgYWRkQXR0 cmlidXRlOk5TRm9udEF0dHJpYnV0ZU5hbWUgdmFsdWU6Zm9udCByYW5nZTpOU01ha2VSYW5nZSgw LCBbYXR0cmlidXRlZFN0cmluZy5nZXQoKSBsZW5ndGhdKV07CiAKLSAgICBbbV93a1ZpZXcgc2hv d0RlZmluaXRpb25Gb3JBdHRyaWJ1dGVkU3RyaW5nOmF0dHJpYnV0ZWRTdHJpbmcuZ2V0KCkgYXRQ b2ludDp0ZXh0SW5mby5iYXNlbGluZU9yaWdpbl07CisgICAgTlNQb2ludCB0ZXh0QmFzZWxpbmVP cmlnaW4gPSB0ZXh0SW5mby5iYXNlbGluZU9yaWdpbjsKKworICAgIE5TRGljdGlvbmFyeSAqb3B0 aW9ucyA9IFtOU0RpY3Rpb25hcnkgZGljdGlvbmFyeVdpdGhPYmplY3Q6TlNEZWZpbml0aW9uUHJl c2VudGF0aW9uVHlwZU92ZXJsYXkgZm9yS2V5Ok5TRGVmaW5pdGlvblByZXNlbnRhdGlvblR5cGVL ZXldOworICAgIFttX3drVmlldyBzaG93RGVmaW5pdGlvbkZvckF0dHJpYnV0ZWRTdHJpbmc6YXR0 cmlidXRlZFN0cmluZy5nZXQoKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcmFuZ2U6TlNNYWtlUmFuZ2UoMCwgW2F0dHJpYnV0ZWRTdHJpbmcuZ2V0KCkgbGVuZ3Ro XSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvcHRpb25zOm9wdGlv bnMKKyAgICAgICAgICAgICAgICAgICAgICAgICBiYXNlbGluZU9yaWdpblByb3ZpZGVyOl4oTlNS YW5nZSBhZGp1c3RlZFJhbmdlKSB7IHJldHVybiAoTlNQb2ludCl0ZXh0QmFzZWxpbmVPcmlnaW47 IH1dOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK