55330 2011-02-27 13:47:51 -0800 [Qt] [WK2] QGraphicsWKView::showContextMenu() should be public 2011-11-26 11:51:29 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P3 Normal --- 1 benjamin webkit-unassigned oldest_to_newest 358770 0 benjamin 2011-02-27 13:47:51 -0800 I originally made QGraphicsWKView::showContextMenu() private because I considered the users could just make their own slot and cut the connection to the existing slot. However, the implementation of the menu is non trivial due to the possibility of multiple call from the WebProcess. I now think the method should be accessible to implementors so they have an easy way to handle those corner case by calling the original method with their own menu. (and I added some doc so it is mentioned somewhere the menu can be empty, that cannot hurt :)) 358774 1 83993 benjamin 2011-02-27 13:53:14 -0800 Created attachment 83993 Patch 358795 2 83993 kenneth 2011-02-27 15:03:50 -0800 Comment on attachment 83993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83993&action=review Very nice to see documentation for our WebKit2 classes! > Source/WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:335 > + actions possible for its current position, it is empty if there is no action for the position. I don't think it should be a comma here. Maybe ; would do, or you could add another sentence instead. 358800 3 benjamin 2011-02-27 15:19:37 -0800 Committed r79832: <http://trac.webkit.org/changeset/79832> 83993 2011-02-27 13:53:14 -0800 2011-11-26 11:51:29 -0800 Patch bug-55330-20110227230253.patch text/plain 2543 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogNzk4MjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBlYTJkODZlMDgxMDQ2Zjdm OGE2ZDAwNTY0NDU3M2NhNWQ5ODVmNjk3Li41ZGExMzk3MGMwYTliZDY2MDljNjJhMzQwY2VmMWEz MWFjZTMzNGE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMjcgIEJlbmph bWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFtXSzJdIFFHcmFwaGljc1dL Vmlldzo6c2hvd0NvbnRleHRNZW51KCkgc2hvdWxkIGJlIHB1YmxpYworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUzMzAKKworICAgICAgICBNb3ZlIFFH cmFwaGljc1dLVmlldzo6c2hvd0NvbnRleHRNZW51KCkgdG8gdGhlIHB1YmxpYyBBUEkuIEFkZCBk b2N1bWVudGF0aW9uCisgICAgICAgIG9uIGl0cyB1c2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL3F0L3FncmFwaGljc3drdmlldy5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9x Z3JhcGhpY3N3a3ZpZXcuaDoKKwogMjAxMS0wMi0yNyAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFs ZXhAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXhlZCBHVEsgY29tcGlsYXRp b24gYWZ0ZXIgcjc5ODA2LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC9xZ3JhcGhpY3N3a3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xZ3JhcGhpY3N3a3ZpZXcuY3BwCmluZGV4IDJmYzM0YTA2ODllNTU2NzFjYjNjNTEwNWQyNzU0 NDYzOWJkMTFmNDQuLmU3MmYxMzMwNjk4NTE3NmNmNjA0ZDkxNDdhZDNjMmY2ZDFiNDRlM2EgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2aWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmll dy5jcHAKQEAgLTMyNyw2ICszMjcsMTMgQEAgdm9pZCBRR3JhcGhpY3NXS1ZpZXc6OmZvY3VzT3V0 RXZlbnQoUUZvY3VzRXZlbnQqKQogICAgIHBhZ2UoKS0+ZC0+cGFnZS0+dmlld1N0YXRlRGlkQ2hh bmdlKFdlYlBhZ2VQcm94eTo6Vmlld0lzRm9jdXNlZCB8IFdlYlBhZ2VQcm94eTo6Vmlld1dpbmRv d0lzQWN0aXZlKTsKIH0KIAorCisvKiEKKyAgICBUaGlzIHNsb3QgaXMgY2FsbGVkIHdoZW4gdGhl IGVuZ2luZSByZXF1aXJlIGEgY29udGV4dCBzZW5zaXRpdmUgbWVudSB0byBiZSBkaXNwbGF5ZWQu CisKKyAgICBUaGUgXGEgbWVudSBwYXNzZWQgYXMgYSBwYXJhbWV0ZXIgaXMgdGhlIG1lbnUgdG8g YmUgZGlzcGxheWVkLiBJdCBpcyBwb3B1bGF0ZWQgd2l0aCB0aGUKKyAgICBhY3Rpb25zIHBvc3Np YmxlIGZvciBpdHMgY3VycmVudCBwb3NpdGlvbiwgaXQgaXMgZW1wdHkgaWYgdGhlcmUgaXMgbm8g YWN0aW9uIGZvciB0aGUgcG9zaXRpb24uCisqLwogdm9pZCBRR3JhcGhpY3NXS1ZpZXc6OnNob3dD b250ZXh0TWVudShRU2hhcmVkUG9pbnRlcjxRTWVudT4gbWVudSkKIHsKICAgICAvLyBSZW1vdmUg dGhlIGFjdGl2ZSBtZW51IGluIGNhc2UgdGhpcyBmdW5jdGlvbiBpcyBjYWxsZWQgdHdpY2UuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmll dy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuaApp bmRleCAwNzBjYmVkMGMzNDk2OWU0OWM3MTljNDlmMzI0YzM5ZWM4MGYwYmVkLi4wM2ZjNzIyMzg1 MTAwODRmNjcwMzNkZmU5MDRhZTI4ODViYjMxYjBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2aWV3LmgKQEAgLTY4LDYgKzY4LDcgQEAgcHVi bGljIFFfU0xPVFM6CiAgICAgdm9pZCBmb3J3YXJkKCk7CiAgICAgdm9pZCByZWxvYWQoKTsKICAg ICB2b2lkIHN0b3AoKTsKKyAgICB2b2lkIHNob3dDb250ZXh0TWVudShRU2hhcmVkUG9pbnRlcjxR TWVudT4pOwogCiBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkIGtleVByZXNzRXZlbnQoUUtl eUV2ZW50Kik7CkBAIC04OCw5ICs4OSw2IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIHZvaWQg Zm9jdXNJbkV2ZW50KFFGb2N1c0V2ZW50Kik7CiAgICAgdmlydHVhbCB2b2lkIGZvY3VzT3V0RXZl bnQoUUZvY3VzRXZlbnQqKTsKIAotcHJpdmF0ZSBRX1NMT1RTOgotICAgIHZvaWQgc2hvd0NvbnRl eHRNZW51KFFTaGFyZWRQb2ludGVyPFFNZW51Pik7Ci0KIHByaXZhdGU6CiAgICAgUV9QUklWQVRF X1NMT1QoZCwgdm9pZCBvblNjYWxlQ2hhbmdlZCgpKTsKIAo=