55322 2011-02-27 10:09:38 -0800 [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject() 2011-02-27 11:39:11 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 benjamin benjamin commit-queue noam oldest_to_newest 358709 0 benjamin 2011-02-27 10:09:38 -0800 The QtWebKit bridge documentation is important to do anything non-trivial with QWebFrame::addToJavaScriptWindowObject(), the page should be referenced from there so people would find it more easily. 358711 1 83977 benjamin 2011-02-27 10:14:43 -0800 Created attachment 83977 Patch 358712 2 83977 kling 2011-02-27 10:15:45 -0800 Comment on attachment 83977 Patch Did you performance test this? 358740 3 commit-queue 2011-02-27 11:37:29 -0800 The commit-queue encountered the following flaky tests while processing attachment 83977: animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 358741 4 83977 commit-queue 2011-02-27 11:39:06 -0800 Comment on attachment 83977 Patch Clearing flags on attachment: 83977 Committed r79826: <http://trac.webkit.org/changeset/79826> 358742 5 commit-queue 2011-02-27 11:39:11 -0800 All reviewed patches have been landed. Closing bug. 83977 2011-02-27 10:14:43 -0800 2011-02-27 11:39:06 -0800 Patch 55322.diff text/plain 1739 benjamin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCmluZGV4IGFiMzg1NGQuLjU3MDZlZTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvU291cmNlL1dl YktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcApAQCAtNTU0LDYgKzU1NCw3IEBAIFFXZWJGcmFtZTo6 flFXZWJGcmFtZSgpCiAKICAgICBRdCBwcm9wZXJ0aWVzIHdpbGwgYmUgZXhwb3NlZCBhcyBKYXZh U2NyaXB0IHByb3BlcnRpZXMgYW5kIHNsb3RzIGFzCiAgICAgSmF2YVNjcmlwdCBtZXRob2RzLgor ICAgIFRoZSBpbnRlcmFjdGlvbiBiZXR3ZWVuIEMrKyBhbmQgSmF2YVNjcmlwdCBpcyBleHBsYWlu ZWQgaW4gdGhlIGRvY3VtZW50YXRpb24gb2YgdGhlIFxse1RoZSBRdFdlYktpdCBCcmlkZ2V9e1F0 V2ViS2l0IGJyaWRnZX0uCiAKICAgICBJZiB5b3Ugd2FudCB0byBlbnN1cmUgdGhhdCB5b3VyIFFP YmplY3RzIHJlbWFpbiBhY2Nlc3NpYmxlIGFmdGVyIGxvYWRpbmcgYQogICAgIG5ldyBVUkwsIHlv dSBzaG91bGQgYWRkIHRoZW0gaW4gYSBzbG90IGNvbm5lY3RlZCB0byB0aGUKQEAgLTU3OCw2ICs1 NzksNyBAQCB2b2lkIFFXZWJGcmFtZTo6YWRkVG9KYXZhU2NyaXB0V2luZG93T2JqZWN0KGNvbnN0 IFFTdHJpbmcgJm5hbWUsIFFPYmplY3QgKm9iamVjdAogCiAgICAgUXQgcHJvcGVydGllcyB3aWxs IGJlIGV4cG9zZWQgYXMgSmF2YVNjcmlwdCBwcm9wZXJ0aWVzIGFuZCBzbG90cyBhcwogICAgIEph dmFTY3JpcHQgbWV0aG9kcy4KKyAgICBUaGUgaW50ZXJhY3Rpb24gYmV0d2VlbiBDKysgYW5kIEph dmFTY3JpcHQgaXMgZXhwbGFpbmVkIGluIHRoZSBkb2N1bWVudGF0aW9uIG9mIHRoZSBcbHtUaGUg UXRXZWJLaXQgQnJpZGdlfXtRdFdlYktpdCBicmlkZ2V9LgogCiAgICAgSWYgeW91IHdhbnQgdG8g ZW5zdXJlIHRoYXQgeW91ciBRT2JqZWN0cyByZW1haW4gYWNjZXNzaWJsZSBhZnRlciBsb2FkaW5n IGEKICAgICBuZXcgVVJMLCB5b3Ugc2hvdWxkIGFkZCB0aGVtIGluIGEgc2xvdCBjb25uZWN0ZWQg dG8gdGhlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDFkMjRiZmQuLjQ3ZjQ1NTAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMjcgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1p bi5wb3VsYWluQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbUXRdIFJlZmVyZW5jZSB0aGUgZG9jdW1lbnRhdGlvbiBvZiB0aGUgV2Vi S2l0IGJyaWRnZSBmcm9tIFFXZWJGcmFtZTo6YWRkVG9KYXZhU2NyaXB0V2luZG93T2JqZWN0KCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MzIyCisK KyAgICAgICAgRG9jdW1lbnRhdGlvbiB1cGRhdGUsIGFkZCBhIHJlZmVyZW5jZSB0byB0aGUgUXRX ZWJLaXQgYnJpZGdlIHBhZ2UuCisKKyAgICAgICAgKiBBcGkvcXdlYmZyYW1lLmNwcDoKKwogMjAx MS0wMi0yNiAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgo=