55318 2011-02-27 09:18:47 -0800 Crash logs aren't saved on Windows 7 when a relative --results-directory path is used (like on the test slaves) 2011-02-27 09:30:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED PlatformOnly P2 Normal --- 44135 1 aroben aroben sfalken oldest_to_newest 358691 0 aroben 2011-02-27 09:18:47 -0800 Crash logs aren't saved on Windows 7 when a relative --results-directory path is used (like on the test slaves). Windows XP does not have this issue. The problem is due to a difference in how the post-mortem debugger is launched on these two OSes. Windows XP: The post-mortem debugger is a child process of the crashing process, and its working directory matches the crashing process's. Windows 7: The post-mortem debugger is a child process of WerFault.exe, and its working directory is c:\Windows\system32. We save crash logs to a location relative to $testResultsDirectory in old-run-webkit-tests. When a relative path is passed to --results-directory, the path to the crash log file ends up being relative, too. Since the post-mortem debugger's working directory is c:\Windows\system32, the crash log file path gets resolved against that path, rather than getting resolved against old-run-webkit-tests working directory. 358694 1 83975 aroben 2011-02-27 09:26:37 -0800 Created attachment 83975 Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving 358695 2 aroben 2011-02-27 09:30:25 -0800 Committed r79819: <http://trac.webkit.org/changeset/79819> 83975 2011-02-27 09:26:37 -0800 2011-02-27 09:28:01 -0800 Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving bug-55318-20110227122639.patch text/plain 2120 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogNzk4MTYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkYTg3NGNlYWVhODBkOGEyYzAzMDlmNzgxYzRlNDBlODI4 YWRhZDM2Li42YmFhZGQyYzFhYmM4ZjMyZjIxYmU4ODMwMjdlMDYyMjE2NGIzM2Q5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMDItMjcgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCisgICAgICAg IEVuc3VyZSAkdGVzdFJlc3VsdHNEaXJlY3RvcnkgaXMgYW4gYWJzb2x1dGUgcGF0aCBiZWZvcmUg c2V0dGluZyB1cCBXaW5kb3dzIGNyYXNoIGxvZyBzYXZpbmcKKworICAgICAgICBXaW5kb3dzIDcg KGFuZCBtYXliZSBWaXN0YT8pIGxhdW5jaGVzIHRoZSBwb3N0LW1vcnRlbSBkZWJ1Z2dlciB3aXRo IGEgd29ya2luZyBkaXJlY3RvcnkgdGhhdAorICAgICAgICBpcyBkaWZmZXJlbnQgZnJvbSBvbGQt cnVuLXdlYmtpdC10ZXN0J3MuIEJlY2F1c2Ugb2YgdGhpcywgdGhlIHBhdGggdG8gdGhlIGNyYXNo IGxvZyBmaWxlCisgICAgICAgICh3aGljaCBpcyByZWxhdGl2ZSB0byAkdGVzdFJlc3VsdHNEaXJl Y3RvcnkpIG11c3QgYmUgYW4gYWJzb2x1dGUgcGF0aC4gU2VlIHRoZSBidWcgZm9yIG1vcmUKKyAg ICAgICAgZGV0YWlscy4KKworICAgICAgICBGaXhlcyA8aHR0cDovL3dlYmtpdC5vcmcvYi81NTMx OD4gQ3Jhc2ggbG9ncyBhcmVuJ3Qgc2F2ZWQgb24gV2luZG93cyA3IHdoZW4gYSByZWxhdGl2ZQor ICAgICAgICAtLXJlc3VsdHMtZGlyZWN0b3J5IHBhdGggaXMgdXNlZCAobGlrZSBvbiB0aGUgdGVz dCBzbGF2ZXMpCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOiBNb3ZlZCB0aGUgY2FsbCB0byBzZXRV cFdpbmRvd3NDcmFzaExvZ1NhdmluZyBhZnRlciB3ZSd2ZQorICAgICAgICBtYWRlICR0ZXN0UmVz dWx0c0RpcmVjdG9yeSBhbiBhYnNvbHV0ZSBwYXRoLgorCiAyMDExLTAyLTI2ICBEb21pbmljIE1h enpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0g QmFydGguCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzIGIv VG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwppbmRleCBhODVjZjk2ZmRlYzA1ZmMx ODMxODViMzlmNmFmMGI1ZWRiNTJjM2RkLi5kNWIzMjg5NTUwY2M3ZjY4YmM2Y2M1NWM4NTc3MmM2 YjkwZjQ0OTMzIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3Rz CisrKyBiL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKQEAgLTQwMyw4ICs0MDMs NiBAQCAkdGVzdE1lZGlhID0gMCBpZiAkc2hvdWxkQ2hlY2tMZWFrcyAmJiBpc1RpZ2VyKCk7CiAj IEdlbmVyYXRpbmcgcmVtb3RlIGxpbmtzIGNhdXNlcyBhIGxvdCBvZiB1bm5lY2Vzc2FyeSBzcGV3 IG9uIEdUSyBidWlsZCBib3QKICR1c2VSZW1vdGVMaW5rc1RvVGVzdHMgPSAwIGlmIGlzR3RrKCk7 CiAKLXNldFVwV2luZG93c0NyYXNoTG9nU2F2aW5nKCkgaWYgaXNDeWd3aW4oKTsKLQogc2V0Q29u ZmlndXJhdGlvblByb2R1Y3REaXIoQ3dkOjphYnNfcGF0aCgkcm9vdCkpIGlmIChkZWZpbmVkKCRy b290KSk7CiBteSAkcHJvZHVjdERpciA9IHByb2R1Y3REaXIoKTsKICRwcm9kdWN0RGlyIC49ICIv YmluIiBpZiBpc1F0KCk7CkBAIC00NjQsOSArNDYyLDEwIEBAIGlmIChpc0FwcGxlTWFjV2ViS2l0 KCkpIHsKICAgICBpZiAoc3lzdGVtKCIvdXNyL2Jpbi9tYWtlIiwgIi1DIiwgIiRqYXZhVGVzdHNE aXJlY3RvcnkiKSkgewogICAgICAgICBleGl0IDE7CiAgICAgfQorfSBlbHNpZiAoaXNDeWd3aW4o KSkgeworICAgIHNldFVwV2luZG93c0NyYXNoTG9nU2F2aW5nKCk7CiB9CiAKLQogcHJpbnQgIlJ1 bm5pbmcgdGVzdHMgZnJvbSAkdGVzdERpcmVjdG9yeVxuIjsKIGlmICgkcGl4ZWxUZXN0cykgewog ICAgIHByaW50ICJFbmFibGluZyBwaXhlbCB0ZXN0cyB3aXRoIGEgdG9sZXJhbmNlIG9mICR0b2xl cmFuY2UlXG4iOwo=