<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>55314</bug_id>
          
          <creation_ts>2011-02-26 18:20:46 -0800</creation_ts>
          <short_desc>[GTK] Build failed with ‘GDK_KEY_KP_Space’ was not declared in this scope</short_desc>
          <delta_ts>2011-03-29 15:01:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter>marinalan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>alex</cc>
    
    <cc>eric</cc>
    
    <cc>mrobinson</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>358621</commentid>
    <comment_count>0</comment_count>
    <who name="">marinalan</who>
    <bug_when>2011-02-26 18:20:46 -0800</bug_when>
    <thetext>Steps to reproduce:

svn update
./autogen.sh --enable-web-sockets --enable-geolocation --enable-3D-transforms --enable-filters --enable-webkit2
make

After many hours of compilation:....
-----------------------------------------
.......
  CXX    Source/WebCore/bindings/js/libwebkit2gtk_1_0_la-JSDOMImplementationCustom.lo
  CXX    Source/WebCore/storage/libwebkit2gtk_1_0_la-IDBBackingStore.lo
  CXX    Source/WebCore/platform/graphics/gstreamer/libwebkit2gtk_1_0_la-GRefPtrGStreamer.lo
  CXX    Source/WebKit/gtk/webkit/libWebKit2_la-webkiterror.lo
  CXX    Source/WebKit2/Shared/gtk/libWebKit2_la-NativeWebKeyboardEventGtk.lo
  CXX    Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo
Source/WebKit2/Shared/gtk/WebEventFactory.cpp: In function ‘bool WebKit::isGdkKeyCodeFromKeyPad(unsigned int)’:
Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_Space’ was not declared in this scope
Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_9’ was not declared in this scope
make[1]: *** [Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo] Error 1

-------------------------------

svn info
Path: .
URL: http://svn.webkit.org/repository/webkit/trunk
Repository Root: http://svn.webkit.org/repository/webkit
Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Revision: 79798
Node Kind: directory
Schedule: normal
Last Changed Author: commit-queue@webkit.org
Last Changed Rev: 79798
Last Changed Date: 2011-02-26 10:26:08 -0800 (Sat, 26 Feb 2011)

------------------------------
Environment: Fedora13</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>358622</commentid>
    <comment_count>1</comment_count>
    <who name="">marinalan</who>
    <bug_when>2011-02-26 18:22:57 -0800</bug_when>
    <thetext>Can you suggest me with what configure parameters of autogen.sh
webkit for GTK can be built from code in trunk of subversion?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363444</commentid>
    <comment_count>2</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-03-07 11:38:13 -0800</bug_when>
    <thetext>Thanks for reporting this issue. Two thing that may interest you though:

1. 3D transformations are not implemented for GTK+ currently.
2. WebKit2 is far from usable with the GTK+ port currently.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>370237</commentid>
    <comment_count>3</comment_count>
    <who name="">marinalan</who>
    <bug_when>2011-03-20 13:55:13 -0700</bug_when>
    <thetext>./autogen.sh --enable-web-sockets --enable-mathml --enable-geolocation  --enable-filters --enable-directory-upload --enable-file-system --enable-webkit2


also ends with ....
---------------------------

  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriter.lo
  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriterCallback.lo
  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriterSync.lo
  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFlags.lo
  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSMetadata.lo
  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSMetadataCallback.lo
  CXX    Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo
Source/WebKit2/Shared/gtk/WebEventFactory.cpp: In function ‘bool WebKit::isGdkKeyCodeFromKeyPad(unsigned int)’:
Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_Space’ was not declared in this scope
Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_9’ was not declared in this scope
make[1]: *** [Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo] Error 1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>370446</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-03-21 10:21:16 -0700</bug_when>
    <thetext>
&gt;   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriter.lo
&gt;   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriterCallback.lo
&gt;   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriterSync.lo
&gt;   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFlags.lo
&gt;   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSMetadata.lo
&gt;   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSMetadataCallback.lo
&gt;   CXX    Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo
&gt; Source/WebKit2/Shared/gtk/WebEventFactory.cpp: In function ‘bool WebKit::isGdkKeyCodeFromKeyPad(unsigned int)’:
&gt; Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_Space’ was not declared in this scope
&gt; Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_9’ was not declared in this scope
&gt; make[1]: *** [Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo] Error 1


What version of GDK/GTK+ do you have? GDK_KEY_KP_Space and GDK_KEY_KP_9 should be defined in gdkkeysyms.h.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>371112</commentid>
    <comment_count>5</comment_count>
    <who name="">marinalan</who>
    <bug_when>2011-03-21 18:12:44 -0700</bug_when>
    <thetext>I am on Fedora 13, and among rpm packages I see gtk2-2.20.1-1.fc13.i686, so probably my GTK version is 2.10.1


I do have file /usr/include/gtk-2.0/gdk/gdkkeysyms.h
and I can not find within it strings GDK_KEY_KP_9 or GDK_KEY_KP_Space

But when i was running ./autogen.sh, it was not telling me that my GTK version is too old, autogen.sh/configure do not check that

Marina</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375737</commentid>
    <comment_count>6</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-03-29 14:05:38 -0700</bug_when>
    <thetext>Committed r82318: &lt;http://trac.webkit.org/changeset/82318&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375739</commentid>
    <comment_count>7</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-03-29 14:06:17 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; Committed r82318: &lt;http://trac.webkit.org/changeset/82318&gt;

Thanks for reporting this issue! I believe it has been fixed in the repository. Feel free to reopen the issue if you still have problems.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>375788</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-03-29 15:01:06 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/82318 might have broken Windows 7 Release (Tests)</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>