5531 2005-10-28 03:24:15 -0700 1px gap appears between percent-sized floats adding to 100% 2022-07-06 13:12:13 -0700 1 1 1 Unclassified WebKit Layout and Rendering 412 Mac OS X 10.4 RESOLVED CONFIGURATION CHANGED http://problemattic.net/files/round-error.html InRadar P2 Minor --- 5164 1 matt webkit-unassigned bfulgham ian leviw robert scheglov waldelefant+bugzilla webkit-bug-importer oldest_to_newest 23114 0 matt 2005-10-28 03:24:15 -0700 With two floats, widths 22% and 78%, and floated in opposite directions, a 1 pixel gap appears between them. 22 + 78 = 100, therefore there should be no gap. Likely a rounding problem. Expected result: no gap Actual result: 1 pixel gap 23118 1 4507 matt 2005-10-28 03:26:30 -0700 Created attachment 4507 Test Case/Reduction for bug 23235 2 ap 2005-10-29 10:50:04 -0700 Firefox 1.0.5, MacIE and WinIE render the test without a gap; Opera 8.50 renders it like Safari. 26865 3 eric 2005-12-27 15:44:29 -0800 Yes, we use integers for storing these sorts of values. It's possible this might also be due to the QRect width/height off-by-one confusion found so often in our code. 16042 4 ap 2007-03-31 11:42:39 -0700 Actually, Firefox 1.5 doesn't always render this test case without a gap: it appears at certain page widths. 11401 5 waldelefant+bugzilla 2007-05-03 07:53:43 -0700 This bug also appears, if both divs are floated with left. The gab appears simply at end (i.e. right) of the line. Also it seems the bug does not depend on the values (22%, 78%). For example: use 50%, 50% as width. you will also see a gab at end. If you don't, resize the window and you will see the gab. Possibly it depends on whether the window's width can be divided integrally in 50%, 50%. The gab becomes bigger with number of the divs. This bug is quite anoying for peoples who try to eliminate tables from their layouts XD 11402 6 14318 waldelefant+bugzilla 2007-05-03 08:03:01 -0700 Created attachment 14318 testcase with more than two divs a testcase for last comment of mine. Four divs floated within a container (div). You see a gap at the end of the line/container. The gap's size changes (kind of flicker), if you resize the window. 473123 7 scheglov 2011-09-26 08:53:06 -0700 Just for records. Problem is that integer type is used to store width and location. So, when Length::calcMinValue calculates: return static_cast<int>(static_cast<float>(maxValue * percent() / 100.0f)); For maxValue=201px we get 100 for one float 50% and for another float 50%. So, we get 1px gap at the right. I'm not sure how to solve this without using floating point. It seems that Firefox uses floating point here, because it shows 100.5px in calculated style. 478546 8 scheglov 2011-10-05 11:41:11 -0700 May be https://bugs.webkit.org/show_bug.cgi?id=60318 will fix this, or at least will make solution easier. 746427 9 robert 2012-10-19 10:36:48 -0700 Both test cases look fine to me as of r131397. Can the reporters confirm and we can close? 746994 10 matt 2012-10-20 14:26:00 -0700 I just tested in r131989, and my two-div test case still shows the problem. There should be no white space between the two divs. (Note that resizing your browser window will cause the gap to appear and disappear at certain points.) 746997 11 waldelefant+bugzilla 2012-10-20 14:40:14 -0700 I see gaps in both test cases, running r131989 on 10.8 747058 12 robert 2012-10-21 02:33:36 -0700 I though all ports were using subpixel precision but maybe that's not the case - http://trac.webkit.org/wiki/LayoutUnit. Adding Levi as this seems subpixel-related - and I can't recreate on Chrome. 1881062 13 bfulgham 2022-07-06 13:11:45 -0700 Safari, Firefox, and Chrome match behavior here. Both test cases work identically on all browsers. 1881063 14 webkit-bug-importer 2022-07-06 13:12:13 -0700 <rdar://problem/96543246> 4507 2005-10-28 03:26:30 -0700 2005-10-28 03:26:30 -0700 Test Case/Reduction for bug round-error.html text/html 775 matt PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9FTiIg DSJodHRwOi8vd3d3LnczLm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJpY3QuZHRkIj4NPGh0 bWwgeG1sbnM9Imh0dHA6Ly93d3cuYXBwbGUuY29tLzIwMDQveGh0bWwtZXh0ZW5kZWQvIj4NPGhl YWQ+DQk8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsg Y2hhcnNldD1VVEYtOCIgLz4NCTx0aXRsZT5QZXJjZW50IFJvdW5kaW5nIEVycm9yIEJ1ZzogVGVz dCBDYXNlPC90aXRsZT4KCTxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CiAgICAgICAgI2xhcmdlIHsK ICAgICAgICAgICAgd2lkdGg6IDc4JTsKICAgICAgICAgICAgZmxvYXQ6IGxlZnQ7CiAgICAgICAg ICAgIGJhY2tncm91bmQtY29sb3I6ICMwMDA7CiAgICAgICAgICAgIGNvbG9yOiAjZmZmOwogICAg ICAgIH0KICAgICAgICAKICAgICAgICAjc21hbGwgewogICAgICAgICAgICB3aWR0aDogMjIlOwog ICAgICAgICAgICBmbG9hdDogcmlnaHQ7CiAgICAgICAgICAgIGJhY2tncm91bmQtY29sb3I6ICMz MzM7CiAgICAgICAgICAgIGNvbG9yOiAjZmZmOwogICAgICAgIH0KCTwvc3R5bGU+DTwvaGVhZD4N PGJvZHk+CiAgICAgICAgPGRpdiBpZD0ibGFyZ2UiPgogICAgICAgICAgICBEaXYgMQogICAgICAg IDwvZGl2PgogICAgICAgIAogICAgICAgIDxkaXYgaWQ9InNtYWxsIj4KICAgICAgICAgICAgRGl2 IDIKICAgICAgICA8L2Rpdj4NPC9ib2R5Pg08L2h0bWw+DQ== 14318 2007-05-03 08:03:01 -0700 2007-05-03 08:03:01 -0700 testcase with more than two divs index.htm text/html 504 waldelefant+bugzilla PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIiAiaHR0cDov L3d3dy53My5vcmcvVFIvaHRtbDQvc3RyaWN0LmR0ZCI+CjxodG1sPgo8aGVhZD4KPG1ldGEgaHR0 cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9aXNvLTg4 NTktMSIgLz4KPHN0eWxlPgoKLmNvbHMgewoJb3ZlcmZsb3c6IGhpZGRlbjsKCWJvcmRlcjogMXB4 IHNvbGlkICMwOGY7Cn0KCi5jb2xzID4gZGl2IHsKCWZsb2F0OiBsZWZ0OwoJd2lkdGg6IDI1JTsK fQoKLmNvbHMgPiBkaXYgPiBkaXYgewoJYm9yZGVyOiAxcHggc29saWQgcmVkOwp9Cgo8L3N0eWxl Pgo8L2hlYWQ+Cjxib2R5Pgo8ZGl2IGNsYXNzPSJjb2xzIj4KPGRpdj48ZGl2PiAxIDwvZGl2Pjwv ZGl2Pgo8ZGl2PjxkaXY+IDIgPC9kaXY+PC9kaXY+CjxkaXY+PGRpdj4gMyA8L2Rpdj48L2Rpdj4K PGRpdj48ZGl2PiA0IDwvZGl2PjwvZGl2Pgo8L2Rpdj4KPC9ib2R5Pgo8L2h0bWw+