55301 2011-02-26 11:24:33 -0800 [REGRESSION r79784?] Can't open Network panel in the inspector (assertion failed in layout) 2011-02-28 09:07:31 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 55386 P2 Normal --- 1 pfeldman webkit-unassigned aroben cabanier commit-queue hyatt jamesr simon.fraser oldest_to_newest 358554 0 pfeldman 2011-02-26 11:24:33 -0800 #0 0x1015d9687 in WebCore::Length::setValue at Length.h:91 #1 0x1019104ab in WebCore::FixedTableLayout::calcWidthArray at FixedTableLayout.cpp:121 #2 0x10191095f in WebCore::FixedTableLayout::computePreferredLogicalWidths at FixedTableLayout.cpp:204 #3 0x1020794d3 in WebCore::RenderTable::computePreferredLogicalWidths at RenderTable.cpp:574 #4 0x101f8c035 in WebCore::RenderBox::minPreferredLogicalWidth at RenderBox.cpp:659 #5 0x10207b2dc in WebCore::RenderTable::computeLogicalWidth at RenderTable.cpp:219 #6 0x10207a5f4 in WebCore::RenderTable::layout at RenderTable.cpp:278 #7 0x101f5ed92 in WebCore::RenderBlock::layoutBlockChild at RenderBlock.cpp:1958 #8 0x101f6093f in WebCore::RenderBlock::layoutBlockChildren at RenderBlock.cpp:1896 #9 0x101f60fb4 in WebCore::RenderBlock::layoutBlock at RenderBlock.cpp:1224 #10 0x101f5fc6e in WebCore::RenderBlock::layout at RenderBlock.cpp:1120 #11 0x101f83337 in WebCore::RenderObject::layoutIfNeeded at RenderObject.h:520 #12 0x101f5df34 in WebCore::RenderBlock::layoutPositionedObjects at RenderBlock.cpp:2137 #13 0x101f6128f in WebCore::RenderBlock::layoutBlock at RenderBlock.cpp:1255 #14 0x101f5fc6e in WebCore::RenderBlock::layout at RenderBlock.cpp:1120 #15 0x101f83337 in WebCore::RenderObject::layoutIfNeeded at RenderObject.h:520 #16 0x101f5df34 in WebCore::RenderBlock::layoutPositionedObjects at RenderBlock.cpp:2137 #17 0x101f6128f in WebCore::RenderBlock::layoutBlock at RenderBlock.cpp:1255 #18 0x101f5fc6e in WebCore::RenderBlock::layout at RenderBlock.cpp:1120 #19 0x101f83337 in WebCore::RenderObject::layoutIfNeeded at RenderObject.h:520 #20 0x101f5df34 in WebCore::RenderBlock::layoutPositionedObjects at RenderBlock.cpp:2137 #21 0x101f6128f in WebCore::RenderBlock::layoutBlock at RenderBlock.cpp:1255 #22 0x101f5fc6e in WebCore::RenderBlock::layout at RenderBlock.cpp:1120 #23 0x101f83337 in WebCore::RenderObject::layoutIfNeeded at RenderObject.h:520 #24 0x101f5df34 in WebCore::RenderBlock::layoutPositionedObjects at RenderBlock.cpp:2137 #25 0x101f6128f in WebCore::RenderBlock::layoutBlock at RenderBlock.cpp:1255 #26 0x101f5fc6e in WebCore::RenderBlock::layout at RenderBlock.cpp:1120 #27 0x101f83337 in WebCore::RenderObject::layoutIfNeeded at RenderObject.h:520 #28 0x101f5df34 in WebCore::RenderBlock::layoutPositionedObjects at RenderBlock.cpp:2137 #29 0x101f5fe50 in WebCore::RenderBlock::layoutOnlyPositionedObjects at RenderBlock.cpp:2087 #30 0x101f60a4e in WebCore::RenderBlock::layoutBlock at RenderBlock.cpp:1135 #31 0x101f5fc6e in WebCore::RenderBlock::layout at RenderBlock.cpp:1120 #32 0x101f83337 in WebCore::RenderObject::layoutIfNeeded at RenderObject.h:520 #33 0x101f5df34 in WebCore::RenderBlock::layoutPositionedObjects at RenderBlock.cpp:2137 #34 0x101f5fe50 in WebCore::RenderBlock::layoutOnlyPositionedObjects at RenderBlock.cpp:2087 #35 0x101f60a4e in WebCore::RenderBlock::layoutBlock at RenderBlock.cpp:1135 #36 0x101f5fc6e in WebCore::RenderBlock::layout at RenderBlock.cpp:1120 #37 0x101f83337 in WebCore::RenderObject::layoutIfNeeded at RenderObject.h:520 #38 0x101f5df34 in WebCore::RenderBlock::layoutPositionedObjects at RenderBlock.cpp:2137 #39 0x101f5fe50 in WebCore::RenderBlock::layoutOnlyPositionedObjects at RenderBlock.cpp:2087 #40 0x101f60a4e in WebCore::RenderBlock::layoutBlock at RenderBlock.cpp:1135 #41 0x101f5fc6e in WebCore::RenderBlock::layout at RenderBlock.cpp:1120 #42 0x1020b6fc3 in WebCore::RenderView::layout at RenderView.cpp:130 #43 0x101966cfc in WebCore::FrameView::layout at FrameView.cpp:906 #44 0x1017a5ef9 in WebCore::Document::updateLayout at Document.cpp:1592 #45 0x1017a85b8 in WebCore::Document::updateLayoutIgnorePendingStylesheets at Document.cpp:1623 #46 0x1018cd774 in WebCore::Element::focus at Element.cpp:1498 #47 0x101c3e412 in WebCore::jsElementPrototypeFunctionFocus at JSElement.cpp:1761 #48 0x279468c001b8 in ?? #49 0x1007e21f7 in JSC::JITCode::execute at JITCode.h:77 #50 0x1007dcc56 in JSC::Interpreter::executeCall at Interpreter.cpp:851 #51 0x10079632d in JSC::call at CallData.cpp:38 #52 0x100847b89 in JSC::JSObject::put at JSObject.cpp:149 #53 0x100815fbd in JSC::JSValue::put at JSObject.h:780 #54 0x10080f0ab in cti_op_put_by_id at JITStubs.cpp:1351 #55 0x100803dcd in WTF::doubleHash at HashTable.h:447 #56 0x1007e21f7 in JSC::JITCode::execute at JITCode.h:77 #57 0x1007dcc56 in JSC::Interpreter::executeCall at Interpreter.cpp:851 #58 0x10079632d in JSC::call at CallData.cpp:38 #59 0x100847b89 in JSC::JSObject::put at JSObject.cpp:149 #60 0x100815fbd in JSC::JSValue::put at JSObject.h:780 #61 0x10080f0ab in cti_op_put_by_id at JITStubs.cpp:1351 #62 0x100803dcd in WTF::doubleHash at HashTable.h:447 #63 0x1007e21f7 in JSC::JITCode::execute at JITCode.h:77 #64 0x1007dcc56 in JSC::Interpreter::executeCall at Interpreter.cpp:851 #65 0x10079632d in JSC::call at CallData.cpp:38 #66 0x1022d2f41 in WebCore::JSMainThreadExecState::call at JSMainThreadExecState.h:48 #67 0x101c50447 in WebCore::JSEventListener::handleEvent at JSEventListener.cpp:123 #68 0x1018ed642 in WebCore::EventTarget::fireEventListeners at EventTarget.cpp:354 #69 0x1018edc71 in WebCore::EventTarget::fireEventListeners at EventTarget.cpp:323 #70 0x101ec7d8f in WebCore::Node::handleLocalEvents at Node.cpp:2543 #71 0x1018d78d6 in WebCore::EventContext::handleLocalEvents at EventContext.cpp:48 #72 0x101ecff58 in WebCore::Node::dispatchGenericEvent at Node.cpp:2694 #73 0x101ed0379 in WebCore::Node::dispatchEvent at Node.cpp:2612 #74 0x101eceb58 in WebCore::Node::dispatchMouseEvent at Node.cpp:2902 #75 0x101ecf183 in WebCore::Node::dispatchMouseEvent at Node.cpp:2799 #76 0x1018df9af in WebCore::EventHandler::dispatchMouseEvent at EventHandler.cpp:1910 #77 0x1018e0f90 in WebCore::EventHandler::handleMouseReleaseEvent at EventHandler.cpp:1623 #78 0x1018e6fd5 in WebCore::EventHandler::mouseUp at EventHandlerMac.mm:546 #79 0x100ff8b3c in -[WebHTMLView mouseUp:] at WebHTMLView.mm:3764 #80 0x7fff8568d7ed in -[NSWindow sendEvent:] #81 0x100041bf5 in ?? #82 0x100041b81 in ?? #83 0x7fff855c2ee2 in -[NSApplication sendEvent:] #84 0x1000388c2 in ?? #85 0x7fff85559922 in -[NSApplication run] #86 0x7fff855525f8 in NSApplicationMain #87 0x100009b18 in ?? 358632 1 cabanier 2011-02-26 20:26:20 -0800 It's worse. Anything with table that have a percent will fail in debug mode. I will fix this. 358633 2 83962 cabanier 2011-02-26 20:59:59 -0800 Created attachment 83962 changed code to work around asserts + updated to real boolean values 358634 3 83963 cabanier 2011-02-26 21:13:38 -0800 Created attachment 83963 changed code to work around asserts + updated to real boolean values 358635 4 83964 cabanier 2011-02-26 21:26:44 -0800 Created attachment 83964 changed code to work around asserts + updated to real boolean values 358637 5 83964 abarth 2011-02-26 22:05:53 -0800 Comment on attachment 83964 changed code to work around asserts + updated to real boolean values View in context: https://bugs.webkit.org/attachment.cgi?id=83964&action=review This change needs a test. > Source/WebCore/ChangeLog:11 > + * WebCore.xcodeproj/project.pbxproj: Probably should remove this line from the changelog. 358641 6 83966 cabanier 2011-02-26 22:34:05 -0800 Created attachment 83966 changed code to work around asserts + updated to real boolean values + added test 358649 7 83966 pfeldman 2011-02-26 23:30:13 -0800 Comment on attachment 83966 changed code to work around asserts + updated to real boolean values + added test I don't see a test in this patch, 358683 8 cabanier 2011-02-27 08:55:55 -0800 (In reply to comment #7) > (From update of attachment 83966 [details]) > I don't see a test in this patch, The changelog is referring to a test file. Since this bug only happens in debug, I can't come up with a test case for the layout test since they don't run in debug. http://www.webkit.org/coding/contributing.html doesn't mention anything about creating testfiles. http://www.webkit.org/quality/testwriting.html does but that is if you change the layout which this code doesn't. 358706 9 aroben 2011-02-27 10:01:08 -0800 *** Bug 55321 has been marked as a duplicate of this bug. *** 358873 10 jamesr 2011-02-27 20:23:18 -0800 Layout tests can (and are) run in debug, which is why so many bots are having trouble with the previous patch. Why is it valid to remove this ASSERT()? Did it serve no purpose before? It looks like the table layout code was using setRawValue() when it wanted to directly set a value (and not go through this path), why did you change those to setValue()? 358876 11 cabanier 2011-02-27 20:29:26 -0800 (In reply to comment #10) > Layout tests can (and are) run in debug, which is why so many bots are having trouble with the previous patch. > > Why is it valid to remove this ASSERT()? Did it serve no purpose before? It looks like the table layout code was using setRawValue() when it wanted to directly set a value (and not go through this path), why did you change those to setValue()? I did that by request of dhyatt since at first glance there was no more difference between setValue and setRawValue and he thought it was less confusing than having 2 almost identical calls. These changes are definitely a work in progress as the intent is to move everything to float values at which point all the assert can go away. 358879 12 cabanier 2011-02-27 20:40:51 -0800 (In reply to comment #10) > Layout tests can (and are) run in debug, which is why so many bots are having trouble with the previous patch. > > Why is it valid to remove this ASSERT()? Did it serve no purpose before? It looks like the table layout code was using setRawValue() when it wanted to directly set a value (and not go through this path), why did you change those to setValue()? In response to question 1 and 2: the assert used to test that you didn't call setvalue with a percent value but SetRawValue. I guess this was done to make sure that you knew what your are doing (which seems hacky). 359035 13 83966 koivisto 2011-02-28 07:28:05 -0800 Comment on attachment 83966 changed code to work around asserts + updated to real boolean values + added test ChangeLog totally fails to explain the change but it does look correct. r+ anyway since this breaking stuff. 359043 14 83966 koivisto 2011-02-28 07:34:17 -0800 Comment on attachment 83966 changed code to work around asserts + updated to real boolean values + added test I take that back. This clearly changes the behavior of the quirks flag. It doesn't get reset anymore. Why is that ok? 359102 15 aroben 2011-02-28 09:07:31 -0800 We're rolling out the offending change. *** This bug has been marked as a duplicate of bug 55386 *** 83962 2011-02-26 20:59:59 -0800 2011-02-26 21:13:38 -0800 changed code to work around asserts + updated to real boolean values patch.txt text/plain 2556 cabanier SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5ODE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMjYgIFJpayBDYWJh bmllciAgPGNhYmFuaWVyQGFkb2JlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlZCBhIGJ1ZyBpbiB0aGUgYXNzZXJ0cyBvZiB0aGUgTGVu Z3RoIGNsYXNzLgorCQlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUz MDEKKwkJCisJCVRoaXMgYnVnIHdhcyBpbnRyb2R1Y2VkIGJ5IHRoZSBmaXggZm9yIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjY5OQorCQlJdCBpcyBvbmx5IGEgcHJv YmxlbSBpbiBkZWJ1ZyBidWlsZHMKKworICAgICAgICAqIFdlYkNvcmUueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvajoKKyAgICAgICAgKiBwbGF0Zm9ybS9MZW5ndGguaDoKKyAgICAgICAgKFdlYkNv cmU6Okxlbmd0aDo6TGVuZ3RoKToKKyAgICAgICAgKFdlYkNvcmU6Okxlbmd0aDo6c2V0VmFsdWUp OgorCiAyMDExLTAyLTI2ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9MZW5ndGguaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9MZW5ndGguaAkocmV2aXNpb24gNzk4MTUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9MZW5ndGguaAkod29ya2luZyBjb3B5KQpAQCAtNDAsMjggKzQwLDI4IEBAIHN0cnVjdCBM ZW5ndGggewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIExlbmd0 aCgpCi0gICAgICAgIDogbV9pbnRWYWx1ZSgwKSwgbV9xdWlyaygwKSwgbV90eXBlKEF1dG8pLCBt X2lzRmxvYXQoMCkKKyAgICAgICAgOiBtX2ludFZhbHVlKDApLCBtX3F1aXJrKDApLCBtX3R5cGUo QXV0byksIG1faXNGbG9hdChmYWxzZSkKICAgICB7CiAgICAgfQogCiAgICAgTGVuZ3RoKExlbmd0 aFR5cGUgdCkKLSAgICAgICAgOiBtX2ludFZhbHVlKDApLCBtX3F1aXJrKDApLCBtX3R5cGUodCks IG1faXNGbG9hdCgwKQorICAgICAgICA6IG1faW50VmFsdWUoMCksIG1fcXVpcmsoMCksIG1fdHlw ZSh0KSwgbV9pc0Zsb2F0KGZhbHNlKQogICAgIHsKICAgICB9CiAKICAgICBMZW5ndGgoaW50IHYs IExlbmd0aFR5cGUgdCwgYm9vbCBxID0gZmFsc2UpCi0gICAgICAgIDogbV9pbnRWYWx1ZSh2KSwg bV9xdWlyayhxKSwgbV90eXBlKHQpLCBtX2lzRmxvYXQoMCkKKyAgICAgICAgOiBtX2ludFZhbHVl KHYpLCBtX3F1aXJrKHEpLCBtX3R5cGUodCksIG1faXNGbG9hdChmYWxzZSkKICAgICB7CiAgICAg ICAgIEFTU0VSVCh0ICE9IFBlcmNlbnQpOwogICAgIH0KIAogICAgIExlbmd0aChkb3VibGUgdiwg TGVuZ3RoVHlwZSB0LCBib29sIHEgPSBmYWxzZSkKLSAgICAgICAgOiBtX3F1aXJrKHEpLCBtX3R5 cGUodCksIG1faXNGbG9hdCgwKQorICAgICAgICA6IG1fcXVpcmsocSksIG1fdHlwZSh0KSwgbV9p c0Zsb2F0KGZhbHNlKQogICAgIHsKICAgICAgICAgaWYgKG1fdHlwZSA9PSBQZXJjZW50KQogICAg ICAgICAgICAgbV9pbnRWYWx1ZSA9IHN0YXRpY19jYXN0PGludD4odipwZXJjZW50U2NhbGVGYWN0 b3IpOwogICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgIG1faXNGbG9hdCA9IDE7ICAgICAgICAg ICAgCisgICAgICAgICAgICBtX2lzRmxvYXQgPSB0cnVlOyAgICAgICAgICAgIAogICAgICAgICAg ICAgbV9mbG9hdFZhbHVlID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+KHYpOwogICAgICAgICB9CiAgICAg fQpAQCAtODgsOCArODgsOSBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHNldFZhbHVlKExlbmd0aFR5 cGUgdCwgaW50IHZhbHVlKQogICAgIHsKLSAgICAgICAgQVNTRVJUKHQgIT0gUGVyY2VudCk7Ci0g ICAgICAgICp0aGlzID0gTGVuZ3RoKHZhbHVlLCB0KTsKKyAgICAgICAgbV90eXBlID0gdDsKKyAg ICAgICAgbV9pbnRWYWx1ZSA9IHZhbHVlOworICAgICAgICBtX2lzRmxvYXQgPSBmYWxzZTsKICAg ICB9CiAKICAgICB2b2lkIHNldFZhbHVlKGludCB2YWx1ZSkKQEAgLTEwMCw3ICsxMDEsOSBAQCBw dWJsaWM6CiAKICAgICB2b2lkIHNldFZhbHVlKExlbmd0aFR5cGUgdCwgZG91YmxlIHZhbHVlKQog ICAgIHsKLSAgICAgICAgKnRoaXMgPSBMZW5ndGgodmFsdWUsIHQpOworICAgICAgICBtX3R5cGUg PSB0OworICAgICAgICBtX2Zsb2F0VmFsdWUgPSB2YWx1ZTsKKyAgICAgICAgbV9pc0Zsb2F0ID0g dHJ1ZTsKICAgICB9CiAKICAgICB2b2lkIHNldFZhbHVlKGRvdWJsZSB2YWx1ZSkK 83963 2011-02-26 21:13:38 -0800 2011-02-26 21:26:44 -0800 changed code to work around asserts + updated to real boolean values patch.txt text/plain 2566 cabanier SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5ODE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMjYgIFJpayBDYWJh bmllciAgPGNhYmFuaWVyQGFkb2JlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlZCBhIGJ1ZyBpbiB0aGUgYXNzZXJ0cyBvZiB0aGUgTGVu Z3RoIGNsYXNzLgorCQlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUz MDEKKwkJCisJCVRoaXMgYnVnIHdhcyBpbnRyb2R1Y2VkIGJ5IHRoZSBmaXggZm9yIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjY5OQorCQlJdCBpcyBvbmx5IGEgcHJv YmxlbSBpbiBkZWJ1ZyBidWlsZHMKKwkJCisgICAgICAgICogV2ViQ29yZS54Y29kZXByb2ovcHJv amVjdC5wYnhwcm9qOgorICAgICAgICAqIHBsYXRmb3JtL0xlbmd0aC5oOgorICAgICAgICAoV2Vi Q29yZTo6TGVuZ3RoOjpMZW5ndGgpOgorICAgICAgICAoV2ViQ29yZTo6TGVuZ3RoOjpzZXRWYWx1 ZSk6CisKIDIwMTEtMDItMjYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL0xlbmd0aC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL0xlbmd0aC5oCShyZXZpc2lvbiA3OTgxNSkKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL0xlbmd0aC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MCwyOCArNDAsMjggQEAgc3RydWN0 IExlbmd0aCB7CiAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgTGVu Z3RoKCkKLSAgICAgICAgOiBtX2ludFZhbHVlKDApLCBtX3F1aXJrKDApLCBtX3R5cGUoQXV0byks IG1faXNGbG9hdCgwKQorICAgICAgICA6IG1faW50VmFsdWUoMCksIG1fcXVpcmsoZmFsc2UpLCBt X3R5cGUoQXV0byksIG1faXNGbG9hdChmYWxzZSkKICAgICB7CiAgICAgfQogCiAgICAgTGVuZ3Ro KExlbmd0aFR5cGUgdCkKLSAgICAgICAgOiBtX2ludFZhbHVlKDApLCBtX3F1aXJrKDApLCBtX3R5 cGUodCksIG1faXNGbG9hdCgwKQorICAgICAgICA6IG1faW50VmFsdWUoMCksIG1fcXVpcmsoZmFs c2UpLCBtX3R5cGUodCksIG1faXNGbG9hdChmYWxzZSkKICAgICB7CiAgICAgfQogCiAgICAgTGVu Z3RoKGludCB2LCBMZW5ndGhUeXBlIHQsIGJvb2wgcSA9IGZhbHNlKQotICAgICAgICA6IG1faW50 VmFsdWUodiksIG1fcXVpcmsocSksIG1fdHlwZSh0KSwgbV9pc0Zsb2F0KDApCisgICAgICAgIDog bV9pbnRWYWx1ZSh2KSwgbV9xdWlyayhxKSwgbV90eXBlKHQpLCBtX2lzRmxvYXQoZmFsc2UpCiAg ICAgewogICAgICAgICBBU1NFUlQodCAhPSBQZXJjZW50KTsKICAgICB9CiAKICAgICBMZW5ndGgo ZG91YmxlIHYsIExlbmd0aFR5cGUgdCwgYm9vbCBxID0gZmFsc2UpCi0gICAgICAgIDogbV9xdWly ayhxKSwgbV90eXBlKHQpLCBtX2lzRmxvYXQoMCkKKyAgICAgICAgOiBtX3F1aXJrKHEpLCBtX3R5 cGUodCksIG1faXNGbG9hdChmYWxzZSkKICAgICB7CiAgICAgICAgIGlmIChtX3R5cGUgPT0gUGVy Y2VudCkKICAgICAgICAgICAgIG1faW50VmFsdWUgPSBzdGF0aWNfY2FzdDxpbnQ+KHYqcGVyY2Vu dFNjYWxlRmFjdG9yKTsKICAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICBtX2lzRmxvYXQgPSAx OyAgICAgICAgICAgIAorICAgICAgICAgICAgbV9pc0Zsb2F0ID0gdHJ1ZTsgICAgICAgICAgICAK ICAgICAgICAgICAgIG1fZmxvYXRWYWx1ZSA9IHN0YXRpY19jYXN0PGZsb2F0Pih2KTsKICAgICAg ICAgfQogICAgIH0KQEAgLTg4LDggKzg4LDkgQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXRWYWx1 ZShMZW5ndGhUeXBlIHQsIGludCB2YWx1ZSkKICAgICB7Ci0gICAgICAgIEFTU0VSVCh0ICE9IFBl cmNlbnQpOwotICAgICAgICAqdGhpcyA9IExlbmd0aCh2YWx1ZSwgdCk7CisgICAgICAgIG1fdHlw ZSA9IHQ7CisgICAgICAgIG1faW50VmFsdWUgPSB2YWx1ZTsKKyAgICAgICAgbV9pc0Zsb2F0ID0g ZmFsc2U7CiAgICAgfQogCiAgICAgdm9pZCBzZXRWYWx1ZShpbnQgdmFsdWUpCkBAIC0xMDAsNyAr MTAxLDkgQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXRWYWx1ZShMZW5ndGhUeXBlIHQsIGRvdWJs ZSB2YWx1ZSkKICAgICB7Ci0gICAgICAgICp0aGlzID0gTGVuZ3RoKHZhbHVlLCB0KTsKKyAgICAg ICAgbV90eXBlID0gdDsKKyAgICAgICAgbV9mbG9hdFZhbHVlID0gdmFsdWU7CisgICAgICAgIG1f aXNGbG9hdCA9IHRydWU7CiAgICAgfQogCiAgICAgdm9pZCBzZXRWYWx1ZShkb3VibGUgdmFsdWUp Cg== 83964 2011-02-26 21:26:44 -0800 2011-02-26 22:34:05 -0800 changed code to work around asserts + updated to real boolean values patch.txt text/plain 2580 cabanier SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5ODE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMjYgIFJpayBDYWJh bmllciAgPGNhYmFuaWVyQGFkb2JlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlZCBhIGJ1ZyBpbiB0aGUgYXNzZXJ0cyBvZiB0aGUgTGVu Z3RoIGNsYXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTUzMDEKKworICAgICAgICBUaGlzIGJ1ZyB3YXMgaW50cm9kdWNlZCBieSB0aGUgZml4IGZv ciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI2OTkKKyAgICAgICAg SXQgaXMgb25seSBhIHByb2JsZW0gaW4gZGVidWcgYnVpbGRzCisKKyAgICAgICAgKiBXZWJDb3Jl Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6CisgICAgICAgICogcGxhdGZvcm0vTGVuZ3RoLmg6 CisgICAgICAgIChXZWJDb3JlOjpMZW5ndGg6Okxlbmd0aCk6CisgICAgICAgIChXZWJDb3JlOjpM ZW5ndGg6OnNldFZhbHVlKToKKwogMjAxMS0wMi0yNiAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJv Z2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292 LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGVuZ3RoLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGVuZ3RoLmgJKHJldmlzaW9uIDc5ODE1KQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGVuZ3RoLmgJKHdvcmtpbmcgY29weSkKQEAgLTQwLDI4ICs0 MCwyOCBAQCBzdHJ1Y3QgTGVuZ3RoIHsKICAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1 YmxpYzoKICAgICBMZW5ndGgoKQotICAgICAgICA6IG1faW50VmFsdWUoMCksIG1fcXVpcmsoMCks IG1fdHlwZShBdXRvKSwgbV9pc0Zsb2F0KDApCisgICAgICAgIDogbV9pbnRWYWx1ZSgwKSwgbV9x dWlyayhmYWxzZSksIG1fdHlwZShBdXRvKSwgbV9pc0Zsb2F0KGZhbHNlKQogICAgIHsKICAgICB9 CiAKICAgICBMZW5ndGgoTGVuZ3RoVHlwZSB0KQotICAgICAgICA6IG1faW50VmFsdWUoMCksIG1f cXVpcmsoMCksIG1fdHlwZSh0KSwgbV9pc0Zsb2F0KDApCisgICAgICAgIDogbV9pbnRWYWx1ZSgw KSwgbV9xdWlyayhmYWxzZSksIG1fdHlwZSh0KSwgbV9pc0Zsb2F0KGZhbHNlKQogICAgIHsKICAg ICB9CiAKICAgICBMZW5ndGgoaW50IHYsIExlbmd0aFR5cGUgdCwgYm9vbCBxID0gZmFsc2UpCi0g ICAgICAgIDogbV9pbnRWYWx1ZSh2KSwgbV9xdWlyayhxKSwgbV90eXBlKHQpLCBtX2lzRmxvYXQo MCkKKyAgICAgICAgOiBtX2ludFZhbHVlKHYpLCBtX3F1aXJrKHEpLCBtX3R5cGUodCksIG1faXNG bG9hdChmYWxzZSkKICAgICB7CiAgICAgICAgIEFTU0VSVCh0ICE9IFBlcmNlbnQpOwogICAgIH0K IAogICAgIExlbmd0aChkb3VibGUgdiwgTGVuZ3RoVHlwZSB0LCBib29sIHEgPSBmYWxzZSkKLSAg ICAgICAgOiBtX3F1aXJrKHEpLCBtX3R5cGUodCksIG1faXNGbG9hdCgwKQorICAgICAgICA6IG1f cXVpcmsocSksIG1fdHlwZSh0KSwgbV9pc0Zsb2F0KGZhbHNlKQogICAgIHsKICAgICAgICAgaWYg KG1fdHlwZSA9PSBQZXJjZW50KQogICAgICAgICAgICAgbV9pbnRWYWx1ZSA9IHN0YXRpY19jYXN0 PGludD4odipwZXJjZW50U2NhbGVGYWN0b3IpOwogICAgICAgICBlbHNlIHsKLSAgICAgICAgICAg IG1faXNGbG9hdCA9IDE7ICAgICAgICAgICAgCisgICAgICAgICAgICBtX2lzRmxvYXQgPSB0cnVl OyAgICAgICAgICAgIAogICAgICAgICAgICAgbV9mbG9hdFZhbHVlID0gc3RhdGljX2Nhc3Q8Zmxv YXQ+KHYpOwogICAgICAgICB9CiAgICAgfQpAQCAtODgsOCArODgsOSBAQCBwdWJsaWM6CiAKICAg ICB2b2lkIHNldFZhbHVlKExlbmd0aFR5cGUgdCwgaW50IHZhbHVlKQogICAgIHsKLSAgICAgICAg QVNTRVJUKHQgIT0gUGVyY2VudCk7Ci0gICAgICAgICp0aGlzID0gTGVuZ3RoKHZhbHVlLCB0KTsK KyAgICAgICAgbV90eXBlID0gdDsKKyAgICAgICAgbV9pbnRWYWx1ZSA9IHZhbHVlOworICAgICAg ICBtX2lzRmxvYXQgPSBmYWxzZTsKICAgICB9CiAKICAgICB2b2lkIHNldFZhbHVlKGludCB2YWx1 ZSkKQEAgLTEwMCw3ICsxMDEsOSBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHNldFZhbHVlKExlbmd0 aFR5cGUgdCwgZG91YmxlIHZhbHVlKQogICAgIHsKLSAgICAgICAgKnRoaXMgPSBMZW5ndGgodmFs dWUsIHQpOworICAgICAgICBtX3R5cGUgPSB0OworICAgICAgICBtX2Zsb2F0VmFsdWUgPSB2YWx1 ZTsKKyAgICAgICAgbV9pc0Zsb2F0ID0gdHJ1ZTsKICAgICB9CiAKICAgICB2b2lkIHNldFZhbHVl KGRvdWJsZSB2YWx1ZSkK 83966 2011-02-26 22:34:05 -0800 2011-02-28 07:34:17 -0800 changed code to work around asserts + updated to real boolean values + added test patch.txt text/plain 2666 cabanier SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5ODE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMjYgIFJpayBDYWJh bmllciAgPGNhYmFuaWVyQGFkb2JlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlZCBhIGJ1ZyBpbiB0aGUgYXNzZXJ0cyBvZiB0aGUgTGVu Z3RoIGNsYXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTUzMDEKKworICAgICAgICBUaGlzIGJ1ZyB3YXMgaW50cm9kdWNlZCBieSB0aGUgZml4IGZv ciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTI2OTkKKyAgICAgICAg SXQgaXMgb25seSBhIHByb2JsZW0gaW4gZGVidWcgYnVpbGRzCisKKyAgICAgICAgVGVzdDogdGFi bGVzL21vemlsbGEvY29yZS9uZXN0ZWQxLmh0bWwgKFRoaXMgb25seSBoYXBwZW5zIGluIGRlYnVn IGJ1aWxkcykKKworICAgICAgICAqIFdlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajoK KyAgICAgICAgKiBwbGF0Zm9ybS9MZW5ndGguaDoKKyAgICAgICAgKFdlYkNvcmU6Okxlbmd0aDo6 TGVuZ3RoKToKKyAgICAgICAgKFdlYkNvcmU6Okxlbmd0aDo6c2V0VmFsdWUpOgorCiAyMDExLTAy LTI2ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9MZW5ndGguaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MZW5n dGguaAkocmV2aXNpb24gNzk4MTUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MZW5ndGgu aAkod29ya2luZyBjb3B5KQpAQCAtNDAsMjggKzQwLDI4IEBAIHN0cnVjdCBMZW5ndGggewogICAg IFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIExlbmd0aCgpCi0gICAgICAg IDogbV9pbnRWYWx1ZSgwKSwgbV9xdWlyaygwKSwgbV90eXBlKEF1dG8pLCBtX2lzRmxvYXQoMCkK KyAgICAgICAgOiBtX2ludFZhbHVlKDApLCBtX3F1aXJrKGZhbHNlKSwgbV90eXBlKEF1dG8pLCBt X2lzRmxvYXQoZmFsc2UpCiAgICAgewogICAgIH0KIAogICAgIExlbmd0aChMZW5ndGhUeXBlIHQp Ci0gICAgICAgIDogbV9pbnRWYWx1ZSgwKSwgbV9xdWlyaygwKSwgbV90eXBlKHQpLCBtX2lzRmxv YXQoMCkKKyAgICAgICAgOiBtX2ludFZhbHVlKDApLCBtX3F1aXJrKGZhbHNlKSwgbV90eXBlKHQp LCBtX2lzRmxvYXQoZmFsc2UpCiAgICAgewogICAgIH0KIAogICAgIExlbmd0aChpbnQgdiwgTGVu Z3RoVHlwZSB0LCBib29sIHEgPSBmYWxzZSkKLSAgICAgICAgOiBtX2ludFZhbHVlKHYpLCBtX3F1 aXJrKHEpLCBtX3R5cGUodCksIG1faXNGbG9hdCgwKQorICAgICAgICA6IG1faW50VmFsdWUodiks IG1fcXVpcmsocSksIG1fdHlwZSh0KSwgbV9pc0Zsb2F0KGZhbHNlKQogICAgIHsKICAgICAgICAg QVNTRVJUKHQgIT0gUGVyY2VudCk7CiAgICAgfQogCiAgICAgTGVuZ3RoKGRvdWJsZSB2LCBMZW5n dGhUeXBlIHQsIGJvb2wgcSA9IGZhbHNlKQotICAgICAgICA6IG1fcXVpcmsocSksIG1fdHlwZSh0 KSwgbV9pc0Zsb2F0KDApCisgICAgICAgIDogbV9xdWlyayhxKSwgbV90eXBlKHQpLCBtX2lzRmxv YXQoZmFsc2UpCiAgICAgewogICAgICAgICBpZiAobV90eXBlID09IFBlcmNlbnQpCiAgICAgICAg ICAgICBtX2ludFZhbHVlID0gc3RhdGljX2Nhc3Q8aW50Pih2KnBlcmNlbnRTY2FsZUZhY3Rvcik7 CiAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgbV9pc0Zsb2F0ID0gMTsgICAgICAgICAgICAK KyAgICAgICAgICAgIG1faXNGbG9hdCA9IHRydWU7ICAgICAgICAgICAgCiAgICAgICAgICAgICBt X2Zsb2F0VmFsdWUgPSBzdGF0aWNfY2FzdDxmbG9hdD4odik7CiAgICAgICAgIH0KICAgICB9CkBA IC04OCw4ICs4OCw5IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc2V0VmFsdWUoTGVuZ3RoVHlwZSB0 LCBpbnQgdmFsdWUpCiAgICAgewotICAgICAgICBBU1NFUlQodCAhPSBQZXJjZW50KTsKLSAgICAg ICAgKnRoaXMgPSBMZW5ndGgodmFsdWUsIHQpOworICAgICAgICBtX3R5cGUgPSB0OworICAgICAg ICBtX2ludFZhbHVlID0gdmFsdWU7CisgICAgICAgIG1faXNGbG9hdCA9IGZhbHNlOwogICAgIH0K IAogICAgIHZvaWQgc2V0VmFsdWUoaW50IHZhbHVlKQpAQCAtMTAwLDcgKzEwMSw5IEBAIHB1Ymxp YzoKIAogICAgIHZvaWQgc2V0VmFsdWUoTGVuZ3RoVHlwZSB0LCBkb3VibGUgdmFsdWUpCiAgICAg ewotICAgICAgICAqdGhpcyA9IExlbmd0aCh2YWx1ZSwgdCk7CisgICAgICAgIG1fdHlwZSA9IHQ7 CisgICAgICAgIG1fZmxvYXRWYWx1ZSA9IHZhbHVlOworICAgICAgICBtX2lzRmxvYXQgPSB0cnVl OwogICAgIH0KIAogICAgIHZvaWQgc2V0VmFsdWUoZG91YmxlIHZhbHVlKQo=