55288 2011-02-25 19:45:40 -0800 [Qt] Fix the focus in MiniBrowser. 2011-02-26 07:53:22 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 1 yael webkit-unassigned commit-queue kling oldest_to_newest 358357 0 yael 2011-02-25 19:45:40 -0800 Currently, loading pages such as www.google.com show a caret blinking both in the address bar and in the search box. This is really annoying :) 358359 1 83919 yael 2011-02-25 19:50:58 -0800 Created attachment 83919 Patch. Basic focus functionality. Note that isVisible() is called before the view is created thus the extra check. 358468 2 83919 kling 2011-02-26 05:32:15 -0800 Comment on attachment 83919 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=83919&action=review > Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:168 > + return view->isActive(); No null check for 'view'? > Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:173 > + return view->hasFocus(); No null check for 'view'? > Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:178 > + return view ? view->isVisible() : false; return view && view->isVisible(); 358469 3 kling 2011-02-26 05:33:05 -0800 (In reply to comment #1) > Note that isVisible() is called before the view is created thus the extra check. D'oh. Another case of I-went-straight-to-the-patch-review-interface. 358501 4 83941 yael 2011-02-26 07:31:26 -0800 Created attachment 83941 Patch. 358514 5 83941 commit-queue 2011-02-26 07:53:18 -0800 Comment on attachment 83941 Patch. Clearing flags on attachment: 83941 Committed r79791: <http://trac.webkit.org/changeset/79791> 358515 6 commit-queue 2011-02-26 07:53:22 -0800 All reviewed patches have been landed. Closing bug. 83919 2011-02-25 19:50:58 -0800 2011-02-26 07:31:26 -0800 Patch. 55288.patch text/plain 2566 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5NzU3KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMjUgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IHRoZSBmb2N1cyBpbiBNaW5pQnJvd3Nlci4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1Mjg4CisK KyAgICAgICAgSW1wbGVtZW50IGJhc2ljIGZ1bmN0aW9uYWxpdHkgZm9yIGZvY3VzIGluIFFXS1Bh Z2VQcml2YXRlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcDoKKyAg ICAgICAgKFFXS1BhZ2VQcml2YXRlOjppc1ZpZXdXaW5kb3dBY3RpdmUpOgorICAgICAgICAoUVdL UGFnZVByaXZhdGU6OmlzVmlld0ZvY3VzZWQpOgorICAgICAgICAoUVdLUGFnZVByaXZhdGU6Omlz Vmlld1Zpc2libGUpOgorCiAyMDExLTAyLTI1ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAJKHJldmlzaW9uIDc5NzE4 KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTY1LDIwICsxNjUsMTcgQEAgV2ViQ29yZTo6SW50U2l6ZSBRV0tQYWdlUHJp dmF0ZTo6dmlld1NpegogCiBib29sIFFXS1BhZ2VQcml2YXRlOjppc1ZpZXdXaW5kb3dBY3RpdmUo KQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCi0gICAgcmV0dXJuIHRydWU7CisgICAgcmV0 dXJuIHZpZXctPmlzQWN0aXZlKCk7CiB9CiAKIGJvb2wgUVdLUGFnZVByaXZhdGU6OmlzVmlld0Zv Y3VzZWQoKQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCi0gICAgcmV0dXJuIHRydWU7Cisg ICAgcmV0dXJuIHZpZXctPmhhc0ZvY3VzKCk7CiB9CiAKIGJvb2wgUVdLUGFnZVByaXZhdGU6Omlz Vmlld1Zpc2libGUoKQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCi0gICAgcmV0dXJuIHRy dWU7CisgICAgcmV0dXJuIHZpZXcgPyB2aWV3LT5pc1Zpc2libGUoKSA6IGZhbHNlOwogfQogCiBi b29sIFFXS1BhZ2VQcml2YXRlOjppc1ZpZXdJbldpbmRvdygpCkluZGV4OiBUb29scy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3OTc1NykKKysrIFRv b2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTAyLTI1 ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpeCB0aGUgZm9jdXMgaW4gTWlu aUJyb3dzZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NTI4OAorCisgICAgICAgIEdpdmUgZm9jdXMgdG8gdGhlIHdlYiB2aWV3IHdoZW4gYSBsb2Fk IHN0YXJ0cy4KKworICAgICAgICAqIE1pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwOgor ICAgICAgICAoQnJvd3NlcldpbmRvdzo6dXJsQ2hhbmdlZCk6CisKIDIwMTEtMDItMjUgIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHI3OTMyNC4KSW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dz ZXJXaW5kb3cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJX aW5kb3cuY3BwCShyZXZpc2lvbiA3OTcxOCkKKysrIFRvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dz ZXJXaW5kb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTcsNiArMTk3LDggQEAgdm9pZCBCcm93 c2VyV2luZG93Ojpsb2FkUHJvZ3Jlc3MoaW50IHBybwogdm9pZCBCcm93c2VyV2luZG93Ojp1cmxD aGFuZ2VkKGNvbnN0IFFVcmwmIHVybCkKIHsKICAgICBtX2FkZHJlc3NCYXItPnNldFRleHQodXJs LnRvU3RyaW5nKCkpOworICAgIG1fYnJvd3Nlci0+c2V0Rm9jdXMoKTsKKyAgICBtX2Jyb3dzZXIt PnZpZXcoKS0+c2V0Rm9jdXMoKTsKIH0KIAogdm9pZCBCcm93c2VyV2luZG93OjpvcGVuRmlsZSgp Cg== 83941 2011-02-26 07:31:26 -0800 2011-02-26 07:53:18 -0800 Patch. 55288.patch text/plain 2573 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5NzU3KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMjYgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IEFuZHJl YXMgS2xpbmcuCisKKyAgICAgICAgW1F0XSBGaXggdGhlIGZvY3VzIGluIE1pbmlCcm93c2VyLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUyODgKKwor ICAgICAgICBJbXBsZW1lbnQgYmFzaWMgZnVuY3Rpb25hbGl0eSBmb3IgZm9jdXMgaW4gUVdLUGFn ZVByaXZhdGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwOgorICAg ICAgICAoUVdLUGFnZVByaXZhdGU6OmlzVmlld1dpbmRvd0FjdGl2ZSk6CisgICAgICAgIChRV0tQ YWdlUHJpdmF0ZTo6aXNWaWV3Rm9jdXNlZCk6CisgICAgICAgIChRV0tQYWdlUHJpdmF0ZTo6aXNW aWV3VmlzaWJsZSk6CisKIDIwMTEtMDItMjUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcAkocmV2aXNpb24gNzk3MTgp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xNjUsMjAgKzE2NSwxNyBAQCBXZWJDb3JlOjpJbnRTaXplIFFXS1BhZ2VQcml2 YXRlOjp2aWV3U2l6CiAKIGJvb2wgUVdLUGFnZVByaXZhdGU6OmlzVmlld1dpbmRvd0FjdGl2ZSgp CiB7Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudC4KLSAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1 cm4gdmlldyAmJiB2aWV3LT5pc0FjdGl2ZSgpOwogfQogCiBib29sIFFXS1BhZ2VQcml2YXRlOjpp c1ZpZXdGb2N1c2VkKCkKIHsKLSAgICAvLyBGSVhNRTogSW1wbGVtZW50LgotICAgIHJldHVybiB0 cnVlOworICAgIHJldHVybiB2aWV3ICYmIHZpZXctPmhhc0ZvY3VzKCk7CiB9CiAKIGJvb2wgUVdL UGFnZVByaXZhdGU6OmlzVmlld1Zpc2libGUoKQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQu Ci0gICAgcmV0dXJuIHRydWU7CisgICAgcmV0dXJuIHZpZXcgJiYgdmlldy0+aXNWaXNpYmxlKCk7 CiB9CiAKIGJvb2wgUVdLUGFnZVByaXZhdGU6OmlzVmlld0luV2luZG93KCkKSW5kZXg6IFRvb2xz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5NzU3 KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTEtMDItMjYgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCisKKyAgICAgICAgW1F0XSBGaXggdGhlIGZvY3Vz IGluIE1pbmlCcm93c2VyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTUyODgKKworICAgICAgICBHaXZlIGZvY3VzIHRvIHRoZSB3ZWIgdmlldyB3aGVu IGEgbG9hZCBzdGFydHMuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93 LmNwcDoKKyAgICAgICAgKEJyb3dzZXJXaW5kb3c6OnVybENoYW5nZWQpOgorCiAyMDExLTAyLTI1 ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByNzkzMjQuCkluZGV4OiBUb29scy9NaW5pQnJvd3Nlci9x dC9Ccm93c2VyV2luZG93LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9xdC9C cm93c2VyV2luZG93LmNwcAkocmV2aXNpb24gNzk3MTgpCisrKyBUb29scy9NaW5pQnJvd3Nlci9x dC9Ccm93c2VyV2luZG93LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk3LDYgKzE5Nyw4IEBAIHZv aWQgQnJvd3NlcldpbmRvdzo6bG9hZFByb2dyZXNzKGludCBwcm8KIHZvaWQgQnJvd3NlcldpbmRv dzo6dXJsQ2hhbmdlZChjb25zdCBRVXJsJiB1cmwpCiB7CiAgICAgbV9hZGRyZXNzQmFyLT5zZXRU ZXh0KHVybC50b1N0cmluZygpKTsKKyAgICBtX2Jyb3dzZXItPnNldEZvY3VzKCk7CisgICAgbV9i cm93c2VyLT52aWV3KCktPnNldEZvY3VzKCk7CiB9CiAKIHZvaWQgQnJvd3NlcldpbmRvdzo6b3Bl bkZpbGUoKQo=