55269 2011-02-25 15:10:33 -0800 [chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLayerChromium 2011-02-28 15:36:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 53608 54694 0 vrk webkit-unassigned commit-queue dpranke kbr mihaip oldest_to_newest 358223 0 vrk 2011-02-25 15:10:33 -0800 [chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLayerChromium 358225 1 83887 vrk 2011-02-25 15:13:03 -0800 Created attachment 83887 Patch 358229 2 vrk 2011-02-25 15:18:56 -0800 This fix will enable <videos> to be painted in DRT with GPU-acceleration turned on. 359263 3 83887 kbr 2011-02-28 13:07:42 -0800 Comment on attachment 83887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83887&action=review > Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:224 > + GLC(context, context->texSubImage2D(GraphicsContext3D::TEXTURE_2D, 0, 0, 0, dimensions.width(), dimensions.height(), GraphicsContext3D::LUMINANCE, GraphicsContext3D::UNSIGNED_BYTE, data)); Should this use the incoming argument "format" instead of GraphicsContext3D::LUMINANCE directly? 359296 4 84108 vrk 2011-02-28 13:33:09 -0800 Created attachment 84108 Patch 359299 5 vrk 2011-02-28 13:34:09 -0800 (In reply to comment #3) > Should this use the incoming argument "format" instead of GraphicsContext3D::LUMINANCE directly? Yes! Thanks for the catch. Fixed in my uploaded patch. 359306 6 84108 kbr 2011-02-28 13:41:20 -0800 Comment on attachment 84108 Patch Looks good. 359434 7 84108 commit-queue 2011-02-28 15:36:09 -0800 Comment on attachment 84108 Patch Clearing flags on attachment: 84108 Committed r79935: <http://trac.webkit.org/changeset/79935> 359435 8 commit-queue 2011-02-28 15:36:14 -0800 All reviewed patches have been landed. Closing bug. 83887 2011-02-25 15:13:03 -0800 2011-02-28 13:33:06 -0800 Patch bug-55269-20110225151301.patch text/plain 2096 vrk U3VidmVyc2lvbiBSZXZpc2lvbjogNzk3MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlZGVmZmRmMTcyMGFjYTdi YWZkYzBlYjZlYzA0M2EyZjQxOTgyMzc0Li5jOTJkZjNiYzEwNGU1ZDg2NmFjMjUyMTE5ZDQ5Njli NzIyOWU5ZjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMjUgIFZpY3Rv cmlhIEtpcnN0ICA8dnJrQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBGYWxsIGJhY2sgdG8gdGV4U3ViSW1hZ2Uy RCB3aGVuIG1hcFRleFN1YkltYWdlMkQgZmFpbHMgaW4gVmlkZW9MYXllckNocm9taXVtCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTI2OQorCisgICAg ICAgIE1lc2EgZG9lcyBub3Qgc3VwcG9ydCBtYXBUZXhTdWJJbWFnZTJELCBzbyB0aGlzIGNoYW5n ZSBsZXRzCisgICAgICAgIEdQVS1hY2NlbGVyYXRlZCB2aWRlbyB3b3JrIHdpdGggRFJUIGxheW91 dCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVvTGF5 ZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWaWRlb0xheWVyQ2hyb21pdW06OnVw ZGF0ZVRleHR1cmUpOgorCiAyMDExLTAyLTI1ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVmlkZW9MYXllckNocm9taXVtLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVvTGF5ZXJD aHJvbWl1bS5jcHAKaW5kZXggZDU1YjU4NWVmNTg2ZjQ1OWExMTAyYTNlOGY0OGY3MDIxNzQwMWYx ZC4uMDE2MGE1NTdiYzM2MmEyMWYxZjc5NzliOGQ1ODljOWIwMWQ3M2RhMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVmlkZW9MYXllckNocm9t aXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9W aWRlb0xheWVyQ2hyb21pdW0uY3BwCkBAIC0yMTgsOSArMjE4LDEwIEBAIHZvaWQgVmlkZW9MYXll ckNocm9taXVtOjp1cGRhdGVUZXh0dXJlKEdyYXBoaWNzQ29udGV4dDNEKiBjb250ZXh0LCB1bnNp Z25lZCB0ZXh0CiAgICAgICAgIG1lbWNweShtZW0sIGRhdGEsIGRpbWVuc2lvbnMud2lkdGgoKSAq IGRpbWVuc2lvbnMuaGVpZ2h0KCkpOwogICAgICAgICBHTEMoY29udGV4dCwgc3RhdGljX2Nhc3Q8 RXh0ZW5zaW9uczNEQ2hyb21pdW0qPihjb250ZXh0LT5nZXRFeHRlbnNpb25zKCkpLT51bm1hcFRl eFN1YkltYWdlMkRDSFJPTUlVTShtZW0pKTsKICAgICB9IGVsc2UgewotICAgICAgICAvLyBGSVhN RTogV2Ugc2hvdWxkIGhhdmUgc29tZSBzb3J0IG9mIGNvZGUgdG8gaGFuZGxlIHRoZSBjYXNlIHdo ZW4KLSAgICAgICAgLy8gbWFwVGV4U3ViSW1hZ2UyRCBmYWlscy4KLSAgICAgICAgbV9za2lwc0Ry YXcgPSB0cnVlOworICAgICAgICAvLyBJZiBtYXBUZXhTdWJJbWFnZTJEQ0hST01JVU0gZmFpbHMs IHRoZW4gZG8gdGhlIHNsb3dlciB0ZXhTdWJJbWFnZTJECisgICAgICAgIC8vIHVwbG9hZC4gVGhp cyBkb2VzIHR3aWNlIHRoZSBjb3BpZXMgYXMgbWFwVGV4U3ViSW1hZ2UyRENIUk9NSVVNLCBvbmUK KyAgICAgICAgLy8gaW4gdGhlIGNvbW1hbmQgYnVmZmVyIGFuZCBhbm90aGVyIHRvIHRoZSB0ZXh0 dXJlLgorICAgICAgICBHTEMoY29udGV4dCwgY29udGV4dC0+dGV4U3ViSW1hZ2UyRChHcmFwaGlj c0NvbnRleHQzRDo6VEVYVFVSRV8yRCwgMCwgMCwgMCwgZGltZW5zaW9ucy53aWR0aCgpLCBkaW1l bnNpb25zLmhlaWdodCgpLCBHcmFwaGljc0NvbnRleHQzRDo6TFVNSU5BTkNFLCBHcmFwaGljc0Nv bnRleHQzRDo6VU5TSUdORURfQllURSwgZGF0YSkpOwogICAgIH0KIH0KIAo= 84108 2011-02-28 13:33:09 -0800 2011-02-28 15:36:09 -0800 Patch bug-55269-20110228133308.patch text/plain 2074 vrk U3VidmVyc2lvbiBSZXZpc2lvbjogNzk3MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlZGVmZmRmMTcyMGFjYTdi YWZkYzBlYjZlYzA0M2EyZjQxOTgyMzc0Li5jOTJkZjNiYzEwNGU1ZDg2NmFjMjUyMTE5ZDQ5Njli NzIyOWU5ZjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMjUgIFZpY3Rv cmlhIEtpcnN0ICA8dnJrQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBGYWxsIGJhY2sgdG8gdGV4U3ViSW1hZ2Uy RCB3aGVuIG1hcFRleFN1YkltYWdlMkQgZmFpbHMgaW4gVmlkZW9MYXllckNocm9taXVtCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTI2OQorCisgICAg ICAgIE1lc2EgZG9lcyBub3Qgc3VwcG9ydCBtYXBUZXhTdWJJbWFnZTJELCBzbyB0aGlzIGNoYW5n ZSBsZXRzCisgICAgICAgIEdQVS1hY2NlbGVyYXRlZCB2aWRlbyB3b3JrIHdpdGggRFJUIGxheW91 dCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVvTGF5 ZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWaWRlb0xheWVyQ2hyb21pdW06OnVw ZGF0ZVRleHR1cmUpOgorCiAyMDExLTAyLTI1ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVmlkZW9MYXllckNocm9taXVtLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVvTGF5ZXJD aHJvbWl1bS5jcHAKaW5kZXggZDU1YjU4NWVmNTg2ZjQ1OWExMTAyYTNlOGY0OGY3MDIxNzQwMWYx ZC4uNWQ3YTZlN2FmZTU1YmQ4MGY5ZmVmYjI0YjlmN2M4NzQ2YmExYTM3YiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVmlkZW9MYXllckNocm9t aXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9W aWRlb0xheWVyQ2hyb21pdW0uY3BwCkBAIC0yMTgsOSArMjE4LDEwIEBAIHZvaWQgVmlkZW9MYXll ckNocm9taXVtOjp1cGRhdGVUZXh0dXJlKEdyYXBoaWNzQ29udGV4dDNEKiBjb250ZXh0LCB1bnNp Z25lZCB0ZXh0CiAgICAgICAgIG1lbWNweShtZW0sIGRhdGEsIGRpbWVuc2lvbnMud2lkdGgoKSAq IGRpbWVuc2lvbnMuaGVpZ2h0KCkpOwogICAgICAgICBHTEMoY29udGV4dCwgc3RhdGljX2Nhc3Q8 RXh0ZW5zaW9uczNEQ2hyb21pdW0qPihjb250ZXh0LT5nZXRFeHRlbnNpb25zKCkpLT51bm1hcFRl eFN1YkltYWdlMkRDSFJPTUlVTShtZW0pKTsKICAgICB9IGVsc2UgewotICAgICAgICAvLyBGSVhN RTogV2Ugc2hvdWxkIGhhdmUgc29tZSBzb3J0IG9mIGNvZGUgdG8gaGFuZGxlIHRoZSBjYXNlIHdo ZW4KLSAgICAgICAgLy8gbWFwVGV4U3ViSW1hZ2UyRCBmYWlscy4KLSAgICAgICAgbV9za2lwc0Ry YXcgPSB0cnVlOworICAgICAgICAvLyBJZiBtYXBUZXhTdWJJbWFnZTJEQ0hST01JVU0gZmFpbHMs IHRoZW4gZG8gdGhlIHNsb3dlciB0ZXhTdWJJbWFnZTJECisgICAgICAgIC8vIHVwbG9hZC4gVGhp cyBkb2VzIHR3aWNlIHRoZSBjb3BpZXMgYXMgbWFwVGV4U3ViSW1hZ2UyRENIUk9NSVVNLCBvbmUK KyAgICAgICAgLy8gaW4gdGhlIGNvbW1hbmQgYnVmZmVyIGFuZCBhbm90aGVyIHRvIHRoZSB0ZXh0 dXJlLgorICAgICAgICBHTEMoY29udGV4dCwgY29udGV4dC0+dGV4U3ViSW1hZ2UyRChHcmFwaGlj c0NvbnRleHQzRDo6VEVYVFVSRV8yRCwgMCwgMCwgMCwgZGltZW5zaW9ucy53aWR0aCgpLCBkaW1l bnNpb25zLmhlaWdodCgpLCBmb3JtYXQsIEdyYXBoaWNzQ29udGV4dDNEOjpVTlNJR05FRF9CWVRF LCBkYXRhKSk7CiAgICAgfQogfQogCg==