55252 2011-02-25 13:06:03 -0800 [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed 2011-02-28 14:04:40 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 max.hong.shen max.hong.shen ademar commit-queue nancy.piedra vestbo oldest_to_newest 358133 0 max.hong.shen 2011-02-25 13:06:03 -0800 Need to involk the call back function to notify the HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed. 358142 1 83865 max.hong.shen 2011-02-25 13:18:18 -0800 Created attachment 83865 first try 358470 2 83865 kling 2011-02-26 05:39:30 -0800 Comment on attachment 83865 first try View in context: https://bugs.webkit.org/attachment.cgi?id=83865&action=review > Source/WebCore/ChangeLog:8 > + Need to involk a call back function to notify the HTMLMediaElement s/involk/invoke/ s/call back/callback/ > Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:243 > + // Don't send PlaybackChanged notification for pre-roll Sentence style for comments (period at end missing.) :) > Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:160 > + bool m_ignorePlaybackChanged; Not a fan of this name, m_suppressNextPlaybackChanged perhaps? The fact that it only affects the next state change and then goes back to normal should be reflected somehow. 358567 3 83949 max.hong.shen 2011-02-26 12:49:45 -0800 Created attachment 83949 updated with Kling's suggestion Thanks Kling :) 358568 4 83949 kling 2011-02-26 12:51:01 -0800 Comment on attachment 83949 updated with Kling's suggestion r=me 358582 5 83949 commit-queue 2011-02-26 14:38:59 -0800 Comment on attachment 83949 updated with Kling's suggestion Clearing flags on attachment: 83949 Committed r79809: <http://trac.webkit.org/changeset/79809> 358583 6 commit-queue 2011-02-26 14:39:04 -0800 All reviewed patches have been landed. Closing bug. 359333 7 ademar 2011-02-28 14:04:35 -0800 Revision r79809 cherry-picked into qtwebkit-2.1.x with commit ac25b02 <http://gitorious.org/webkit/qtwebkit/commit/ac25b02> 83865 2011-02-25 13:18:18 -0800 2011-02-26 12:49:45 -0800 first try 55252.patch text/plain 2925 max.hong.shen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5NzE4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDItMjUgIFlpIFNoZW4g IDx5aS40LnNoZW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtRdF0gTm90aWZ5IEhUTUxNZWRpYUVsZW1lbnQgd2hlbiBNZWRpYVBs YXllclByaXZhdGVRdCdzIHBsYXliYWNrIHN0YXRlIGdldHMgY2hhbmdlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUyNTIKKworICAgICAgICBOZWVk IHRvIGludm9sayBhIGNhbGwgYmFjayBmdW5jdGlvbiB0byBub3RpZnkgdGhlIEhUTUxNZWRpYUVs ZW1lbnQKKyAgICAgICAgd2hlbiBNZWRpYVBsYXllclByaXZhdGVRdCdzIHBsYXliYWNrIHN0YXRl IGdldHMgY2hhbmdlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxh eWVyUHJpdmF0ZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZVF0 OjpNZWRpYVBsYXllclByaXZhdGVRdCk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclBy aXZhdGVRdDo6Y29tbWl0TG9hZCk6IFNldCBhIGZsYWcgdG8gaWdub3JlIHRoZSBwbGF5YmFjayBz dGF0ZSBjaGFuZ2UgZm9yIHByZS1yb2xsCisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclBy aXZhdGVRdDo6c3RhdGVDaGFuZ2VkKTogQ2FsbCBwbGF5YmFja1N0YXRlQ2hhbmdlZCgpIHRvIG5v dGlmeSBIVE1MTWVkaWFFbGVtZW50CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVk aWFQbGF5ZXJQcml2YXRlUXQuaDoKKwogMjAxMS0wMi0yNSAgRXJpYyBDYXJsc29uICA8ZXJpYy5j YXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0 ZVF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9x dC9NZWRpYVBsYXllclByaXZhdGVRdC5jcHAJKHJldmlzaW9uIDc5NzEzKQorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2YXRlUXQuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMDUsNiArMTA1LDcgQEAgTWVkaWFQbGF5ZXJQcml2YXRlUXQ6Ok1lZGlh UGxheWVyUHJpdmF0ZQogICAgICwgbV9jb21wb3NpdGVkKGZhbHNlKQogICAgICwgbV9xdWV1ZWRT ZWVrKC0xKQogICAgICwgbV9wcmVsb2FkKE1lZGlhUGxheWVyOjpBdXRvKQorICAgICwgbV9pZ25v cmVQbGF5YmFja0NoYW5nZWQoZmFsc2UpCiB7CiAgICAgbV9tZWRpYVBsYXllci0+c2V0VmlkZW9P dXRwdXQobV92aWRlb0l0ZW0pOwogICAgIG1fdmlkZW9TY2VuZS0+YWRkSXRlbShtX3ZpZGVvSXRl bSk7CkBAIC0yMzksNiArMjQwLDkgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVRdDo6Y29tbWl0 TG9hZChjbwogICAgIG1fbWVkaWFQbGF5ZXItPnNldE11dGVkKGVsZW1lbnQtPm11dGVkKCkpOwog ICAgIG1fbWVkaWFQbGF5ZXItPnNldFZvbHVtZShzdGF0aWNfY2FzdDxpbnQ+KGVsZW1lbnQtPnZv bHVtZSgpICogMTAwLjApKTsKIAorICAgIC8vIERvbid0IHNlbmQgUGxheWJhY2tDaGFuZ2VkIG5v dGlmaWNhdGlvbiBmb3IgcHJlLXJvbGwKKyAgICBtX2lnbm9yZVBsYXliYWNrQ2hhbmdlZCA9IHRy dWU7CisKICAgICAvLyBTZXR0aW5nIGEgbWVkaWEgc291cmNlIHdpbGwgc3RhcnQgbG9hZGluZyB0 aGUgbWVkaWEsIGJ1dCB3ZSBuZWVkCiAgICAgLy8gdG8gcHJlLXJvbGwgYXMgd2VsbCB0byBnZXQg dmlkZW8gc2l6ZS1oaW50cyBhbmQgYnVmZmVyLXN0YXR1cwogICAgIGlmIChlbGVtZW50LT5wYXVz ZWQoKSkKQEAgLTQ0NSw2ICs0NDksMTEgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVRdDo6c3Rh dGVDaGFuZ2VkKAogICAgICAgICBtX21lZGlhUGxheWVyLT5zZXRQb3NpdGlvbihtX3F1ZXVlZFNl ZWspOwogICAgICAgICBtX3F1ZXVlZFNlZWsgPSAtMTsKICAgICB9CisKKyAgICBpZiAoIW1faWdu b3JlUGxheWJhY2tDaGFuZ2VkKQorICAgICAgICBtX3dlYkNvcmVQbGF5ZXItPnBsYXliYWNrU3Rh dGVDaGFuZ2VkKCk7CisgICAgZWxzZQorICAgICAgICBtX2lnbm9yZVBsYXliYWNrQ2hhbmdlZCA9 IGZhbHNlOwogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZVF0OjpuYXRpdmVTaXplQ2hhbmdl ZChjb25zdCBRU2l6ZUYmIHNpemUpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9xdC9NZWRpYVBsYXllclByaXZhdGVRdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0ZVF0LmgJKHJldmlzaW9u IDc5NzEzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5 ZXJQcml2YXRlUXQuaAkod29ya2luZyBjb3B5KQpAQCAtMTU3LDYgKzE1Nyw3IEBAIHByaXZhdGU6 CiAgICAgTWVkaWFQbGF5ZXI6OlByZWxvYWQgbV9wcmVsb2FkOwogICAgIGJvb2wgbV9kZWxheWlu Z0xvYWQ7CiAgICAgU3RyaW5nIG1fbWVkaWFVcmw7CisgICAgYm9vbCBtX2lnbm9yZVBsYXliYWNr Q2hhbmdlZDsKIAogfTsKIH0K 83949 2011-02-26 12:49:45 -0800 2011-02-26 14:38:59 -0800 updated with Kling's suggestion 55252.patch text/plain 2957 max.hong.shen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5ODAzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDItMjYgIFlpIFNoZW4g IDx5aS40LnNoZW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtRdF0gTm90aWZ5IEhUTUxNZWRpYUVsZW1lbnQgd2hlbiBNZWRpYVBs YXllclByaXZhdGVRdCdzIHBsYXliYWNrIHN0YXRlIGdldHMgY2hhbmdlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUyNTIKKworICAgICAgICBOZWVk IHRvIGludm9rZSBhIGNhbGxiYWNrIGZ1bmN0aW9uIHRvIG5vdGlmeSB0aGUgSFRNTE1lZGlhRWxl bWVudAorICAgICAgICB3aGVuIE1lZGlhUGxheWVyUHJpdmF0ZVF0J3MgcGxheWJhY2sgc3RhdGUg Z2V0cyBjaGFuZ2VkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5 ZXJQcml2YXRlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlUXQ6 Ok1lZGlhUGxheWVyUHJpdmF0ZVF0KTogU2V0IGEgZmxhZyB0byBpZ25vcmUgdGhlIHBsYXliYWNr IHN0YXRlIGNoYW5nZSBmb3IgcHJlLXJvbGwKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVy UHJpdmF0ZVF0Ojpjb21taXRMb2FkKTogQ2FsbCBwbGF5YmFja1N0YXRlQ2hhbmdlZCgpIHRvIG5v dGlmeSBIVE1MTWVkaWFFbGVtZW50CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZh dGVRdDo6c3RhdGVDaGFuZ2VkKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRp YVBsYXllclByaXZhdGVRdC5oOgorCiAyMDExLTAyLTI1ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2 aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXllclByaXZh dGVRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvTWVkaWFQbGF5ZXJQcml2YXRlUXQuY3BwCShyZXZpc2lvbiA3OTc5OCkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0ZVF0LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTA1LDYgKzEwNSw3IEBAIE1lZGlhUGxheWVyUHJpdmF0ZVF0OjpNZWRp YVBsYXllclByaXZhdGUKICAgICAsIG1fY29tcG9zaXRlZChmYWxzZSkKICAgICAsIG1fcXVldWVk U2VlaygtMSkKICAgICAsIG1fcHJlbG9hZChNZWRpYVBsYXllcjo6QXV0bykKKyAgICAsIG1fc3Vw cHJlc3NOZXh0UGxheWJhY2tDaGFuZ2VkKGZhbHNlKQogewogICAgIG1fbWVkaWFQbGF5ZXItPnNl dFZpZGVvT3V0cHV0KG1fdmlkZW9JdGVtKTsKICAgICBtX3ZpZGVvU2NlbmUtPmFkZEl0ZW0obV92 aWRlb0l0ZW0pOwpAQCAtMjM5LDYgKzI0MCw5IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlUXQ6 OmNvbW1pdExvYWQoY28KICAgICBtX21lZGlhUGxheWVyLT5zZXRNdXRlZChlbGVtZW50LT5tdXRl ZCgpKTsKICAgICBtX21lZGlhUGxheWVyLT5zZXRWb2x1bWUoc3RhdGljX2Nhc3Q8aW50PihlbGVt ZW50LT52b2x1bWUoKSAqIDEwMC4wKSk7CiAKKyAgICAvLyBEb24ndCBzZW5kIFBsYXliYWNrQ2hh bmdlZCBub3RpZmljYXRpb24gZm9yIHByZS1yb2xsLgorICAgIG1fc3VwcHJlc3NOZXh0UGxheWJh Y2tDaGFuZ2VkID0gdHJ1ZTsKKwogICAgIC8vIFNldHRpbmcgYSBtZWRpYSBzb3VyY2Ugd2lsbCBz dGFydCBsb2FkaW5nIHRoZSBtZWRpYSwgYnV0IHdlIG5lZWQKICAgICAvLyB0byBwcmUtcm9sbCBh cyB3ZWxsIHRvIGdldCB2aWRlbyBzaXplLWhpbnRzIGFuZCBidWZmZXItc3RhdHVzCiAgICAgaWYg KGVsZW1lbnQtPnBhdXNlZCgpKQpAQCAtNDQ1LDYgKzQ0OSwxMSBAQCB2b2lkIE1lZGlhUGxheWVy UHJpdmF0ZVF0OjpzdGF0ZUNoYW5nZWQoCiAgICAgICAgIG1fbWVkaWFQbGF5ZXItPnNldFBvc2l0 aW9uKG1fcXVldWVkU2Vlayk7CiAgICAgICAgIG1fcXVldWVkU2VlayA9IC0xOwogICAgIH0KKwor ICAgIGlmICghbV9zdXBwcmVzc05leHRQbGF5YmFja0NoYW5nZWQpCisgICAgICAgIG1fd2ViQ29y ZVBsYXllci0+cGxheWJhY2tTdGF0ZUNoYW5nZWQoKTsKKyAgICBlbHNlCisgICAgICAgIG1fc3Vw cHJlc3NOZXh0UGxheWJhY2tDaGFuZ2VkID0gZmFsc2U7CiB9CiAKIHZvaWQgTWVkaWFQbGF5ZXJQ cml2YXRlUXQ6Om5hdGl2ZVNpemVDaGFuZ2VkKGNvbnN0IFFTaXplRiYgc2l6ZSkKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0ZVF0LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQ bGF5ZXJQcml2YXRlUXQuaAkocmV2aXNpb24gNzk3OTgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXllclByaXZhdGVRdC5oCSh3b3JraW5nIGNvcHkpCkBA IC0xNTcsNiArMTU3LDcgQEAgcHJpdmF0ZToKICAgICBNZWRpYVBsYXllcjo6UHJlbG9hZCBtX3By ZWxvYWQ7CiAgICAgYm9vbCBtX2RlbGF5aW5nTG9hZDsKICAgICBTdHJpbmcgbV9tZWRpYVVybDsK KyAgICBib29sIG1fc3VwcHJlc3NOZXh0UGxheWJhY2tDaGFuZ2VkOwogCiB9OwogfQo=