55251 2011-02-25 12:27:10 -0800 On Mac, need to remove misspell underline in Editor::learnSpelling(). 2011-02-26 07:54:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 jiapu.mail webkit-unassigned commit-queue oldest_to_newest 358116 0 jiapu.mail 2011-02-25 12:27:10 -0800 In some version of Mac OS X, the red misspell underline persists after user has chosen "Learn Spelling" in contextual menu. <rdar://problem/8676782> 358185 1 83874 jiapu.mail 2011-02-25 14:25:24 -0800 Created attachment 83874 Proposed patch (v1) 358202 2 83874 mitz 2011-02-25 14:37:55 -0800 Comment on attachment 83874 Proposed patch (v1) View in context: https://bugs.webkit.org/attachment.cgi?id=83874&action=review Not changing to cq+ because you may want to clarify the comment. > Source/WebCore/editing/Editor.cpp:1771 > + // FIXME: On Mac OS X, when use "learn" button on "Spelling and Grammar" panel, we don't call this function. It should remove misspelling markers around the learned word, see <rdar://problem/5396072>. Seems like the second sentence in the comment isn’t needed anymore, because now the function does what it should do. 358512 3 83874 commit-queue 2011-02-26 07:48:36 -0800 Comment on attachment 83874 Proposed patch (v1) Clearing flags on attachment: 83874 Committed r79790: <http://trac.webkit.org/changeset/79790> 358513 4 commit-queue 2011-02-26 07:48:41 -0800 All reviewed patches have been landed. Closing bug. 358518 5 commit-queue 2011-02-26 07:54:20 -0800 The commit-queue encountered the following flaky tests while processing attachment 83874: fast/dom/onerror-img.html bug 51019 The commit-queue is continuing to process your patch. 83874 2011-02-25 14:25:24 -0800 2011-02-26 07:48:36 -0800 Proposed patch (v1) bug-55251-20110225142522.patch text/plain 1726 jiapu.mail U3VidmVyc2lvbiBSZXZpc2lvbjogNzk2MzQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYTYzZDMxYzRlMDQ0MDJl MzljYTJkMjJjMjZmZWNiNTU0ZWI0MmZmLi5jOTQyZTNhYWI4MDNkZWUwMGY4ZDgyMzM4OGFiOTBi NzgwYTBhYjUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMjUgIEppYSBQ dSAgPGpwdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgT24gTWFjLCBuZWVkIHRvIHJlbW92ZSBtaXNzcGVsbCB1bmRlcmxpbmUgaW4g RWRpdG9yOjpsZWFyblNwZWxsaW5nKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01NTI1MQorCisgICAgICAgIFRoaXMgY2hhbmdlIG1ha2VzIHN1cmUg dGhhdCB0aGUgbWlzc3BlbGxpbmcgbWFya2VycyBhcmUgcmVtb3ZlZCBhZnRlciB0aGUgd29yZCBp cyBsZWFybmVkLgorCisgICAgICAgICogZWRpdGluZy9FZGl0b3IuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RWRpdG9yOjpsZWFyblNwZWxsaW5nKToKKwogMjAxMS0wMi0yNCAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL0VkaXRvci5jcHAKaW5kZXggYWMyMDNmMTg2ZWI2ZDQzODNmNGQwOTYzYjA2 NjJjM2UzNGE4N2UwYy4uMzNiNzg4NjJjODExYzAxNjBiMDRjYzk4YzA3ZGY4M2RmZmUyMDkwOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcApAQCAtMTc2OCw4ICsxNzY4LDExIEBAIHZvaWQg RWRpdG9yOjpsZWFyblNwZWxsaW5nKCkKICAgICBpZiAoIWNsaWVudCgpKQogICAgICAgICByZXR1 cm47CiAgICAgICAgIAotICAgIC8vIEZJWE1FOiBXZSBkb24ndCBjYWxsIHRoaXMgb24gdGhlIE1h YywgYW5kIGl0IHNob3VsZCByZW1vdmUgbWlzc3BlbGxpbmcgbWFya2VycyBhcm91bmQgdGhlIAot ICAgIC8vIGxlYXJuZWQgd29yZCwgc2VlIDxyZGFyOi8vcHJvYmxlbS81Mzk2MDcyPi4KKyAgICAv LyBGSVhNRTogT24gTWFjIE9TIFgsIHdoZW4gdXNlICJsZWFybiIgYnV0dG9uIG9uICJTcGVsbGlu ZyBhbmQgR3JhbW1hciIgcGFuZWwsIHdlIGRvbid0IGNhbGwgdGhpcyBmdW5jdGlvbi4gSXQgc2hv dWxkIHJlbW92ZSBtaXNzcGVsbGluZyBtYXJrZXJzIGFyb3VuZCB0aGUgbGVhcm5lZCB3b3JkLCBz ZWUgPHJkYXI6Ly9wcm9ibGVtLzUzOTYwNzI+LgorCisgICAgUmVmUHRyPFJhbmdlPiBzZWxlY3Rl ZFJhbmdlID0gZnJhbWUoKS0+c2VsZWN0aW9uKCktPnRvTm9ybWFsaXplZFJhbmdlKCk7CisgICAg aWYgKHNlbGVjdGVkUmFuZ2UpCisgICAgICAgIGZyYW1lKCktPmRvY3VtZW50KCktPm1hcmtlcnMo KS0+cmVtb3ZlTWFya2VycyhzZWxlY3RlZFJhbmdlLmdldCgpLCBEb2N1bWVudE1hcmtlcjo6U3Bl bGxpbmcpOwogCiAgICAgU3RyaW5nIHRleHQgPSBzZWxlY3RlZFRleHQoKTsKICAgICBBU1NFUlQo dGV4dC5sZW5ndGgoKSk7Cg==