55249 2011-02-25 11:32:16 -0800 Leak in JSParser::Scope of ScopeLabelInfo Vector 2011-02-25 17:27:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 358084 0 msaboff 2011-02-25 11:32:16 -0800 In the struct Scope, the fuction pushLabel creates a LabelStack as needed that never gets cleaned up. void pushLabel(const Identifier* label, bool isLoop) { if (!m_labels) m_labels = new LabelStack; m_labels->append(ScopeLabelInfo(label->impl(), isLoop)); } 358090 1 83857 msaboff 2011-02-25 11:39:14 -0800 Created attachment 83857 Added Destructor to clean up JSParser::Scope leak of ScopeLabelInfo Vector 358092 2 83857 darin 2011-02-25 11:42:19 -0800 Comment on attachment 83857 Added Destructor to clean up JSParser::Scope leak of ScopeLabelInfo Vector View in context: https://bugs.webkit.org/attachment.cgi?id=83857&action=review I’d rather see m_labels be changed to an OwnPtr than just add the missing deletion. > Source/JavaScriptCore/parser/JSParser.cpp:300 > + if (m_labels) > + delete m_labels; The if isn’t needed. C++ defines the delete operator to do nothing if the pointer passed is null. 358302 3 msaboff 2011-02-25 17:27:17 -0800 Committed r79749: <http://trac.webkit.org/changeset/79749> 83857 2011-02-25 11:39:14 -0800 2011-02-25 11:42:19 -0800 Added Destructor to clean up JSParser::Scope leak of ScopeLabelInfo Vector 55249.patch text/plain 1225 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzk3MDgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDItMjUgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGVhayBpbiBKU1BhcnNl cjo6U2NvcGUgb2YgU2NvcGVMYWJlbEluZm8gVmVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTI0OQorCisgICAgICAgIEFkZGVkIFNjb3BlIGR0 b3IgdG8gY2xlYW4gdXAgbV9sYWJlbHMgaWYgbmVlZGVkLgorCisgICAgICAgICogcGFyc2VyL0pT UGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6SlNQYXJzZXI6OlNjb3BlOjp+U2NvcGUpOgorCiAy MDExLTAyLTI1ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQgV2luQ0UgYnVpbGQgZml4IGZvciByNzk2OTUuCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcGFyc2VyL0pTUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcGFyc2VyL0pTUGFyc2VyLmNwcAkocmV2aXNpb24gNzk2ODYpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0pTUGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjk0LDYgKzI5NCwxMiBAQCBwcml2YXRlOgogICAgICAgICB7CiAgICAgICAgIH0KICAgICAg ICAgCisgICAgICAgIH5TY29wZSgpCisgICAgICAgIHsKKyAgICAgICAgICAgIGlmIChtX2xhYmVs cykKKyAgICAgICAgICAgICAgICBkZWxldGUgbV9sYWJlbHM7CisgICAgICAgIH0KKyAgICAgICAg CiAgICAgICAgIHZvaWQgc3RhcnRTd2l0Y2goKSB7IG1fc3dpdGNoRGVwdGgrKzsgfQogICAgICAg ICB2b2lkIGVuZFN3aXRjaCgpIHsgbV9zd2l0Y2hEZXB0aC0tOyB9CiAgICAgICAgIHZvaWQgc3Rh cnRMb29wKCkgeyBtX2xvb3BEZXB0aCsrOyB9Cg==