55245 2011-02-25 11:22:37 -0800 input element's placeholder text stays visible when suggestion text is applied 2011-03-03 04:15:30 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://www.slugworth.com/autofill/form_placeholder.html P2 Normal --- 0 dhollowa webkit-unassigned commit-queue dglazkov fishd isherman oldest_to_newest 358070 0 dhollowa 2011-02-25 11:22:37 -0800 Steps: 1. Launch Chrome with Form Autofill enabled 2. Surf to http://www.slugworth.com/autofill/form_placeholder.html 3. Notice the placeholder text visible in the form 4. Double click on an input element to trigger Autofill suggestions to appear Result: The suggestion text is composited on top of the placeholder text. Expect: The suggestion text should replace the placeholder text, not composite on top of it. Ie. placeholder text should be invisible. 358087 1 83856 dhollowa 2011-02-25 11:36:04 -0800 Created attachment 83856 Patch 358099 2 83860 dhollowa 2011-02-25 11:53:08 -0800 Created attachment 83860 Patch 358100 3 dhollowa 2011-02-25 11:56:34 -0800 This time with ChangeLog. Darin, please let me know layout test is expected with this. Thanks. 360196 4 dhollowa 2011-03-01 13:45:41 -0800 Ping. 360846 5 83860 dglazkov 2011-03-02 09:28:39 -0800 Comment on attachment 83860 Patch I think this is testable using a layout test, right? 360847 6 dhollowa 2011-03-02 09:30:58 -0800 Actually, I looked into it and it does not seem testable in a Layout test, no. This is because, by design, the suggestion text is not accessible through the DOM. 360860 7 dglazkov 2011-03-02 09:49:01 -0800 (In reply to comment #6) > Actually, I looked into it and it does not seem testable in a Layout test, no. This is because, by design, the suggestion text is not accessible through the DOM. I see. Then this looks ok, except for the explanation in the ChangeLog on why there's no layout test :) 360880 8 84433 dhollowa 2011-03-02 10:15:47 -0800 Created attachment 84433 Updated ChangeLog with explanation for no new tests. Thanks! 360882 9 84433 dglazkov 2011-03-02 10:17:10 -0800 Comment on attachment 84433 Updated ChangeLog with explanation for no new tests. Thanks! ok. 361515 10 84433 commit-queue 2011-03-03 04:15:24 -0800 Comment on attachment 84433 Updated ChangeLog with explanation for no new tests. Thanks! Clearing flags on attachment: 84433 Committed r80232: <http://trac.webkit.org/changeset/80232> 361516 11 commit-queue 2011-03-03 04:15:30 -0800 All reviewed patches have been landed. Closing bug. 83856 2011-02-25 11:36:04 -0800 2011-02-25 11:53:06 -0800 Patch bug-55245-20110225113603.patch text/plain 4089 dhollowa U3VidmVyc2lvbiBSZXZpc2lvbjogNzk3MDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxG b3JtQ29udHJvbEVsZW1lbnQuY3BwCmluZGV4IGIyNjIwMzNhYTM1MGI3ODY1YzI2YmI0NDAyN2I3 N2Q2N2EyMDY2ZjQuLmUwODNjNDc5ZDlmZTczNTE0YTk2MzgxNDdmZTUyZmIzYTlmZGFmNzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcApAQCAt MTMwLDcgKzEzMCw3IEBAIHZvaWQgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6YXR0YWNoKCkKICAg ICAvLyBvbiB0aGUgcmVuZGVyZXIuCiAgICAgaWYgKHJlbmRlcmVyKCkpCiAgICAgICAgIHJlbmRl cmVyKCktPnVwZGF0ZUZyb21FbGVtZW50KCk7Ci0gICAgICAgIAorCiAgICAgLy8gRm9jdXMgdGhl IGVsZW1lbnQgaWYgaXQgc2hvdWxkIGhvbm91ciBpdHMgYXV0b2ZvY3VzIGF0dHJpYnV0ZS4KICAg ICAvLyBXZSBoYXZlIHRvIGRldGVybWluZSBpZiB0aGUgZWxlbWVudCBpcyBhIFRleHRBcmVhL0lu cHV0L0J1dHRvbi9TZWxlY3QsCiAgICAgLy8gaWYgaW5wdXQgdHlwZSBoaWRkZW4gaWdub3JlIGF1 dG9mb2N1cy4gU28gaWYgZGlzYWJsZWQgb3IgcmVhZG9ubHkuCkBAIC00NjYsMTMgKzQ2NiwxMyBA QCBQYXNzUmVmUHRyPE5vZGVMaXN0PiBIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpsYWJlbHMoKQog ICAgICAgICByZXR1cm4gMDsKICAgICBpZiAoIWRvY3VtZW50KCkpCiAgICAgICAgIHJldHVybiAw OwotICAgIAorCiAgICAgTm9kZVJhcmVEYXRhKiBkYXRhID0gTm9kZTo6ZW5zdXJlUmFyZURhdGEo KTsKICAgICBpZiAoIWRhdGEtPm5vZGVMaXN0cygpKSB7CiAgICAgICAgIGRhdGEtPnNldE5vZGVM aXN0cyhOb2RlTGlzdHNOb2RlRGF0YTo6Y3JlYXRlKCkpOwogICAgICAgICBkb2N1bWVudCgpLT5h ZGROb2RlTGlzdENhY2hlKCk7CiAgICAgfQotICAgIAorCiAgICAgcmV0dXJuIExhYmVsc05vZGVM aXN0OjpjcmVhdGUodGhpcyk7CiB9CiAKQEAgLTU5Nyw2ICs1OTcsNyBAQCBib29sIEhUTUxUZXh0 Rm9ybUNvbnRyb2xFbGVtZW50OjpwbGFjZWhvbGRlclNob3VsZEJlVmlzaWJsZSgpIGNvbnN0CiB7 CiAgICAgcmV0dXJuIHN1cHBvcnRzUGxhY2Vob2xkZXIoKQogICAgICAgICAmJiBpc0VtcHR5VmFs dWUoKQorICAgICAgICAmJiBpc0VtcHR5U3VnZ2VzdGVkVmFsdWUoKQogICAgICAgICAmJiAhaXNQ bGFjZWhvbGRlckVtcHR5KCkKICAgICAgICAgJiYgKGRvY3VtZW50KCktPmZvY3VzZWROb2RlKCkg IT0gdGhpcyB8fCAocmVuZGVyZXIoKSAmJiByZW5kZXJlcigpLT50aGVtZSgpLT5zaG91bGRTaG93 UGxhY2Vob2xkZXJXaGVuRm9jdXNlZCgpKSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEZvcm1Db250cm9sRWxlbWVudC5oCmluZGV4IDM2OGRjZmFkN2Y0ZDY4NTAzODY0ZThhYWNkZWZm YTRkODVkYzliMWUuLmM1NGMzZDcwOWQ0NzJlZWIzOWJhYzliZmM1OTAxYmM2YTdhN2ZmMTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5oCkBAIC0yMjMs NiArMjIzLDggQEAgcHJpdmF0ZToKIAogICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB1c2VyLWVkaXRh YmxlIHZhbHVlIGlzIGVtcHR5LiBVc2VkIHRvIGNoZWNrIHBsYWNlaG9sZGVyIHZpc2liaWxpdHku CiAgICAgdmlydHVhbCBib29sIGlzRW1wdHlWYWx1ZSgpIGNvbnN0ID0gMDsKKyAgICAvLyBSZXR1 cm5zIHRydWUgaWYgc3VnZ2VzdGVkIHZhbHVlIGlzIGVtcHR5LiBVc2VkIHRvIGNoZWNrIHBsYWNl aG9sZGVyIHZpc2liaWxpdHkuCisgICAgdmlydHVhbCBib29sIGlzRW1wdHlTdWdnZXN0ZWRWYWx1 ZSgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KICAgICAvLyBDYWxsZWQgaW4gZGlzcGF0Y2hGb2N1 c0V2ZW50KCksIGFmdGVyIHBsYWNlaG9sZGVyIHByb2Nlc3MsIGJlZm9yZSBjYWxsaW5nIHBhcmVu dCdzIGRpc3BhdGNoRm9jdXNFdmVudCgpLgogICAgIHZpcnR1YWwgdm9pZCBoYW5kbGVGb2N1c0V2 ZW50KCkgeyB9CiAgICAgLy8gQ2FsbGVkIGluIGRpc3BhdGNoQmx1ckV2ZW50KCksIGFmdGVyIHBs YWNlaG9sZGVyIHByb2Nlc3MsIGJlZm9yZSBjYWxsaW5nIHBhcmVudCdzIGRpc3BhdGNoQmx1ckV2 ZW50KCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQu aCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCmluZGV4IDc1Nzk5MmFk YTY3NTQyNjBmNjAxNDMzMTA3MzFiZGQ4ZmMwOGMwYTUuLjYyYzZmNDA3MTk5MTBhZGMxYjBjNTJh YWI3OTVjZTUyOGQ3N2U4MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElu cHV0RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5o CkBAIC0xOTYsNyArMTk2LDcgQEAgcHVibGljOgogICAgIENoZWNrZWRSYWRpb0J1dHRvbnMmIGNo ZWNrZWRSYWRpb0J1dHRvbnMoKSBjb25zdDsKICAgICB2b2lkIGhhbmRsZUJlZm9yZVRleHRJbnNl cnRlZEV2ZW50KEV2ZW50Kik7CiAgICAgdm9pZCB1cGRhdGVDaGVja2VkUmFkaW9CdXR0b25zKCk7 Ci0gICAgCisKIHByb3RlY3RlZDoKICAgICBIVE1MSW5wdXRFbGVtZW50KGNvbnN0IFF1YWxpZmll ZE5hbWUmLCBEb2N1bWVudCosIEhUTUxGb3JtRWxlbWVudCosIGJvb2wgY3JlYXRlZEJ5UGFyc2Vy KTsKIApAQCAtMjE3LDExICsyMTcsMTEgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgc2hv dWxkVXNlSW5wdXRNZXRob2QoKSBjb25zdDsKIAogICAgIHZpcnR1YWwgY29uc3QgQXRvbWljU3Ry aW5nJiBmb3JtQ29udHJvbE5hbWUoKSBjb25zdDsKLSAKKwogICAgIC8vIGlzQ2hlY2tlZCBpcyB1 c2VkIGJ5IHRoZSByZW5kZXJpbmcgdHJlZS9DU1Mgd2hpbGUgY2hlY2tlZCgpIGlzIHVzZWQgYnkg SlMgdG8gZGV0ZXJtaW5lIGNoZWNrZWQgc3RhdGUKICAgICB2aXJ0dWFsIGJvb2wgaXNDaGVja2Vk KCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGlzSW5kZXRlcm1pbmF0ZSgpIGNvbnN0IHsgcmV0 dXJuIGluZGV0ZXJtaW5hdGUoKTsgfQotICAgIAorCiAgICAgdmlydHVhbCBib29sIGlzVGV4dEZv cm1Db250cm9sKCkgY29uc3QgeyByZXR1cm4gaXNUZXh0RmllbGQoKTsgfQogCiAgICAgdmlydHVh bCBib29sIGhhc1NwaW5CdXR0b24oKSBjb25zdDsKQEAgLTIzNSw3ICsyMzUsNyBAQCBwcml2YXRl OgogICAgIHZpcnR1YWwgdm9pZCByZXN0b3JlRm9ybUNvbnRyb2xTdGF0ZShjb25zdCBTdHJpbmcm KTsKIAogICAgIHZpcnR1YWwgYm9vbCBjYW5TdGFydFNlbGVjdGlvbigpIGNvbnN0OwotICAgIAor CiAgICAgdmlydHVhbCB2b2lkIGFjY2Vzc0tleUFjdGlvbihib29sIHNlbmRUb0FueUVsZW1lbnQp OwogCiAgICAgdmlydHVhbCBib29sIG1hcFRvRW50cnkoY29uc3QgUXVhbGlmaWVkTmFtZSYgYXR0 ck5hbWUsIE1hcHBlZEF0dHJpYnV0ZUVudHJ5JiByZXN1bHQpIGNvbnN0OwpAQCAtMjgwLDYgKzI4 MCw3IEBAIHByaXZhdGU6CiAKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNQbGFjZWhvbGRlcigp IGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBpc0VtcHR5VmFsdWUoKSBjb25zdCB7IHJldHVybiB2 YWx1ZSgpLmlzRW1wdHkoKTsgfQorICAgIHZpcnR1YWwgYm9vbCBpc0VtcHR5U3VnZ2VzdGVkVmFs dWUoKSBjb25zdCB7IHJldHVybiBzdWdnZXN0ZWRWYWx1ZSgpLmlzRW1wdHkoKTsgfQogICAgIHZp cnR1YWwgdm9pZCBoYW5kbGVGb2N1c0V2ZW50KCk7CiAgICAgdmlydHVhbCB2b2lkIGhhbmRsZUJs dXJFdmVudCgpOwogICAgIHZpcnR1YWwgaW50IGNhY2hlZFNlbGVjdGlvblN0YXJ0KCkgY29uc3Qg eyByZXR1cm4gbV9kYXRhLmNhY2hlZFNlbGVjdGlvblN0YXJ0KCk7IH0K 83860 2011-02-25 11:53:08 -0800 2011-03-02 10:15:44 -0800 Patch bug-55245-20110225115307.patch text/plain 5146 dhollowa U3VidmVyc2lvbiBSZXZpc2lvbjogNzk3MDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1OTdmNTE4MzNlMGVjYWMz ZjhkMTVlMWMxOWRjMDEzNDFmNDQ0ODE1Li4xOGQyOWVhN2NhM2FkM2I2ZDY0ZDAwODY0Mzk0OWVm NDFjODI1ZDM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDItMjUgIERhdmlk IEhvbGxvd2F5ICA8ZGhvbGxvd2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZXMgSFRNTFRleHRGb3JtQ29udHJvbEVs ZW1lbnQ6OnBsYWNlaG9sZGVyU2hvdWxkQmVWaXNpYmxlIHRvIGFjY291bnQKKyAgICAgICAgZm9y IG5vbi1lbXB0eSBzdWdnZXN0aW9uIHRleHQuICBUaGUgdmlzaWJpbGl0eSBvZiB0aGUgcGxhY2Vo b2xkZXIgdGV4dAorICAgICAgICBub3cgdHVybmVkIG9mZiB3aGVuIHN1Z2dlc3Rpb24gdGV4dCBp cyBzZXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NTI0NQorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogaHRtbC9I VE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUZXh0Rm9y bUNvbnRyb2xFbGVtZW50OjpwbGFjZWhvbGRlclNob3VsZEJlVmlzaWJsZSk6CisgICAgICAgICog aHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVGV4 dEZvcm1Db250cm9sRWxlbWVudDo6aXNFbXB0eVN1Z2dlc3RlZFZhbHVlKToKKyAgICAgICAgKiBo dG1sL0hUTUxJbnB1dEVsZW1lbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1l bnQ6OmlzRW1wdHlTdWdnZXN0ZWRWYWx1ZSk6CisKIDIwMTEtMDItMjUgIFBhdHJpY2sgR2Fuc3Rl cmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXgu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAppbmRl eCBiMjYyMDMzYWEzNTBiNzg2NWMyNmJiNDQwMjdiNzdkNjdhMjA2NmY0Li5lMDgzYzQ3OWQ5ZmU3 MzUxNGE5NjM4MTQ3ZmU1MmZiM2E5ZmRhZjc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKQEAgLTEzMCw3ICsxMzAsNyBAQCB2b2lkIEhUTUxG b3JtQ29udHJvbEVsZW1lbnQ6OmF0dGFjaCgpCiAgICAgLy8gb24gdGhlIHJlbmRlcmVyLgogICAg IGlmIChyZW5kZXJlcigpKQogICAgICAgICByZW5kZXJlcigpLT51cGRhdGVGcm9tRWxlbWVudCgp OwotICAgICAgICAKKwogICAgIC8vIEZvY3VzIHRoZSBlbGVtZW50IGlmIGl0IHNob3VsZCBob25v dXIgaXRzIGF1dG9mb2N1cyBhdHRyaWJ1dGUuCiAgICAgLy8gV2UgaGF2ZSB0byBkZXRlcm1pbmUg aWYgdGhlIGVsZW1lbnQgaXMgYSBUZXh0QXJlYS9JbnB1dC9CdXR0b24vU2VsZWN0LAogICAgIC8v IGlmIGlucHV0IHR5cGUgaGlkZGVuIGlnbm9yZSBhdXRvZm9jdXMuIFNvIGlmIGRpc2FibGVkIG9y IHJlYWRvbmx5LgpAQCAtNDY2LDEzICs0NjYsMTMgQEAgUGFzc1JlZlB0cjxOb2RlTGlzdD4gSFRN TEZvcm1Db250cm9sRWxlbWVudDo6bGFiZWxzKCkKICAgICAgICAgcmV0dXJuIDA7CiAgICAgaWYg KCFkb2N1bWVudCgpKQogICAgICAgICByZXR1cm4gMDsKLSAgICAKKwogICAgIE5vZGVSYXJlRGF0 YSogZGF0YSA9IE5vZGU6OmVuc3VyZVJhcmVEYXRhKCk7CiAgICAgaWYgKCFkYXRhLT5ub2RlTGlz dHMoKSkgewogICAgICAgICBkYXRhLT5zZXROb2RlTGlzdHMoTm9kZUxpc3RzTm9kZURhdGE6OmNy ZWF0ZSgpKTsKICAgICAgICAgZG9jdW1lbnQoKS0+YWRkTm9kZUxpc3RDYWNoZSgpOwogICAgIH0K LSAgICAKKwogICAgIHJldHVybiBMYWJlbHNOb2RlTGlzdDo6Y3JlYXRlKHRoaXMpOwogfQogCkBA IC01OTcsNiArNTk3LDcgQEAgYm9vbCBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6cGxhY2Vo b2xkZXJTaG91bGRCZVZpc2libGUoKSBjb25zdAogewogICAgIHJldHVybiBzdXBwb3J0c1BsYWNl aG9sZGVyKCkKICAgICAgICAgJiYgaXNFbXB0eVZhbHVlKCkKKyAgICAgICAgJiYgaXNFbXB0eVN1 Z2dlc3RlZFZhbHVlKCkKICAgICAgICAgJiYgIWlzUGxhY2Vob2xkZXJFbXB0eSgpCiAgICAgICAg ICYmIChkb2N1bWVudCgpLT5mb2N1c2VkTm9kZSgpICE9IHRoaXMgfHwgKHJlbmRlcmVyKCkgJiYg cmVuZGVyZXIoKS0+dGhlbWUoKS0+c2hvdWxkU2hvd1BsYWNlaG9sZGVyV2hlbkZvY3VzZWQoKSkp OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVt ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaAppbmRl eCAzNjhkY2ZhZDdmNGQ2ODUwMzg2NGU4YWFjZGVmZmE0ZDg1ZGM5YjFlLi5jNTRjM2Q3MDlkNDcy ZWViMzliYWM5YmZjNTkwMWJjNmE3YTdmZjE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxGb3JtQ29udHJvbEVsZW1lbnQuaApAQCAtMjIzLDYgKzIyMyw4IEBAIHByaXZhdGU6CiAKICAg ICAvLyBSZXR1cm5zIHRydWUgaWYgdXNlci1lZGl0YWJsZSB2YWx1ZSBpcyBlbXB0eS4gVXNlZCB0 byBjaGVjayBwbGFjZWhvbGRlciB2aXNpYmlsaXR5LgogICAgIHZpcnR1YWwgYm9vbCBpc0VtcHR5 VmFsdWUoKSBjb25zdCA9IDA7CisgICAgLy8gUmV0dXJucyB0cnVlIGlmIHN1Z2dlc3RlZCB2YWx1 ZSBpcyBlbXB0eS4gVXNlZCB0byBjaGVjayBwbGFjZWhvbGRlciB2aXNpYmlsaXR5LgorICAgIHZp cnR1YWwgYm9vbCBpc0VtcHR5U3VnZ2VzdGVkVmFsdWUoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9 CiAgICAgLy8gQ2FsbGVkIGluIGRpc3BhdGNoRm9jdXNFdmVudCgpLCBhZnRlciBwbGFjZWhvbGRl ciBwcm9jZXNzLCBiZWZvcmUgY2FsbGluZyBwYXJlbnQncyBkaXNwYXRjaEZvY3VzRXZlbnQoKS4K ICAgICB2aXJ0dWFsIHZvaWQgaGFuZGxlRm9jdXNFdmVudCgpIHsgfQogICAgIC8vIENhbGxlZCBp biBkaXNwYXRjaEJsdXJFdmVudCgpLCBhZnRlciBwbGFjZWhvbGRlciBwcm9jZXNzLCBiZWZvcmUg Y2FsbGluZyBwYXJlbnQncyBkaXNwYXRjaEJsdXJFdmVudCgpLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxJbnB1dEVsZW1lbnQuaAppbmRleCA3NTc5OTJhZGE2NzU0MjYwZjYwMTQzMzEwNzMxYmRkOGZj MDhjMGE1Li42MmM2ZjQwNzE5OTEwYWRjMWIwYzUyYWFiNzk1Y2U1MjhkNzdlODJiIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaApAQCAtMTk2LDcgKzE5Niw3IEBAIHB1Ymxp YzoKICAgICBDaGVja2VkUmFkaW9CdXR0b25zJiBjaGVja2VkUmFkaW9CdXR0b25zKCkgY29uc3Q7 CiAgICAgdm9pZCBoYW5kbGVCZWZvcmVUZXh0SW5zZXJ0ZWRFdmVudChFdmVudCopOwogICAgIHZv aWQgdXBkYXRlQ2hlY2tlZFJhZGlvQnV0dG9ucygpOwotICAgIAorCiBwcm90ZWN0ZWQ6CiAgICAg SFRNTElucHV0RWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiwgRG9jdW1lbnQqLCBIVE1MRm9y bUVsZW1lbnQqLCBib29sIGNyZWF0ZWRCeVBhcnNlcik7CiAKQEAgLTIxNywxMSArMjE3LDExIEBA IHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIHNob3VsZFVzZUlucHV0TWV0aG9kKCkgY29uc3Q7 CiAKICAgICB2aXJ0dWFsIGNvbnN0IEF0b21pY1N0cmluZyYgZm9ybUNvbnRyb2xOYW1lKCkgY29u c3Q7Ci0gCisKICAgICAvLyBpc0NoZWNrZWQgaXMgdXNlZCBieSB0aGUgcmVuZGVyaW5nIHRyZWUv Q1NTIHdoaWxlIGNoZWNrZWQoKSBpcyB1c2VkIGJ5IEpTIHRvIGRldGVybWluZSBjaGVja2VkIHN0 YXRlCiAgICAgdmlydHVhbCBib29sIGlzQ2hlY2tlZCgpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9v bCBpc0luZGV0ZXJtaW5hdGUoKSBjb25zdCB7IHJldHVybiBpbmRldGVybWluYXRlKCk7IH0KLSAg ICAKKwogICAgIHZpcnR1YWwgYm9vbCBpc1RleHRGb3JtQ29udHJvbCgpIGNvbnN0IHsgcmV0dXJu IGlzVGV4dEZpZWxkKCk7IH0KIAogICAgIHZpcnR1YWwgYm9vbCBoYXNTcGluQnV0dG9uKCkgY29u c3Q7CkBAIC0yMzUsNyArMjM1LDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgcmVzdG9y ZUZvcm1Db250cm9sU3RhdGUoY29uc3QgU3RyaW5nJik7CiAKICAgICB2aXJ0dWFsIGJvb2wgY2Fu U3RhcnRTZWxlY3Rpb24oKSBjb25zdDsKLSAgICAKKwogICAgIHZpcnR1YWwgdm9pZCBhY2Nlc3NL ZXlBY3Rpb24oYm9vbCBzZW5kVG9BbnlFbGVtZW50KTsKIAogICAgIHZpcnR1YWwgYm9vbCBtYXBU b0VudHJ5KGNvbnN0IFF1YWxpZmllZE5hbWUmIGF0dHJOYW1lLCBNYXBwZWRBdHRyaWJ1dGVFbnRy eSYgcmVzdWx0KSBjb25zdDsKQEAgLTI4MCw2ICsyODAsNyBAQCBwcml2YXRlOgogCiAgICAgdmly dHVhbCBib29sIHN1cHBvcnRzUGxhY2Vob2xkZXIoKSBjb25zdDsKICAgICB2aXJ0dWFsIGJvb2wg aXNFbXB0eVZhbHVlKCkgY29uc3QgeyByZXR1cm4gdmFsdWUoKS5pc0VtcHR5KCk7IH0KKyAgICB2 aXJ0dWFsIGJvb2wgaXNFbXB0eVN1Z2dlc3RlZFZhbHVlKCkgY29uc3QgeyByZXR1cm4gc3VnZ2Vz dGVkVmFsdWUoKS5pc0VtcHR5KCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgaGFuZGxlRm9jdXNFdmVu dCgpOwogICAgIHZpcnR1YWwgdm9pZCBoYW5kbGVCbHVyRXZlbnQoKTsKICAgICB2aXJ0dWFsIGlu dCBjYWNoZWRTZWxlY3Rpb25TdGFydCgpIGNvbnN0IHsgcmV0dXJuIG1fZGF0YS5jYWNoZWRTZWxl Y3Rpb25TdGFydCgpOyB9Cg== 84433 2011-03-02 10:15:47 -0800 2011-03-03 04:15:24 -0800 Updated ChangeLog with explanation for no new tests. Thanks! bug-55245-20110302101546.patch text/plain 5219 dhollowa U3VidmVyc2lvbiBSZXZpc2lvbjogNzk5MDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkYjFjNDUxNjQ3Njk2ZGIz MGNiZDRhMTI5NWI2NTM3NzFlYmY2OTRjLi5iZTdiODk0MDMyZjY5OGNhMWE2NjVlYzJiNGI0Njhi Mzg3NDY2NDUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDMtMDIgIERhdmlk IEhvbGxvd2F5ICA8ZGhvbGxvd2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZXMgSFRNTFRleHRGb3JtQ29udHJvbEVs ZW1lbnQ6OnBsYWNlaG9sZGVyU2hvdWxkQmVWaXNpYmxlIHRvIGFjY291bnQKKyAgICAgICAgZm9y IG5vbi1lbXB0eSBzdWdnZXN0aW9uIHRleHQuICBUaGUgdmlzaWJpbGl0eSBvZiB0aGUgcGxhY2Vo b2xkZXIgdGV4dAorICAgICAgICBub3cgdHVybmVkIG9mZiB3aGVuIHN1Z2dlc3Rpb24gdGV4dCBp cyBzZXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NTI0NQorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlLCBieSBkZXNpZ24sIHRoZSBzdWdn ZXN0aW9uIHRleHQgaXMgbm90IGFjY2Vzc2libGUKKyAgICAgICAgdGhyb3VnaCB0aGUgRE9NLgor CisgICAgICAgICogaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjpwbGFjZWhvbGRlclNob3VsZEJlVmlz aWJsZSk6CisgICAgICAgICogaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50Lmg6CisgICAgICAg IChXZWJDb3JlOjpIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6aXNFbXB0eVN1Z2dlc3RlZFZh bHVlKToKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuaDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxJbnB1dEVsZW1lbnQ6OmlzRW1wdHlTdWdnZXN0ZWRWYWx1ZSk6CisKIDIwMTEtMDIt MjUgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9y bUNvbnRyb2xFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9s RWxlbWVudC5jcHAKaW5kZXggYjI2MjAzM2FhMzUwYjc4NjVjMjZiYjQ0MDI3Yjc3ZDY3YTIwNjZm NC4uZTA4M2M0NzlkOWZlNzM1MTRhOTYzODE0N2ZlNTJmYjNhOWZkYWY3NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwCkBAIC0xMzAsNyArMTMw LDcgQEAgdm9pZCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjphdHRhY2goKQogICAgIC8vIG9uIHRo ZSByZW5kZXJlci4KICAgICBpZiAocmVuZGVyZXIoKSkKICAgICAgICAgcmVuZGVyZXIoKS0+dXBk YXRlRnJvbUVsZW1lbnQoKTsKLSAgICAgICAgCisKICAgICAvLyBGb2N1cyB0aGUgZWxlbWVudCBp ZiBpdCBzaG91bGQgaG9ub3VyIGl0cyBhdXRvZm9jdXMgYXR0cmlidXRlLgogICAgIC8vIFdlIGhh dmUgdG8gZGV0ZXJtaW5lIGlmIHRoZSBlbGVtZW50IGlzIGEgVGV4dEFyZWEvSW5wdXQvQnV0dG9u L1NlbGVjdCwKICAgICAvLyBpZiBpbnB1dCB0eXBlIGhpZGRlbiBpZ25vcmUgYXV0b2ZvY3VzLiBT byBpZiBkaXNhYmxlZCBvciByZWFkb25seS4KQEAgLTQ2NiwxMyArNDY2LDEzIEBAIFBhc3NSZWZQ dHI8Tm9kZUxpc3Q+IEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmxhYmVscygpCiAgICAgICAgIHJl dHVybiAwOwogICAgIGlmICghZG9jdW1lbnQoKSkKICAgICAgICAgcmV0dXJuIDA7Ci0gICAgCisK ICAgICBOb2RlUmFyZURhdGEqIGRhdGEgPSBOb2RlOjplbnN1cmVSYXJlRGF0YSgpOwogICAgIGlm ICghZGF0YS0+bm9kZUxpc3RzKCkpIHsKICAgICAgICAgZGF0YS0+c2V0Tm9kZUxpc3RzKE5vZGVM aXN0c05vZGVEYXRhOjpjcmVhdGUoKSk7CiAgICAgICAgIGRvY3VtZW50KCktPmFkZE5vZGVMaXN0 Q2FjaGUoKTsKICAgICB9Ci0gICAgCisKICAgICByZXR1cm4gTGFiZWxzTm9kZUxpc3Q6OmNyZWF0 ZSh0aGlzKTsKIH0KIApAQCAtNTk3LDYgKzU5Nyw3IEBAIGJvb2wgSFRNTFRleHRGb3JtQ29udHJv bEVsZW1lbnQ6OnBsYWNlaG9sZGVyU2hvdWxkQmVWaXNpYmxlKCkgY29uc3QKIHsKICAgICByZXR1 cm4gc3VwcG9ydHNQbGFjZWhvbGRlcigpCiAgICAgICAgICYmIGlzRW1wdHlWYWx1ZSgpCisgICAg ICAgICYmIGlzRW1wdHlTdWdnZXN0ZWRWYWx1ZSgpCiAgICAgICAgICYmICFpc1BsYWNlaG9sZGVy RW1wdHkoKQogICAgICAgICAmJiAoZG9jdW1lbnQoKS0+Zm9jdXNlZE5vZGUoKSAhPSB0aGlzIHx8 IChyZW5kZXJlcigpICYmIHJlbmRlcmVyKCktPnRoZW1lKCktPnNob3VsZFNob3dQbGFjZWhvbGRl cldoZW5Gb2N1c2VkKCkpKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEZvcm1Db250cm9sRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRy b2xFbGVtZW50LmgKaW5kZXggMzY4ZGNmYWQ3ZjRkNjg1MDM4NjRlOGFhY2RlZmZhNGQ4NWRjOWIx ZS4uYzU0YzNkNzA5ZDQ3MmVlYjM5YmFjOWJmYzU5MDFiYzZhN2E3ZmYxNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmgKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmgKQEAgLTIyMyw2ICsyMjMsOCBA QCBwcml2YXRlOgogCiAgICAgLy8gUmV0dXJucyB0cnVlIGlmIHVzZXItZWRpdGFibGUgdmFsdWUg aXMgZW1wdHkuIFVzZWQgdG8gY2hlY2sgcGxhY2Vob2xkZXIgdmlzaWJpbGl0eS4KICAgICB2aXJ0 dWFsIGJvb2wgaXNFbXB0eVZhbHVlKCkgY29uc3QgPSAwOworICAgIC8vIFJldHVybnMgdHJ1ZSBp ZiBzdWdnZXN0ZWQgdmFsdWUgaXMgZW1wdHkuIFVzZWQgdG8gY2hlY2sgcGxhY2Vob2xkZXIgdmlz aWJpbGl0eS4KKyAgICB2aXJ0dWFsIGJvb2wgaXNFbXB0eVN1Z2dlc3RlZFZhbHVlKCkgY29uc3Qg eyByZXR1cm4gdHJ1ZTsgfQogICAgIC8vIENhbGxlZCBpbiBkaXNwYXRjaEZvY3VzRXZlbnQoKSwg YWZ0ZXIgcGxhY2Vob2xkZXIgcHJvY2VzcywgYmVmb3JlIGNhbGxpbmcgcGFyZW50J3MgZGlzcGF0 Y2hGb2N1c0V2ZW50KCkuCiAgICAgdmlydHVhbCB2b2lkIGhhbmRsZUZvY3VzRXZlbnQoKSB7IH0K ICAgICAvLyBDYWxsZWQgaW4gZGlzcGF0Y2hCbHVyRXZlbnQoKSwgYWZ0ZXIgcGxhY2Vob2xkZXIg cHJvY2VzcywgYmVmb3JlIGNhbGxpbmcgcGFyZW50J3MgZGlzcGF0Y2hCbHVyRXZlbnQoKS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKaW5kZXggNzU3OTkyYWRhNjc1NDI2MGY2 MDE0MzMxMDczMWJkZDhmYzA4YzBhNS4uNjJjNmY0MDcxOTkxMGFkYzFiMGM1MmFhYjc5NWNlNTI4 ZDc3ZTgyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKQEAgLTE5Niw3 ICsxOTYsNyBAQCBwdWJsaWM6CiAgICAgQ2hlY2tlZFJhZGlvQnV0dG9ucyYgY2hlY2tlZFJhZGlv QnV0dG9ucygpIGNvbnN0OwogICAgIHZvaWQgaGFuZGxlQmVmb3JlVGV4dEluc2VydGVkRXZlbnQo RXZlbnQqKTsKICAgICB2b2lkIHVwZGF0ZUNoZWNrZWRSYWRpb0J1dHRvbnMoKTsKLSAgICAKKwog cHJvdGVjdGVkOgogICAgIEhUTUxJbnB1dEVsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFtZSYsIERv Y3VtZW50KiwgSFRNTEZvcm1FbGVtZW50KiwgYm9vbCBjcmVhdGVkQnlQYXJzZXIpOwogCkBAIC0y MTcsMTEgKzIxNywxMSBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRVc2VJbnB1 dE1ldGhvZCgpIGNvbnN0OwogCiAgICAgdmlydHVhbCBjb25zdCBBdG9taWNTdHJpbmcmIGZvcm1D b250cm9sTmFtZSgpIGNvbnN0OwotIAorCiAgICAgLy8gaXNDaGVja2VkIGlzIHVzZWQgYnkgdGhl IHJlbmRlcmluZyB0cmVlL0NTUyB3aGlsZSBjaGVja2VkKCkgaXMgdXNlZCBieSBKUyB0byBkZXRl cm1pbmUgY2hlY2tlZCBzdGF0ZQogICAgIHZpcnR1YWwgYm9vbCBpc0NoZWNrZWQoKSBjb25zdDsK ICAgICB2aXJ0dWFsIGJvb2wgaXNJbmRldGVybWluYXRlKCkgY29uc3QgeyByZXR1cm4gaW5kZXRl cm1pbmF0ZSgpOyB9Ci0gICAgCisKICAgICB2aXJ0dWFsIGJvb2wgaXNUZXh0Rm9ybUNvbnRyb2wo KSBjb25zdCB7IHJldHVybiBpc1RleHRGaWVsZCgpOyB9CiAKICAgICB2aXJ0dWFsIGJvb2wgaGFz U3BpbkJ1dHRvbigpIGNvbnN0OwpAQCAtMjM1LDcgKzIzNSw3IEBAIHByaXZhdGU6CiAgICAgdmly dHVhbCB2b2lkIHJlc3RvcmVGb3JtQ29udHJvbFN0YXRlKGNvbnN0IFN0cmluZyYpOwogCiAgICAg dmlydHVhbCBib29sIGNhblN0YXJ0U2VsZWN0aW9uKCkgY29uc3Q7Ci0gICAgCisKICAgICB2aXJ0 dWFsIHZvaWQgYWNjZXNzS2V5QWN0aW9uKGJvb2wgc2VuZFRvQW55RWxlbWVudCk7CiAKICAgICB2 aXJ0dWFsIGJvb2wgbWFwVG9FbnRyeShjb25zdCBRdWFsaWZpZWROYW1lJiBhdHRyTmFtZSwgTWFw cGVkQXR0cmlidXRlRW50cnkmIHJlc3VsdCkgY29uc3Q7CkBAIC0yODAsNiArMjgwLDcgQEAgcHJp dmF0ZToKIAogICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c1BsYWNlaG9sZGVyKCkgY29uc3Q7CiAg ICAgdmlydHVhbCBib29sIGlzRW1wdHlWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIHZhbHVlKCkuaXNF bXB0eSgpOyB9CisgICAgdmlydHVhbCBib29sIGlzRW1wdHlTdWdnZXN0ZWRWYWx1ZSgpIGNvbnN0 IHsgcmV0dXJuIHN1Z2dlc3RlZFZhbHVlKCkuaXNFbXB0eSgpOyB9CiAgICAgdmlydHVhbCB2b2lk IGhhbmRsZUZvY3VzRXZlbnQoKTsKICAgICB2aXJ0dWFsIHZvaWQgaGFuZGxlQmx1ckV2ZW50KCk7 CiAgICAgdmlydHVhbCBpbnQgY2FjaGVkU2VsZWN0aW9uU3RhcnQoKSBjb25zdCB7IHJldHVybiBt X2RhdGEuY2FjaGVkU2VsZWN0aW9uU3RhcnQoKTsgfQo=