55239 2011-02-25 11:11:38 -0800 Allow webkitEnterFullScreen from outside user gesture when restrictions are unrestricted 2011-06-23 03:45:33 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 dino dino adamjernst eric.carlson oldest_to_newest 358057 0 dino 2011-02-25 11:11:38 -0800 webkitEnterFullScreen is protected by a user gesture. If the rateChange restriction is relaxed, full screen should be allowed outside gestures. Meanwhile, the helper functions that return the restriction info should be moved from private to protected. <rdar://problem/7648874> 358075 1 83850 dino 2011-02-25 11:25:29 -0800 Created attachment 83850 Patch I can't think of a good way to test this. It requires tweaking restrictions on media elements. 358106 2 83850 eric.carlson 2011-02-25 12:05:21 -0800 Comment on attachment 83850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83850&action=review I think it would make more sense to define a new restriction, maybe RequireUserGestureForFullScreen, and have it be set by default but allow a port to clear if it wants to allow unrestricted fullscreen. > Source/WebCore/html/HTMLVideoElement.cpp:235 > - if (!isUserGesture || !supportsFullscreen()) { > + if ((!isUserGesture && requireUserGestureForRateChange()) || !supportsFullscreen()) { This will allow any script to trigger fullscreen for any port that doesn't restrict playback to a user gesture - not good. 358117 3 83861 dino 2011-02-25 12:30:01 -0800 Created attachment 83861 Updated patch Good point. Added a new restriction, but made the access methods public so it is easier for a port to add/remove restrictions. FullScreen is now protected by default. 358118 4 83861 eric.carlson 2011-02-25 12:35:27 -0800 Comment on attachment 83861 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=83861&action=review > Source/WebCore/html/HTMLMediaElement.h:191 > + void setRestrictions(BehaviorRestrictions restrictions) { m_restrictions = restrictions; } setRestrictions" is pretty generic, setBehaviorRestrictions maybe? > Source/WebCore/html/HTMLVideoElement.cpp:235 > + if ((!isUserGesture && requireUserGestureForFullScreen()) || !supportsFullscreen()) { As long as you are making a change anyway, I think this will be slightly clearer if you switch the order of the comparisons: "(requireUserGestureForFullScreen() && !isUserGesture)" 358145 5 83866 dino 2011-02-25 13:23:03 -0800 Created attachment 83866 Another update Made Eric's changes 359360 6 dino 2011-02-28 14:33:10 -0800 M Source/WebCore/ChangeLog M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.h M Source/WebCore/html/HTMLVideoElement.cpp Committed r79922 425790 7 adamjernst 2011-06-22 17:47:17 -0700 *** Bug 63202 has been marked as a duplicate of this bug. *** 426070 8 83866 menard 2011-06-23 03:45:33 -0700 Comment on attachment 83866 Another update I believe I can clear the flag it has been landed. 83850 2011-02-25 11:25:29 -0800 2011-02-25 12:30:01 -0800 Patch webkitfullscreen.diff text/plain 2553 dino ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MTVjODQ5Li5hN2ZmNmZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTEtMDItMjUgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MjM5CisKKyAgICAgICAgQWxsb3cgd2Vi a2l0RW50ZXJGdWxsU2NyZWVuIHRvIGJlIGNhbGxlZCBmcm9tIG91dHNpZGUKKyAgICAgICAgYSB1 c2VyIGdlc3R1cmUsIGJ1dCBvbmx5IHdoZW4gdGhlIGNvcnJlY3QgcmVzdHJpY3Rpb25zCisgICAg ICAgIGhhdmUgYmVlbiBsaWZ0ZWQgaW4gV2ViQ29yZSAoaW4gdGhpcyBjYXNlLCBhbGxvd2luZwor ICAgICAgICByYXRlIGNoYW5nZXMsIHdoaWNoIGlzIHRoZSBzYW1lIHJlc3RyaWN0aW9uIHRoYXQK KyAgICAgICAgcGxheSBtYXkgcmVxdWlyZSkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlz IGRvZXNuJ3QgY2hhbmdlIGV4aXN0aW5nIGJlaGF2aW9yLiBTb21lCisgICAgICAgIFdlYktpdCBj bGllbnRzIGxpZnQgdGhlIHJlc3RyaWN0aW9uLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFF bGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpyZXF1aXJlVXNl ckdlc3R1cmVGb3JMb2FkKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnJl cXVpcmVVc2VyR2VzdHVyZUZvclJhdGVDaGFuZ2UpOgorICAgICAgICAtIG5ldyBwcm90ZWN0ZWQg bWV0aG9kcyB0byBleHBvc2UgdGhlIGN1cnJlbnQgcmVzdHJpY3Rpb25zCisgICAgICAgICogaHRt bC9IVE1MVmlkZW9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxWaWRlb0VsZW1l bnQ6OndlYmtpdEVudGVyRnVsbHNjcmVlbik6CisKIDIwMTEtMDItMTAgIE1pY2hhZWwgU2Fib2Zm ICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmZyZXkgR2Fy ZW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmluZGV4IDk3NzhmZDQuLmNj MjY1YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBAIC0xOTEsNiAr MTkxLDkgQEAgcHJvdGVjdGVkOgogICAgIERpc3BsYXlNb2RlIGRpc3BsYXlNb2RlKCkgY29uc3Qg eyByZXR1cm4gbV9kaXNwbGF5TW9kZTsgfQogICAgIHZpcnR1YWwgdm9pZCBzZXREaXNwbGF5TW9k ZShEaXNwbGF5TW9kZSBtb2RlKSB7IG1fZGlzcGxheU1vZGUgPSBtb2RlOyB9CiAKKyAgICBib29s IHJlcXVpcmVVc2VyR2VzdHVyZUZvckxvYWQoKSBjb25zdCB7IHJldHVybiBtX3Jlc3RyaWN0aW9u cyAmIFJlcXVpcmVVc2VyR2VzdHVyZUZvckxvYWRSZXN0cmljdGlvbjsgfQorICAgIGJvb2wgcmVx dWlyZVVzZXJHZXN0dXJlRm9yUmF0ZUNoYW5nZSgpIGNvbnN0IHsgcmV0dXJuIG1fcmVzdHJpY3Rp b25zICYgUmVxdWlyZVVzZXJHZXN0dXJlRm9yUmF0ZUNoYW5nZVJlc3RyaWN0aW9uOyB9CisKIHBy aXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGF0dHJpYnV0ZUNoYW5nZWQoQXR0cmlidXRlKiwgYm9v bCBwcmVzZXJ2ZURlY2xzKTsKICAgICB2aXJ0dWFsIGJvb2wgcmVuZGVyZXJJc05lZWRlZChSZW5k ZXJTdHlsZSopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlkZW9FbGVt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFZpZGVvRWxlbWVudC5jcHAKaW5kZXgg MjAwNGU0OC4uMDkxNThlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlk ZW9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQu Y3BwCkBAIC0yMzIsNyArMjMyLDcgQEAgdm9pZCBIVE1MVmlkZW9FbGVtZW50Ojp3ZWJraXRFbnRl ckZ1bGxzY3JlZW4oYm9vbCBpc1VzZXJHZXN0dXJlLCBFeGNlcHRpb25Db2RlJgogCiAgICAgLy8g R2VuZXJhdGUgYW4gZXhjZXB0aW9uIGlmIHRoaXMgaXNuJ3QgY2FsbGVkIGluIHJlc3BvbnNlIHRv IGEgdXNlciBnZXN0dXJlLCBvciBpZiB0aGUgCiAgICAgLy8gZWxlbWVudCBkb2VzIG5vdCBzdXBw b3J0IGZ1bGxzY3JlZW4uCi0gICAgaWYgKCFpc1VzZXJHZXN0dXJlIHx8ICFzdXBwb3J0c0Z1bGxz Y3JlZW4oKSkgeworICAgIGlmICgoIWlzVXNlckdlc3R1cmUgJiYgcmVxdWlyZVVzZXJHZXN0dXJl Rm9yUmF0ZUNoYW5nZSgpKSB8fCAhc3VwcG9ydHNGdWxsc2NyZWVuKCkpIHsKICAgICAgICAgZWMg PSBJTlZBTElEX1NUQVRFX0VSUjsKICAgICAgICAgcmV0dXJuOwogICAgIH0K 83861 2011-02-25 12:30:01 -0800 2011-02-25 13:23:03 -0800 Updated patch webkitfullscreen.diff text/plain 4570 dino ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MTVjODQ5Li5kZWEwNjY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEg QEAKKzIwMTEtMDItMjUgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTIzOQorCisgICAgICAgIEFsbG93IHdlYmtpdEVudGVy RnVsbFNjcmVlbiB0byBiZSBjYWxsZWQgZnJvbSBvdXRzaWRlCisgICAgICAgIGEgdXNlciBnZXN0 dXJlLCBidXQgb25seSB3aGVuIHRoZSBjb3JyZWN0IHJlc3RyaWN0aW9ucworICAgICAgICBoYXZl IGJlZW4gbGlmdGVkIGluIFdlYkNvcmUuIEFkZCBhIG5ldyByZXN0cmljdGlvbiB0eXBlCisgICAg ICAgIGZvciB0aGlzIHNpdHVhdGlvbi4gTWVhbndoaWxlLCBleHBvc2UgdGhlIGN1cnJlbnQKKyAg ICAgICAgcmVzdHJpY3Rpb25zIGV4dGVybmFsbHkgZnJvbSBIVE1MTWVkaWFFbGVtZW50LCBzbyB0 aGF0CisgICAgICAgIGNsaWVudHMgY2FuIGVhc2lseSBzZXQgcmVzdHJpY3Rpb25zIG9uIHRoZWly IHBvcnQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGRvZXNuJ3QgY2hhbmdlIGV4aXN0 aW5nIGJlaGF2aW9yLiBTb21lCisgICAgICAgIFdlYktpdCBjbGllbnRzIG1heSBsaWZ0IHRoZSBy ZXN0cmljdGlvbi4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpIVE1MTWVkaWFFbGVtZW50KToKKyAgICAg ICAgLSBlbnN1cmUgcmVzdHJpY3Rpb25zIGluaXRpYWxpemUgd2l0aCBmdWxsc2NyZWVuIHJlc3Ry aWN0ZWQKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuaDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnJlcXVpcmVVc2VyR2VzdHVyZUZvckxvYWQpOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6cmVxdWlyZVVzZXJHZXN0dXJlRm9yUmF0ZUNo YW5nZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpyZXF1aXJlVXNlckdl c3R1cmVGb3JGdWxsU2NyZWVuKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6 OnNldFJlc3RyaWN0aW9ucyk6CisgICAgICAgIC0gbmV3IG1ldGhvZHMgdG8gZXhwb3NlIHRoZSBj dXJyZW50IHJlc3RyaWN0aW9ucworICAgICAgICAqIGh0bWwvSFRNTFZpZGVvRWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MVmlkZW9FbGVtZW50Ojp3ZWJraXRFbnRlckZ1bGxzY3Jl ZW4pOgorCiAyMDExLTAyLTEwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVuLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggMmNmNDdjYy4uZTBkNmNlNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0xMzksNyArMTM5LDcgQEAgSFRNTE1l ZGlhRWxlbWVudDo6SFRNTE1lZGlhRWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1l LCBEb2N1bWVudCogZG9jdW0KICNpZiBFTkFCTEUoUExVR0lOX1BST1hZX0ZPUl9WSURFTykKICAg ICAsIG1fcHJveHlXaWRnZXQoMCkKICNlbmRpZgotICAgICwgbV9yZXN0cmljdGlvbnMoTm9SZXN0 cmljdGlvbnMpCisgICAgLCBtX3Jlc3RyaWN0aW9ucyhSZXF1aXJlVXNlckdlc3R1cmVGb3JGdWxs U2NyZWVuUmVzdHJpY3Rpb24pCiAgICAgLCBtX3ByZWxvYWQoTWVkaWFQbGF5ZXI6OkF1dG8pCiAg ICAgLCBtX2Rpc3BsYXlNb2RlKFVua25vd24pCiAgICAgLCBtX3Byb2Nlc3NpbmdNZWRpYVBsYXll ckNhbGxiYWNrKDApCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmluZGV4IDk3 NzhmZDQuLjY4ODIxOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBA IC0xNzYsNiArMTc2LDIwIEBAIHB1YmxpYzoKICAgICB2b2lkIHNvdXJjZVdpbGxCZVJlbW92ZWQo SFRNTFNvdXJjZUVsZW1lbnQqKTsKICAgICB2b2lkIHNvdXJjZVdhc0FkZGVkKEhUTUxTb3VyY2VF bGVtZW50Kik7CiAKKyAgICAvLyBSZXN0cmljdGlvbnMgdG8gY2hhbmdlIGRlZmF1bHQgYmVoYXZp b3JzLgorICAgIGVudW0gQmVoYXZpb3JSZXN0cmljdGlvbnMgeworICAgICAgICBOb1Jlc3RyaWN0 aW9ucyA9IDAsCisgICAgICAgIFJlcXVpcmVVc2VyR2VzdHVyZUZvckxvYWRSZXN0cmljdGlvbiA9 IDEgPDwgMCwKKyAgICAgICAgUmVxdWlyZVVzZXJHZXN0dXJlRm9yUmF0ZUNoYW5nZVJlc3RyaWN0 aW9uID0gMSA8PCAxLAorICAgICAgICBSZXF1aXJlVXNlckdlc3R1cmVGb3JGdWxsU2NyZWVuUmVz dHJpY3Rpb24gPSAxIDw8IDIKKyAgICB9OworCisgICAgYm9vbCByZXF1aXJlVXNlckdlc3R1cmVG b3JMb2FkKCkgY29uc3QgeyByZXR1cm4gbV9yZXN0cmljdGlvbnMgJiBSZXF1aXJlVXNlckdlc3R1 cmVGb3JMb2FkUmVzdHJpY3Rpb247IH0KKyAgICBib29sIHJlcXVpcmVVc2VyR2VzdHVyZUZvclJh dGVDaGFuZ2UoKSBjb25zdCB7IHJldHVybiBtX3Jlc3RyaWN0aW9ucyAmIFJlcXVpcmVVc2VyR2Vz dHVyZUZvclJhdGVDaGFuZ2VSZXN0cmljdGlvbjsgfQorICAgIGJvb2wgcmVxdWlyZVVzZXJHZXN0 dXJlRm9yRnVsbFNjcmVlbigpIGNvbnN0IHsgcmV0dXJuIG1fcmVzdHJpY3Rpb25zICYgUmVxdWly ZVVzZXJHZXN0dXJlRm9yRnVsbFNjcmVlblJlc3RyaWN0aW9uOyB9CisKKyAgICB2b2lkIHNldFJl c3RyaWN0aW9ucyhCZWhhdmlvclJlc3RyaWN0aW9ucyByZXN0cmljdGlvbnMpIHsgbV9yZXN0cmlj dGlvbnMgPSByZXN0cmljdGlvbnM7IH0KKwogcHJvdGVjdGVkOgogICAgIEhUTUxNZWRpYUVsZW1l bnQoY29uc3QgUXVhbGlmaWVkTmFtZSYsIERvY3VtZW50Kik7CiAgICAgdmlydHVhbCB+SFRNTE1l ZGlhRWxlbWVudCgpOwpAQCAtMjk4LDE0ICszMTIsNiBAQCBwcml2YXRlOgogICAgIHZvaWQgaW52 YWxpZGF0ZUNhY2hlZFRpbWUoKTsKICAgICB2b2lkIHJlZnJlc2hDYWNoZWRUaW1lKCkgY29uc3Q7 CiAKLSAgICAvLyBSZXN0cmljdGlvbnMgdG8gY2hhbmdlIGRlZmF1bHQgYmVoYXZpb3JzLiBUaGlz IGlzIGVmZmVjdGl2ZWx5IGEgY29tcGlsZSB0aW1lIGNob2ljZSBhdCB0aGUgbW9tZW50Ci0gICAg Ly8gYmVjYXVzZSB0aGVyZSBhcmUgbm8gYWNjZXNzb3IgZnVuY3Rpb25zLgotICAgIGVudW0gQmVo YXZpb3JSZXN0cmljdGlvbnMgewotICAgICAgICBOb1Jlc3RyaWN0aW9ucyA9IDAsCi0gICAgICAg IFJlcXVpcmVVc2VyR2VzdHVyZUZvckxvYWRSZXN0cmljdGlvbiA9IDEgPDwgMCwKLSAgICAgICAg UmVxdWlyZVVzZXJHZXN0dXJlRm9yUmF0ZUNoYW5nZVJlc3RyaWN0aW9uID0gMSA8PCAxLAotICAg IH07Ci0KICAgICBUaW1lcjxIVE1MTWVkaWFFbGVtZW50PiBtX2xvYWRUaW1lcjsKICAgICBUaW1l cjxIVE1MTWVkaWFFbGVtZW50PiBtX2FzeW5jRXZlbnRUaW1lcjsKICAgICBUaW1lcjxIVE1MTWVk aWFFbGVtZW50PiBtX3Byb2dyZXNzRXZlbnRUaW1lcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFZpZGVvRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxW aWRlb0VsZW1lbnQuY3BwCmluZGV4IDIwMDRlNDguLjdlZjBlYTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTFZpZGVvRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MVmlkZW9FbGVtZW50LmNwcApAQCAtMjMyLDcgKzIzMiw3IEBAIHZvaWQgSFRNTFZp ZGVvRWxlbWVudDo6d2Via2l0RW50ZXJGdWxsc2NyZWVuKGJvb2wgaXNVc2VyR2VzdHVyZSwgRXhj ZXB0aW9uQ29kZSYKIAogICAgIC8vIEdlbmVyYXRlIGFuIGV4Y2VwdGlvbiBpZiB0aGlzIGlzbid0 IGNhbGxlZCBpbiByZXNwb25zZSB0byBhIHVzZXIgZ2VzdHVyZSwgb3IgaWYgdGhlIAogICAgIC8v IGVsZW1lbnQgZG9lcyBub3Qgc3VwcG9ydCBmdWxsc2NyZWVuLgotICAgIGlmICghaXNVc2VyR2Vz dHVyZSB8fCAhc3VwcG9ydHNGdWxsc2NyZWVuKCkpIHsKKyAgICBpZiAoKCFpc1VzZXJHZXN0dXJl ICYmIHJlcXVpcmVVc2VyR2VzdHVyZUZvckZ1bGxTY3JlZW4oKSkgfHwgIXN1cHBvcnRzRnVsbHNj cmVlbigpKSB7CiAgICAgICAgIGVjID0gSU5WQUxJRF9TVEFURV9FUlI7CiAgICAgICAgIHJldHVy bjsKICAgICB9Cg== 83866 2011-02-25 13:23:03 -0800 2011-06-23 03:45:33 -0700 Another update webkitfullscreen.diff text/plain 4586 dino ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MTVjODQ5Li43NWIxMmMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEg QEAKKzIwMTEtMDItMjUgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTIzOQorCisgICAgICAgIEFsbG93IHdlYmtpdEVudGVy RnVsbFNjcmVlbiB0byBiZSBjYWxsZWQgZnJvbSBvdXRzaWRlCisgICAgICAgIGEgdXNlciBnZXN0 dXJlLCBidXQgb25seSB3aGVuIHRoZSBjb3JyZWN0IHJlc3RyaWN0aW9ucworICAgICAgICBoYXZl IGJlZW4gbGlmdGVkIGluIFdlYkNvcmUuIEFkZCBhIG5ldyByZXN0cmljdGlvbiB0eXBlCisgICAg ICAgIGZvciB0aGlzIHNpdHVhdGlvbi4gTWVhbndoaWxlLCBleHBvc2UgdGhlIGN1cnJlbnQKKyAg ICAgICAgcmVzdHJpY3Rpb25zIGV4dGVybmFsbHkgZnJvbSBIVE1MTWVkaWFFbGVtZW50LCBzbyB0 aGF0CisgICAgICAgIGNsaWVudHMgY2FuIGVhc2lseSBzZXQgcmVzdHJpY3Rpb25zIG9uIHRoZWly IHBvcnQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGRvZXNuJ3QgY2hhbmdlIGV4aXN0 aW5nIGJlaGF2aW9yLiBTb21lCisgICAgICAgIFdlYktpdCBjbGllbnRzIG1heSBsaWZ0IHRoZSBy ZXN0cmljdGlvbi4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpIVE1MTWVkaWFFbGVtZW50KToKKyAgICAg ICAgLSBlbnN1cmUgcmVzdHJpY3Rpb25zIGluaXRpYWxpemUgd2l0aCBmdWxsc2NyZWVuIHJlc3Ry aWN0ZWQKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuaDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnJlcXVpcmVVc2VyR2VzdHVyZUZvckxvYWQpOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6cmVxdWlyZVVzZXJHZXN0dXJlRm9yUmF0ZUNo YW5nZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpyZXF1aXJlVXNlckdl c3R1cmVGb3JGdWxsU2NyZWVuKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6 OnNldEJlaGF2aW9yUmVzdHJpY3Rpb25zKToKKyAgICAgICAgLSBuZXcgbWV0aG9kcyB0byBleHBv c2UgdGhlIGN1cnJlbnQgcmVzdHJpY3Rpb25zCisgICAgICAgICogaHRtbC9IVE1MVmlkZW9FbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxWaWRlb0VsZW1lbnQ6OndlYmtpdEVudGVy RnVsbHNjcmVlbik6CisKIDIwMTEtMDItMTAgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmZyZXkgR2FyZW4uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCAyY2Y0N2NjLi5lMGQ2Y2U0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTEzOSw3ICsxMzksNyBA QCBIVE1MTWVkaWFFbGVtZW50OjpIVE1MTWVkaWFFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUm IHRhZ05hbWUsIERvY3VtZW50KiBkb2N1bQogI2lmIEVOQUJMRShQTFVHSU5fUFJPWFlfRk9SX1ZJ REVPKQogICAgICwgbV9wcm94eVdpZGdldCgwKQogI2VuZGlmCi0gICAgLCBtX3Jlc3RyaWN0aW9u cyhOb1Jlc3RyaWN0aW9ucykKKyAgICAsIG1fcmVzdHJpY3Rpb25zKFJlcXVpcmVVc2VyR2VzdHVy ZUZvckZ1bGxTY3JlZW5SZXN0cmljdGlvbikKICAgICAsIG1fcHJlbG9hZChNZWRpYVBsYXllcjo6 QXV0bykKICAgICAsIG1fZGlzcGxheU1vZGUoVW5rbm93bikKICAgICAsIG1fcHJvY2Vzc2luZ01l ZGlhUGxheWVyQ2FsbGJhY2soMCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE1lZGlhRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgK aW5kZXggOTc3OGZkNC4uNjFhM2Q0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MTWVkaWFFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmgKQEAgLTE3Niw2ICsxNzYsMjAgQEAgcHVibGljOgogICAgIHZvaWQgc291cmNlV2lsbEJl UmVtb3ZlZChIVE1MU291cmNlRWxlbWVudCopOwogICAgIHZvaWQgc291cmNlV2FzQWRkZWQoSFRN TFNvdXJjZUVsZW1lbnQqKTsKIAorICAgIC8vIFJlc3RyaWN0aW9ucyB0byBjaGFuZ2UgZGVmYXVs dCBiZWhhdmlvcnMuCisgICAgZW51bSBCZWhhdmlvclJlc3RyaWN0aW9ucyB7CisgICAgICAgIE5v UmVzdHJpY3Rpb25zID0gMCwKKyAgICAgICAgUmVxdWlyZVVzZXJHZXN0dXJlRm9yTG9hZFJlc3Ry aWN0aW9uID0gMSA8PCAwLAorICAgICAgICBSZXF1aXJlVXNlckdlc3R1cmVGb3JSYXRlQ2hhbmdl UmVzdHJpY3Rpb24gPSAxIDw8IDEsCisgICAgICAgIFJlcXVpcmVVc2VyR2VzdHVyZUZvckZ1bGxT Y3JlZW5SZXN0cmljdGlvbiA9IDEgPDwgMgorICAgIH07CisKKyAgICBib29sIHJlcXVpcmVVc2Vy R2VzdHVyZUZvckxvYWQoKSBjb25zdCB7IHJldHVybiBtX3Jlc3RyaWN0aW9ucyAmIFJlcXVpcmVV c2VyR2VzdHVyZUZvckxvYWRSZXN0cmljdGlvbjsgfQorICAgIGJvb2wgcmVxdWlyZVVzZXJHZXN0 dXJlRm9yUmF0ZUNoYW5nZSgpIGNvbnN0IHsgcmV0dXJuIG1fcmVzdHJpY3Rpb25zICYgUmVxdWly ZVVzZXJHZXN0dXJlRm9yUmF0ZUNoYW5nZVJlc3RyaWN0aW9uOyB9CisgICAgYm9vbCByZXF1aXJl VXNlckdlc3R1cmVGb3JGdWxsU2NyZWVuKCkgY29uc3QgeyByZXR1cm4gbV9yZXN0cmljdGlvbnMg JiBSZXF1aXJlVXNlckdlc3R1cmVGb3JGdWxsU2NyZWVuUmVzdHJpY3Rpb247IH0KKworICAgIHZv aWQgc2V0QmVoYXZpb3JSZXN0cmljdGlvbnMoQmVoYXZpb3JSZXN0cmljdGlvbnMgcmVzdHJpY3Rp b25zKSB7IG1fcmVzdHJpY3Rpb25zID0gcmVzdHJpY3Rpb25zOyB9CisKIHByb3RlY3RlZDoKICAg ICBIVE1MTWVkaWFFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCopOwogICAg IHZpcnR1YWwgfkhUTUxNZWRpYUVsZW1lbnQoKTsKQEAgLTI5OCwxNCArMzEyLDYgQEAgcHJpdmF0 ZToKICAgICB2b2lkIGludmFsaWRhdGVDYWNoZWRUaW1lKCk7CiAgICAgdm9pZCByZWZyZXNoQ2Fj aGVkVGltZSgpIGNvbnN0OwogCi0gICAgLy8gUmVzdHJpY3Rpb25zIHRvIGNoYW5nZSBkZWZhdWx0 IGJlaGF2aW9ycy4gVGhpcyBpcyBlZmZlY3RpdmVseSBhIGNvbXBpbGUgdGltZSBjaG9pY2UgYXQg dGhlIG1vbWVudAotICAgIC8vIGJlY2F1c2UgdGhlcmUgYXJlIG5vIGFjY2Vzc29yIGZ1bmN0aW9u cy4KLSAgICBlbnVtIEJlaGF2aW9yUmVzdHJpY3Rpb25zIHsKLSAgICAgICAgTm9SZXN0cmljdGlv bnMgPSAwLAotICAgICAgICBSZXF1aXJlVXNlckdlc3R1cmVGb3JMb2FkUmVzdHJpY3Rpb24gPSAx IDw8IDAsCi0gICAgICAgIFJlcXVpcmVVc2VyR2VzdHVyZUZvclJhdGVDaGFuZ2VSZXN0cmljdGlv biA9IDEgPDwgMSwKLSAgICB9OwotCiAgICAgVGltZXI8SFRNTE1lZGlhRWxlbWVudD4gbV9sb2Fk VGltZXI7CiAgICAgVGltZXI8SFRNTE1lZGlhRWxlbWVudD4gbV9hc3luY0V2ZW50VGltZXI7CiAg ICAgVGltZXI8SFRNTE1lZGlhRWxlbWVudD4gbV9wcm9ncmVzc0V2ZW50VGltZXI7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MVmlkZW9FbGVtZW50LmNwcAppbmRleCAyMDA0ZTQ4Li5iMjA3MTMzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFZpZGVvRWxlbWVudC5jcHAKQEAgLTIzMiw3ICsyMzIs NyBAQCB2b2lkIEhUTUxWaWRlb0VsZW1lbnQ6OndlYmtpdEVudGVyRnVsbHNjcmVlbihib29sIGlz VXNlckdlc3R1cmUsIEV4Y2VwdGlvbkNvZGUmCiAKICAgICAvLyBHZW5lcmF0ZSBhbiBleGNlcHRp b24gaWYgdGhpcyBpc24ndCBjYWxsZWQgaW4gcmVzcG9uc2UgdG8gYSB1c2VyIGdlc3R1cmUsIG9y IGlmIHRoZSAKICAgICAvLyBlbGVtZW50IGRvZXMgbm90IHN1cHBvcnQgZnVsbHNjcmVlbi4KLSAg ICBpZiAoIWlzVXNlckdlc3R1cmUgfHwgIXN1cHBvcnRzRnVsbHNjcmVlbigpKSB7CisgICAgaWYg KChyZXF1aXJlVXNlckdlc3R1cmVGb3JGdWxsU2NyZWVuKCkgJiYgIWlzVXNlckdlc3R1cmUpIHx8 ICFzdXBwb3J0c0Z1bGxzY3JlZW4oKSkgewogICAgICAgICBlYyA9IElOVkFMSURfU1RBVEVfRVJS OwogICAgICAgICByZXR1cm47CiAgICAgfQo=