<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>55236</bug_id>
          
          <creation_ts>2011-02-25 11:05:03 -0800</creation_ts>
          <short_desc>[Chromium] .checksum files without .pngs and vice-versa</short_desc>
          <delta_ts>2011-03-08 11:43:32 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mihai Parparita">mihaip</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>dglazkov</cc>
    
    <cc>dpranke</cc>
    
    <cc>joepeck</cc>
    
    <cc>rniwa</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>358049</commentid>
    <comment_count>0</comment_count>
    <who name="Mihai Parparita">mihaip</who>
    <bug_when>2011-02-25 11:05:03 -0800</bug_when>
    <thetext>We seem to have a bunch of .checksum expectation files that don&apos;t have a .png (and vice-versa). This seems like a bad idea since it can lead to inconsistent/confusing results (e.g. .checksum mismatch even through the .pngs would match).

In directory LayoutTests/platform/chromium-mac/animations
  No PNG:
    state-at-end-event-expected
In directory LayoutTests/platform/chromium-mac/css2.1
  No checksum:
    t0905-c414-flt-01-d-g-expected
    t100801-c544-valgn-03-d-agi-expected
    t100801-c544-valgn-02-d-agi-expected
    t100801-c544-valgn-04-d-agi-expected
In directory LayoutTests/platform/chromium-mac/editing/deleting
  No PNG:
    5390681-2-expected
In directory LayoutTests/platform/chromium-mac/editing/execCommand
  No PNG:
    5481523-expected
    indent-selection-expected
    5138441-expected
In directory LayoutTests/platform/chromium-mac/editing/selection
  No checksum:
    replaced-boundaries-1-expected
    image-before-linebreak-expected
    extend-by-word-002-expected
    replaced-boundaries-2-expected
    4402375-expected
  No PNG:
    select-text-overflow-ellipsis-expected
    4960116-expected
In directory LayoutTests/platform/chromium-mac/fast/backgrounds
  No PNG:
    quirks-mode-line-box-backgrounds-expected
    svg-as-background-2-expected
In directory LayoutTests/platform/chromium-mac/fast/block/positioning
  No PNG:
    absolute-positioning-no-scrollbar-expected
In directory LayoutTests/platform/chromium-mac/fast/blockflow
  No checksum:
    background-vertical-rl-expected
    english-lr-text-expected
    japanese-rl-text-expected
In directory LayoutTests/platform/chromium-mac/fast/borders
  No PNG:
    borderRadiusSolid04-expected
    borderRadiusSolid03-expected
    borderRadiusGroove02-expected
    borderRadiusGroove01-expected
    borderRadiusOutset01-expected
    fieldsetBorderRadius-expected
    borderRadiusSolid01-expected
    borderRadiusDouble02-expected
    borderRadiusDouble03-expected
    borderRadiusArcs01-expected
    borderRadiusInset01-expected
    borderRadiusSolid02-expected
    borderRadiusRidge01-expected
In directory LayoutTests/platform/chromium-mac/fast/css
  No PNG:
    font-face-woff-expected
    css3-space-in-nth-and-lang-expected
    compare-content-style-expected
    apple-prefix-expected
In directory LayoutTests/platform/chromium-mac/fast/css/namespaces
  No PNG:
    namespaces-comments-expected
    namespaces-invalid-at-expected
    namespaces-empty-expected
    namespaces-escapes-expected
In directory LayoutTests/platform/chromium-mac/fast/dom/HTMLMeterElement
  No checksum:
    meter-appearances-capacity-expected
    meter-styles-expected
    meter-styles-changing-pseudo-expected
    meter-optimums-expected
    meter-element-expected
In directory LayoutTests/platform/chromium-mac/fast/forms
  No checksum:
    preserveFormDuringResidualStyle-expected
    input-appearance-bkcolor-expected
    input-align-image-expected
    input-type-change-expected
  No PNG:
    textarea-scrollbar-expected
In directory LayoutTests/platform/chromium-mac/fast/images
  No checksum:
    icon-decoding-expected
    imagemap-focus-ring-expected
In directory LayoutTests/platform/chromium-mac/fast/js
  No PNG:
    missing-title-end-tag-js-expected
In directory LayoutTests/platform/chromium-mac/fast/lists
  No PNG:
    anonymous-items-expected
    marker-before-empty-inline-expected
In directory LayoutTests/platform/chromium-mac/fast/media
  No checksum:
    media-query-invalid-value-expected
In directory LayoutTests/platform/chromium-mac/fast/multicol
  No PNG:
    column-count-with-rules-expected
In directory LayoutTests/platform/chromium-mac/fast/overflow
  No PNG:
    line-clamp-expected
In directory LayoutTests/platform/chromium-mac/fast/reflections
  No PNG:
    opacity-reflection-transform-expected
In directory LayoutTests/platform/chromium-mac/fast/replaced
  No checksum:
    image-tag-expected
In directory LayoutTests/platform/chromium-mac/fast/runin
  No PNG:
    generated3-expected
    generated4-expected
    generated2-expected
In directory LayoutTests/platform/chromium-mac/fast/text
  No PNG:
    stripNullFromText-expected
In directory LayoutTests/platform/chromium-mac/http/tests/misc
  No PNG:
    slow-loading-mask-expected
In directory LayoutTests/platform/chromium-mac/media
  No PNG:
    video-transformed-expected
In directory LayoutTests/platform/chromium-mac/scrollbars
  No checksum:
    overflow-scrollbar-combinations-expected
    listbox-scrollbar-combinations-expected
In directory LayoutTests/platform/chromium-mac/svg/batik/text
  No PNG:
    textProperties-expected
In directory LayoutTests/platform/chromium-mac/svg/css
  No checksum:
    text-gradient-shadow-expected
  No PNG:
    css-box-min-width-expected
In directory LayoutTests/platform/chromium-mac/svg/custom
  No PNG:
    fill-opacity-rgba-expected
    gradient-stop-corner-cases-expected
    container-opacity-clip-viewBox-expected
    fill-opacity-hsl-expected
    mask-invalidation-expected
    massive-coordinates-expected
    transformedMaskFails-expected
In directory LayoutTests/platform/chromium-mac/svg/filters
  No checksum:
    filterRes-expected
    filteredImage-expected
  No PNG:
    feColorMatrix-values-expected
In directory LayoutTests/platform/chromium-mac/svg/text
  No checksum:
    foreignObject-text-clipping-bug-expected
In directory LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1
  No checksum:
    struct-image-01-t-expected
In directory LayoutTests/platform/chromium-mac/tables/mozilla/bugs
  No checksum:
    bug12908-1-expected
    bug56563-expected
    bug10565-expected
    bug13169-expected
    bug4527-expected
    bug50695-2-expected
    bug4284-expected
    bug17138-expected
    bug120107-expected
    bug196870-expected
    bug12908-2-expected
    bug15544-expected
    bug1271-expected
    bug2981-2-expected
    bug6404-expected
    bug86708-expected
    bug4093-expected
    bug11026-expected
    bug1188-expected
    bug1318-expected
  No PNG:
    bug6674-expected
In directory LayoutTests/platform/chromium-mac/tables/mozilla/core
  No checksum:
    misc-expected
    col_widths_auto_autoFix-expected
In directory LayoutTests/platform/chromium-mac/tables/mozilla/marvin
  No checksum:
    th_valign_middle-expected
    thead_valign_baseline-expected
    tbody_valign_middle-expected
    tfoot_valign_baseline-expected
    thead_valign_middle-expected
    tr_valign_top-expected
    tbody_valign_bottom-expected
    td_valign_baseline-expected
    tr_valign_middle-expected
    tbody_valign_top-expected
    tbody_valign_baseline-expected
    th_valign_top-expected
    thead_valign_top-expected
    th_valign_baseline-expected
    td_valign_top-expected
    td_valign_middle-expected
    tfoot_valign_bottom-expected
    th_valign_bottom-expected
    td_valign_bottom-expected
    tr_valign_bottom-expected
    tfoot_valign_middle-expected
    tr_valign_baseline-expected
    thead_valign_bottom-expected
    tfoot_valign_top-expected
In directory LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs
  No checksum:
    bug6933-expected
    97619-expected
In directory LayoutTests/platform/chromium-mac/transitions
  No PNG:
    transition-end-event-rendering-expected
In directory LayoutTests/platform/chromium-mac/webarchive
  No PNG:
    test-link-rel-icon-expected

In directory LayoutTests/platform/chromium-win/compositing/repaint
  No checksum:
    become-overlay-composited-layer-expected
In directory LayoutTests/platform/chromium-win/fast/backgrounds/size
  No PNG:
    backgroundSize03-expected
In directory LayoutTests/platform/chromium-win/fast/block/float
  No PNG:
    float-on-zero-height-line-expected
    br-with-clear-expected
    negative-margin-clear-expected
    009-expected
    overhanging-after-height-decrease-offsets-expected
    nowrap-clear-min-width-expected
    034-expected
    narrow-after-wide-expected
    4145535Crash-expected
In directory LayoutTests/platform/chromium-win/fast/block/positioning
  No PNG:
    010-expected
    003-expected
    038-expected
    015-expected
    018-expected
    049-expected
    029-expected
    030-expected
    relative-overconstrained-expected
    028-expected
    021-expected
    017-expected
    013-expected
    006-expected
    035-expected
    005-expected
    042-expected
    039-expected
    041-expected
    024-expected
    move-with-auto-width-expected
    044-expected
    033-expected
    023-expected
    025-expected
    027-expected
    020-expected
    032-expected
    036-expected
    016-expected
    050-expected
    009-expected
    045-expected
    008-expected
    007-expected
    043-expected
    048-expected
    062-expected
    019-expected
    014-expected
    004-expected
    012-expected
    022-expected
    040-expected
    037-expected
    026-expected
    034-expected
    011-expected
    031-expected
    046-expected
In directory LayoutTests/platform/chromium-win/fast/borders
  No PNG:
    outline-offset-min-assert-expected
In directory LayoutTests/platform/chromium-win/fast/canvas
  No PNG:
    canvas-transform-identity-expected
    canvas-transform-infinity-expected
    canvas-transform-multiply-expected
    canvas-transform-nan-expected
    canvas-transform-non-invertible-expected
In directory LayoutTests/platform/chromium-win/fast/clip
  No PNG:
    017-expected
In directory LayoutTests/platform/chromium-win/fast/css
  No PNG:
    last-child-style-sharing-expected
    transition-color-unspecified-expected
    content-dynamic-expected
    affected-by-hover-after-style-change-expected
    006-expected
In directory LayoutTests/platform/chromium-win/fast/dom
  No PNG:
    css-cached-import-rule-expected
    delete-contents-expected
    css-insert-import-rule-expected
In directory LayoutTests/platform/chromium-win/fast/dom/HTMLStyleElement
  No PNG:
    insert-parser-generated-expected
In directory LayoutTests/platform/chromium-win/fast/dynamic
  No PNG:
    staticY-expected
    positioned-movement-with-positioned-children-expected
    subtree-boundary-percent-height-expected
    001-expected
    floating-to-positioned-expected
    subtree-table-cell-height-expected
    005-expected
    float-withdrawal-2-expected
    float-no-longer-overhanging-expected
    genContentDestroyChildren-expected
    floating-to-positioned-2-expected
    subtree-no-common-root-static-y-expected
In directory LayoutTests/platform/chromium-win/fast/events
  No PNG:
    onloadFrameCrash-expected
In directory LayoutTests/platform/chromium-win/fast/forms
  No checksum:
    searchfield-heights-expected
In directory LayoutTests/platform/chromium-win/fast/frames
  No PNG:
    calculate-relative-expected
    empty-cols-attribute-expected
    empty-frame-src-expected
    002-expected
    frame-length-fractional-expected
    calculate-fixed-expected
    calculate-percentage-expected
    calculate-order-expected
    no-frame-borders-expected
    calculate-round-expected
    frame-set-whitespace-attributes-expected
In directory LayoutTests/platform/chromium-win/fast/images
  No PNG:
    pdf-as-tiled-background-expected
    svg-width-100p-as-background-expected
    svg-as-image-expected
    svg-as-relative-image-expected
    svg-as-background-expected
    image-in-map-expected
In directory LayoutTests/platform/chromium-win/fast/inline-block
  No PNG:
    005-expected
    004-expected
In directory LayoutTests/platform/chromium-win/fast/invalid
  No PNG:
    table-residual-style-crash-expected
    015-expected
In directory LayoutTests/platform/chromium-win/fast/js
  No PNG:
    missing-title-end-tag-js-expected
    missing-style-end-tag-js-expected
    exception-linenums-in-html-3-expected
In directory LayoutTests/platform/chromium-win/fast/layers
  No PNG:
    positioned-inside-root-with-margins-expected
    zindex-ridonkulous-expected
In directory LayoutTests/platform/chromium-win/fast/lists
  No PNG:
    outSideListMarkers-expected
In directory LayoutTests/platform/chromium-win/fast/media
  No checksum:
    media-query-invalid-value-expected
In directory LayoutTests/platform/chromium-win/fast/overflow
  No PNG:
    position-relative-expected
    unreachable-content-test-expected
In directory LayoutTests/platform/chromium-win/fast/parser
  No PNG:
    style-script-head-test-expected
In directory LayoutTests/platform/chromium-win/fast/reflections
  No PNG:
    table-cell-expected
In directory LayoutTests/platform/chromium-win/fast/repaint
  No PNG:
    button-spurious-layout-hint-expected
    float-in-new-block-with-layout-delta-expected
In directory LayoutTests/platform/chromium-win/fast/replaced
  No PNG:
    008-expected
In directory LayoutTests/platform/chromium-win/fast/table
  No PNG:
    vertical-align-baseline-readjust-expected
    growCellForImageQuirk-expected
    024-expected
    max-width-integer-overflow-expected
    percent-widths-stretch-expected
    giantCellspacing-expected
    031-expected
    caption-relayout-expected
    div-as-col-span-expected
In directory LayoutTests/platform/chromium-win/fast/text
  No PNG:
    align-center-rtl-spill-expected
    apply-start-width-after-skipped-text-expected
    selection-painted-separately-expected
    soft-hyphen-3-expected
    stripNullFromText-expected
    fixed-pitch-control-characters-expected
In directory LayoutTests/platform/chromium-win/fast/tokenizer
  No PNG:
    missing-style-end-tag-2-expected
    missing-style-end-tag-1-expected
    script-after-frameset-expected
In directory LayoutTests/platform/chromium-win/fast/xsl
  No PNG:
    xslt-mismatched-tags-in-xslt-expected
In directory LayoutTests/platform/chromium-win/printing
  No checksum:
    return-from-printing-mode-expected
In directory LayoutTests/platform/chromium-win/svg/custom
  No PNG:
    transform-ignore-after-invalid-expected
    use-recalcStyle-crash-expected
    inner-svg-hit-test-expected
    fill-update-expected
    inner-percent-expected
    transformedMaskFails-expected
    use-empty-reference-expected
    invalid-transforms-expected
    gradient-add-stops-expected
    clip-path-with-transform-expected
    create-metadata-element-expected
    percentage-rect2-expected
    visibility-override-expected
    polyline-invalid-points-expected
    resource-client-removal-expected
    visibility-override-mask-expected
    evt-onload-expected
    transform-scale-parse-expected
    image-with-aspect-ratio-stretch-expected
    viewport-update2-expected
    dynamic-viewBox-expected
    transform-with-ending-space-expected
    repaint-on-image-bounds-change-expected
    SVGRect-interface-expected
    mask-excessive-malloc-expected
    pattern-in-defs-expected
    viewport-no-width-height-expected
    viewport-clip-expected
    svg-absolute-children-expected
    scroll-hit-test-expected
    xhtml-no-svg-renderer-expected
    SVGNumber-interface-expected
    clip-path-href-changes-expected
    polyline-setattribute-points-null-expected
    SVGPoint-interface-expected
    xml-stylesheet-expected
    css-pixels-dpi-expected
    polyline-hittest-expected
    rgbcolor-syntax-expected
    gradient-attr-update-expected
    visibility-override-clip-expected
    viewport-update-expected
    hover-default-fill-expected
    clip-path-child-changes-expected
    rootelement-expected
    class-selector-expected
    transform-removeAttributeNS-expected
    gradient-stop-style-change-expected
    text-gradient-no-content-expected
    transform-invalid-expected
    display-none-expected
    prevent-default-expected
    sheet-title-expected
    filter-source-alpha-expected
    mask-inside-defs-expected
    createelement-expected
    conditional-processing-outside-switch-expected
    clip-path-units-changes-expected
    poly-identify-expected
    attribute-namespace-check-expected
    use-symbol-overflow-expected
In directory LayoutTests/platform/chromium-win/svg/hixie/dynamic
  No PNG:
    003-expected
    004-expected
    006-expected
In directory LayoutTests/platform/chromium-win/svg/hixie/error
  No PNG:
    007-expected
    001-expected
    015-expected
    014-test-expected
    016-expected
    006-expected
    009-expected
    008-expected
    014-expected
In directory LayoutTests/platform/chromium-win/svg/hixie/painting
  No PNG:
    001-expected
In directory LayoutTests/platform/chromium-win/svg/hixie/processing-model
  No PNG:
    005-expected
In directory LayoutTests/platform/chromium-win/svg/hixie/rendering-model
  No PNG:
    003a-expected
In directory LayoutTests/platform/chromium-win/svg/hixie/use
  No PNG:
    002-expected
    002-test-expected
    001-expected
In directory LayoutTests/platform/chromium-win/svg/hixie/viewbox
  No PNG:
    003-expected
    002-expected
    004-expected
    001-expected
In directory LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1
  No PNG:
    struct-frag-01-t-expected
In directory LayoutTests/platform/chromium-win/svg/webarchive
  No PNG:
    svg-script-subresouces-expected
In directory LayoutTests/platform/chromium-win/tables/mozilla/bugs
  No PNG:
    bug222336-expected
    bug222467-expected
    bug8032-2-expected
    bug9024-expected
    bug269566-expected
    adforce_imgis_com-expected
    bug1818-6-expected
    bug277062-expected
    bug103533-expected
    bug2954-expected
    bug28933-expected
In directory LayoutTests/platform/chromium-win/tables/mozilla/core
  No PNG:
    col_widths_fix_autoFixPer-expected
In directory LayoutTests/platform/chromium-win/tables/mozilla_expected_failures/bugs
  No PNG:
    bug3517-expected
    bug128876-expected
In directory LayoutTests/platform/chromium-win/transitions
  No PNG:
    transition-end-event-rendering-expected
In directory LayoutTests/platform/chromium-win/webarchive
  No PNG:
    test-td-background-expected
    test-img-src-expected
    test-link-rel-icon-expected
    test-body-background-expected
    test-input-src-expected
    test-script-src-expected
    test-object-data-expected
    archive-with-unencoded-url-expected
    test-xml-stylesheet-expected
    test-table-background-expected


In directory LayoutTests/platform/chromium-linux/animations
  No PNG:
    suspend-transform-animation-expected
In directory LayoutTests/platform/chromium-linux/fast/block/float
  No checksum:
    clear-element-too-wide-for-containing-block-expected
In directory LayoutTests/platform/chromium-linux/fast/blockflow
  No checksum:
    english-bt-text-expected
    english-rl-text-expected
    english-lr-text-expected
In directory LayoutTests/platform/chromium-linux/fast/lists
  No PNG:
    outSideListMarkers-expected
In directory LayoutTests/platform/chromium-linux/fast/multicol
  No checksum:
    margin-collapse-expected
    border-padding-pagination-expected
In directory LayoutTests/platform/chromium-linux/svg/text
  No PNG:
    text-hkern-expected
    text-vkern-expected
In directory LayoutTests/platform/chromium-linux/tables/mozilla/bugs
  No checksum:
    bug16012-expected
In directory LayoutTests/platform/chromium-linux/transitions
  No PNG:
    suspend-transform-transition-expected</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>358051</commentid>
    <comment_count>1</comment_count>
      <attachid>83842</attachid>
    <who name="Mihai Parparita">mihaip</who>
    <bug_when>2011-02-25 11:06:08 -0800</bug_when>
    <thetext>Created attachment 83842
find-mismatched-results.py

Script that I used to find these</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>358064</commentid>
    <comment_count>2</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-02-25 11:17:47 -0800</bug_when>
    <thetext>I have a script that generates .checksum from .png files, but it&apos;s probably not useful.  Odds are if there&apos;s a png and no checksum, we should delete the png.

If there&apos;s a checksum and no png, we can probably run the rebaseline script to grab the pngs.

If there&apos;s a mismatch, we probably want to manually verify the differences.  The rebaseline script can still help with this.

A pre-submit hook would be useful for catching the missing file cases.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>358067</commentid>
    <comment_count>3</comment_count>
      <attachid>83846</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-02-25 11:19:32 -0800</bug_when>
    <thetext>Created attachment 83846
generate checksums from pngs

For reference, here&apos;s how to calculate the checksum in python.  I think it only works for win/linux since mac does something weird with opacity.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362735</commentid>
    <comment_count>4</comment_count>
      <attachid>84809</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-03-04 15:09:22 -0800</bug_when>
    <thetext>Created attachment 84809
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>362736</commentid>
    <comment_count>5</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-03-04 15:10:17 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; Created an attachment (id=84809) [details]
&gt; Patch

May as well get find-mismatched-results.py checked in.  This is based on Mihai&apos;s code, but I wanted something I could pipe to xargs rm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363596</commentid>
    <comment_count>6</comment_count>
      <attachid>84809</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-03-07 14:43:26 -0800</bug_when>
    <thetext>Comment on attachment 84809
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84809&amp;action=review

Looks fine otherwise.

&gt; Tools/Scripts/find-mismatched-results:51
&gt; +        option_parser.error(&quot;Please --missing-pngs or --missing-checksums.&quot;)

Nit. &quot;Please specify either ...&quot;

&gt; Tools/Scripts/find-mismatched-results:55
&gt; +            &apos;..&apos;, &apos;..&apos;, &apos;LayoutTests&apos;)]

Nit. Should replace this with a webkitpy routine to find the top of the tree. Unfortunately, common.checkout.scm.find_checkout_root() doesn&apos;t really do the right thing. layout_tests.port.get().path_from_webkit_base(&apos;LayoutTests&apos;) should, I think. Maybe add a FIXME?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363620</commentid>
    <comment_count>7</comment_count>
      <attachid>84985</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-03-07 15:02:37 -0800</bug_when>
    <thetext>Created attachment 84985
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363623</commentid>
    <comment_count>8</comment_count>
      <attachid>84985</attachid>
    <who name="Mihai Parparita">mihaip</who>
    <bug_when>2011-03-07 15:09:11 -0800</bug_when>
    <thetext>Comment on attachment 84985
Patch

Nit: The name find-mismatched-results is rather generic, maybe find-mismatched-layout-test-results?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363624</commentid>
    <comment_count>9</comment_count>
      <attachid>84985</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2011-03-07 15:11:56 -0800</bug_when>
    <thetext>Comment on attachment 84985
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84985&amp;action=review

&gt; Tools/ChangeLog:5
&gt; +        [Chromium] .checksum files without .pngs and vice-versa

Nit (if it&apos;s not too late): &quot;Find .checksum files ...&quot; ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363639</commentid>
    <comment_count>10</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-03-07 15:41:03 -0800</bug_when>
    <thetext>Committed r80504: &lt;http://trac.webkit.org/changeset/80504&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>363642</commentid>
    <comment_count>11</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-03-07 15:43:56 -0800</bug_when>
    <thetext>I&apos;m going to go ahead and delete pngs without checksums (all ports) and try grabbing pngs from the bots for checksums without pngs (chromium ports only).

We should probably also have a presubmit check for this, but that can be tracked in a different bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>364064</commentid>
    <comment_count>12</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2011-03-08 11:43:32 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; I&apos;m going to go ahead and delete pngs without checksums (all ports) and try grabbing pngs from the bots for checksums without pngs (chromium ports only).

I deleted pngs without checksums, so `find-mismatched-layout-test-results --missing-checksums` should return nothing now.

I was unable to grab pngs from the bots because passing tests don&apos;t have archived results.  I went ahead and landed pngs for chromium-linux, but most of the missing pngs are in chromium-mac.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>83842</attachid>
            <date>2011-02-25 11:06:08 -0800</date>
            <delta_ts>2011-02-25 11:06:08 -0800</delta_ts>
            <desc>find-mismatched-results.py</desc>
            <filename>find-mismatched-results.py</filename>
            <type>text/x-python-script</type>
            <size>702</size>
            <attacher name="Mihai Parparita">mihaip</attacher>
            
              <data encoding="base64">aW1wb3J0IG9zCmltcG9ydCBvcy5wYXRoCmltcG9ydCBzeXMKCmZvciBkaXJwYXRoLCBkaXJuYW1l
cywgZmlsZW5hbWVzIGluIG9zLndhbGsoc3lzLmFyZ3ZbMV0pOgogIGNoZWNrc3VtX2ZpbGVzID0g
c2V0KCkKICBwbmdfZmlsZXMgPSBzZXQoKQogIAogIGZvciBmaWxlbmFtZSBpbiBmaWxlbmFtZXM6
CiAgICBuYW1lLCBleHRlbnNpb24gPSBvcy5wYXRoLnNwbGl0ZXh0KGZpbGVuYW1lKQogICAgaWYg
ZXh0ZW5zaW9uID09ICIuY2hlY2tzdW0iOgogICAgICBjaGVja3N1bV9maWxlcy5hZGQobmFtZSkK
ICAgIGVsaWYgZXh0ZW5zaW9uID09ICIucG5nIjoKICAgICAgcG5nX2ZpbGVzLmFkZChuYW1lKQoK
ICBub19jaGVja3N1bSA9IGNoZWNrc3VtX2ZpbGVzLmRpZmZlcmVuY2UocG5nX2ZpbGVzKQogIG5v
X3BuZyA9IHBuZ19maWxlcy5kaWZmZXJlbmNlKGNoZWNrc3VtX2ZpbGVzKQogIGlmIG5vX2NoZWNr
c3VtIG9yIG5vX3BuZzoKICAgIHByaW50ICJJbiBkaXJlY3RvcnkgJXMiICUgZGlycGF0aAogICAg
aWYgbm9fY2hlY2tzdW06CiAgICAgIHByaW50ICIgIE5vIGNoZWNrc3VtOiIKICAgICAgZm9yIGYg
aW4gbm9fY2hlY2tzdW06CiAgICAgICAgcHJpbnQgIiAgICAlcyIgJSBmCiAgICBpZiBub19wbmc6
CiAgICAgIHByaW50ICIgIE5vIFBORzoiCiAgICAgIGZvciBmIGluIG5vX3BuZzoKICAgICAgICBw
cmludCAiICAgICVzIiAlIGYK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>83846</attachid>
            <date>2011-02-25 11:19:32 -0800</date>
            <delta_ts>2011-02-25 11:19:32 -0800</delta_ts>
            <desc>generate checksums from pngs</desc>
            <filename>checksum.py</filename>
            <type>text/plain</type>
            <size>1779</size>
            <attacher name="Tony Chang">tony</attacher>
            
              <data encoding="base64">aW1wb3J0IGhhc2hsaWIKaW1wb3J0IG9zCmZyb20gUElMIGltcG9ydCBJbWFnZQoKZGVmIGNvbXB1
dGVfY2hlY2tzdW0oZmlsZW5hbWUpOgogIGltID0gSW1hZ2Uub3BlbihmaWxlbmFtZSkKICByZ2Jh
X2RhdGEgPSAnJwogIGZvciBwaXhlbCBpbiBpbS5nZXRkYXRhKCk6CiAgICBwaXhlbHMgPSBtYXAo
Y2hyLCBwaXhlbCkKICAgIHBpeGVscy5yZXZlcnNlKCkKICAgIGJ5dGVzID0gJycuam9pbihwaXhl
bHMpCiAgICByZ2JhX2RhdGEgKz0gYnl0ZXMgKyAnXHhmZicKCiAgI29wZW4oInJhd2ltYWdlMiIs
ICJ3Iikud3JpdGUocmdiYV9kYXRhKQoKICBtZDUgPSBoYXNobGliLm1kNSgpCiAgbWQ1LnVwZGF0
ZShyZ2JhX2RhdGEpCiAgcmV0dXJuIG1kNS5oZXhkaWdlc3QoKQoKCmRlZiBDaGVja0ZhbGxiYWNr
KGNoZWNrc3VtLCBwbmcpOgogICMgU2VlIGlmIHRoZSBwbmcgaXMgaW4gYSBmYWxsYmFjayBkaXIu
CiAgcHJpbnQgIkxvb2tpbmcgZm9yIGZhbGxiYWNrOiIsIGNoZWNrc3VtCiAgZmFsbGJhY2sgPSBw
bmcucmVwbGFjZSgiY2hyb21pdW0tbGludXgiLCAiY2hyb21pdW0td2luIikKICBpZiBub3Qgb3Mu
cGF0aC5leGlzdHMoZmFsbGJhY2spOgogICAgZmFsbGJhY2sgPSBmYWxsYmFjay5yZXBsYWNlKCJj
aHJvbWl1bS13aW4iLCAiY2hyb21pdW0tbWFjIikKICBpZiBub3Qgb3MucGF0aC5leGlzdHMoZmFs
bGJhY2spOgogICAgZmFsbGJhY2sgPSBmYWxsYmFjay5yZXBsYWNlKCJjaHJvbWl1bS1tYWMiLCAi
Y2hyb21pdW0iKQogIGlmIG5vdCBvcy5wYXRoLmV4aXN0cyhmYWxsYmFjayk6CiAgICBwcmludCAi
Q2FuJ3QgZmluZCByZXN1bHQ6ICIgKyBwbmcKICAgIHJldHVybgogIG5ld19jaGVja3N1bSA9IGNv
bXB1dGVfY2hlY2tzdW0oZmFsbGJhY2spCiAgYmFzZW5hbWUsIF8gPSBvcy5wYXRoLnNwbGl0ZXh0
KGZhbGxiYWNrKQogIGlmIG9wZW4oYmFzZW5hbWUgKyAiLmNoZWNrc3VtIikucmVhZCgpID09IG5l
d19jaGVja3N1bToKICAgIHByaW50ICJNYXliZSByZW1vdmUiLCBjaGVja3N1bSwgIj8iCiAgZWxz
ZToKICAgIHByaW50ICJOZWVkIGEgbmV3IGNoZWNrc3VtPyIsIHBuZwoKCmtCYXNlRGlyID0gJy9z
cmMvV2ViS2l0L0xheW91dFRlc3RzL3BsYXRmb3JtL2dvb2dsZS1jaHJvbWUtbGludXg2NCcKZm9y
IHJvb3QsIGRpcnMsIGZpbGVzIGluIG9zLndhbGsoa0Jhc2VEaXIpOgogIGZvciBmaWxlbmFtZSBp
biBmaWxlczoKICAgIGlmIGZpbGVuYW1lLmVuZHN3aXRoKCctZXhwZWN0ZWQucG5nJyk6CiAgICAg
IG5ld19jaGVja3N1bSA9IGNvbXB1dGVfY2hlY2tzdW0ob3MucGF0aC5qb2luKHJvb3QsIGZpbGVu
YW1lKSkKICAgICAgY2hlY2tzdW1fZmlsZW5hbWUsIF8gPSBvcy5wYXRoLnNwbGl0ZXh0KGZpbGVu
YW1lKQogICAgICBjaGVja3N1bV9maWxlbmFtZSA9IG9zLnBhdGguam9pbihyb290LCBjaGVja3N1
bV9maWxlbmFtZSArICcuY2hlY2tzdW0nKQogICAgICBmID0gb3BlbihjaGVja3N1bV9maWxlbmFt
ZSwgJ3cnKTsKICAgICAgZi53cml0ZShuZXdfY2hlY2tzdW0pOwogICAgICBmLmNsb3NlKCkKICAg
ICAgY29udGludWUKICAgIGlmIGZpbGVuYW1lLmVuZHN3aXRoKCctZXhwZWN0ZWQuY2hlY2tzdW0n
KToKICAgICAgYmFzZSwgXyA9IG9zLnBhdGguc3BsaXRleHQoZmlsZW5hbWUpCiAgICAgIHBuZyA9
IG9zLnBhdGguam9pbihyb290LCBiYXNlICsgIi5wbmciKQogICAgICBpZiBub3Qgb3MucGF0aC5l
eGlzdHMocG5nKToKICAgICAgICBDaGVja0ZhbGxiYWNrKG9zLnBhdGguam9pbihyb290LCBmaWxl
bmFtZSksIHBuZykK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>84809</attachid>
            <date>2011-03-04 15:09:22 -0800</date>
            <delta_ts>2011-03-07 15:02:33 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-55236-20110304150930.patch</filename>
            <type>text/plain</type>
            <size>4972</size>
            <attacher name="Tony Chang">tony</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODAzNzgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmYmNmODczMWRhNTg2MWVmMzVkY2U5MTkyMzBkNzYwNTIz
YTU4MTkxLi4xNzhmYjQ4MmYxYWFmZDM3ZjA5ODEwZGIwNDhiMjVjMjA3Nzk0MjY5IDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg
QEAKKzIwMTEtMDMtMDQgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIC5jaGVj
a3N1bSBmaWxlcyB3aXRob3V0IC5wbmdzIGFuZCB2aWNlLXZlcnNhCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTIzNgorCisgICAgICAgICogU2NyaXB0
cy9maW5kLW1pc21hdGNoZWQtcmVzdWx0czogQWRkZWQuIEEgc2NyaXB0IGZvciBmaW5kaW5nCisg
ICAgICAgICAgICBtaXNtYXRjaGVkIHJlc3VsdHMuCisKIDIwMTEtMDMtMDQgIEV2YW4gTWFydGlu
ICA8ZXZhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4K
ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvZmluZC1taXNtYXRjaGVkLXJlc3VsdHMgYi9Ub29s
cy9TY3JpcHRzL2ZpbmQtbWlzbWF0Y2hlZC1yZXN1bHRzCm5ldyBmaWxlIG1vZGUgMTAwNzU1Cmlu
ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjVlMTJjZWQ3ZjRi
Y2ViYTRiYTFmNjhkYmU4MzczZTdhZmNkMDM5YzIKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9T
Y3JpcHRzL2ZpbmQtbWlzbWF0Y2hlZC1yZXN1bHRzCkBAIC0wLDAgKzEsOTQgQEAKKyMhL3Vzci9i
aW4vZW52IHB5dGhvbgorIyBDb3B5cmlnaHQgKGMpIDIwMTEgR29vZ2xlIEluYy4gQWxsIHJpZ2h0
cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp
bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRl
ZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyMgbWV0OgorIwor
IyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFi
b3ZlIGNvcHlyaWdodAorIyBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUg
Zm9sbG93aW5nIGRpc2NsYWltZXIuCisjICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkg
Zm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyMgY29weXJpZ2h0IG5vdGljZSwgdGhpcyBs
aXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorIyBpbiB0aGUg
ZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisj
IGRpc3RyaWJ1dGlvbi4KKyMgICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBu
b3IgdGhlIG5hbWVzIG9mIGl0cworIyBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3Jz
ZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorIyB0aGlzIHNvZnR3YXJlIHdpdGhv
dXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorIworIyBUSElTIFNPRlRXQVJF
IElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisj
ICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5H
LCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hB
TlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorIyBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElT
Q0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAorIyBPV05FUiBPUiBDT05U
UklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwK
KyMgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElO
RywgQlVUIE5PVAorIyBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RT
IE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyMgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5F
U1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisjIFRIRU9SWSBPRiBM
SUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQK
KyMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZ
IE9VVCBPRiBUSEUgVVNFCisjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBU
SEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKKyIiIkZpbmRzIC5wbmcgZXhwZWN0YXRp
b25zIHdpdGhvdXQgLmNoZWNrc3VtcyBvciAuY2hlY2tzdW0gZXhwZWN0YXRpb25zCit3aXRob3V0
IC5wbmdzLiIiIgorCitpbXBvcnQgb3B0cGFyc2UKK2ltcG9ydCBvcworCitkZWYgcGFyc2VfYXJn
cygpOgorICAgICIiIlJldHVybnMgYSAyLXR1cGxlIChvcHRpb25zLCBwYXRocykgd2hlcmUgb3B0
aW9ucyBjb250YWlucyB0aGUKKyAgICBwYXJzZWQgYXJndW1lbnRzIGFuZCBwYXRocyBpcyBhIGxp
c3Qgb2YgZGlyZWN0b3JpZXMgdG8gc2VhcmNoLiIiIgorICAgIG9wdGlvbl9saXN0ID0gWworICAg
ICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLXAiLCAiLS1taXNzaW5nLXBuZ3MiLCBkZXN0PSJt
aXNzaW5nX3BuZ3MiLAorICAgICAgICAgICAgYWN0aW9uPSJzdG9yZV90cnVlIiwgZGVmYXVsdD1G
YWxzZSwgaGVscD0iT25seSBsaXN0IG1pc3NpbmcgcG5ncy4iKSwKKyAgICAgICAgb3B0cGFyc2Uu
bWFrZV9vcHRpb24oIi1jIiwgIi0tbWlzc2luZy1jaGVja3N1bXMiLAorICAgICAgICAgICAgZGVz
dD0ibWlzc2luZ19jaGVja3N1bXMiLCBhY3Rpb249InN0b3JlX3RydWUiLCBkZWZhdWx0PUZhbHNl
LAorICAgICAgICAgICAgaGVscD0iT25seSBsaXN0IG1pc3NpbmcgY2hlY2tzdW1zLiIpLAorICAg
IF0KKworICAgIG9wdGlvbl9wYXJzZXIgPSBvcHRwYXJzZS5PcHRpb25QYXJzZXIob3B0aW9uX2xp
c3Q9b3B0aW9uX2xpc3QsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBkZXNjcmlwdGlvbj1fX2RvY19fKQorICAgIG9wdGlvbnMsIHBhdGhzID0gb3B0aW9uX3BhcnNl
ci5wYXJzZV9hcmdzKCkKKyAgICBpZiBub3Qgb3B0aW9ucy5taXNzaW5nX3BuZ3MgYW5kIG5vdCBv
cHRpb25zLm1pc3NpbmdfY2hlY2tzdW1zOgorICAgICAgICBvcHRpb25fcGFyc2VyLmVycm9yKCJQ
bGVhc2UgLS1taXNzaW5nLXBuZ3Mgb3IgLS1taXNzaW5nLWNoZWNrc3Vtcy4iKQorCisgICAgaWYg
bm90IHBhdGhzOgorICAgICAgICBwYXRocyA9IFtvcy5wYXRoLmpvaW4ob3MucGF0aC5kaXJuYW1l
KG9zLnBhdGguYWJzcGF0aChfX2ZpbGVfXykpLAorICAgICAgICAgICAgJy4uJywgJy4uJywgJ0xh
eW91dFRlc3RzJyldCisgICAgcmV0dXJuIG9wdGlvbnMsIHBhdGhzCisKK2RlZiBmaW5kX21pc21h
dGNoZWRfcmVzdWx0cyhkaXJwYXRoLCBmaWxlbmFtZXMsIG9wdGlvbnMpOgorICAgICIiIlByaW50
cyBtaXNtYXRjaGVkIHJlc3VsdHMgdG8gc3Rkb3V0LgorICAgIGRpcnBhdGggaXMgdGhlIGRpcmVj
dG9yeSB3ZSBhcmUgc2VhcmNoaW5nCisgICAgZmlsZW5hbWVzIGlzIGEgbGlzdCBvZiB0aGUgZmls
ZW5hbWVzIGluIGRpcnBhdGguCisgICAgb3B0aW9ucyBpcyB0aGUgcGFyc2VkIGFyZ3VtZW50cy4i
IiIKKyAgICBjaGVja3N1bV9maWxlcyA9IHNldCgpCisgICAgcG5nX2ZpbGVzID0gc2V0KCkKKyAg
ICAKKyAgICBmb3IgZmlsZW5hbWUgaW4gZmlsZW5hbWVzOgorICAgICAgICBuYW1lLCBleHRlbnNp
b24gPSBvcy5wYXRoLnNwbGl0ZXh0KGZpbGVuYW1lKQorICAgICAgICBpZiBub3QgbmFtZS5lbmRz
d2l0aCgiLWV4cGVjdGVkIik6CisgICAgICAgICAgICBjb250aW51ZQorICAgICAgICBpZiBleHRl
bnNpb24gPT0gIi5jaGVja3N1bSI6CisgICAgICAgICAgICBjaGVja3N1bV9maWxlcy5hZGQobmFt
ZSkKKyAgICAgICAgZWxpZiBleHRlbnNpb24gPT0gIi5wbmciOgorICAgICAgICAgICAgcG5nX2Zp
bGVzLmFkZChuYW1lKQorCisgICAgaWYgb3B0aW9ucy5taXNzaW5nX3BuZ3M6CisgICAgICAgIG1p
c3NpbmdfcG5ncyA9IGNoZWNrc3VtX2ZpbGVzLmRpZmZlcmVuY2UocG5nX2ZpbGVzKQorICAgICAg
ICBmb3IgbWlzc2luZ19wbmcgaW4gbWlzc2luZ19wbmdzOgorICAgICAgICAgICAgcHJpbnQgb3Mu
cGF0aC5ub3JtcGF0aChvcy5wYXRoLmpvaW4oZGlycGF0aCwgbWlzc2luZ19wbmcpCisgICAgICAg
ICAgICAgICAgKSArICcuY2hlY2tzdW0nCisKKyAgICBpZiBvcHRpb25zLm1pc3NpbmdfY2hlY2tz
dW1zOgorICAgICAgICBtaXNzaW5nX2NoZWNrc3VtcyA9IHBuZ19maWxlcy5kaWZmZXJlbmNlKGNo
ZWNrc3VtX2ZpbGVzKQorICAgICAgICBmb3IgbWlzc2luZ19jaGVja3N1bSBpbiBtaXNzaW5nX2No
ZWNrc3VtczoKKyAgICAgICAgICAgIHByaW50IG9zLnBhdGgubm9ybXBhdGgob3MucGF0aC5qb2lu
KGRpcnBhdGgsIG1pc3NpbmdfY2hlY2tzdW0pCisgICAgICAgICAgICAgICAgKSArICcucG5nJwor
CitkZWYgbWFpbigpOgorICAgIG9wdGlvbnMsIHBhdGhzID0gcGFyc2VfYXJncygpCisKKyAgICBm
b3IgcGF0aCBpbiBwYXRoczoKKyAgICAgICAgZm9yIGRpcnBhdGgsIGRpcm5hbWVzLCBmaWxlbmFt
ZXMgaW4gb3Mud2FsayhwYXRoKToKKyAgICAgICAgICAgIGZpbmRfbWlzbWF0Y2hlZF9yZXN1bHRz
KGRpcnBhdGgsIGZpbGVuYW1lcywgb3B0aW9ucykKK2lmIF9fbmFtZV9fID09ICJfX21haW5fXyI6
CisgICAgbWFpbigpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>84985</attachid>
            <date>2011-03-07 15:02:37 -0800</date>
            <delta_ts>2011-03-07 15:11:56 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-55236-20110307150258.patch</filename>
            <type>text/plain</type>
            <size>5003</size>
            <attacher name="Tony Chang">tony</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODA1MDAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlOTQyZDZmNTMzZjU2OTU3NjM0MjQyY2I4MTEyMTVlMzFm
MTFlZmY0Li45N2IxZDk1ZTFhZTNmYTVjNTQ4Njc1MGU5ODU2NDZiZTNhN2JkMmY4IDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg
QEAKKzIwMTEtMDMtMDcgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIC5jaGVj
a3N1bSBmaWxlcyB3aXRob3V0IC5wbmdzIGFuZCB2aWNlLXZlcnNhCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTIzNgorCisgICAgICAgICogU2NyaXB0
cy9maW5kLW1pc21hdGNoZWQtcmVzdWx0czogQWRkZWQuIEEgc2NyaXB0IGZvciBmaW5kaW5nCisg
ICAgICAgICAgICBtaXNtYXRjaGVkIHJlc3VsdHMuCisKIDIwMTEtMDMtMDcgIENocmlzIEZsZWl6
YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBCZXRoIERh
a2luLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9maW5kLW1pc21hdGNoZWQtcmVzdWx0cyBi
L1Rvb2xzL1NjcmlwdHMvZmluZC1taXNtYXRjaGVkLXJlc3VsdHMKbmV3IGZpbGUgbW9kZSAxMDA3
NTUKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDU0MzE3
MTVlMmNmMTJmNWIzY2QyNWVkZDJlY2I3Mjk2OWE4MGQ5NwotLS0gL2Rldi9udWxsCisrKyBiL1Rv
b2xzL1NjcmlwdHMvZmluZC1taXNtYXRjaGVkLXJlc3VsdHMKQEAgLTAsMCArMSw5NiBAQAorIyEv
dXNyL2Jpbi9lbnYgcHl0aG9uCisjIENvcHlyaWdodCAoYykgMjAxMSBHb29nbGUgSW5jLiBBbGwg
cmlnaHRzIHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBh
bmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9uLCBhcmUgcGVy
bWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorIyBtZXQ6
CisjCisjICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0
aGUgYWJvdmUgY29weXJpZ2h0CisjIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5k
IHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgICAgICogUmVkaXN0cmlidXRpb25zIGluIGJp
bmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorIyBjb3B5cmlnaHQgbm90aWNlLCB0
aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisjIGlu
IHRoZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0
aGUKKyMgZGlzdHJpYnV0aW9uLgorIyAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJ
bmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCisjIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBl
bmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tCisjIHRoaXMgc29mdHdhcmUg
d2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisjCisjIFRISVMgU09G
VFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRP
UlMKKyMgIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNM
VURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBN
RVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisjIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFS
RSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisjIE9XTkVSIE9S
IENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVO
VEFMLAorIyBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5D
TFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUg
R09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorIyBEQVRBLCBPUiBQUk9GSVRTOyBPUiBC
VVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyMgVEhFT1JZ
IE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1Ig
VE9SVAorIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFO
WSBXQVkgT1VUIE9GIFRIRSBVU0UKKyMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VE
IE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKworIiIiRmluZHMgLnBuZyBleHBl
Y3RhdGlvbnMgd2l0aG91dCAuY2hlY2tzdW1zIG9yIC5jaGVja3N1bSBleHBlY3RhdGlvbnMKK3dp
dGhvdXQgLnBuZ3MuIiIiCisKK2ltcG9ydCBvcHRwYXJzZQoraW1wb3J0IG9zCisKK2Zyb20gd2Vi
a2l0cHkuY29tbW9uLmNoZWNrb3V0IGltcG9ydCBzY20KKworZGVmIHBhcnNlX2FyZ3MoKToKKyAg
ICAiIiJSZXR1cm5zIGEgMi10dXBsZSAob3B0aW9ucywgcGF0aHMpIHdoZXJlIG9wdGlvbnMgY29u
dGFpbnMgdGhlCisgICAgcGFyc2VkIGFyZ3VtZW50cyBhbmQgcGF0aHMgaXMgYSBsaXN0IG9mIGRp
cmVjdG9yaWVzIHRvIHNlYXJjaC4iIiIKKyAgICBvcHRpb25fbGlzdCA9IFsKKyAgICAgICAgb3B0
cGFyc2UubWFrZV9vcHRpb24oIi1wIiwgIi0tbWlzc2luZy1wbmdzIiwgZGVzdD0ibWlzc2luZ19w
bmdzIiwKKyAgICAgICAgICAgIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsIGRlZmF1bHQ9RmFsc2UsIGhl
bHA9Ik9ubHkgbGlzdCBtaXNzaW5nIHBuZ3MuIiksCisgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0
aW9uKCItYyIsICItLW1pc3NpbmctY2hlY2tzdW1zIiwKKyAgICAgICAgICAgIGRlc3Q9Im1pc3Np
bmdfY2hlY2tzdW1zIiwgYWN0aW9uPSJzdG9yZV90cnVlIiwgZGVmYXVsdD1GYWxzZSwKKyAgICAg
ICAgICAgIGhlbHA9Ik9ubHkgbGlzdCBtaXNzaW5nIGNoZWNrc3Vtcy4iKSwKKyAgICBdCisKKyAg
ICBvcHRpb25fcGFyc2VyID0gb3B0cGFyc2UuT3B0aW9uUGFyc2VyKG9wdGlvbl9saXN0PW9wdGlv
bl9saXN0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVzY3Jp
cHRpb249X19kb2NfXykKKyAgICBvcHRpb25zLCBwYXRocyA9IG9wdGlvbl9wYXJzZXIucGFyc2Vf
YXJncygpCisgICAgaWYgbm90IG9wdGlvbnMubWlzc2luZ19wbmdzIGFuZCBub3Qgb3B0aW9ucy5t
aXNzaW5nX2NoZWNrc3VtczoKKyAgICAgICAgb3B0aW9uX3BhcnNlci5lcnJvcigKKyAgICAgICAg
ICAgICJQbGVhc2Ugc3BlY2lmeSBlaXRoZXIgLS1taXNzaW5nLXBuZ3Mgb3IgLS1taXNzaW5nLWNo
ZWNrc3Vtcy4iKQorCisgICAgaWYgbm90IHBhdGhzOgorICAgICAgICBwYXRocyA9IFtvcy5wYXRo
LmpvaW4oc2NtLmZpbmRfY2hlY2tvdXRfcm9vdCgpLCAnTGF5b3V0VGVzdHMnKV0KKyAgICByZXR1
cm4gb3B0aW9ucywgcGF0aHMKKworZGVmIGZpbmRfbWlzbWF0Y2hlZF9yZXN1bHRzKGRpcnBhdGgs
IGZpbGVuYW1lcywgb3B0aW9ucyk6CisgICAgIiIiUHJpbnRzIG1pc21hdGNoZWQgcmVzdWx0cyB0
byBzdGRvdXQuCisgICAgZGlycGF0aCBpcyB0aGUgZGlyZWN0b3J5IHdlIGFyZSBzZWFyY2hpbmcK
KyAgICBmaWxlbmFtZXMgaXMgYSBsaXN0IG9mIHRoZSBmaWxlbmFtZXMgaW4gZGlycGF0aC4KKyAg
ICBvcHRpb25zIGlzIHRoZSBwYXJzZWQgYXJndW1lbnRzLiIiIgorICAgIGNoZWNrc3VtX2ZpbGVz
ID0gc2V0KCkKKyAgICBwbmdfZmlsZXMgPSBzZXQoKQorCisgICAgZm9yIGZpbGVuYW1lIGluIGZp
bGVuYW1lczoKKyAgICAgICAgbmFtZSwgZXh0ZW5zaW9uID0gb3MucGF0aC5zcGxpdGV4dChmaWxl
bmFtZSkKKyAgICAgICAgaWYgbm90IG5hbWUuZW5kc3dpdGgoIi1leHBlY3RlZCIpOgorICAgICAg
ICAgICAgY29udGludWUKKyAgICAgICAgaWYgZXh0ZW5zaW9uID09ICIuY2hlY2tzdW0iOgorICAg
ICAgICAgICAgY2hlY2tzdW1fZmlsZXMuYWRkKG5hbWUpCisgICAgICAgIGVsaWYgZXh0ZW5zaW9u
ID09ICIucG5nIjoKKyAgICAgICAgICAgIHBuZ19maWxlcy5hZGQobmFtZSkKKworICAgIGlmIG9w
dGlvbnMubWlzc2luZ19wbmdzOgorICAgICAgICBtaXNzaW5nX3BuZ3MgPSBjaGVja3N1bV9maWxl
cy5kaWZmZXJlbmNlKHBuZ19maWxlcykKKyAgICAgICAgZm9yIG1pc3NpbmdfcG5nIGluIG1pc3Np
bmdfcG5nczoKKyAgICAgICAgICAgIHByaW50IG9zLnBhdGgubm9ybXBhdGgob3MucGF0aC5qb2lu
KGRpcnBhdGgsIG1pc3NpbmdfcG5nKQorICAgICAgICAgICAgICAgICkgKyAnLmNoZWNrc3VtJwor
CisgICAgaWYgb3B0aW9ucy5taXNzaW5nX2NoZWNrc3VtczoKKyAgICAgICAgbWlzc2luZ19jaGVj
a3N1bXMgPSBwbmdfZmlsZXMuZGlmZmVyZW5jZShjaGVja3N1bV9maWxlcykKKyAgICAgICAgZm9y
IG1pc3NpbmdfY2hlY2tzdW0gaW4gbWlzc2luZ19jaGVja3N1bXM6CisgICAgICAgICAgICBwcmlu
dCBvcy5wYXRoLm5vcm1wYXRoKG9zLnBhdGguam9pbihkaXJwYXRoLCBtaXNzaW5nX2NoZWNrc3Vt
KQorICAgICAgICAgICAgICAgICkgKyAnLnBuZycKKworZGVmIG1haW4oKToKKyAgICBvcHRpb25z
LCBwYXRocyA9IHBhcnNlX2FyZ3MoKQorCisgICAgZm9yIHBhdGggaW4gcGF0aHM6CisgICAgICAg
IGZvciBkaXJwYXRoLCBkaXJuYW1lcywgZmlsZW5hbWVzIGluIG9zLndhbGsocGF0aCk6CisgICAg
ICAgICAgICBmaW5kX21pc21hdGNoZWRfcmVzdWx0cyhkaXJwYXRoLCBmaWxlbmFtZXMsIG9wdGlv
bnMpCitpZiBfX25hbWVfXyA9PSAiX19tYWluX18iOgorICAgIG1haW4oKQo=
</data>
<flag name="review"
          id="77043"
          type_id="1"
          status="+"
          setter="mihaip"
    />
          </attachment>
      

    </bug>

</bugzilla>