55232 2011-02-25 10:35:42 -0800 Chromium: pass frame history state in the context menu parameters. 2011-02-27 23:29:11 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman fishd oldest_to_newest 358018 0 pfeldman 2011-02-25 10:35:42 -0800 Patch to follow. 358022 1 83836 pfeldman 2011-02-25 10:37:50 -0800 Created attachment 83836 [PATCH] Proposed change. 358044 2 83836 fishd 2011-02-25 11:01:08 -0800 Comment on attachment 83836 [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=83836&action=review > Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:246 > + RefPtr<HistoryItem> historyItem = selectedFrame->loader()->history()->currentItem(); indentation! :-( 358907 3 pfeldman 2011-02-27 23:29:11 -0800 Committed r79843: <http://trac.webkit.org/changeset/79843> 83836 2011-02-25 10:37:50 -0800 2011-02-25 11:01:08 -0800 [PATCH] Proposed change. context_menu text/plain 2582 pfeldman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMDZmZmFiZC4uNGMyMmIyYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wMi0yNSAgUGF2ZWwgRmVs ZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBQYXNzIGZyYW1lIGhpc3Rvcnkgc3RhdGUgaW4gdGhlIGNv bnRleHQgbWVudSBwYXJhbWV0ZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTUyMzIKKworICAgICAgICAqIHB1YmxpYy9XZWJDb250ZXh0TWVudURh dGEuaDoKKyAgICAgICAgKiBzcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAg KFdlYktpdDo6Q29udGV4dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJ dGVtcyk6CisKIDIwMTEtMDItMjQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb250ZXh0TWVudURhdGEuaCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNvbnRleHRNZW51RGF0YS5oCmluZGV4IDYwNjk5NGIu LjVmYWQ2MTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNv bnRleHRNZW51RGF0YS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNv bnRleHRNZW51RGF0YS5oCkBAIC0zMSw2ICszMSw3IEBACiAjaWZuZGVmIFdlYkNvbnRleHRNZW51 RGF0YV9oCiAjZGVmaW5lIFdlYkNvbnRleHRNZW51RGF0YV9oCiAKKyNpbmNsdWRlICJXZWJIaXN0 b3J5SXRlbS5oIgogI2luY2x1ZGUgIldlYk1lbnVJdGVtSW5mby5oIgogI2luY2x1ZGUgIldlYk5v ZGUuaCIKICNpbmNsdWRlICJXZWJQb2ludC5oIgpAQCAtNzgsNiArNzksOSBAQCBzdHJ1Y3QgV2Vi Q29udGV4dE1lbnVEYXRhIHsKICAgICAvLyBUaGUgZW5jb2RpbmcgZm9yIHRoZSBmcmFtZSBpbiBj b250ZXh0LgogICAgIFdlYlN0cmluZyBmcmFtZUVuY29kaW5nOwogCisgICAgLy8gSGlzdG9yeSBz dGF0ZSBvZiB0aGUgc3ViZnJhbWUgaW4gY29udGV4dC4KKyAgICBXZWJIaXN0b3J5SXRlbSBmcmFt ZUhpc3RvcnlJdGVtOworCiAgICAgZW51bSBNZWRpYUZsYWdzIHsKICAgICAgICAgTWVkaWFOb25l ID0gMHgwLAogICAgICAgICBNZWRpYUluRXJyb3IgPSAweDEsCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAppbmRleCA0OWRlMDQz Li5hNjZhMGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0 TWVudUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRl eHRNZW51Q2xpZW50SW1wbC5jcHAKQEAgLTQxLDYgKzQxLDcgQEAKICNpbmNsdWRlICJFdmVudEhh bmRsZXIuaCIKICNpbmNsdWRlICJGcmFtZUxvYWRlci5oIgogI2luY2x1ZGUgIkZyYW1lVmlldy5o IgorI2luY2x1ZGUgIkhpc3RvcnlJdGVtLmgiCiAjaW5jbHVkZSAiSGl0VGVzdFJlc3VsdC5oIgog I2luY2x1ZGUgIkhUTUxNZWRpYUVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MTmFtZXMuaCIKQEAg LTI0MCw4ICsyNDEsMTIgQEAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29udGV4dE1lbnVDbGll bnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcygKIAogICAgIC8vIFNlbmQgdGhl IGZyYW1lIGFuZCBwYWdlIFVSTHMgaW4gYW55IGNhc2UuCiAgICAgZGF0YS5wYWdlVVJMID0gdXJs RnJvbUZyYW1lKG1fd2ViVmlldy0+bWFpbkZyYW1lSW1wbCgpLT5mcmFtZSgpKTsKLSAgICBpZiAo c2VsZWN0ZWRGcmFtZSAhPSBtX3dlYlZpZXctPm1haW5GcmFtZUltcGwoKS0+ZnJhbWUoKSkKKyAg ICBpZiAoc2VsZWN0ZWRGcmFtZSAhPSBtX3dlYlZpZXctPm1haW5GcmFtZUltcGwoKS0+ZnJhbWUo KSkgewogICAgICAgICBkYXRhLmZyYW1lVVJMID0gdXJsRnJvbUZyYW1lKHNlbGVjdGVkRnJhbWUp OworICAgICAgUmVmUHRyPEhpc3RvcnlJdGVtPiBoaXN0b3J5SXRlbSA9IHNlbGVjdGVkRnJhbWUt PmxvYWRlcigpLT5oaXN0b3J5KCktPmN1cnJlbnRJdGVtKCk7CisgICAgICBpZiAoaGlzdG9yeUl0 ZW0pCisgICAgICAgIGRhdGEuZnJhbWVIaXN0b3J5SXRlbSA9IFdlYkhpc3RvcnlJdGVtKGhpc3Rv cnlJdGVtKTsKKyAgICB9CiAKICAgICBpZiAoci5pc1NlbGVjdGVkKCkpCiAgICAgICAgIGRhdGEu c2VsZWN0ZWRUZXh0ID0gc2VsZWN0ZWRGcmFtZS0+ZWRpdG9yKCktPnNlbGVjdGVkVGV4dCgpLnN0 cmlwV2hpdGVTcGFjZSgpOwo=