55229 2011-02-25 10:11:06 -0800 REGRESSION (r66062) - inputElement.innerText = "" throws 2022-08-09 14:30:23 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 beidson webkit-unassigned abarth ahmad.saleem792 ap bfulgham eric rniwa webkit-bug-importer oldest_to_newest 357999 0 beidson 2011-02-25 10:11:06 -0800 REGRESSION (r66062) - set(Inner/Outer)Text on many types of elements throws an exception, and they didn't before. Link to the change: http://trac.webkit.org/changeset/66057 Link to the original bug: https://bugs.webkit.org/show_bug.cgi?id=44626 ChangeLog says "this is just moving code and should have no functional change." But by replacing the usage of "HTMLElement::endTagRequirement()" with "HTMLElement::ieForbidsInsertHTML()" in 3 key places in HTMLElement, it had functional change. Before this change, HTMLElement::deprecatedCreateContextualFragment would only fail to return a fragment for <wbr> elements. Now it fails for ~20 tag names listed in HTMLElement::ieForbidsInsertHTML() Before this change, HTMLElement::setInnerText and HTMLElement::setOuterText only threw exceptions for 10 tag names they knew about, and <wbr>. Now they throw exceptions for the 10 tag names they knew about, and the ~20 listed in HTMLElement::ieForbidsInsertHTML() This broke compatibility with other browsers like Firefox and Opera. It also *broke* compatibility with IE while purporting to match IE's rules, as noted in the FIXME comment in ieForbidsInsertHTML() Test case coming soon... 358079 1 83852 beidson 2011-02-25 11:27:35 -0800 Created attachment 83852 Test derived from This is a test derived from a real world affected site my.schedulemaster.com Sadly the real site requires logins and no pilot would be likely to hand theirs out (I sure am not). But let's just say that a lot of pilots really like WebKit based browsers. :) 358080 2 83853 beidson 2011-02-25 11:29:06 -0800 Created attachment 83853 Better test with explanatory text 358085 3 beidson 2011-02-25 11:32:42 -0800 <rdar://problem/9055014> 358603 4 eric 2011-02-26 16:24:39 -0800 innerText isn't spec'd, but the change in question was not supposed to change behavior. Will investigate what changed. 358604 5 eric 2011-02-26 16:28:12 -0800 Firefox doesn't support innerText, so the testcase is misleading. I suspect the site in question follows a different codepath for firefox. 358605 6 eric 2011-02-26 16:29:34 -0800 Has this shipped in a Safari? I'm testing with Version 5.0.3 (6533.19.4) and I see the same exception as top of tree. 358718 7 beidson 2011-02-27 10:21:33 -0800 (In reply to comment #6) > Has this shipped in a Safari? I'm testing with Version 5.0.3 (6533.19.4) and I see the same exception as top of tree. Hmmmm. Admittedly and amusingly I'd never tried with Safari 5.0.3, I only tried with ToT and the patch partially rolled out. Maybe "partially" rolled out invented the state I was expecting to see. Will explore more when I'm around code on Monday. 1890102 8 ahmad.saleem792 2022-08-09 14:29:39 -0700 I am unable to reproduce this bug in Safari 15.6 on macOS 12.5 and it does not throw any exception in Console or no dialog box. It was similar to Firefox Nightly 105 and Chrome Canary 106. Further, Safari also pass all test cases here: https://wpt.fyi/results/html/dom/elements/the-innertext-and-outertext-properties/innertext-setter.html?label=master&label=experimental&aligned&view=subtest&q=innerText I am going to mark this as "RESOLVED CONFIGURATION CHANGED" but if you are able to reproduce then please reopen this. Thanks! 1890103 9 webkit-bug-importer 2022-08-09 14:30:23 -0700 <rdar://problem/98406179> 83852 2011-02-25 11:27:35 -0800 2011-02-25 11:29:06 -0800 Test derived from test.html text/html 580 beidson PHNjcmlwdD4KCndpbmRvdy5vbmVycm9yID0gZnVuY3Rpb24oZXJyLCB1cmwsIGxpbmVudW1iZXIp IHsKICAgYWxlcnQoIndpbmRvdy5vbmVycm9yIGNhbGxlZCB3aXRoICciICsgZXJyICsgIiciKTsK fQoKZnVuY3Rpb24gdGVzdDEoKSB7CiAgICB2YXIgbm9kZSA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJ0ZXN0bm9kZSIpOwogICAgdHJ5IHsKICAgICAgICBub2RlLmlubmVyVGV4dCA9ICIiOwog ICAgfSBjYXRjaChlKSB7CiAgICAgICBhbGVydCgiQ2F1Z2h0IGV4Y2VwdGlvbiAnIiArIGUgKyAi JyIpOwogICAgfQp9CgpmdW5jdGlvbiB0ZXN0MigpIHsKICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJ0ZXN0bm9kZSIpLmlubmVyVGV4dCA9ICIiOwp9Cgo8L3NjcmlwdD4KCjxodG1sPgo8aW5w dXQgaWQ9InRlc3Rub2RlIiB0eXBlPSJ0ZXh0Ij48L2lucHV0Pjxicj4KPGJ1dHRvbiBvbmNsaWNr PSJ0ZXN0MSgpIj5UZXN0IGV4Y2VwdGlvbiBoYW5kbGluZzwvYnV0dG9uPjxicj4KPGJ1dHRvbiBv bmNsaWNrPSJ0ZXN0MigpIj5UZXN0IHdpbmRvdy5vbmVycm9yIGZhbGxiYWNrPC9idXR0b24+PGJy Pgo8L2h0bWw+Cg== 83853 2011-02-25 11:29:06 -0800 2011-02-25 11:29:06 -0800 Better test with explanatory text test.html text/html 754 beidson PHNjcmlwdD4KCndpbmRvdy5vbmVycm9yID0gZnVuY3Rpb24oZXJyLCB1cmwsIGxpbmVudW1iZXIp IHsKICAgYWxlcnQoIndpbmRvdy5vbmVycm9yIGNhbGxlZCB3aXRoICciICsgZXJyICsgIiciKTsK fQoKZnVuY3Rpb24gdGVzdDEoKSB7CiAgICB2YXIgbm9kZSA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJ0ZXN0bm9kZSIpOwogICAgdHJ5IHsKICAgICAgICBub2RlLmlubmVyVGV4dCA9ICIiOwog ICAgfSBjYXRjaChlKSB7CiAgICAgICBhbGVydCgiQ2F1Z2h0IGV4Y2VwdGlvbiAnIiArIGUgKyAi JyIpOwogICAgfQp9CgpmdW5jdGlvbiB0ZXN0MigpIHsKICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJ0ZXN0bm9kZSIpLmlubmVyVGV4dCA9ICIiOwp9Cgo8L3NjcmlwdD4KCjxodG1sPgo8aW5w dXQgaWQ9InRlc3Rub2RlIiB0eXBlPSJ0ZXh0Ij48L2lucHV0Pjxicj4KPGJ1dHRvbiBvbmNsaWNr PSJ0ZXN0MSgpIj5UZXN0IGV4Y2VwdGlvbiBoYW5kbGluZzwvYnV0dG9uPjxicj4KPGJ1dHRvbiBv bmNsaWNrPSJ0ZXN0MigpIj5UZXN0IHdpbmRvdy5vbmVycm9yIGZhbGxiYWNrPC9idXR0b24+PGJy Pjxicj4KSW4gSUUsIEZpcmVmb3gsIG9yIFdlYktpdCBiZWZvcmUgcjY2MDYyIHlvdSB3aWxsIHNl ZSBubyBhbGVydHMgYXQgYWxsLCBiZWNhdXNlIHRoaXMgYWN0aW9uIGRvZXNuJ3QgdGhyb3cgYW4g ZXhjZXB0aW9uLjxicj4KQWZ0ZXIgcjY2MDYyLCB5b3UnbGwgc2VlIHRoZSBhbGVydHMgaW4gV2Vi S2l0Lgo8L2h0bWw+Cg==