55227 2011-02-25 09:48:31 -0800 old-run-webkit-tests falsely claims to be saving crash logs on Windows Vista/7 2011-02-25 10:50:31 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED PlatformOnly P2 Normal --- 1 aroben webkit-unassigned ddkilzer sfalken oldest_to_newest 357978 0 aroben 2011-02-25 09:48:31 -0800 old-run-webkit-tests modifies the registry to configure a post-mortem debugger to save crash logs. This doesn't work on Windows Vista/7 because you need administrator privileges to modify the registry. But old-run-webkit-tests thinks it successfully modified the registry and thus claims to be saving crash logs. Actually making crash log saving work is covered by bug 44135. But in the meantime we should make old-run-webkit-tests stop lying. 357984 1 83827 aroben 2011-02-25 09:53:11 -0800 Created attachment 83827 Double-check that modifying the registry worked 358038 2 aroben 2011-02-25 10:50:31 -0800 Committed r79698: <http://trac.webkit.org/changeset/79698> 83827 2011-02-25 09:53:11 -0800 2011-02-25 09:57:03 -0800 Double-check that modifying the registry worked bug-55227-20110225125338.patch text/plain 1931 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogNzk2NzYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ZWQzZjBkN2ZjZmIzZGQ5MDI0ZGFiMjgzODUxYTY1ZjI1 ZGIyNzMzLi5lYzQ3MWUzZDA4NDE2NzdiZTFjZjU4MjY0NTgxMDU3YzViYjhlNTdlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTEtMDItMjUgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCisgICAgICAg IERvdWJsZS1jaGVjayB0aGF0IG1vZGlmeWluZyB0aGUgcmVnaXN0cnkgd29ya2VkCisKKyAgICAg ICAgT24gV2luZG93cyBWaXN0YS83IHdpdGggVUFDIGVuYWJsZWQsIHJlZ3Rvb2wgd2lsbCBmYWls IHRvIG1vZGlmeSB0aGUgcmVnaXN0cnksIGJ1dCBpdCB3aWxsCisgICAgICAgIHN0aWxsIHJldHVy biBhIHN1Y2Nlc3NmdWwgZXhpdCBjb2RlLiBTbyB3ZSBkb3VibGUtY2hlY2sgaGVyZSB0aGF0IHRo ZSB2YWx1ZSB3ZSB0cmllZCB0bworICAgICAgICB3cml0ZSB0byB0aGUgcmVnaXN0cnkgd2FzIHJl YWxseSB3cml0dGVuLgorCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzU1MjI3 PiBvbGQtcnVuLXdlYmtpdC10ZXN0cyBmYWxzZWx5IGNsYWltcyB0byBiZSBzYXZpbmcgY3Jhc2gK KyAgICAgICAgbG9ncyBvbiBXaW5kb3dzIFZpc3RhLzcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHM6 CisgICAgICAgICh3cml0ZVJlZ2lzdHJ5U3RyaW5nKTogQWZ0ZXIgdHJ5aW5nIHRvIHdyaXRlIHRo ZSBzdHJpbmcgdmFsdWUsIGNoZWNrIHRoYXQgaXQgd2FzIHJlYWxseQorICAgICAgICB3cml0dGVu LgorCisyMDExLTAyLTI1ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KKwogICAgICAg ICBTZXQgdGhlIDMyLWJpdCBwb3N0LW1vcnRlbSBkZWJ1Z2dlciBvbiA2NC1iaXQgT1NlcwogCiAg ICAgICAgIFRoZSBwb3N0LW1vcnRlbSBkZWJ1Z2dlciBpcyBjb250cm9sbGVkIGJ5IHNvbWUgcmVn aXN0cnkgdmFsdWVzIGluCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0 LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwppbmRleCBlNzQ5Zjlh NmE0M2Q3ZDg5NmNjZDRhYWI3MTE1ODZkM2FhYzkzMjEzLi42MDIxOTM5ZjU3MGI4NjBjYzNlMzkx ZWU0YzU5ZjgzMGIwNDFlMmVkIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Vi a2l0LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKQEAgLTI2 MTIsOCArMjYxMiwxMyBAQCBzdWIgcmVhZFJlZ2lzdHJ5U3RyaW5nKCQpCiBzdWIgd3JpdGVSZWdp c3RyeVN0cmluZygkJCkKIHsKICAgICBteSAoJHZhbHVlTmFtZSwgJHN0cmluZykgPSBAXzsKKwog ICAgIG15ICRlcnJvciA9IHN5c3RlbSAicmVndG9vbCIsICItLXdvdzMyIiwgInNldCIsICItcyIs ICR2YWx1ZU5hbWUsICRzdHJpbmc7Ci0gICAgcmV0dXJuICEkZXJyb3I7CisKKyAgICAjIE9uIFdp bmRvd3MgVmlzdGEvNyB3aXRoIFVBQyBlbmFibGVkLCByZWd0b29sIHdpbGwgZmFpbCB0byBtb2Rp ZnkgdGhlIHJlZ2lzdHJ5LCBidXQgaXQgd2lsbAorICAgICMgc3RpbGwgcmV0dXJuIGEgc3VjY2Vz c2Z1bCBleGl0IGNvZGUuIFNvIHdlIGRvdWJsZS1jaGVjayBoZXJlIHRoYXQgdGhlIHZhbHVlIHdl IHRyaWVkIHRvIHdyaXRlCisgICAgIyB0byB0aGUgcmVnaXN0cnkgd2FzIHJlYWxseSB3cml0dGVu LgorICAgIHJldHVybiAhJGVycm9yICYmIHJlYWRSZWdpc3RyeVN0cmluZygkdmFsdWVOYW1lKSBl cSAkc3RyaW5nOwogfQogCiBzdWIgc2V0VXBXaW5kb3dzQ3Jhc2hMb2dTYXZpbmcoKQo=