55224 2011-02-25 09:24:54 -0800 old-run-webkit-test's Windows registry code is ugly 2011-02-25 10:49:29 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 55225 1 aroben aroben ddkilzer oldest_to_newest 357962 0 aroben 2011-02-25 09:24:54 -0800 old-run-webkit-test's Windows registry code is ugly 357963 1 83823 aroben 2011-02-25 09:26:32 -0800 Created attachment 83823 Patch 358024 2 83823 ddkilzer 2011-02-25 10:38:58 -0800 Comment on attachment 83823 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83823&action=review r=me > Tools/Scripts/old-run-webkit-tests:2607 > + my ($valueName) = @_; Maybe $key instead of $valueName? > Tools/Scripts/old-run-webkit-tests:2614 > + my ($valueName, $data) = @_; Maybe ($key, $value) instead of ($valueName, $data)? 358030 3 83823 aroben 2011-02-25 10:45:13 -0800 Comment on attachment 83823 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83823&action=review >> Tools/Scripts/old-run-webkit-tests:2607 >> + my ($valueName) = @_; > > Maybe $key instead of $valueName? Unfortunately, "key" has a different meaning in registry-speak. (The registry is a tree. Leaf nodes are called "values", and a value has a name, a type, and some data associated with it. Non-leaf nodes are called "keys", and just have a name.) >> Tools/Scripts/old-run-webkit-tests:2614 >> + my ($valueName, $data) = @_; > > Maybe ($key, $value) instead of ($valueName, $data)? I changed $data to $string, but left $valueName alone. 358036 4 aroben 2011-02-25 10:49:29 -0800 Committed r79696: <http://trac.webkit.org/changeset/79696> 83823 2011-02-25 09:26:32 -0800 2011-02-25 10:45:13 -0800 Patch bug-55224-20110225122642.patch text/plain 3150 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogNzk2NzYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxOWUzOThlZDBiOGJiZThjYjZhMWRmMmZlMTYwNGUwZDBl MjYxNjI4Li5mMTA3YWY3ZWYwYTEzY2YyZmU2N2Q3NWNkNTQxMTc4NmVmOWVkMTVkIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTEtMDItMjUgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCisgICAgICAg IENsZWFuIHVwIGNvZGUgdG8gc2V0IHVwIGNyYXNoIGxvZyBzYXZpbmcgb24gV2luZG93cworCisg ICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzU1MjI0PiBvbGQtcnVuLXdlYmtpdC10 ZXN0J3MgV2luZG93cyByZWdpc3RyeSBjb2RlIGlzIHVnbHkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVz dHM6CisgICAgICAgIChyZWFkUmVnaXN0cnlTdHJpbmcpOgorICAgICAgICAod3JpdGVSZWdpc3Ry eVN0cmluZyk6CisgICAgICAgIE1vdmVkIGNvZGUgdG8gcmVhZCBzdHJpbmdzIGZyb20gYW5kIHdy aXRlIHN0cmluZ3MgdG8gdGhlIHJlZ2lzdHJ5IGhlcmUuLi4KKworICAgICAgICAoc2V0VXBXaW5k b3dzQ3Jhc2hMb2dTYXZpbmcpOiAuLi5mcm9tIGhlcmUuCisKKzIwMTEtMDItMjUgIEFkYW0gUm9i ZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCiAgICAgICAgIFdvcmsgYXJvdW5kIEN5Z3dpbidzIGNy YXNoLXN1cHByZXNzaW9uIGJlaGF2aW9yCiAKICAgICAgICAgQ3lnd2luIGNhbGxzIDo6U2V0RXJy b3JNb2RlKFNFTV9GQUlMQ1JJVElDQUxFUlJPUlMpLCB3aGljaCBhbnkgcHJvY2Vzc2VzIGl0IGxh dW5jaGVzIHdpbGwKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVz dHMgYi9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCmluZGV4IDNlNTc3MDZkMzE0 MDk2MDg0YWQ3ODI4OWMwMWUzMTI2MjgxNTBkY2EuLmQ0OWI0NjY4NzExMDNhOTM5MDZhMjBjNzkw YTA5ODYyODY2NWZiNWMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQt dGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwpAQCAtMjYwMiw2 ICsyNjAyLDIwIEBAIHN1YiBjcmVhdGVEZWJ1Z2dlckNvbW1hbmRGaWxlKCkKICAgICByZXR1cm4g JGNvbW1hbmRGaWxlOwogfQogCitzdWIgcmVhZFJlZ2lzdHJ5U3RyaW5nKCQpCit7CisgICAgbXkg KCR2YWx1ZU5hbWUpID0gQF87CisgICAgY2hvbXAobXkgJHN0cmluZyA9IGByZWd0b29sIGdldCAi JHZhbHVlTmFtZSJgKTsKKyAgICByZXR1cm4gJHN0cmluZzsKK30KKworc3ViIHdyaXRlUmVnaXN0 cnlTdHJpbmcoJCQpCit7CisgICAgbXkgKCR2YWx1ZU5hbWUsICRkYXRhKSA9IEBfOworICAgIG15 ICRlcnJvciA9IHN5c3RlbSAicmVndG9vbCIsICJzZXQiLCAiLXMiLCAkdmFsdWVOYW1lLCAkZGF0 YTsKKyAgICByZXR1cm4gISRlcnJvcjsKK30KKwogc3ViIHNldFVwV2luZG93c0NyYXNoTG9nU2F2 aW5nKCkKIHsKICAgICByZXR1cm4gdW5sZXNzIGlzQ3lnd2luKCk7CkBAIC0yNjQxLDkgKzI2NTUs OCBAQCBzdWIgc2V0VXBXaW5kb3dzQ3Jhc2hMb2dTYXZpbmcoKQogICAgICk7CiAKICAgICBmb3Jl YWNoIG15ICR2YWx1ZSAoa2V5cyAldmFsdWVzKSB7Ci0gICAgICAgIGNob21wKCRwcmV2aW91c1dp bmRvd3NQb3N0TW9ydGVtRGVidWdnZXJWYWx1ZXN7JHZhbHVlfSA9IGByZWd0b29sIGdldCAiJHdp bmRvd3NQb3N0TW9ydGVtRGVidWdnZXJLZXkvJHZhbHVlImApOwotICAgICAgICBteSAkcmVzdWx0 ID0gc3lzdGVtICJyZWd0b29sIiwgInNldCIsICItcyIsICIkd2luZG93c1Bvc3RNb3J0ZW1EZWJ1 Z2dlcktleS8kdmFsdWUiLCAkdmFsdWVzeyR2YWx1ZX07Ci0gICAgICAgIG5leHQgdW5sZXNzICRy ZXN1bHQ7CisgICAgICAgICRwcmV2aW91c1dpbmRvd3NQb3N0TW9ydGVtRGVidWdnZXJWYWx1ZXN7 JHZhbHVlfSA9IHJlYWRSZWdpc3RyeVN0cmluZygiJHdpbmRvd3NQb3N0TW9ydGVtRGVidWdnZXJL ZXkvJHZhbHVlIik7CisgICAgICAgIG5leHQgaWYgd3JpdGVSZWdpc3RyeVN0cmluZygiJHdpbmRv d3NQb3N0TW9ydGVtRGVidWdnZXJLZXkvJHZhbHVlIiwgJHZhbHVlc3skdmFsdWV9KTsKIAogICAg ICAgICBwcmludCAiRmFpbGVkIHRvIHNldCBcIiR3aW5kb3dzUG9zdE1vcnRlbURlYnVnZ2VyS2V5 LyR2YWx1ZVwiLiBDcmFzaCBsb2dzIHdpbGwgbm90IGJlIHNhdmVkLlxuU2VlIDxodHRwOi8vdHJh Yy53ZWJraXQub3JnL3dpa2kvQnVpbGRpbmdPbldpbmRvd3MjR2V0dGluZ0NyYXNoTG9ncz4uXG4i OwogICAgICAgICByZXR1cm47CkBAIC0yNjU2LDcgKzI2NjksNyBAQCBFTkQgewogICAgIHJldHVy biB1bmxlc3MgaXNDeWd3aW4oKTsKIAogICAgIGZvcmVhY2ggbXkgJHZhbHVlIChrZXlzICVwcmV2 aW91c1dpbmRvd3NQb3N0TW9ydGVtRGVidWdnZXJWYWx1ZXMpIHsKLSAgICAgICAgbXkgJHJlc3Vs dCA9IHN5c3RlbSAicmVndG9vbCIsICJzZXQiLCAiLXMiLCAiJHdpbmRvd3NQb3N0TW9ydGVtRGVi dWdnZXJLZXkvJHZhbHVlIiwgJHByZXZpb3VzV2luZG93c1Bvc3RNb3J0ZW1EZWJ1Z2dlclZhbHVl c3skdmFsdWV9OwotICAgICAgICAhJHJlc3VsdCBvciBwcmludCAiRmFpbGVkIHRvIHJlc3RvcmUg XCIkd2luZG93c1Bvc3RNb3J0ZW1EZWJ1Z2dlcktleS8kdmFsdWVcIiB0byBpdHMgcHJldmlvdXMg dmFsdWUgXCIkcHJldmlvdXNXaW5kb3dzUG9zdE1vcnRlbURlYnVnZ2VyVmFsdWVzeyR2YWx1ZX1c IlxuLiI7CisgICAgICAgIG5leHQgaWYgd3JpdGVSZWdpc3RyeVN0cmluZygiJHdpbmRvd3NQb3N0 TW9ydGVtRGVidWdnZXJLZXkvJHZhbHVlIiwgJHByZXZpb3VzV2luZG93c1Bvc3RNb3J0ZW1EZWJ1 Z2dlclZhbHVlc3skdmFsdWV9KTsKKyAgICAgICAgcHJpbnQgIkZhaWxlZCB0byByZXN0b3JlIFwi JHdpbmRvd3NQb3N0TW9ydGVtRGVidWdnZXJLZXkvJHZhbHVlXCIgdG8gaXRzIHByZXZpb3VzIHZh bHVlIFwiJHByZXZpb3VzV2luZG93c1Bvc3RNb3J0ZW1EZWJ1Z2dlclZhbHVlc3skdmFsdWV9XCJc bi4iOwogICAgIH0KIH0K