55221 2011-02-25 08:31:10 -0800 Build fix for Intel ICC Compiler 2011-02-28 12:25:25 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 menard webkit-unassigned ap commit-queue eric menard zimmermann oldest_to_newest 357934 0 menard 2011-02-25 08:31:10 -0800 With Intel ICC compiler for Linux 64 bits, there is some issue to link against a version of WebKit build with ICC : undefined reference to the destructor of SVGTransformable(). I think ICC is confused with the virtual inheritance and virtual methods in the class. 357935 1 83817 menard 2011-02-25 08:31:40 -0800 Created attachment 83817 Proposed patch to fix the build. 358000 2 83817 darin 2011-02-25 10:11:49 -0800 Comment on attachment 83817 Proposed patch to fix the build. Might have been slightly better to add a brief comment as well. Otherwise I see no reason someone wouldn’t just remove this later. 358010 3 83832 menard 2011-02-25 10:27:44 -0800 Created attachment 83832 V2 with a comment. 358381 4 ap 2011-02-25 21:39:50 -0800 This is surprising. I thought that Intel ICC was supposed to be an extremely compliant compiler, so perhaps there is a real reason why an implementation is needed? I can't think of any though. I suggest adding the implementation in a .cpp file if that works with ICC, because an inline virtual destructor in a base class causes significant code bloat. Please mark a patch for review, so that it doesn't get overlooked. 358988 5 84041 menard 2011-02-28 05:11:20 -0800 Created attachment 84041 New patch with Alexey's comments @Alexey : Me too, actually ICC is a very good compiler. Though his main problem is that it's not widely used therefore there is still bugs. For instance there is a huge gap from version 11 to version 12 in term of bugfixing (in a good way). I think if I have a bit of time I will try to reproduce in a small C++ example and fill a bug to Intel. Thanks for the review. 359090 6 84041 ap 2011-02-28 08:53:00 -0800 Comment on attachment 84041 New patch with Alexey's comments +{ + +} We don't put a blank line in empty function bodies. + // This destructor is needed in order to link correctly with Intel ICC. The comment is only needed to prevent accidental removal of the destructor - it would be sufficient (and better) to only have it in .cpp file. People looking for something else in the header don't need to know about this. 359096 7 84070 menard 2011-02-28 09:03:36 -0800 Created attachment 84070 New patch V2 with Alexey's comments 359098 8 84070 ap 2011-02-28 09:04:55 -0800 Comment on attachment 84070 New patch V2 with Alexey's comments Thank you! 359143 9 84070 commit-queue 2011-02-28 10:21:28 -0800 Comment on attachment 84070 New patch V2 with Alexey's comments Rejecting attachment 84070 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'bu..." exit_code: 2 Last 500 characters of output: ccessibility/AccessibilityMenuList.cpp -o /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AccessibilityMenuList.o ** BUILD FAILED ** The following build commands failed: WebCore: CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AccessibilityMenuListOption.o /Projects/CommitQueue/Source/WebCore/accessibility/AccessibilityMenuListOption.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (1 failure) Full output: http://queues.webkit.org/results/8074328 359152 10 84070 ap 2011-02-28 10:28:41 -0800 Comment on attachment 84070 New patch V2 with Alexey's comments Trying again... 359161 11 eric 2011-02-28 10:37:19 -0800 Odd. The commit-queue hasn't historically had flaky builds in the past. I suspect this will fail again, but it's worth the try! 359235 12 commit-queue 2011-02-28 12:23:19 -0800 The commit-queue encountered the following flaky tests while processing attachment 84070: http/tests/websocket/tests/workers/close-in-shared-worker.html bug 55397 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 359237 13 84070 commit-queue 2011-02-28 12:25:19 -0800 Comment on attachment 84070 New patch V2 with Alexey's comments Clearing flags on attachment: 84070 Committed r79896: <http://trac.webkit.org/changeset/79896> 359238 14 commit-queue 2011-02-28 12:25:25 -0800 All reviewed patches have been landed. Closing bug. 83817 2011-02-25 08:31:40 -0800 2011-02-25 10:27:44 -0800 Proposed patch to fix the build. iyVTeKuW.txt text/plain 1271 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZmRiZGNlLi5iMzhjOTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDItMjUgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVp bGQgZml4IHdpdGggaW50ZWwgSUNDIGNvbXBpbGVyLiBUaGUgdmlydHVhbCBpbmhlcml0YW5jZSBz ZWVtcyB0byBjb25mdXNlIElDQy4KKyAgICAgICAgQW55dGhpbmcgdGhhdCBsaW5rcyB3aXRoIHdl YmtpdCBoYXMgYW4gdW5kZWZpbmVkIHJlZmVyZW5jZSBvdGhlcndpc2UuCisKKyAgICAgICAgKiBz dmcvU1ZHVHJhbnNmb3JtYWJsZS5oOgorICAgICAgICAoV2ViQ29yZTo6U1ZHVHJhbnNmb3JtYWJs ZTo6flNWR1RyYW5zZm9ybWFibGUpOgorCiAyMDExLTAyLTI0ICBBbGV4YW5kZXIgUGF2bG92ICA8 YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1h bi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1hYmxlLmggYi9T b3VyY2UvV2ViQ29yZS9zdmcvU1ZHVHJhbnNmb3JtYWJsZS5oCmluZGV4IDFjZDI4ODEuLmMyYzYy MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1hYmxlLmgKKysr IGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybWFibGUuaApAQCAtNDAsNiArNDAsOCBA QCBwdWJsaWM6CiAgICAgICAgIERvTm90Q2xlYXJMaXN0CiAgICAgfTsKIAorICAgIHZpcnR1YWwg flNWR1RyYW5zZm9ybWFibGUoKSB7IH0KKwogICAgIHN0YXRpYyBib29sIHBhcnNlVHJhbnNmb3Jt QXR0cmlidXRlKFNWR1RyYW5zZm9ybUxpc3QmLCBjb25zdCBBdG9taWNTdHJpbmcmIHRyYW5zZm9y bSk7CiAgICAgc3RhdGljIGJvb2wgcGFyc2VUcmFuc2Zvcm1BdHRyaWJ1dGUoU1ZHVHJhbnNmb3Jt TGlzdCYsIGNvbnN0IFVDaGFyKiYgcHRyLCBjb25zdCBVQ2hhciogZW5kLCBUcmFuc2Zvcm1QYXJz aW5nTW9kZSBtb2RlID0gQ2xlYXJMaXN0KTsKICAgICBzdGF0aWMgYm9vbCBwYXJzZVRyYW5zZm9y bVZhbHVlKHVuc2lnbmVkIHR5cGUsIGNvbnN0IFVDaGFyKiYgcHRyLCBjb25zdCBVQ2hhciogZW5k LCBTVkdUcmFuc2Zvcm0mKTs= 83832 2011-02-25 10:27:44 -0800 2011-02-28 05:11:20 -0800 V2 with a comment. plop.diff text/plain 1343 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzOWIxOTE0Li4xOTY4MTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDItMjUgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVp bGQgZml4IHdpdGggaW50ZWwgSUNDIGNvbXBpbGVyLiBUaGUgdmlydHVhbCBpbmhlcml0YW5jZSBz ZWVtcyB0byBjb25mdXNlIElDQy4KKyAgICAgICAgQW55dGhpbmcgdGhhdCBsaW5rcyB3aXRoIHdl YmtpdCBoYXMgYW4gdW5kZWZpbmVkIHJlZmVyZW5jZSBvdGhlcndpc2UuCisKKyAgICAgICAgKiBz dmcvU1ZHVHJhbnNmb3JtYWJsZS5oOgorICAgICAgICAoV2ViQ29yZTo6U1ZHVHJhbnNmb3JtYWJs ZTo6flNWR1RyYW5zZm9ybWFibGUpOgorCiAyMDExLTAyLTI1ICBBYmhpc2hlayBBcnlhICA8aW5m ZXJub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1hYmxlLmggYi9Tb3VyY2Uv V2ViQ29yZS9zdmcvU1ZHVHJhbnNmb3JtYWJsZS5oCmluZGV4IDFjZDI4ODEuLjFjYTY4NDQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1hYmxlLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybWFibGUuaApAQCAtNDAsNiArNDAsOSBAQCBwdWJs aWM6CiAgICAgICAgIERvTm90Q2xlYXJMaXN0CiAgICAgfTsKIAorICAgIC8vIFRoaXMgZGVzdHJ1 Y3RvciBpcyBuZWVkZWQgaW4gb3JkZXIgdG8gbGluayBjb3JyZWN0bHkgd2l0aCBJbnRlbCBJQ0Mu CisgICAgdmlydHVhbCB+U1ZHVHJhbnNmb3JtYWJsZSgpIHsgfQorCiAgICAgc3RhdGljIGJvb2wg cGFyc2VUcmFuc2Zvcm1BdHRyaWJ1dGUoU1ZHVHJhbnNmb3JtTGlzdCYsIGNvbnN0IEF0b21pY1N0 cmluZyYgdHJhbnNmb3JtKTsKICAgICBzdGF0aWMgYm9vbCBwYXJzZVRyYW5zZm9ybUF0dHJpYnV0 ZShTVkdUcmFuc2Zvcm1MaXN0JiwgY29uc3QgVUNoYXIqJiBwdHIsIGNvbnN0IFVDaGFyKiBlbmQs IFRyYW5zZm9ybVBhcnNpbmdNb2RlIG1vZGUgPSBDbGVhckxpc3QpOwogICAgIHN0YXRpYyBib29s IHBhcnNlVHJhbnNmb3JtVmFsdWUodW5zaWduZWQgdHlwZSwgY29uc3QgVUNoYXIqJiBwdHIsIGNv bnN0IFVDaGFyKiBlbmQsIFNWR1RyYW5zZm9ybSYpOwo= 84041 2011-02-28 05:11:20 -0800 2011-02-28 09:03:36 -0800 New patch with Alexey's comments plop.diff text/plain 2095 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzOWIxOTE0Li4xOTY4MTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDItMjUgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVp bGQgZml4IHdpdGggaW50ZWwgSUNDIGNvbXBpbGVyLiBUaGUgdmlydHVhbCBpbmhlcml0YW5jZSBz ZWVtcyB0byBjb25mdXNlIElDQy4KKyAgICAgICAgQW55dGhpbmcgdGhhdCBsaW5rcyB3aXRoIHdl YmtpdCBoYXMgYW4gdW5kZWZpbmVkIHJlZmVyZW5jZSBvdGhlcndpc2UuCisKKyAgICAgICAgKiBz dmcvU1ZHVHJhbnNmb3JtYWJsZS5oOgorICAgICAgICAoV2ViQ29yZTo6U1ZHVHJhbnNmb3JtYWJs ZTo6flNWR1RyYW5zZm9ybWFibGUpOgorCiAyMDExLTAyLTI1ICBBYmhpc2hlayBBcnlhICA8aW5m ZXJub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1hYmxlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1hYmxlLmNwcAppbmRleCBlNjM3ZTdjLi5lNjQ3MmJl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVHJhbnNmb3JtYWJsZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybWFibGUuY3BwCkBAIC04OSw2ICs4OSwx MiBAQCBzdGF0aWMgaW50IHBhcnNlVHJhbnNmb3JtUGFyYW1MaXN0KGNvbnN0IFVDaGFyKiYgcHRy LCBjb25zdCBVQ2hhciogZW5kLCBmbG9hdCogdgogc3RhdGljIGNvbnN0IGludCByZXF1aXJlZFZh bHVlc0ZvclR5cGVbXSA9ICB7MCwgNiwgMSwgMSwgMSwgMSwgMX07CiBzdGF0aWMgY29uc3QgaW50 IG9wdGlvbmFsVmFsdWVzRm9yVHlwZVtdID0gIHswLCAwLCAxLCAxLCAyLCAwLCAwfTsKIAorLy8g VGhpcyBkZXN0cnVjdG9yIGlzIG5lZWRlZCBpbiBvcmRlciB0byBsaW5rIGNvcnJlY3RseSB3aXRo IEludGVsIElDQy4KK1NWR1RyYW5zZm9ybWFibGU6On5TVkdUcmFuc2Zvcm1hYmxlKCkKK3sKKwor fQorCiBib29sIFNWR1RyYW5zZm9ybWFibGU6OnBhcnNlVHJhbnNmb3JtVmFsdWUodW5zaWduZWQg dHlwZSwgY29uc3QgVUNoYXIqJiBwdHIsIGNvbnN0IFVDaGFyKiBlbmQsIFNWR1RyYW5zZm9ybSYg dHJhbnNmb3JtKQogewogICAgIGlmICh0eXBlID09IFNWR1RyYW5zZm9ybTo6U1ZHX1RSQU5TRk9S TV9VTktOT1dOKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybWFi bGUuaCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1hYmxlLmgKaW5kZXggMWNkMjg4 MS4uOTRkYmVhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybWFi bGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVHJhbnNmb3JtYWJsZS5oCkBAIC00MCw2 ICs0MCw5IEBAIHB1YmxpYzoKICAgICAgICAgRG9Ob3RDbGVhckxpc3QKICAgICB9OwogCisgICAg Ly8gVGhpcyBkZXN0cnVjdG9yIGlzIG5lZWRlZCBpbiBvcmRlciB0byBsaW5rIGNvcnJlY3RseSB3 aXRoIEludGVsIElDQy4KKyAgICB2aXJ0dWFsIH5TVkdUcmFuc2Zvcm1hYmxlKCk7CisKICAgICBz dGF0aWMgYm9vbCBwYXJzZVRyYW5zZm9ybUF0dHJpYnV0ZShTVkdUcmFuc2Zvcm1MaXN0JiwgY29u c3QgQXRvbWljU3RyaW5nJiB0cmFuc2Zvcm0pOwogICAgIHN0YXRpYyBib29sIHBhcnNlVHJhbnNm b3JtQXR0cmlidXRlKFNWR1RyYW5zZm9ybUxpc3QmLCBjb25zdCBVQ2hhciomIHB0ciwgY29uc3Qg VUNoYXIqIGVuZCwgVHJhbnNmb3JtUGFyc2luZ01vZGUgbW9kZSA9IENsZWFyTGlzdCk7CiAgICAg c3RhdGljIGJvb2wgcGFyc2VUcmFuc2Zvcm1WYWx1ZSh1bnNpZ25lZCB0eXBlLCBjb25zdCBVQ2hh ciomIHB0ciwgY29uc3QgVUNoYXIqIGVuZCwgU1ZHVHJhbnNmb3JtJik7Cg== 84070 2011-02-28 09:03:36 -0800 2011-02-28 12:25:19 -0800 New patch V2 with Alexey's comments plop.diff text/plain 2117 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkNzZjNjljLi5hNGNjOTI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDItMjggIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVp bGQgZml4IGZvciBJbnRlbCBJQ0MgQ29tcGlsZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTIyMQorCisgICAgICAgIFRoZSB2aXJ0dWFsIGluaGVy aXRhbmNlIHNlZW1zIHRvIGNvbmZ1c2UgSUNDLgorICAgICAgICBBbnl0aGluZyB0aGF0IGxpbmtz IHdpdGggd2Via2l0IGhhcyBhbiB1bmRlZmluZWQgcmVmZXJlbmNlIG90aGVyd2lzZS4KKworICAg ICAgICAqIHN2Zy9TVkdUcmFuc2Zvcm1hYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1Ry YW5zZm9ybWFibGU6On5TVkdUcmFuc2Zvcm1hYmxlKToKKyAgICAgICAgKiBzdmcvU1ZHVHJhbnNm b3JtYWJsZS5oOgorCiAyMDExLTAyLTI4ICBSZW5hdGEgSG9kb3ZhbiAgPHJlbmlAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybWFibGUuY3BwIGIvU291cmNlL1dlYkNvcmUvc3Zn L1NWR1RyYW5zZm9ybWFibGUuY3BwCmluZGV4IGU2MzdlN2MuLmEzMTA3ZDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1hYmxlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9zdmcvU1ZHVHJhbnNmb3JtYWJsZS5jcHAKQEAgLTg5LDYgKzg5LDExIEBAIHN0YXRpYyBp bnQgcGFyc2VUcmFuc2Zvcm1QYXJhbUxpc3QoY29uc3QgVUNoYXIqJiBwdHIsIGNvbnN0IFVDaGFy KiBlbmQsIGZsb2F0KiB2CiBzdGF0aWMgY29uc3QgaW50IHJlcXVpcmVkVmFsdWVzRm9yVHlwZVtd ID0gIHswLCA2LCAxLCAxLCAxLCAxLCAxfTsKIHN0YXRpYyBjb25zdCBpbnQgb3B0aW9uYWxWYWx1 ZXNGb3JUeXBlW10gPSAgezAsIDAsIDEsIDEsIDIsIDAsIDB9OwogCisvLyBUaGlzIGRlc3RydWN0 b3IgaXMgbmVlZGVkIGluIG9yZGVyIHRvIGxpbmsgY29ycmVjdGx5IHdpdGggSW50ZWwgSUNDLgor U1ZHVHJhbnNmb3JtYWJsZTo6flNWR1RyYW5zZm9ybWFibGUoKQoreworfQorCiBib29sIFNWR1Ry YW5zZm9ybWFibGU6OnBhcnNlVHJhbnNmb3JtVmFsdWUodW5zaWduZWQgdHlwZSwgY29uc3QgVUNo YXIqJiBwdHIsIGNvbnN0IFVDaGFyKiBlbmQsIFNWR1RyYW5zZm9ybSYgdHJhbnNmb3JtKQogewog ICAgIGlmICh0eXBlID09IFNWR1RyYW5zZm9ybTo6U1ZHX1RSQU5TRk9STV9VTktOT1dOKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybWFibGUuaCBiL1NvdXJjZS9X ZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm1hYmxlLmgKaW5kZXggMWNkMjg4MS4uYzcxMzM2NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybWFibGUuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9zdmcvU1ZHVHJhbnNmb3JtYWJsZS5oCkBAIC00MCw2ICs0MCw4IEBAIHB1Ymxp YzoKICAgICAgICAgRG9Ob3RDbGVhckxpc3QKICAgICB9OwogCisgICAgdmlydHVhbCB+U1ZHVHJh bnNmb3JtYWJsZSgpOworCiAgICAgc3RhdGljIGJvb2wgcGFyc2VUcmFuc2Zvcm1BdHRyaWJ1dGUo U1ZHVHJhbnNmb3JtTGlzdCYsIGNvbnN0IEF0b21pY1N0cmluZyYgdHJhbnNmb3JtKTsKICAgICBz dGF0aWMgYm9vbCBwYXJzZVRyYW5zZm9ybUF0dHJpYnV0ZShTVkdUcmFuc2Zvcm1MaXN0JiwgY29u c3QgVUNoYXIqJiBwdHIsIGNvbnN0IFVDaGFyKiBlbmQsIFRyYW5zZm9ybVBhcnNpbmdNb2RlIG1v ZGUgPSBDbGVhckxpc3QpOwogICAgIHN0YXRpYyBib29sIHBhcnNlVHJhbnNmb3JtVmFsdWUodW5z aWduZWQgdHlwZSwgY29uc3QgVUNoYXIqJiBwdHIsIGNvbnN0IFVDaGFyKiBlbmQsIFNWR1RyYW5z Zm9ybSYpOwo=