55204 2011-02-24 22:04:01 -0800 malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement 2011-02-27 09:01:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 48719 1 eric eric abarth aestes commit-queue eric mjs webkit.review.bot oldest_to_newest 357690 0 eric 2011-02-24 22:04:01 -0800 malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement 357693 1 83771 eric 2011-02-24 22:06:27 -0800 Created attachment 83771 Patch 357694 2 eric 2011-02-24 22:07:38 -0800 Here are my benchmark numbers: Before: avg 396.96666666666664 median 399 stdev 6.554811633872905 min 375 max 402 After: avg 386.26666666666665 median 388 stdev 6.303085664092541 min 368 max 395 I'm not sure that I trust them though. They're quite noisy. That's 30 runs of (locally modified) peacekeeper domDynamicCreationCreateElement. 357715 3 83774 eric 2011-02-24 22:59:10 -0800 Created attachment 83774 Patch 357729 4 83774 mjs 2011-02-24 23:34:14 -0800 Comment on attachment 83774 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83774&action=review r=me > Source/WebCore/dom/ContainerNode.cpp:359 > + // FIXME: We should tune the inlineCapacity. Having this function call malloc > + // as a result of needing to expand capacity is expensive an shows up on benchmarks. This FIXME is probably not super helpful. Just do your best to tune it now. Someone else can always tune more later. > Source/WebCore/dom/ContainerNode.cpp:521 > + // FIXME: We should tune the inlineCapacity. Having this function call malloc > + // as a result of needing to expand capacity is expensive an shows up on benchmarks. Ditto. > Source/WebCore/dom/ContainerNode.cpp:524 > + // childNodeCount() results in a full walk of the nodes, but should be faster > + // than having to malloc twice if we have lots of kids. Dup of a previous comment - maybe this version can be shorter? 357730 5 83774 eric 2011-02-24 23:35:09 -0800 Comment on attachment 83774 Patch Will fix. 357741 6 83777 eric 2011-02-25 00:10:27 -0800 Created attachment 83777 Patch for landing 358476 7 83777 commit-queue 2011-02-26 05:59:52 -0800 Comment on attachment 83777 Patch for landing Clearing flags on attachment: 83777 Committed r79781: <http://trac.webkit.org/changeset/79781> 358477 8 commit-queue 2011-02-26 05:59:57 -0800 All reviewed patches have been landed. Closing bug. 358685 9 webkit.review.bot 2011-02-27 09:01:27 -0800 http://trac.webkit.org/changeset/79781 might have broken GTK Linux 64-bit Debug 83771 2011-02-24 22:06:27 -0800 2011-02-24 22:59:07 -0800 Patch bug-55204-20110224220625.patch text/plain 2253 eric U3VidmVyc2lvbiBSZXZpc2lvbjogNzk2NTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYjlmYTdmMjU4NmU5MzI2 OGE5NjQyOGI2MmRhNmZjMDA3YWYwOTRkLi4wNmExMmZiYjkzYjljNDcxYTNlMzAxMjgyMjY5M2Zj MDg4NjM1Y2Y1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTggQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBtYWxsb2MgaW4gcmVtb3ZlQ2hpbGRyZW4g c2hvd3MgdXAgb24gcHJvZmlsZSBvZiBwZWFjZWtlZXBlciBkb21EeW5hbWljQ3JlYXRpb25DcmVh dGVFbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NTIwNAorCisgICAgICAgICogZG9tL0NvbnRhaW5lck5vZGUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q29udGFpbmVyTm9kZTo6cmVtb3ZlQ2hpbGRyZW4pOgorICAgICAgICAgLSBVc2luZyBh biBpbmxpbmVDYXBhY2l0eSBvZiAxMCBmb3Igbm93LiBXZSBtYXkgd2FudCB0byB0d2VhayBpdCBs YXRlci4KKyAgICAgICAgIC0gVGhpcyByZW1vdmVzIHlldCBhbm90aGVyIG1hbGxvYyBmcm9tIGNv ZGUgd2hpY2ggcmVtb3ZlcyBub2RlcyAod2hpY2ggaXMgcmF0aGVyIGNvbW1vbikuCisKKzIwMTEt MDItMjQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIGRpc2FibGVSYW5nZU11dGF0aW9uIHF1aXJr IGZvciBtYWlsIHNsb3dzIGRvd24gcGVhY2VrZWVwZXIgZG9tRHluYW1pY0NyZWF0aW9uQ3JlYXRl RWxlbWVudAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTUxMjcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCmluZGV4IGJjODgxYzY2M2Fi NDQ3NzJhOWU5ZmVjZmFlNjZjMjU2MDA2ZTJkNTYuLmY3ZDdlNDIzNDIxNTY4NWE3Mzk0M2MyNDgz YWY2ZTI3MjY2MWViZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJO b2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKQEAgLTUx MiwxMCArNTEyLDE1IEBAIHZvaWQgQ29udGFpbmVyTm9kZTo6cmVtb3ZlQ2hpbGRyZW4oKQogICAg IGRvY3VtZW50KCktPnJlbW92ZUZvY3VzZWROb2RlT2ZTdWJ0cmVlKHRoaXMsIHRydWUpOwogCiAg ICAgZm9yYmlkRXZlbnREaXNwYXRjaCgpOwotICAgIFZlY3RvcjxSZWZQdHI8Tm9kZT4gPiByZW1v dmVkQ2hpbGRyZW47CisgICAgLy8gRklYTUU6IFdlIHNob3VsZCB0dW5lIHRoZSBpbmxpbmVDYXBh Y2l0eS4gIEhhdmluZyB0aGlzIGZ1bmN0aW9uIGNhbGwgbWFsbG9jCisgICAgLy8gYXMgYSByZXN1 bHQgb2YgbmVlZGluZyB0byBleHBhbmQgY2FwYWNpdHkgaXMgZXhwZW5zaXZlIGFuIHNob3dzIHVw IG9uIGJlbmNobWFya3MuCisgICAgVmVjdG9yPFJlZlB0cjxOb2RlPiwgMTA+IHJlbW92ZWRDaGls ZHJlbjsKKyAgICAvLyBjaGlsZE5vZGVDb3VudCgpIHJlc3VsdHMgaW4gYSBmdWxsIHdhbGsgb2Yg dGhlIG5vZGVzLCBidXQgc2hvdWxkIGJlIGZhc3RlcgorICAgIC8vIHRoYW4gaGF2aW5nIHRvIG1h bGxvYyB0d2ljZSBpZiB3ZSBoYXZlIGxvdHMgb2Yga2lkcy4KKyAgICByZW1vdmVkQ2hpbGRyZW4u cmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShjaGlsZE5vZGVDb3VudCgpKTsKICAgICB3aGlsZSAoUmVm UHRyPE5vZGU+IG4gPSBtX2ZpcnN0Q2hpbGQpIHsKICAgICAgICAgTm9kZSogbmV4dCA9IG4tPm5l eHRTaWJsaW5nKCk7Ci0gICAgICAgIAorCiAgICAgICAgIC8vIFJlbW92ZSB0aGUgbm9kZSBmcm9t IHRoZSB0cmVlIGJlZm9yZSBjYWxsaW5nIGRldGFjaCBvciByZW1vdmVkRnJvbURvY3VtZW50ICg0 NDI3MDI0LCA0MTI5NzQ0KS4KICAgICAgICAgLy8gcmVtb3ZlQ2hpbGQoKSBkb2VzIHRoaXMgYWZ0 ZXIgY2FsbGluZyBkZXRhY2goKS4gVGhlcmUgaXMgbm8gZXhwbGFuYXRpb24gZm9yCiAgICAgICAg IC8vIHRoaXMgZGlzY3JlcGFuY3kgYmV0d2VlbiByZW1vdmVDaGlsZCgpIGFuZCBpdHMgb3B0aW1p emVkIHZlcnNpb24gcmVtb3ZlQ2hpbGRyZW4oKS4K 83774 2011-02-24 22:59:10 -0800 2011-02-25 00:10:23 -0800 Patch bug-55204-20110224225909.patch text/plain 3729 eric U3VidmVyc2lvbiBSZXZpc2lvbjogNzk2NTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYjlmYTdmMjU4NmU5MzI2 OGE5NjQyOGI2MmRhNmZjMDA3YWYwOTRkLi4wNmExMmZiYjkzYjljNDcxYTNlMzAxMjgyMjY5M2Zj MDg4NjM1Y2Y1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTggQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBtYWxsb2MgaW4gcmVtb3ZlQ2hpbGRyZW4g c2hvd3MgdXAgb24gcHJvZmlsZSBvZiBwZWFjZWtlZXBlciBkb21EeW5hbWljQ3JlYXRpb25DcmVh dGVFbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NTIwNAorCisgICAgICAgICogZG9tL0NvbnRhaW5lck5vZGUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q29udGFpbmVyTm9kZTo6cmVtb3ZlQ2hpbGRyZW4pOgorICAgICAgICAgLSBVc2luZyBh biBpbmxpbmVDYXBhY2l0eSBvZiAxMCBmb3Igbm93LiBXZSBtYXkgd2FudCB0byB0d2VhayBpdCBs YXRlci4KKyAgICAgICAgIC0gVGhpcyByZW1vdmVzIHlldCBhbm90aGVyIG1hbGxvYyBmcm9tIGNv ZGUgd2hpY2ggcmVtb3ZlcyBub2RlcyAod2hpY2ggaXMgcmF0aGVyIGNvbW1vbikuCisKKzIwMTEt MDItMjQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIGRpc2FibGVSYW5nZU11dGF0aW9uIHF1aXJr IGZvciBtYWlsIHNsb3dzIGRvd24gcGVhY2VrZWVwZXIgZG9tRHluYW1pY0NyZWF0aW9uQ3JlYXRl RWxlbWVudAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTUxMjcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDU1NTdHls ZURlY2xhcmF0aW9uQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NT U3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHAKaW5kZXggMWE0NDhlZTFkNDZjZWQyNzM5ZmI1NGYw ZDJlNDAzM2IzOTQ0ZWU4OS4uMWU3NTBlNTFmZWQ2MDRiMGRjMjBlMzk2YjliZDMwMGNhYmI2Yzgw NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDU1NTdHlsZURlY2xh cmF0aW9uQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NTU1N0 eWxlRGVjbGFyYXRpb25DdXN0b20uY3BwCkBAIC0xMzUsNiArMTM1LDggQEAgc3RhdGljIFN0cmlu ZyBjc3NQcm9wZXJ0eU5hbWUoY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBib29sKiBo YWRQaXhlbE9yUG8KIAogc3RhdGljIGJvb2wgaXNDU1NQcm9wZXJ0eU5hbWUoY29uc3QgSWRlbnRp ZmllciYgcHJvcGVydHlOYW1lKQogeworICAgIC8vIEZJWE1FOiBUaGlzIG1hbGxvY3MgYSBzdHJp bmcgZm9yIHRoZSBwcm9wZXJ0eSBuYW1lIGFuZCB0aGVuIHRocm93cyBpdAorICAgIC8vIGF3YXku ICBUaGlzIHNob3dzIHVwIG9uIHBlYWNla2VlcGVyJ3MgZG9tRHluYW1pY0NyZWF0aW9uQ3JlYXRl RWxlbWVudC4KICAgICByZXR1cm4gQ1NTU3R5bGVEZWNsYXJhdGlvbjo6aXNQcm9wZXJ0eU5hbWUo Y3NzUHJvcGVydHlOYW1lKHByb3BlcnR5TmFtZSkpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFp bmVyTm9kZS5jcHAKaW5kZXggYmM4ODFjNjYzYWI0NDc3MmE5ZTlmZWNmYWU2NmMyNTYwMDZlMmQ1 Ni4uYjdhZDE1MjJlMzVmNmY2YzVjNzA3NjNmYjk4N2Y5MGI3N2FkNGNhYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Db250YWluZXJOb2RlLmNwcApAQCAtMzU1LDcgKzM1NSwxMiBAQCBib29sIENvbnRhaW5l ck5vZGU6OnJlcGxhY2VDaGlsZChQYXNzUmVmUHRyPE5vZGU+IG5ld0NoaWxkLCBOb2RlKiBvbGRD aGlsZCwgRXhjZQogCiB2b2lkIENvbnRhaW5lck5vZGU6OndpbGxSZW1vdmUoKQogewotICAgIE5v ZGVWZWN0b3Igbm9kZXM7CisgICAgLy8gRklYTUU6IFdlIHNob3VsZCB0dW5lIHRoZSBpbmxpbmVD YXBhY2l0eS4gIEhhdmluZyB0aGlzIGZ1bmN0aW9uIGNhbGwgbWFsbG9jCisgICAgLy8gYXMgYSBy ZXN1bHQgb2YgbmVlZGluZyB0byBleHBhbmQgY2FwYWNpdHkgaXMgZXhwZW5zaXZlIGFuIHNob3dz IHVwIG9uIGJlbmNobWFya3MuCisgICAgVmVjdG9yPFJlZlB0cjxOb2RlPiwgMTA+IG5vZGVzOwor ICAgIC8vIGNoaWxkTm9kZUNvdW50KCkgcmVzdWx0cyBpbiBhIGZ1bGwgd2FsayBvZiB0aGUgbm9k ZXMsIGJ1dCBzaG91bGQgYmUgZmFzdGVyCisgICAgLy8gdGhhbiBoYXZpbmcgdG8gbWFsbG9jIHR3 aWNlIGlmIHdlIGhhdmUgbG90cyBvZiBraWRzLgorICAgIG5vZGVzLnJlc2VydmVJbml0aWFsQ2Fw YWNpdHkoY2hpbGROb2RlQ291bnQoKSk7CiAgICAgZm9yIChOb2RlKiBuID0gbV9sYXN0Q2hpbGQ7 IG47IG4gPSBuLT5wcmV2aW91c1NpYmxpbmcoKSkKICAgICAgICAgbm9kZXMuYXBwZW5kKG4pOwog ICAgIGZvciAoOyBub2Rlcy5zaXplKCk7IG5vZGVzLnJlbW92ZUxhc3QoKSkKQEAgLTUxMiwxMCAr NTE3LDE1IEBAIHZvaWQgQ29udGFpbmVyTm9kZTo6cmVtb3ZlQ2hpbGRyZW4oKQogICAgIGRvY3Vt ZW50KCktPnJlbW92ZUZvY3VzZWROb2RlT2ZTdWJ0cmVlKHRoaXMsIHRydWUpOwogCiAgICAgZm9y YmlkRXZlbnREaXNwYXRjaCgpOwotICAgIFZlY3RvcjxSZWZQdHI8Tm9kZT4gPiByZW1vdmVkQ2hp bGRyZW47CisgICAgLy8gRklYTUU6IFdlIHNob3VsZCB0dW5lIHRoZSBpbmxpbmVDYXBhY2l0eS4g IEhhdmluZyB0aGlzIGZ1bmN0aW9uIGNhbGwgbWFsbG9jCisgICAgLy8gYXMgYSByZXN1bHQgb2Yg bmVlZGluZyB0byBleHBhbmQgY2FwYWNpdHkgaXMgZXhwZW5zaXZlIGFuIHNob3dzIHVwIG9uIGJl bmNobWFya3MuCisgICAgVmVjdG9yPFJlZlB0cjxOb2RlPiwgMTA+IHJlbW92ZWRDaGlsZHJlbjsK KyAgICAvLyBjaGlsZE5vZGVDb3VudCgpIHJlc3VsdHMgaW4gYSBmdWxsIHdhbGsgb2YgdGhlIG5v ZGVzLCBidXQgc2hvdWxkIGJlIGZhc3RlcgorICAgIC8vIHRoYW4gaGF2aW5nIHRvIG1hbGxvYyB0 d2ljZSBpZiB3ZSBoYXZlIGxvdHMgb2Yga2lkcy4KKyAgICByZW1vdmVkQ2hpbGRyZW4ucmVzZXJ2 ZUluaXRpYWxDYXBhY2l0eShjaGlsZE5vZGVDb3VudCgpKTsKICAgICB3aGlsZSAoUmVmUHRyPE5v ZGU+IG4gPSBtX2ZpcnN0Q2hpbGQpIHsKICAgICAgICAgTm9kZSogbmV4dCA9IG4tPm5leHRTaWJs aW5nKCk7Ci0gICAgICAgIAorCiAgICAgICAgIC8vIFJlbW92ZSB0aGUgbm9kZSBmcm9tIHRoZSB0 cmVlIGJlZm9yZSBjYWxsaW5nIGRldGFjaCBvciByZW1vdmVkRnJvbURvY3VtZW50ICg0NDI3MDI0 LCA0MTI5NzQ0KS4KICAgICAgICAgLy8gcmVtb3ZlQ2hpbGQoKSBkb2VzIHRoaXMgYWZ0ZXIgY2Fs bGluZyBkZXRhY2goKS4gVGhlcmUgaXMgbm8gZXhwbGFuYXRpb24gZm9yCiAgICAgICAgIC8vIHRo aXMgZGlzY3JlcGFuY3kgYmV0d2VlbiByZW1vdmVDaGlsZCgpIGFuZCBpdHMgb3B0aW1pemVkIHZl cnNpb24gcmVtb3ZlQ2hpbGRyZW4oKS4K 83777 2011-02-25 00:10:27 -0800 2011-02-26 05:59:52 -0800 Patch for landing bug-55204-20110225001025.patch text/plain 2979 eric U3VidmVyc2lvbiBSZXZpc2lvbjogNzk2NjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNzg0ZjZlYmE2ZWIyYmY2 NmI4NGRhODJlNThjZDYyZmRiNTEyZWMzLi40OWY0ZTQ5MTYwOGEwNWNjOGIxMzJiN2Q5ZWE3ZDFl NWQyNTA0MjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMjUgIEVyaWMg U2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBT dGFjaG93aWFrLgorCisgICAgICAgIG1hbGxvYyBpbiByZW1vdmVDaGlsZHJlbiBzaG93cyB1cCBv biBwcm9maWxlIG9mIHBlYWNla2VlcGVyIGRvbUR5bmFtaWNDcmVhdGlvbkNyZWF0ZUVsZW1lbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MjA0CisK KyAgICAgICAgKiBkb20vQ29udGFpbmVyTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb250 YWluZXJOb2RlOjpyZW1vdmVDaGlsZHJlbik6CisgICAgICAgICAtIFVzaW5nIGFuIGlubGluZUNh cGFjaXR5IG9mIDEwIGZvciBub3cuIFdlIG1heSB3YW50IHRvIHR3ZWFrIGl0IGxhdGVyLgorICAg ICAgICAgLSBUaGlzIHJlbW92ZXMgeWV0IGFub3RoZXIgbWFsbG9jIGZyb20gY29kZSB3aGljaCBy ZW1vdmVzIG5vZGVzICh3aGljaCBpcyByYXRoZXIgY29tbW9uKS4KKwogMjAxMS0wMi0yNCAgRGFu aWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50b25p byBHb21lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NTU3R5 bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NT U1N0eWxlRGVjbGFyYXRpb25DdXN0b20uY3BwCmluZGV4IDFhNDQ4ZWUxZDQ2Y2VkMjczOWZiNTRm MGQyZTQwMzNiMzk0NGVlODkuLjFlNzUwZTUxZmVkNjA0YjBkYzIwZTM5NmI5YmQzMDBjYWJiNmM4 MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NTU3R5bGVEZWNs YXJhdGlvbkN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDU1NT dHlsZURlY2xhcmF0aW9uQ3VzdG9tLmNwcApAQCAtMTM1LDYgKzEzNSw4IEBAIHN0YXRpYyBTdHJp bmcgY3NzUHJvcGVydHlOYW1lKGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgYm9vbCog aGFkUGl4ZWxPclBvCiAKIHN0YXRpYyBib29sIGlzQ1NTUHJvcGVydHlOYW1lKGNvbnN0IElkZW50 aWZpZXImIHByb3BlcnR5TmFtZSkKIHsKKyAgICAvLyBGSVhNRTogVGhpcyBtYWxsb2NzIGEgc3Ry aW5nIGZvciB0aGUgcHJvcGVydHkgbmFtZSBhbmQgdGhlbiB0aHJvd3MgaXQKKyAgICAvLyBhd2F5 LiAgVGhpcyBzaG93cyB1cCBvbiBwZWFjZWtlZXBlcidzIGRvbUR5bmFtaWNDcmVhdGlvbkNyZWF0 ZUVsZW1lbnQuCiAgICAgcmV0dXJuIENTU1N0eWxlRGVjbGFyYXRpb246OmlzUHJvcGVydHlOYW1l KGNzc1Byb3BlcnR5TmFtZShwcm9wZXJ0eU5hbWUpKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRh aW5lck5vZGUuY3BwCmluZGV4IGJjODgxYzY2M2FiNDQ3NzJhOWU5ZmVjZmFlNjZjMjU2MDA2ZTJk NTYuLjU5NDViMTNlNWIwZDE5ZTk1ZTBiZWQxN2M3ZmY2MDIwYjEyZGI2MjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKQEAgLTM1NSw3ICszNTUsOCBAQCBib29sIENvbnRhaW5l ck5vZGU6OnJlcGxhY2VDaGlsZChQYXNzUmVmUHRyPE5vZGU+IG5ld0NoaWxkLCBOb2RlKiBvbGRD aGlsZCwgRXhjZQogCiB2b2lkIENvbnRhaW5lck5vZGU6OndpbGxSZW1vdmUoKQogewotICAgIE5v ZGVWZWN0b3Igbm9kZXM7CisgICAgVmVjdG9yPFJlZlB0cjxOb2RlPiwgMTA+IG5vZGVzOworICAg IG5vZGVzLnJlc2VydmVJbml0aWFsQ2FwYWNpdHkoY2hpbGROb2RlQ291bnQoKSk7CiAgICAgZm9y IChOb2RlKiBuID0gbV9sYXN0Q2hpbGQ7IG47IG4gPSBuLT5wcmV2aW91c1NpYmxpbmcoKSkKICAg ICAgICAgbm9kZXMuYXBwZW5kKG4pOwogICAgIGZvciAoOyBub2Rlcy5zaXplKCk7IG5vZGVzLnJl bW92ZUxhc3QoKSkKQEAgLTUxMiwxMCArNTEzLDExIEBAIHZvaWQgQ29udGFpbmVyTm9kZTo6cmVt b3ZlQ2hpbGRyZW4oKQogICAgIGRvY3VtZW50KCktPnJlbW92ZUZvY3VzZWROb2RlT2ZTdWJ0cmVl KHRoaXMsIHRydWUpOwogCiAgICAgZm9yYmlkRXZlbnREaXNwYXRjaCgpOwotICAgIFZlY3RvcjxS ZWZQdHI8Tm9kZT4gPiByZW1vdmVkQ2hpbGRyZW47CisgICAgVmVjdG9yPFJlZlB0cjxOb2RlPiwg MTA+IHJlbW92ZWRDaGlsZHJlbjsKKyAgICByZW1vdmVkQ2hpbGRyZW4ucmVzZXJ2ZUluaXRpYWxD YXBhY2l0eShjaGlsZE5vZGVDb3VudCgpKTsKICAgICB3aGlsZSAoUmVmUHRyPE5vZGU+IG4gPSBt X2ZpcnN0Q2hpbGQpIHsKICAgICAgICAgTm9kZSogbmV4dCA9IG4tPm5leHRTaWJsaW5nKCk7Ci0g ICAgICAgIAorCiAgICAgICAgIC8vIFJlbW92ZSB0aGUgbm9kZSBmcm9tIHRoZSB0cmVlIGJlZm9y ZSBjYWxsaW5nIGRldGFjaCBvciByZW1vdmVkRnJvbURvY3VtZW50ICg0NDI3MDI0LCA0MTI5NzQ0 KS4KICAgICAgICAgLy8gcmVtb3ZlQ2hpbGQoKSBkb2VzIHRoaXMgYWZ0ZXIgY2FsbGluZyBkZXRh Y2goKS4gVGhlcmUgaXMgbm8gZXhwbGFuYXRpb24gZm9yCiAgICAgICAgIC8vIHRoaXMgZGlzY3Jl cGFuY3kgYmV0d2VlbiByZW1vdmVDaGlsZCgpIGFuZCBpdHMgb3B0aW1pemVkIHZlcnNpb24gcmVt b3ZlQ2hpbGRyZW4oKS4K