55201 2011-02-24 18:24:27 -0800 [Web Timing] loadEvent timing should refer to first load event if there are many 2011-02-28 11:29:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simonjam simonjam commit-queue mrobinson rniwa tonyg xan.lopez oldest_to_newest 357628 0 simonjam 2011-02-24 18:24:27 -0800 [Web Timing] loadEvent timing should refer to first load event if there are many 357630 1 83758 simonjam 2011-02-24 18:26:12 -0800 Created attachment 83758 Patch 357632 2 simonjam 2011-02-24 18:30:29 -0800 This fixes the test we uploaded to the W3C. 357636 3 83758 tonyg 2011-02-24 18:36:12 -0800 Comment on attachment 83758 Patch This fix looks good. But I'm wondering if it is ever correct to fire multiple load events. If not, would it be better to fix that underlying bug instead of this? 357672 4 simonjam 2011-02-24 21:09:15 -0800 (In reply to comment #3) > (From update of attachment 83758 [details]) > This fix looks good. But I'm wondering if it is ever correct to fire multiple load events. If not, would it be better to fix that underlying bug instead of this? From a quick reading of the spec, it looks like it is valid to fire load twice. Any time the parser reaches the end, it's supposed to fire load. document.open() is supposed to create a new parser, so it seems valid to hit load repeatedly. 358450 5 83758 commit-queue 2011-02-26 04:05:11 -0800 Comment on attachment 83758 Patch Clearing flags on attachment: 83758 Committed r79776: <http://trac.webkit.org/changeset/79776> 358451 6 commit-queue 2011-02-26 04:05:16 -0800 All reviewed patches have been landed. Closing bug. 358472 7 rniwa 2011-02-26 05:46:27 -0800 It seems like this patch caused fast/spatial-navigation/snav-single-select-list.html to crash on GTK: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r79776%20(19760)/results.html Stack trace: http://webkit-bots.igalia.com/amd64/svn_79778.core-when_1298727058-_-who_DumpRenderTree-_-why_11.trace.html Thread 1 (Thread 17949): #0 0x00007f9eca092f12 in WTF::RefPtr<WTF::StringImpl>::get (this=0x31) at ../../Source/JavaScriptCore/wtf/RefPtr.h:60 #1 0x00007f9eca09129c in WTF::String::impl (this=0x31) at ../../Source/JavaScriptCore/wtf/text/WTFString.h:126 #2 0x00007f9eca09138c in WTF::AtomicString::impl (this=0x31) at ../../Source/JavaScriptCore/wtf/text/AtomicString.h:61 #3 0x00007f9eca0913ab in WTF::operator== (a=..., b=...) at ../../Source/JavaScriptCore/wtf/text/AtomicString.h:132 #4 0x00007f9eca091e52 in WebCore::QualifiedName::matches (this=0x2a31878, other=...) at ../../Source/WebCore/dom/QualifiedName.h:75 #5 0x00007f9eca091ff9 in WebCore::Element::hasTagName (this=0x2a31810, tagName=...) at ../../Source/WebCore/dom/Element.h:191 #6 0x00007f9eca20aac8 in WebCore::AccessibilityListBoxOption::listBoxOptionParentNode (this=0x26a0900) at ../../Source/WebCore/accessibility/AccessibilityListBoxOption.cpp:192 #7 0x00007f9eca20a935 in WebCore::AccessibilityListBoxOption::parentObject (this=0x26a0900) at ../../Source/WebCore/accessibility/AccessibilityListBoxOption.cpp:162 #8 0x00007f9eca210bcd in WebCore::AccessibilityObject::documentFrameView (this=0x26a0900) at ../../Source/WebCore/accessibility/AccessibilityObject.cpp:735 #9 0x00007f9eca210b75 in WebCore::AccessibilityObject::document (this=0x26a0900) at ../../Source/WebCore/accessibility/AccessibilityObject.cpp:724 #10 0x00007f9eca094c5f in WebCore::notifyChildrenSelectionChange (object=0x2a205e0) at ../../Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:72 #11 0x00007f9eca094ee4 in WebCore::AXObjectCache::postPlatformNotification (this=0x2a37a00, coreObject=0x2a205e0, notification=WebCore::AXObjectCache::AXSelectedChildrenChanged) at ../../Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:112 #12 0x00007f9eca22d5a3 in WebCore::AXObjectCache::notificationPostTimerFired (this=0x2a37a00) at ../../Source/WebCore/accessibility/AXObjectCache.cpp:465 #13 0x00007f9eca23913a in WebCore::Timer<WebCore::AXObjectCache>::fired (this=0x2a37b70) at ../../Source/WebCore/platform/Timer.h:100 #14 0x00007f9eca8f278c in WebCore::ThreadTimers::sharedTimerFiredInternal (this=0xe2fda0) at ../../Source/WebCore/platform/ThreadTimers.cpp:112 #15 0x00007f9eca8f26c3 in WebCore::ThreadTimers::sharedTimerFired () at ../../Source/WebCore/platform/ThreadTimers.cpp:90 #16 0x00007f9eca0e380e in WebCore::timeout_cb () at ../../Source/WebCore/platform/gtk/SharedTimerGtk.cpp:49 #17 0x00007f9ec72fedbb in g_timeout_dispatch (source=0x2a3f060, callback=0xe0cda0, user_data=0x21) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3877 #18 0x00007f9ec72fe362 in g_main_dispatch (context=0xd8b1e0) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:2440 #19 g_main_context_dispatch (context=0xd8b1e0) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3013 #20 0x00007f9ec7302a28 in g_main_context_iterate (context=0xd8b1e0, block=<value optimized out>, dispatch=<value optimized out>, self=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3091 #21 0x00007f9ec7302f35 in g_main_loop_run (loop=0x2a72df0) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3299 #22 0x00007f9ec9237657 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #23 0x000000000041e1e9 in runTest (testPathOrURL=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:679 #24 0x000000000041d87b in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:489 #25 0x000000000041f960 in main (argc=2, argv=0x7fff7757f828) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1143 359194 8 simonjam 2011-02-28 11:29:19 -0800 (In reply to comment #7) > It seems like this patch caused fast/spatial-navigation/snav-single-select-list.html to crash on GTK: > http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r79776%20(19760)/results.html I don't see any of the changed code on the stack and it seems unrelated. I would suspect another change or just flakiness. 83758 2011-02-24 18:26:12 -0800 2011-02-26 04:05:11 -0800 Patch bug-55201-20110224182611.patch text/plain 3946 simonjam U3VidmVyc2lvbiBSZXZpc2lvbjogNzk1MzgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyODY5MjkyNGMwNTVjZWUyZGI0NzEw YjQ1NDY5NTg3NWY2MjhjNWU2Li41NTcyNGIxZjZkNTE2YjE0YzE0Yjk0NjM5YWVhOWM1ZjJiNjgz ZDkzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMjQgIEphbWVzIFNpbW9uc2VuICA8 c2ltb25qYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtXZWIgVGltaW5nXSBsb2FkRXZlbnQgdGltaW5nIHNob3VsZCByZWZl ciB0byBmaXJzdCBsb2FkIGV2ZW50IGlmIHRoZXJlIGFyZSBtYW55CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTIwMQorCisgICAgICAgICogZmFzdC9k b20vc2NyaXB0LXRlc3RzL3dlYnRpbWluZy1kb2N1bWVudC1vcGVuLmpzOgorICAgICAgICAodGVz dFRpbWluZ1dpdGhEb2N1bWVudE9wZW4pOiBGaXJlIHZpYSBzZXRUaW1lb3V0IHRvIG1hdGNoIHcz YyB0ZXN0IGFuZCByZXZlYWwgbG9hZEV2ZW50RW5kLgorICAgICAgICAoZmluaXNoVGVzdCk6IEZp cmUgdmlhIHNldFRpbWVvdXQgdG8gbWF0Y2ggdzNjIHRlc3QuCisKIDIwMTEtMDItMjQgIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBW YWZhaS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NjcmlwdC10ZXN0cy93ZWJ0 aW1pbmctZG9jdW1lbnQtb3Blbi5qcyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NjcmlwdC10ZXN0 cy93ZWJ0aW1pbmctZG9jdW1lbnQtb3Blbi5qcwppbmRleCAyNTdkMmQ4ZjE1NDRjNGMyZDAyYjQ5 MzRmYWFiMTliN2JmNjRlZGYzLi4wZTRlMTdlYTkwYTRjM2M4NmNkNDVlN2U5MWE2MmRmYWM5YWE2 MDk4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zY3JpcHQtdGVzdHMvd2VidGlt aW5nLWRvY3VtZW50LW9wZW4uanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2NyaXB0LXRl c3RzL3dlYnRpbWluZy1kb2N1bWVudC1vcGVuLmpzCkBAIC0zLDcgKzMsNyBAQCB2YXIgbmF2aWdh dGlvbiA9IHBlcmZvcm1hbmNlLm5hdmlnYXRpb24gfHwge307CiB2YXIgdGltaW5nID0gcGVyZm9y bWFuY2UudGltaW5nIHx8IHt9OwogdmFyIG9yaWdpbmFsVGltaW5nID0ge307CiAKLXdpbmRvdy5h ZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgdGVzdFRpbWluZ1dpdGhEb2N1bWVudE9wZW4sIGZhbHNl KTsKK3dpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24oKSB7IHNldFRpbWVv dXQodGVzdFRpbWluZ1dpdGhEb2N1bWVudE9wZW4sIDApOyB9LCBmYWxzZSk7CiAKIGZ1bmN0aW9u IHRlc3RUaW1pbmdXaXRoRG9jdW1lbnRPcGVuKCkKIHsKQEAgLTI3LDYgKzI3LDEwIEBAIGZ1bmN0 aW9uIHRlc3RUaW1pbmdXaXRoRG9jdW1lbnRPcGVuKCkKIAogICAgIGRlc2NyaXB0aW9uKCJUaGlz IHRlc3QgdmVyaWZpZXMgdGhhdCB0aGUgTmF2aWdhdGlvblRpbWluZ3MgZG9uJ3QgY2hhbmdlIGFm dGVyIGEgZG9jdW1lbnQub3BlbigpLiIpOwogCisgICAgc2V0VGltZW91dChmaW5pc2hUZXN0LCAw KTsKK30KKworZnVuY3Rpb24gZmluaXNoVGVzdCgpIHsKICAgICBrZXlzID0gT2JqZWN0LmtleXMo dGltaW5nKS5zb3J0KCk7CiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBrZXlzLmxlbmd0aDsgKytp KSB7CiAgICAgICAgIHNob3VsZEJlKCJ0aW1pbmcuIiArIGtleXNbaV0sICJvcmlnaW5hbFRpbWlu Zy4iICsga2V5c1tpXSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjc2YTU3ZTAwM2JmOTlmZjBlYjljNzk0YWNl MWQ0NGM1YmVjNjgwNi4uYjU2MWZkMjJlMjM5YzIwOTNlOWFjYzFmZmY0NGJiY2IzMDk2OTY4NCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTAyLTI0ICBKYW1lcyBTaW1vbnNlbiAg PHNpbW9uamFtQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBbV2ViIFRpbWluZ10gbG9hZEV2ZW50IHRpbWluZyBzaG91bGQgcmVm ZXIgdG8gZmlyc3QgbG9hZCBldmVudCBpZiB0aGVyZSBhcmUgbWFueQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUyMDEKKworICAgICAgICBUZXN0OiBm YXN0L2RvbS93ZWJ0aW1pbmctZG9jdW1lbnQtb3Blbi5odG1sCisKKyAgICAgICAgKiBwYWdlL0RP TVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OmRpc3BhdGNoTG9hZEV2 ZW50KToKKwogMjAxMS0wMi0yNCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9ET01XaW5kb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3Bw CmluZGV4IGVkNmQwNTcxZjRmZDk0MDBmY2ZmNTUzOGM2N2JiMTViMmQzYjY3NzcuLjA0MzJhYTJm YjM3NTM2OTQxYjUwNDI3YzY0MDlkOTRkMzhkOGM2YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NV2luZG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRv dy5jcHAKQEAgLTE1MTcsOSArMTUxNywxMCBAQCBib29sIERPTVdpbmRvdzo6cmVtb3ZlRXZlbnRM aXN0ZW5lcihjb25zdCBBdG9taWNTdHJpbmcmIGV2ZW50VHlwZSwgRXZlbnRMaXN0ZW5lcgogdm9p ZCBET01XaW5kb3c6OmRpc3BhdGNoTG9hZEV2ZW50KCkKIHsKICAgICBSZWZQdHI8RXZlbnQ+IGxv YWRFdmVudChFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5sb2FkRXZlbnQsIGZhbHNlLCBmYWxz ZSkpOwotICAgIC8vIFRoZSBEb2N1bWVudExvYWRlciAoYW5kIHRodXMgaXRzIERvY3VtZW50TG9h ZFRpbWluZykgbWlnaHQgZ2V0IGRlc3Ryb3llZCB3aGlsZSBkaXNwYXRjaGluZwotICAgIC8vIHRo ZSBldmVudCwgc28gcHJvdGVjdCBpdCB0byBwcmV2ZW50IHdyaXRpbmcgdGhlIGVuZCB0aW1lIGlu dG8gZnJlZWQgbWVtb3J5LgotICAgIGlmIChSZWZQdHI8RG9jdW1lbnRMb2FkZXI+IGRvY3VtZW50 TG9hZGVyID0gbV9mcmFtZSA/IG1fZnJhbWUtPmxvYWRlcigpLT5kb2N1bWVudExvYWRlcigpIDog MCkgeworICAgIGlmIChtX2ZyYW1lICYmIG1fZnJhbWUtPmxvYWRlcigpLT5kb2N1bWVudExvYWRl cigpICYmICFtX2ZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKS0+dGltaW5nKCktPmxv YWRFdmVudFN0YXJ0KSB7CisgICAgICAgIC8vIFRoZSBEb2N1bWVudExvYWRlciAoYW5kIHRodXMg aXRzIERvY3VtZW50TG9hZFRpbWluZykgbWlnaHQgZ2V0IGRlc3Ryb3llZCB3aGlsZSBkaXNwYXRj aGluZworICAgICAgICAvLyB0aGUgZXZlbnQsIHNvIHByb3RlY3QgaXQgdG8gcHJldmVudCB3cml0 aW5nIHRoZSBlbmQgdGltZSBpbnRvIGZyZWVkIG1lbW9yeS4KKyAgICAgICAgUmVmUHRyPERvY3Vt ZW50TG9hZGVyPiBkb2N1bWVudExvYWRlciA9IG1fZnJhbWUtPmxvYWRlcigpLT5kb2N1bWVudExv YWRlcigpOwogICAgICAgICBEb2N1bWVudExvYWRUaW1pbmcqIHRpbWluZyA9IGRvY3VtZW50TG9h ZGVyLT50aW1pbmcoKTsKICAgICAgICAgZGlzcGF0Y2hUaW1lZEV2ZW50KGxvYWRFdmVudCwgZG9j dW1lbnQoKSwgJnRpbWluZy0+bG9hZEV2ZW50U3RhcnQsICZ0aW1pbmctPmxvYWRFdmVudEVuZCk7 CiAgICAgfSBlbHNlCg==