55200 2011-02-24 18:04:22 -0800 [chromium] Don't clear existing files if file chooser is canceled 2011-04-05 03:50:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 sail webkit-unassigned abarth brettw commit-queue eric tkent webkit.review.bot oldest_to_newest 357609 0 sail 2011-02-24 18:04:22 -0800 Don't clear existing files if file chooser is canceled 357611 1 83757 sail 2011-02-24 18:05:34 -0800 Created attachment 83757 Patch 358490 2 tkent 2011-02-26 06:43:44 -0800 (In reply to comment #0) > Don't clear existing files if file chooser is canceled Why? Without the current behavior, users can't clear the selected file. Though the current behavior is not compatible with Safari, I think it's intentional. 358680 3 sail 2011-02-27 08:28:12 -0800 (In reply to comment #2) > (In reply to comment #0) > > Don't clear existing files if file chooser is canceled > > Why? Without the current behavior, users can't clear the selected file. This is a usability bug. Cancel should always abort the current operation. If we need a way to clear the selected file then we should add a separate way to do that. > Though the current behavior is not compatible with Safari, I think it's intentional. It's not about being compatible with Safari. I just tried Firefox and it does the same thing as Safari too. 379307 4 83757 fishd 2011-04-04 21:20:11 -0700 Comment on attachment 83757 Patch Agreed. This seems like the right fix to me. Cancelling a dialog should leave existing state unchanged. 379379 5 83757 commit-queue 2011-04-05 02:07:03 -0700 Comment on attachment 83757 Patch Clearing flags on attachment: 83757 Committed r82914: <http://trac.webkit.org/changeset/82914> 379381 6 commit-queue 2011-04-05 02:07:08 -0700 All reviewed patches have been landed. Closing bug. 379427 7 webkit.review.bot 2011-04-05 03:50:36 -0700 http://trac.webkit.org/changeset/82914 might have broken GTK Linux 32-bit Debug 83757 2011-02-24 18:05:34 -0800 2011-04-05 02:07:03 -0700 Patch bug-55200-20110224180533.patch text/plain 1352 sail SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3OTY1MCkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDItMjQgIFNhaWxlc2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IGNsZWFy IGV4aXN0aW5nIGZpbGVzIGlmIHRoZSB1c2VyIGNhbmNlbHMgdGhlIGZpbGUgY2hvb3NlciBkaWFs b2cuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTIw MAorCisgICAgICAgICogc3JjL1dlYkZpbGVDaG9vc2VyQ29tcGxldGlvbkltcGwuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJGaWxlQ2hvb3NlckNvbXBsZXRpb25JbXBsOjpkaWRDaG9vc2VGaWxl KToKKwogMjAxMS0wMi0yNCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5kZXg6IFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkZpbGVDaG9vc2VyQ29tcGxldGlvbkltcGwuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZpbGVDaG9vc2VyQ29tcGxldGlvbklt cGwuY3BwCShyZXZpc2lvbiA3ODM2MSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YkZpbGVDaG9vc2VyQ29tcGxldGlvbkltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Niw4ICs0 Niw3IEBAIHZvaWQgV2ViRmlsZUNob29zZXJDb21wbGV0aW9uSW1wbDo6ZGlkQ2gKIHsKICAgICBp ZiAoZmlsZU5hbWVzLnNpemUoKSA9PSAxKQogICAgICAgICBtX2ZpbGVDaG9vc2VyLT5jaG9vc2VG aWxlKGZpbGVOYW1lc1swXSk7Ci0gICAgZWxzZSB7Ci0gICAgICAgIC8vIFRoaXMgY2xhdXNlIGhh bmRsZXMgYSBjYXNlIG9mIGZpbGVfbmFtZXMuc2l6ZSgpPT0wIHRvby4KKyAgICBlbHNlIGlmIChm aWxlTmFtZXMuc2l6ZSgpID4gMCkgewogICAgICAgICBWZWN0b3I8V1RGOjpTdHJpbmc+IHBhdGhz OwogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGZpbGVOYW1lcy5zaXplKCk7ICsraSkK ICAgICAgICAgICAgIHBhdGhzLmFwcGVuZChmaWxlTmFtZXNbaV0pOwo=