55190 2011-02-24 15:36:35 -0800 Crash when trying to send a sync message on an invalid connection 2011-02-25 09:54:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca ap mitz oldest_to_newest 357460 0 andersca 2011-02-24 15:36:35 -0800 Crash when trying to send a sync message on an invalid connection 357465 1 83734 andersca 2011-02-24 15:39:06 -0800 Created attachment 83734 Patch 357473 2 83734 mitz 2011-02-24 15:40:25 -0800 Comment on attachment 83734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83734&action=review > Source/WebKit2/ChangeLog:11 > + Don't try to call a client function is isValid() returns false since the client s/n is/n if/ 357474 3 andersca 2011-02-24 15:40:58 -0800 Committed r79634: <http://trac.webkit.org/changeset/79634> 357713 4 ap 2011-02-24 22:52:18 -0800 So, all callers of sendSync() need to test for null return value again? This can't be right. 357986 5 andersca 2011-02-25 09:54:52 -0800 (In reply to comment #4) > So, all callers of sendSync() need to test for null return value again? This can't be right. You obviously can't call the client since the client is null! 83734 2011-02-24 15:39:06 -0800 2011-02-24 15:40:25 -0800 Patch bug-55190-20110224153905.patch text/plain 1412 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5NjMyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMjQgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDcmFzaCB3aGVuIHRyeWluZyB0byBzZW5kIGEgc3luYyBt ZXNzYWdlIG9uIGFuIGludmFsaWQgY29ubmVjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUxOTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzkw MzU4MDY+CisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwOgorICAg ICAgICAoQ29yZUlQQzo6Q29ubmVjdGlvbjo6c2VuZFN5bmNNZXNzYWdlKToKKyAgICAgICAgRG9u J3QgdHJ5IHRvIGNhbGwgYSBjbGllbnQgZnVuY3Rpb24gaXMgaXNWYWxpZCgpIHJldHVybnMgZmFs c2Ugc2luY2UgdGhlIGNsaWVudAorICAgICAgICB3aWxsIGJlIG51bGwgaW4gdGhhdCBjYXNlLgor CiAyMDExLTAyLTI0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAkocmV2aXNpb24gNzk2MjkpCisrKyBT b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNDMsMTAgKzM0Myw4IEBAIFBhc3NPd25QdHI8QXJndW1lbnREZWNvZGVyPiBDb25u ZWN0aW9uOjoKICAgICAvLyBXZSBvbmx5IGFsbG93IHNlbmRpbmcgc3luYyBtZXNzYWdlcyBmcm9t IHRoZSBjbGllbnQgcnVuIGxvb3AuCiAgICAgQVNTRVJUKFJ1bkxvb3A6OmN1cnJlbnQoKSA9PSBt X2NsaWVudFJ1bkxvb3ApOwogCi0gICAgaWYgKCFpc1ZhbGlkKCkpIHsKLSAgICAgICAgbV9jbGll bnQtPmRpZEZhaWxUb1NlbmRTeW5jTWVzc2FnZSh0aGlzKTsKKyAgICBpZiAoIWlzVmFsaWQoKSkK ICAgICAgICAgcmV0dXJuIDA7Ci0gICAgfQogICAgIAogICAgIC8vIFB1c2ggdGhlIHBlbmRpbmcg c3luYyByZXBseSBpbmZvcm1hdGlvbiBvbiBvdXIgc3RhY2suCiAgICAgewo=