55163 2011-02-24 11:23:48 -0800 new-run-webkit-tests: enable multiple processes by default on Chromium Win 2011-04-13 14:23:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 55195 58296 1 dpranke dpranke aroben eric mihaip ojan tony oldest_to_newest 357188 0 dpranke 2011-02-24 11:23:48 -0800 nrwt: enable multiple processes by default on windows 357190 1 83686 dpranke 2011-02-24 11:24:46 -0800 Created attachment 83686 Patch 357430 2 dpranke 2011-02-24 15:05:31 -0800 Committed r79628: <http://trac.webkit.org/changeset/79628> 357565 3 dpranke 2011-02-24 16:47:39 -0800 Okay, turns out processes don't work so well just yet. Two issues I saw: 1) output from the child python processes wasn't getting piped back into the parent processes. I think I had noticed this before and forgotten about it, but this is not a great thing to have going on in --verbose mode. Because of the way windows multiprocessing works, the processes don't share file descriptors, and so I don't get this for free. I think the thing to do is to send the log strings over the message queue. In general we only log a couple of messages per test in the worker, so it shouldn't do more than double the message load. At the same time, on the dbg 2 bot, everything was totally broken: see http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20%28dbg%29%282%29/builds/1265/steps/webkit_gpu_tests/logs/stdio . So it's hard to conclude much from that. 357568 4 dpranke 2011-02-24 16:48:34 -0800 reverted in http://trac.webkit.org/changeset/79641 381077 5 dpranke 2011-04-06 19:45:02 -0700 I don't think it should block bug 34984 and I plan to clear the blocking flag on Mon 4/11. If you disagree, now would be a good time to speak up :). 383785 6 dpranke 2011-04-11 20:06:58 -0700 okay, given the fix to the web server on windows and the logging fix in 58296, everything seems to work for me, so it's time to try again ... 384584 7 dpranke 2011-04-12 18:04:16 -0700 clearing blocking flag. 385228 8 dpranke 2011-04-13 14:23:00 -0700 Committed r83764: <http://trac.webkit.org/changeset/83764> 83686 2011-02-24 11:24:46 -0800 2011-02-24 11:58:32 -0800 Patch bug-55163-20110224112445.patch text/plain 2345 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzk1MTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhOWViZmJmODE1ZDMyNWU1YmI4MjQ0YjMzMDFhNTc1ZWNj MTMyZDMxLi43OTRkMDhkYjFiYWJjNDE2YzUzMjhhMjhiODZmYmI0YzBjNDU3YjJlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDItMjQgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbnJ3dDogZW5hYmxl IG11bHRpcGxlIHByb2Nlc3NlcyBieSBkZWZhdWx0IG9uIENocm9taXVtIFdpbi4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUxNjMKKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fd2luLnB5Ogor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fd2lu X3VuaXR0ZXN0LnB5OgorCiAyMDExLTAyLTIzICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNzkzODcuCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dp bi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1f d2luLnB5CmluZGV4IGU3YzZlNDk3Y2Y3ZmM3OTk2YzkwMDE4NTE3ZDAxYWZkZmE1YzllYzAuLjFi ZjhlNGM3OTk0ZmFjNzM3MDNiOWI1NTBiN2RiYTQyYjY5N2Y0YWYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fd2luLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fd2luLnB5 CkBAIC0xMjksNiArMTI5LDExIEBAIGNsYXNzIENocm9taXVtV2luUG9ydChjaHJvbWl1bS5DaHJv bWl1bVBvcnQpOgogICAgICAgICAgICAgICAgICAgICAgICAnYnVpbGQtaW5zdHJ1Y3Rpb25zLXdp bmRvd3MnKQogICAgICAgICByZXR1cm4gcmVzdWx0CiAKKyAgICBkZWYgZGVmYXVsdF93b3JrZXJf bW9kZWwoc2VsZik6CisgICAgICAgIGlmIHNlbGYuX211bHRpcHJvY2Vzc2luZ19pc19hdmFpbGFi bGU6CisgICAgICAgICAgICByZXR1cm4gJ3Byb2Nlc3NlcycKKyAgICAgICAgcmV0dXJuICdvbGQt dGhyZWFkcycKKwogICAgIGRlZiByZWxhdGl2ZV90ZXN0X2ZpbGVuYW1lKHNlbGYsIGZpbGVuYW1l KToKICAgICAgICAgcGF0aCA9IGZpbGVuYW1lW2xlbihzZWxmLmxheW91dF90ZXN0c19kaXIoKSkg KyAxOl0KICAgICAgICAgcmV0dXJuIHBhdGgucmVwbGFjZSgnXFwnLCAnLycpCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbl91 bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hy b21pdW1fd2luX3VuaXR0ZXN0LnB5CmluZGV4IDhlYTcwNjBjNTNhYjYwM2FkOGMwMjU3Yjk2ODRl MDc1MzkwYjc3YTMuLjU5M2EyNDQzMjMwODU1ZDM2ZTkzODBkNTZiNmNhNzJkOTVhN2FhM2QgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p dW1fd2luX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY2hyb21pdW1fd2luX3VuaXR0ZXN0LnB5CkBAIC01OCwxMyArNTgsNiBAQCBjbGFz cyBDaHJvbWl1bVdpblRlc3QocG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UpOgogICAgIGRlZiBf bW9ja19wYXRoX2Zyb21fY2hyb21pdW1fYmFzZShzZWxmLCAqY29tcHMpOgogICAgICAgICByZXR1 cm4gc2VsZi5fcG9ydC5fZmlsZXN5c3RlbS5qb2luKCIvY2hyb21pdW0vc3JjIiwgKmNvbXBzKQog Ci0gICAgZGVmIHRlc3RfZGVmYXVsdF93b3JrZXJfbW9kZWwoc2VsZik6Ci0gICAgICAgIHBvcnQg PSBzZWxmLm1ha2VfcG9ydCgpCi0gICAgICAgIGlmIG5vdCBwb3J0OgotICAgICAgICAgICAgcmV0 dXJuCi0KLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0LmRlZmF1bHRfd29ya2VyX21vZGVs KCksICdvbGQtdGhyZWFkcycpCi0KICAgICBkZWYgdGVzdF9zZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2 ZXIoc2VsZik6CiAgICAgICAgIHBvcnQgPSBzZWxmLm1ha2VfcG9ydCgpCiAgICAgICAgIGlmIG5v dCBwb3J0Ogo=