55156 2011-02-24 09:23:58 -0800 PatternAlternative leaked in YarrPatternConstructor::atomParenthesesEnd() 2011-02-24 15:59:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 msaboff msaboff abarth eric webkit.review.bot oldest_to_newest 357087 0 msaboff 2011-02-24 09:23:58 -0800 The removal of empty disjunction alternatives from the alternatives vector doesn't delete the removed alternative thus leaking it. 357178 1 83682 msaboff 2011-02-24 11:06:30 -0800 Created attachment 83682 Patch to delete unneeded PatternAlternative 357185 2 83682 oliver 2011-02-24 11:19:23 -0800 Comment on attachment 83682 Patch to delete unneeded PatternAlternative r=me 357193 3 msaboff 2011-02-24 11:25:56 -0800 Committed r79594: <http://trac.webkit.org/changeset/79594> 357242 4 83682 darin 2011-02-24 11:58:14 -0800 Comment on attachment 83682 Patch to delete unneeded PatternAlternative View in context: https://bugs.webkit.org/attachment.cgi?id=83682&action=review > Source/JavaScriptCore/yarr/YarrPattern.cpp:500 > + PatternAlternative* altToRemove = parenthesesDisjunction->m_alternatives[i]; > parenthesesDisjunction->m_alternatives.remove(i); > + delete altToRemove; A couple post-patch-lading thoughts: I would prefer to do this with OwnPtr instead of an explicit delete. Maybe m_alternatives could actually use OwnPtr. I would also have called it alternativeToRemove instead of altToRemove. 357511 5 webkit.review.bot 2011-02-24 15:59:25 -0800 http://trac.webkit.org/changeset/79594 might have broken GTK Linux 32-bit Release 83682 2011-02-24 11:06:30 -0800 2011-02-24 11:58:14 -0800 Patch to delete unneeded PatternAlternative 55156.patch text/plain 1495 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzk1OTEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDItMjQgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGF0dGVybkFsdGVybmF0 aXZlIGxlYWtlZCBpbiBZYXJyUGF0dGVybkNvbnN0cnVjdG9yOjphdG9tUGFyZW50aGVzZXNFbmQo KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUxNTYK KworICAgICAgICBBZGRlZCBjb2RlIHRvIGRlbGV0ZSB1bm5lZWRlZCBQYXR0ZXJuQWx0ZXJuYXRp dmUgYWZ0ZXIgaXQgaXMgcmVtb3ZlZAorICAgICAgICBmcm9tIG1fYWx0ZXJuYXRpdmVzIFZlY3Rv ci4KKworICAgICAgICAqIHlhcnIvWWFyclBhdHRlcm4uY3BwOgorICAgICAgICAoSlNDOjpZYXJy OjpZYXJyUGF0dGVybkNvbnN0cnVjdG9yOjphdG9tUGFyZW50aGVzZXNFbmQpOgorCiAyMDExLTAy LTI0ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJy UGF0dGVybi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3lhcnIvWWFy clBhdHRlcm4uY3BwCShyZXZpc2lvbiA3OTU2NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS95 YXJyL1lhcnJQYXR0ZXJuLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDk1LDcgKzQ5NSw5IEBAIHB1 YmxpYzoKIAogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbnVtUGFyZW5BbHRlcm5h dGl2ZXM7IGkrKykgewogICAgICAgICAgICAgaWYgKCFwYXJlbnRoZXNlc0Rpc2p1bmN0aW9uLT5t X2FsdGVybmF0aXZlc1tpXS0+bV90ZXJtcy5zaXplKCkgJiYgbnVtUGFyZW5BbHRlcm5hdGl2ZXMg PiAxKSB7CisgICAgICAgICAgICAgICAgUGF0dGVybkFsdGVybmF0aXZlKiBhbHRUb1JlbW92ZSA9 IHBhcmVudGhlc2VzRGlzanVuY3Rpb24tPm1fYWx0ZXJuYXRpdmVzW2ldOwogICAgICAgICAgICAg ICAgIHBhcmVudGhlc2VzRGlzanVuY3Rpb24tPm1fYWx0ZXJuYXRpdmVzLnJlbW92ZShpKTsKKyAg ICAgICAgICAgICAgICBkZWxldGUgYWx0VG9SZW1vdmU7CiAgICAgICAgICAgICAgICAgLS1udW1Q YXJlbkFsdGVybmF0aXZlczsKIAogICAgICAgICAgICAgICAgIGNvbnRhaW5zRW1wdHlBbHRlcm5h dGl2ZSA9IHRydWU7Cg==