5514 2005-10-26 09:58:55 -0700 Date conversion to local time gets the DST flag wrong for some dates 2005-11-30 05:26:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 VERIFIED FIXED P2 Normal --- 1 mitz mjs oldest_to_newest 23000 0 mitz 2005-10-26 09:58:55 -0700 For dates before 1970-01-01 00:00 UTC, conversion to local time takes the DST flag from the same day in a different year. This leads to incorrect results in many cases, since DST cutoff dates are not the same every year. The test case demonstrates this for several time zones: now that bug 4142 is fixed, "new Date(y,m,d)" works as expected, but the conversion back to local time is wrong due to using DST status from the same date in 2002. Since the fix for bug 4142 involves passing negative and large positive values to localtime_r(), I'm not sure why the same isn't done in DateProtoFuncImp::callAsFunction(). 23001 1 4484 mitz 2005-10-26 10:00:03 -0700 Created attachment 4484 Testcase 23007 2 ggaren 2005-10-26 14:17:11 -0700 Mitz mentioned on IRC that eliminating the yearOffset hack fixes this bug. But that would make the code slightly less portable. 23111 3 4506 mitz 2005-10-28 03:08:25 -0700 Created attachment 4506 Apply the realYearOffset hack only when absolutely necessary 23113 4 4506 mitz 2005-10-28 03:11:03 -0700 Comment on attachment 4506 Apply the realYearOffset hack only when absolutely necessary Haven't tested it on any platform other than PPC OS X. 23126 5 4506 darin 2005-10-28 10:42:59 -0700 Comment on attachment 4506 Apply the realYearOffset hack only when absolutely necessary This line of code: +const bool time_tIsSigned = isTime_tSigned(); will result in code run at load time. We don't allow that in JavaScriptCore and WebCore. We'll need an alternate approach that does the same thing without a global that requires executing code at library load time. 23135 6 4510 mitz 2005-10-28 13:49:32 -0700 Created attachment 4510 Apply the realYearOffset hack only when absolutely necessary Initialize time_t limits only the first time they're actually needed. 23143 7 ggaren 2005-10-28 17:25:12 -0700 Here's an idea: static bool isTime_tSigned() { time_t minusOne == -1; return minusOne < 0; } 23144 8 ggaren 2005-10-28 17:26:37 -0700 (In reply to comment #7) s/==/=/ 23146 9 4510 darin 2005-10-28 18:25:05 -0700 Comment on attachment 4510 Apply the realYearOffset hack only when absolutely necessary Looks good. r=me 23154 10 mitz 2005-10-29 01:37:00 -0700 (In reply to comment #7) > Here's an idea: > time_t minusOne = -1; Clever! But the above will give a compiler warning if time_t is unsigned. This should work: time_t minusOne = (time_t)(-1); 23155 11 4517 mitz 2005-10-29 01:46:45 -0700 Created attachment 4517 Better patch 23156 12 4517 mitz 2005-10-29 01:48:32 -0700 Comment on attachment 4517 Better patch Did as Geoffrey suggested 4484 2005-10-26 10:00:03 -0700 2005-10-26 10:00:03 -0700 Testcase date-DST-pre-1970.html text/html 1092 mitz PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgpmdW5jdGlvbiBwcmludChtZXNzYWdlKSB7CiAgICB2YXIg cGFyYWdyYXBoID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgicCIpOwogICAgcGFyYWdyYXBoLmFw cGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2UpKTsKICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIikuYXBwZW5kQ2hpbGQocGFyYWdyYXBoKTsKfQoKZnVu Y3Rpb24gdGVzdCgpIHsKICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKICAg ICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CiAgICB9CgogICAgdmFyIGRh dGVzID0gWwogICAgICAgIG5ldyBEYXRlKDE5NzAsIDAsIDEpLCAgIC8vIGZhaWxzIGluIE5aCiAg ICAgICAgbmV3IERhdGUoMTk2OSwgOCwgMSksICAgLy8gZmFpbHMgaW4gQ0VULCBBc2lhL0plcnVz YWxlbQogICAgICAgIG5ldyBEYXRlKDE5NjksIDksIDI4KSwgIC8vIGZhaWxzIGluIFVTL0Vhc3Rl cm4sIE1vdW50YWluLCBQYWNpZmljLCBDZW50cmFsCiAgICBdOwogICAgd2hpbGUgKGQgPSBkYXRl cy5zaGlmdCgpKSB7CiAgICAgICAgaWYgKGQuZ2V0SG91cnMoKSAhPSAwKSB7CiAgICAgICAgICAg IHByaW50KCJGQUlMRUQ6ICIgKyBkKTsKICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgfQogICAg fQogICAgaWYgKCFkKQogICAgICAgIHByaW50KCJOb3RoaW5nIGZhaWxlZC4gUGVyaGFwcyB0aGlz IHRlc3QgZG9lcyBub3QgY292ZXIgeW91ciB0aW1lIHpvbmUhIENvdmVyZWQgem9uZXMgaW5jbHVk ZSBVUy9QYWNpZmljLCBVUy9DZW50cmFsLCBVUy9Nb3VudGFpbiwgVVMvRWFzdGVybiwgQ0VULCBB c2lhL0plcnVzYWxlbSBhbmQgTlouIik7Cn0KPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHkgb25sb2Fk PSJ0ZXN0KCk7Ij4KPHA+VGhpcyB0ZXN0cyB0aGUgRFNUIHN0YXR1cyBpbiBkYXRlcyBlYXJsaWVy IHRoYW4gMTk3MC0wMS0wMSAwMDowMCBVVEMuIFJlZ2FyZGxlc3Mgb2YgeW91ciB0aW1lIHpvbmUs IGl0IHNob3VsZCBub3QgZmFpbC48L3A+Cjxocj4KPGRpdiBpZD0nY29uc29sZScvPgo8L2JvZHk+ CjwvaHRtbD4K 4506 2005-10-28 03:08:25 -0700 2005-10-28 13:49:32 -0700 Apply the realYearOffset hack only when absolutely necessary 5514_r1.patch text/plain 1378 mitz SW5kZXg6IGtqcy9kYXRlX29iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290 L0phdmFTY3JpcHRDb3JlL2tqcy9kYXRlX29iamVjdC5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuNjIKZGlmZiAtcCAtdSAtcjEuNjIgZGF0ZV9vYmplY3QuY3BwCi0tLSBranMvZGF0ZV9vYmpl Y3QuY3BwCTI0IE9jdCAyMDA1IDIwOjQ1OjU5IC0wMDAwCTEuNjIKKysrIGtqcy9kYXRlX29iamVj dC5jcHAJMjggT2N0IDIwMDUgMTA6MDk6NDcgLTAwMDAKQEAgLTEzMCw2ICsxMzAsMTcgQEAgc3Rh dGljIGRvdWJsZSBtYWtlVGltZSh0bSAqLCBkb3VibGUgbXMsIAogc3RhdGljIGRvdWJsZSBwYXJz ZURhdGUoY29uc3QgVVN0cmluZyAmKTsKIHN0YXRpYyBkb3VibGUgdGltZUNsaXAoZG91YmxlKTsK IAorc3RhdGljIGJvb2wgaXNUaW1lX3RTaWduZWQoKQoreworICAgIHRpbWVfdCBtaW51c09uZSA9 ICh0aW1lX3QpKC0xKTsKKyAgICB0bSAqdCA9IGdtdGltZSgmbWludXNPbmUpOworICAgIHJldHVy biB0LT50bV95ZWFyID09IDY5OworfQorCitjb25zdCBib29sIHRpbWVfdElzU2lnbmVkID0gaXNU aW1lX3RTaWduZWQoKTsKK2NvbnN0IGRvdWJsZSB0aW1lX3RNaW4gPSAodGltZV90SXNTaWduZWQg PyAtIChkb3VibGUpKDFVTEwgPDwgKDggKiBzaXplb2YodGltZV90KSAtIDEpKSA6IDApOworY29u c3QgZG91YmxlIHRpbWVfdE1heCA9ICh0aW1lX3RJc1NpZ25lZCA/ICgxVUxMIDw8IDggKiBzaXpl b2YodGltZV90KSAtIDEpIC0gMSA6IDIgKiAoZG91YmxlKSgxVUxMIDw8IDggKiBzaXplb2YodGlt ZV90KSAtIDEpIC0gMSk7CisKICNpZiBfX0FQUExFX18KIAogc3RhdGljIENGRGF0ZUZvcm1hdHRl clN0eWxlIHN0eWxlRnJvbUFyZ1N0cmluZyhjb25zdCBVU3RyaW5nJiBzdHJpbmcsIENGRGF0ZUZv cm1hdHRlclN0eWxlIGRlZmF1bHRTdHlsZSkKQEAgLTUyNiw3ICs1MzcsNyBAQCBWYWx1ZUltcCAq RGF0ZVByb3RvRnVuY0ltcDo6Y2FsbEFzRnVuY3RpCiAgIGRvdWJsZSBtaWxsaU9mZnNldCA9IDAu MDsKICAgZG91YmxlIHNlY3MgPSBmbG9vcihtaWxsaSAvIG1zUGVyU2Vjb25kKTsKIAotICBpZiAo bWlsbGkgPCAwIHx8IG1pbGxpID49IHRpbWVGcm9tWWVhcigyMDM4KSkgeworICBpZiAoc2VjcyA8 IHRpbWVfdE1pbiB8fCBzZWNzID4gdGltZV90TWF4KSB7CiAgICAgLy8gIyMjIHVnbHkgYW5kIHBy b2JhYmx5IG5vdCB2ZXJ5IHByZWNpc2UKICAgICBpbnQgcmVhbFllYXIgPSB5ZWFyRnJvbVRpbWUo bWlsbGkpOwogICAgIGludCBiYXNlID0gZGF5c0luWWVhcihyZWFsWWVhcikgPT0gMzY1ID8gMjAw MSA6IDIwMDA7Cg== 4510 2005-10-28 13:49:32 -0700 2005-10-29 11:55:52 -0700 Apply the realYearOffset hack only when absolutely necessary 5514_r2.patch text/plain 1537 mitz SW5kZXg6IGtqcy9kYXRlX29iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290 L0phdmFTY3JpcHRDb3JlL2tqcy9kYXRlX29iamVjdC5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuNjIKZGlmZiAtcCAtdSAtcjEuNjIgZGF0ZV9vYmplY3QuY3BwCi0tLSBranMvZGF0ZV9vYmpl Y3QuY3BwCTI0IE9jdCAyMDA1IDIwOjQ1OjU5IC0wMDAwCTEuNjIKKysrIGtqcy9kYXRlX29iamVj dC5jcHAJMjggT2N0IDIwMDUgMjA6NDA6NTUgLTAwMDAKQEAgLTQ2OSw2ICs0NjksMTMgQEAgYm9v bCBEYXRlUHJvdG9GdW5jSW1wOjppbXBsZW1lbnRzQ2FsbCgpIAogICAgIHJldHVybiB0cnVlOwog fQogCitzdGF0aWMgYm9vbCBpc1RpbWVfdFNpZ25lZCgpCit7CisgICAgdGltZV90IG1pbnVzT25l ID0gKHRpbWVfdCkoLTEpOworICAgIHRtICp0ID0gZ210aW1lKCZtaW51c09uZSk7CisgICAgcmV0 dXJuIHQtPnRtX3llYXIgPT0gNjk7Cit9CisKIFZhbHVlSW1wICpEYXRlUHJvdG9GdW5jSW1wOjpj YWxsQXNGdW5jdGlvbihFeGVjU3RhdGUgKmV4ZWMsIE9iamVjdEltcCAqdGhpc09iaiwgY29uc3Qg TGlzdCAmYXJncykKIHsKICAgaWYgKChpZCA9PSBUb1N0cmluZyB8fCBpZCA9PSBWYWx1ZU9mIHx8 IGlkID09IEdldFRpbWUgfHwgaWQgPT0gU2V0VGltZSkgJiYKQEAgLTUyMiwxMSArNTI5LDE0IEBA IFZhbHVlSW1wICpEYXRlUHJvdG9GdW5jSW1wOjpjYWxsQXNGdW5jdGkKICAgCiAgIC8vIGNoZWNr IHdoZXRoZXIgdGltZSB2YWx1ZSBpcyBvdXRzaWRlIHRpbWVfdCdzIHVzdWFsIHJhbmdlCiAgIC8v IG1ha2UgdGhlIG5lY2Vzc2FyeSB0cmFuc2Zvcm1hdGlvbnMgaWYgbmVjZXNzYXJ5CisgIHN0YXRp YyBib29sIHRpbWVfdElzU2lnbmVkID0gaXNUaW1lX3RTaWduZWQoKTsKKyAgc3RhdGljIGRvdWJs ZSB0aW1lX3RNaW4gPSAodGltZV90SXNTaWduZWQgPyAtIChkb3VibGUpKDFVTEwgPDwgKDggKiBz aXplb2YodGltZV90KSAtIDEpKSA6IDApOworICBzdGF0aWMgZG91YmxlIHRpbWVfdE1heCA9ICh0 aW1lX3RJc1NpZ25lZCA/ICgxVUxMIDw8IDggKiBzaXplb2YodGltZV90KSAtIDEpIC0gMSA6IDIg KiAoZG91YmxlKSgxVUxMIDw8IDggKiBzaXplb2YodGltZV90KSAtIDEpIC0gMSk7CiAgIGludCBy ZWFsWWVhck9mZnNldCA9IDA7CiAgIGRvdWJsZSBtaWxsaU9mZnNldCA9IDAuMDsKICAgZG91Ymxl IHNlY3MgPSBmbG9vcihtaWxsaSAvIG1zUGVyU2Vjb25kKTsKIAotICBpZiAobWlsbGkgPCAwIHx8 IG1pbGxpID49IHRpbWVGcm9tWWVhcigyMDM4KSkgeworICBpZiAoc2VjcyA8IHRpbWVfdE1pbiB8 fCBzZWNzID4gdGltZV90TWF4KSB7CiAgICAgLy8gIyMjIHVnbHkgYW5kIHByb2JhYmx5IG5vdCB2 ZXJ5IHByZWNpc2UKICAgICBpbnQgcmVhbFllYXIgPSB5ZWFyRnJvbVRpbWUobWlsbGkpOwogICAg IGludCBiYXNlID0gZGF5c0luWWVhcihyZWFsWWVhcikgPT0gMzY1ID8gMjAwMSA6IDIwMDA7Cg== 4517 2005-10-29 01:46:45 -0700 2005-10-29 11:55:42 -0700 Better patch 5514_r3.patch text/plain 1501 mitz SW5kZXg6IGtqcy9kYXRlX29iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290 L0phdmFTY3JpcHRDb3JlL2tqcy9kYXRlX29iamVjdC5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuNjIKZGlmZiAtcCAtdSAtcjEuNjIgZGF0ZV9vYmplY3QuY3BwCi0tLSBranMvZGF0ZV9vYmpl Y3QuY3BwCTI0IE9jdCAyMDA1IDIwOjQ1OjU5IC0wMDAwCTEuNjIKKysrIGtqcy9kYXRlX29iamVj dC5jcHAJMjkgT2N0IDIwMDUgMDg6NDQ6NDEgLTAwMDAKQEAgLTQ2OSw2ICs0NjksMTIgQEAgYm9v bCBEYXRlUHJvdG9GdW5jSW1wOjppbXBsZW1lbnRzQ2FsbCgpIAogICAgIHJldHVybiB0cnVlOwog fQogCitzdGF0aWMgYm9vbCBpc1RpbWVfdFNpZ25lZCgpCit7CisgICAgdGltZV90IG1pbnVzT25l ID0gKHRpbWVfdCkoLTEpOworICAgIHJldHVybiBtaW51c09uZSA8IDA7Cit9CisKIFZhbHVlSW1w ICpEYXRlUHJvdG9GdW5jSW1wOjpjYWxsQXNGdW5jdGlvbihFeGVjU3RhdGUgKmV4ZWMsIE9iamVj dEltcCAqdGhpc09iaiwgY29uc3QgTGlzdCAmYXJncykKIHsKICAgaWYgKChpZCA9PSBUb1N0cmlu ZyB8fCBpZCA9PSBWYWx1ZU9mIHx8IGlkID09IEdldFRpbWUgfHwgaWQgPT0gU2V0VGltZSkgJiYK QEAgLTUyMiwxMSArNTI4LDE0IEBAIFZhbHVlSW1wICpEYXRlUHJvdG9GdW5jSW1wOjpjYWxsQXNG dW5jdGkKICAgCiAgIC8vIGNoZWNrIHdoZXRoZXIgdGltZSB2YWx1ZSBpcyBvdXRzaWRlIHRpbWVf dCdzIHVzdWFsIHJhbmdlCiAgIC8vIG1ha2UgdGhlIG5lY2Vzc2FyeSB0cmFuc2Zvcm1hdGlvbnMg aWYgbmVjZXNzYXJ5CisgIHN0YXRpYyBib29sIHRpbWVfdElzU2lnbmVkID0gaXNUaW1lX3RTaWdu ZWQoKTsKKyAgc3RhdGljIGRvdWJsZSB0aW1lX3RNaW4gPSAodGltZV90SXNTaWduZWQgPyAtIChk b3VibGUpKDFVTEwgPDwgKDggKiBzaXplb2YodGltZV90KSAtIDEpKSA6IDApOworICBzdGF0aWMg ZG91YmxlIHRpbWVfdE1heCA9ICh0aW1lX3RJc1NpZ25lZCA/ICgxVUxMIDw8IDggKiBzaXplb2Yo dGltZV90KSAtIDEpIC0gMSA6IDIgKiAoZG91YmxlKSgxVUxMIDw8IDggKiBzaXplb2YodGltZV90 KSAtIDEpIC0gMSk7CiAgIGludCByZWFsWWVhck9mZnNldCA9IDA7CiAgIGRvdWJsZSBtaWxsaU9m ZnNldCA9IDAuMDsKICAgZG91YmxlIHNlY3MgPSBmbG9vcihtaWxsaSAvIG1zUGVyU2Vjb25kKTsK IAotICBpZiAobWlsbGkgPCAwIHx8IG1pbGxpID49IHRpbWVGcm9tWWVhcigyMDM4KSkgeworICBp ZiAoc2VjcyA8IHRpbWVfdE1pbiB8fCBzZWNzID4gdGltZV90TWF4KSB7CiAgICAgLy8gIyMjIHVn bHkgYW5kIHByb2JhYmx5IG5vdCB2ZXJ5IHByZWNpc2UKICAgICBpbnQgcmVhbFllYXIgPSB5ZWFy RnJvbVRpbWUobWlsbGkpOwogICAgIGludCBiYXNlID0gZGF5c0luWWVhcihyZWFsWWVhcikgPT0g MzY1ID8gMjAwMSA6IDIwMDA7Cg==