55139 2011-02-24 06:38:43 -0800 [Qt] Remove bogus optimizations in TextBreakIteratorQt 2011-05-27 02:09:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling christopher.reiss hausmann qt stawel oldest_to_newest 356939 0 kling 2011-02-24 06:38:43 -0800 TextBreakIteratorQt is currently quite broken, see bug 46695 for more details. While we wait for an ideal fix, let's remove the optimizations that are causing the crashiness. 356941 1 83646 kling 2011-02-24 06:40:08 -0800 Created attachment 83646 Proposed patch 356956 2 hausmann 2011-02-24 07:01:18 -0800 For the record: Move the deep string copy until after the comparision fails, to avoid a deep copy when we hit the "cache" :) 356968 3 kling 2011-02-24 07:17:31 -0800 (In reply to comment #2) > For the record: Move the deep string copy until after the comparision fails, to avoid a deep copy when we hit the "cache" :) I'm a stupidface. Of course. :) 357001 4 kling 2011-02-24 08:09:34 -0800 Committed r79567: <http://trac.webkit.org/changeset/79567> 357874 5 kling 2011-02-25 06:22:43 -0800 *** Bug 55215 has been marked as a duplicate of this bug. *** 411290 6 kling 2011-05-27 02:09:12 -0700 *** Bug 61619 has been marked as a duplicate of this bug. *** 83646 2011-02-24 06:40:08 -0800 2011-02-24 06:58:29 -0800 Proposed patch bug-55139.diff text/plain 2826 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMjU2Nzc0Li5hYWM5N2Y0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDItMjQgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVtb3ZlIGJv Z3VzIG9wdGltaXphdGlvbnMgaW4gVGV4dEJyZWFrSXRlcmF0b3JRdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUxMzkKKworICAgICAgICBMZXQgUVRl eHRCb3VuZGFyeUZpbmRlciBob2xkIGEgZGVlcCBjb3B5IG9mIHRoZSBzdHJpbmcgZGF0YSBpdCdz CisgICAgICAgIG9wZXJhdGluZyBvbiwgYW5kIGRvbid0IHVzZSB0aGUgc2FtZSB3b3JraW5nIGJ1 ZmZlciBmb3IgYWxsIGl0ZXJhdG9ycy4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvcXQvVGV4 dEJyZWFrSXRlcmF0b3JRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0QnJlYWtJdGVyYXRv cjo6VGV4dEJyZWFrSXRlcmF0b3IpOgorICAgICAgICAoV2ViQ29yZTo6c2V0VXBJdGVyYXRvcik6 CisKIDIwMTEtMDItMjQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3RleHQvcXQvVGV4dEJyZWFrSXRlcmF0b3JRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS90ZXh0L3F0L1RleHRCcmVha0l0ZXJhdG9yUXQuY3BwCmluZGV4IGI5ZjVhOWUuLjIw MTYzMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvcXQvVGV4dEJy ZWFrSXRlcmF0b3JRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9xdC9U ZXh0QnJlYWtJdGVyYXRvclF0LmNwcApAQCAtMzksMzYgKzM5LDI5IEBAIGNvbnN0IGNoYXIqIGN1 cnJlbnRUZXh0QnJlYWtMb2NhbGVJRCgpCiAgICAgcmV0dXJuIFFMb2NhbGU6OnN5c3RlbSgpLm5h bWUoKS50b0xhdGluMSgpOwogfQogI2Vsc2UKLSAgICBzdGF0aWMgdW5zaWduZWQgY2hhciBidWZm ZXJbMTAyNF07Ci0KICAgICBjbGFzcyBUZXh0QnJlYWtJdGVyYXRvciA6IHB1YmxpYyBRVGV4dEJv dW5kYXJ5RmluZGVyIHsKICAgICBwdWJsaWM6Ci0gICAgICAgIFRleHRCcmVha0l0ZXJhdG9yKFFU ZXh0Qm91bmRhcnlGaW5kZXI6OkJvdW5kYXJ5VHlwZSB0eXBlLCBjb25zdCBVQ2hhciogc3RyaW5n LCBpbnQgbGVuZ3RoKQotICAgICAgICAgICAgOiBRVGV4dEJvdW5kYXJ5RmluZGVyKHR5cGUsIChj b25zdCBRQ2hhciopc3RyaW5nLCBsZW5ndGgsIGJ1ZmZlciwgc2l6ZW9mKGJ1ZmZlcikpCi0gICAg ICAgICAgICAsIGxlbmd0aChsZW5ndGgpCi0gICAgICAgICAgICAsIHN0cmluZyhzdHJpbmcpIHt9 CisgICAgICAgIFRleHRCcmVha0l0ZXJhdG9yKFFUZXh0Qm91bmRhcnlGaW5kZXI6OkJvdW5kYXJ5 VHlwZSB0eXBlLCBjb25zdCBRU3RyaW5nJiBzdHJpbmcpCisgICAgICAgICAgICA6IFFUZXh0Qm91 bmRhcnlGaW5kZXIodHlwZSwgc3RyaW5nKQorICAgICAgICB7IH0KICAgICAgICAgVGV4dEJyZWFr SXRlcmF0b3IoKQogICAgICAgICAgICAgOiBRVGV4dEJvdW5kYXJ5RmluZGVyKCkKLSAgICAgICAg ICAgICwgbGVuZ3RoKDApCi0gICAgICAgICAgICAsIHN0cmluZygwKSB7fQotCi0gICAgICAgIGlu dCBsZW5ndGg7Ci0gICAgICAgIGNvbnN0IFVDaGFyKiBzdHJpbmc7CisgICAgICAgIHsgfQogICAg IH07CiAKLSAgICBUZXh0QnJlYWtJdGVyYXRvciogc2V0VXBJdGVyYXRvcihUZXh0QnJlYWtJdGVy YXRvciYgaXRlcmF0b3IsIFFUZXh0Qm91bmRhcnlGaW5kZXI6OkJvdW5kYXJ5VHlwZSB0eXBlLCBj b25zdCBVQ2hhciogc3RyaW5nLCBpbnQgbGVuZ3RoKQorICAgIFRleHRCcmVha0l0ZXJhdG9yKiBz ZXRVcEl0ZXJhdG9yKFRleHRCcmVha0l0ZXJhdG9yJiBpdGVyYXRvciwgUVRleHRCb3VuZGFyeUZp bmRlcjo6Qm91bmRhcnlUeXBlIHR5cGUsIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzLCBpbnQgbGVu Z3RoKQogICAgIHsKLSAgICAgICAgaWYgKCFzdHJpbmcgfHwgIWxlbmd0aCkKKyAgICAgICAgaWYg KCFjaGFyYWN0ZXJzIHx8ICFsZW5ndGgpCiAgICAgICAgICAgICByZXR1cm4gMDsKIAotICAgICAg ICBpZiAoaXRlcmF0b3IuaXNWYWxpZCgpICYmIHR5cGUgPT0gaXRlcmF0b3IudHlwZSgpICYmIGxl bmd0aCA9PSBpdGVyYXRvci5sZW5ndGgKLSAgICAgICAgICAgICYmIG1lbWNtcChzdHJpbmcsIGl0 ZXJhdG9yLnN0cmluZywgbGVuZ3RoKSA9PSAwKSB7CisgICAgICAgIFFTdHJpbmcgc3RyaW5nKHJl aW50ZXJwcmV0X2Nhc3Q8Y29uc3QgUUNoYXIqPihjaGFyYWN0ZXJzKSwgbGVuZ3RoKTsKKworICAg ICAgICBpZiAoaXRlcmF0b3IuaXNWYWxpZCgpICYmIHR5cGUgPT0gaXRlcmF0b3IudHlwZSgpICYm IGl0ZXJhdG9yLnN0cmluZygpID09IHN0cmluZykgewogICAgICAgICAgICAgaXRlcmF0b3IudG9T dGFydCgpOwogICAgICAgICAgICAgcmV0dXJuICZpdGVyYXRvcjsKICAgICAgICAgfQogCi0gICAg ICAgIGl0ZXJhdG9yID0gVGV4dEJyZWFrSXRlcmF0b3IodHlwZSwgc3RyaW5nLCBsZW5ndGgpOwot CisgICAgICAgIGl0ZXJhdG9yID0gVGV4dEJyZWFrSXRlcmF0b3IodHlwZSwgc3RyaW5nKTsKICAg ICAgICAgcmV0dXJuICZpdGVyYXRvcjsKICAgICB9CiAK