55134 2011-02-24 05:08:02 -0800 [chromium] WebFrameImpl::m_totalMatchCount should be an int 2011-02-26 00:59:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 johnme webkit-unassigned benjamin commit-queue steveblock oldest_to_newest 356897 0 johnme 2011-02-24 05:08:02 -0800 [chromium] WebFrameImpl::m_totalMatchCount should be an int 356899 1 83637 johnme 2011-02-24 05:09:48 -0800 Created attachment 83637 Patch 356946 2 benjamin 2011-02-24 06:45:24 -0800 No test possible? 356954 3 johnme 2011-02-24 06:57:29 -0800 This is just a trivial cleanup - the variable is documented as sometimes being -1, and is indeed initialized to -1 by the constructor, so shouldn't be using an unsigned type. In practice this won't change any behavior as the code happens to never depend on the signedness, hence it would be tricky to test. 357119 4 83637 johnme 2011-02-24 09:53:10 -0800 Comment on attachment 83637 Patch Thanks for the review. Could someone add this to the commit queue please? 357340 5 83637 eric 2011-02-24 13:38:51 -0800 Comment on attachment 83637 Patch How do we test this? 357812 6 steveblock 2011-02-25 03:20:47 -0800 > How do we test this? As John suggested, this is a trivial fix and the current behaviour is OK, so I don't think it's valuable to try to craft a regression test. 358425 7 83637 commit-queue 2011-02-26 00:59:54 -0800 Comment on attachment 83637 Patch Clearing flags on attachment: 83637 Committed r79767: <http://trac.webkit.org/changeset/79767> 358426 8 commit-queue 2011-02-26 00:59:59 -0800 All reviewed patches have been landed. Closing bug. 83637 2011-02-24 05:09:48 -0800 2011-02-26 00:59:53 -0800 Patch bug-55134-20110224130946.patch text/plain 1506 johnme U3VidmVyc2lvbiBSZXZpc2lvbjogNzk1NDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZGQyNTY0MjczMzVkZDI1ZWEyZTg5YTkwZDI2YTBkZTg2ODk0MTgzNy4uYWU0NTlkN2RkNTQ1ZTBk ZDc4MGZjMDZkMzU4ODhiZDUyYzFhMmUwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0wMi0yNCAgSm9obiBNZWxsb3IgIDxqb2hubWVAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gV2ViRnJhbWVJbXBsOjptX3RvdGFsTWF0Y2hDb3VudCBzaG91bGQgYmUgYW4gaW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTEzNAor CisgICAgICAgIFdlYkZyYW1lSW1wbDo6bV90b3RhbE1hdGNoQ291bnQgc2hvdWxkIGJlIGFuIGlu dCBpbnN0ZWFkIG9mIGEgc2l6ZV90IHNpbmNlIGl0IGNhbiBiZSAtMS4KKworICAgICAgICAqIHNy Yy9XZWJGcmFtZUltcGwuaDoKKwogMjAxMS0wMi0yNCAgUm9iZXJ0IEtyb2VnZXIgPHJqa3JvZWdl QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCmluZGV4IDU1YTlmNTRjN2VlYjdk ZGYzZmQ0MTYyNzE2Y2MzMDZmZjRkMDI0MWQuLjY1Njk4Y2Q1MWEzZWZkY2M3MmQyZGE5ZGM3OGEz OTczN2RjMWM5ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZy YW1lSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5o CkBAIC0zNjIsNyArMzYyLDcgQEAgcHJpdmF0ZToKICAgICAvLyBUaGlzIHZhcmlhYmxlIGtlZXBz IGEgY3VtdWxhdGl2ZSB0b3RhbCBvZiBtYXRjaGVzIGZvdW5kIHNvIGZhciBmb3IgQUxMIHRoZQog ICAgIC8vIGZyYW1lcyBvbiB0aGUgcGFnZSwgYW5kIGlzIG9ubHkgaW5jcmVtZW50ZWQgYnkgY2Fs bGluZyBJbmNyZWFzZU1hdGNoQ291bnQKICAgICAvLyAob24gdGhlIG1haW4gZnJhbWUgb25seSku IEl0IHNob3VsZCBiZSAtMSBmb3IgYWxsIG90aGVyIGZyYW1lcy4KLSAgICBzaXplX3QgbV90b3Rh bE1hdGNoQ291bnQ7CisgICAgaW50IG1fdG90YWxNYXRjaENvdW50OwogCiAgICAgLy8gVGhpcyB2 YXJpYWJsZSBrZWVwcyBhIGN1bXVsYXRpdmUgdG90YWwgb2YgaG93IG1hbnkgZnJhbWVzIGFyZSBj dXJyZW50bHkKICAgICAvLyBzY29waW5nLCBhbmQgaXMgaW5jcmVtZW50ZWQvZGVjcmVtZW50ZWQg b24gdGhlIG1haW4gZnJhbWUgb25seS4K