55121 2011-02-24 00:46:59 -0800 French (fr) sorting does not use 'backward' rule any more with ICU 4.6 2011-02-28 13:43:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jshin jshin commit-queue morrita tony oldest_to_newest 356734 0 jshin 2011-02-24 00:46:59 -0800 French (fr_FR and many fr_FOO other than fr_CA) sorting does not use 'backward first accent weighting' rules any more. Thus, CLDR 1.9 and ICU 4.6 have different sorting for fr_FOO (where FOO !=CA) and fr_CA. fast/xsl/sort-locale has the expectation that treats both the same. Because other ports of Webkit still use old rules while Chrome with ICU 4.6 uses new rules, the expected result should go in platform/chromium. I'm making a patch. 356744 1 morrita 2011-02-24 01:07:36 -0800 Thank you for filing this! I've also filed Bug 55118 so Could you close it after fix this? 357180 2 tony 2011-02-24 11:06:50 -0800 *** Bug 55118 has been marked as a duplicate of this bug. *** 358301 3 83903 jshin 2011-02-25 17:25:25 -0800 Created attachment 83903 add chromium-specific expectation file 358308 4 83904 jshin 2011-02-25 17:37:17 -0800 Created attachment 83904 same as above but a diff from the main expectation to be made clear using 'svn cp' 359119 5 tony 2011-02-28 09:44:07 -0800 Should there also be an updated to test_expectations.txt? 359133 6 83904 commit-queue 2011-02-28 10:02:22 -0800 Comment on attachment 83904 same as above but a diff from the main expectation to be made clear using 'svn cp' Rejecting attachment 83904 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: ebkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 2 Parsed 3 diffs from patch file(s). cp: fast/xsl/sort-locale-expected.txt: No such file or directory Failed to copy fast/xsl/sort-locale-expected.txt platform/chromium/fast/xsl/sort-locale-expected.txt. at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 427. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 2 Full output: http://queues.webkit.org/results/8070423 359209 7 tony 2011-02-28 11:46:03 -0800 (In reply to comment #6) > Parsed 3 diffs from patch file(s). > cp: fast/xsl/sort-locale-expected.txt: No such file or directory > Failed to copy fast/xsl/sort-locale-expected.txt platform/chromium/fast/xsl/sort-locale-expected.txt. at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 427. > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 2 > > Full output: http://queues.webkit.org/results/8070423 The diff around the copy looks weird (it's relative to a different path than the other 2 files). 359309 8 jshin 2011-02-28 13:43:52 -0800 Thank you for the review. The patch creating script does something strange in this case. Anyway, I manually landed the patch with the correct path. ( http://trac.webkit.org/changeset/79912 ). Later, I'll update test_expectations.txt as well. Thank you for the review. The patch creating script does something strange in this case. Anyway, I manually landed the patch with the correct path ( http://trac.webkit.org/changeset/79912 ). I forgot 83903 2011-02-25 17:25:25 -0800 2011-02-25 17:37:17 -0800 add chromium-specific expectation file 55121.patch text/plain 1604 jshin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDc5NzQ3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMjUgIEp1bmdzaGlrIFNoaW4gIDxq c2hpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MTIx CisKKyAgICAgICAgUmVjZW50bHksIEZyZW5jaCBBY2FkZW15IGNoYW5nZWQgdGhlIHNvcnRpbmcg cnVsZXMgZm9yIEZyZW5jaCBpbiAKKyAgICAgICAgc3VjaCBhIHdheSB0aGF0IGFjY2VudHMgYXJl IG5vdCB3ZWlnaHRlZCBmcm9tIHRoZSBlbmQgb2YgYSB3b3JkCisgICAgICAgIGFueSBtb3JlLiBJ Q1UgNC42IC8gQ0xEUiAxLjkgaW5jb3Jwb3JhdGVkIHRoZSBjaGFuZ2UuIENhbmFkaWFuCisgICAg ICAgIEZyZW5jaCBoYXNuJ3QgYWRvcHRlZCB0aGUgY2hhbmdlLCB5ZXQuCisKKyAgICAgICAgQ2hy b21lIGlzIHRoZSBvbmx5IHBvcnQgdGhhdCB1c2VzIG5ldyBydWxlcyB3aXRoIElDVSA0LjYuIFNv LCAKKyAgICAgICAgZm9yIG5vdywgSSdtIGNoYW5naW5nIHRoZSBleHBlY3RhdGlvbiBmaWxlIGZv ciBDaHJvbWUgb25seS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL2Zhc3QveHNsOiBB ZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L3hzbC9zb3J0LWxvY2FsZS1l eHBlY3RlZC50eHQ6IEFkZGVkLgorCiAyMDExLTAyLTI1ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9i aW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBBZGQgdGhlIGZpbmFsIHNldCBvZiBtaXNzaW5n IEdUSysgU1ZHIHBpeGVsIHJlc3VsdHMuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJv bWl1bS9mYXN0L3hzbC9zb3J0LWxvY2FsZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC94c2wvc29ydC1sb2NhbGUtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC94 c2wvc29ydC1sb2NhbGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE4IEBA CitlbgorCitwZWFjaAorcMOpY2jDqQorcMOqY2hlCitzaW4KK2ZyCisKK3BlYWNoCitww6ljaMOp Citww6pjaGUKK3NpbgorZnItQ0EKKworcGVhY2gKK3DDqmNoZQorcMOpY2jDqQorc2luCgpQcm9w ZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L3hzbC9z b3J0LWxvY2FsZS1leHBlY3RlZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBZGRlZDogc3ZuOmVvbC1zdHlsZQog ICArIExGCgo= 83904 2011-02-25 17:37:17 -0800 2011-02-28 10:02:22 -0800 same as above but a diff from the main expectation to be made clear using 'svn cp' 55121.patch.2 text/plain 1687 jshin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDc5NzQ3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMjUgIEp1bmdzaGlrIFNoaW4gIDxq c2hpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MTIx CisKKyAgICAgICAgUmVjZW50bHksIEZyZW5jaCBBY2FkZW15IGNoYW5nZWQgdGhlIHNvcnRpbmcg cnVsZXMgZm9yIEZyZW5jaCBpbiAKKyAgICAgICAgc3VjaCBhIHdheSB0aGF0IGFjY2VudHMgYXJl IG5vdCB3ZWlnaHRlZCBmcm9tIHRoZSBlbmQgb2YgYSB3b3JkCisgICAgICAgIGFueSBtb3JlLiBJ Q1UgNC42IC8gQ0xEUiAxLjkgaW5jb3Jwb3JhdGVkIHRoZSBjaGFuZ2UuIENhbmFkaWFuCisgICAg ICAgIEZyZW5jaCBoYXNuJ3QgYWRvcHRlZCB0aGUgY2hhbmdlLCB5ZXQuCisKKyAgICAgICAgQ2hy b21lIGlzIHRoZSBvbmx5IHBvcnQgdGhhdCB1c2VzIG5ldyBydWxlcyB3aXRoIElDVSA0LjYuIFNv LCAKKyAgICAgICAgZm9yIG5vdywgSSdtIGNoYW5naW5nIHRoZSBleHBlY3RhdGlvbiBmaWxlIGZv ciBDaHJvbWUgb25seS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL2Zhc3QveHNsOiBB ZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L3hzbC9zb3J0LWxvY2FsZS1l eHBlY3RlZC50eHQ6IEFkZGVkLgorCiAyMDExLTAyLTI1ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9i aW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBBZGQgdGhlIGZpbmFsIHNldCBvZiBtaXNzaW5n IEdUSysgU1ZHIHBpeGVsIHJlc3VsdHMuCkluZGV4OiBwbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L3hz bC9zb3J0LWxvY2FsZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZvcm0vY2hyb21p dW0vZmFzdC94c2wvc29ydC1sb2NhbGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA3OTYzOSkJKGZy b20gZmFzdC94c2wvc29ydC1sb2NhbGUtZXhwZWN0ZWQudHh0Ojc5NjM5KQorKysgcGxhdGZvcm0v Y2hyb21pdW0vZmFzdC94c2wvc29ydC1sb2NhbGUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkp CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L3hzbC9zb3J0LWxvY2Fs ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21p dW0vZmFzdC94c2wvc29ydC1sb2NhbGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC94c2wvc29ydC1sb2NhbGUtZXhwZWN0ZWQu dHh0CSh3b3JraW5nIGNvcHkpCkBAIC03LDggKzcsOCBAQCBzaW4KIGZyCiAKIHBlYWNoCi1ww6pj aGUKIHDDqWNow6kKK3DDqmNoZQogc2luCiBmci1DQQogCg==