55120 2011-02-24 00:45:13 -0800 <input value="type=submit"> throws a warning (“HTML parse error”) 2022-08-06 07:46:16 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All OS X 10.6 RESOLVED FIXED data:text/html,<form><input value="type=submit"></form> InRadar P2 Normal --- 1 mathias webkit-unassigned abarth ahmad.saleem792 ap eoconnor eric mathias priyajeet.hora webkit-bug-importer oldest_to_newest 356733 0 mathias 2011-02-24 00:45:13 -0800 Open data:text/html,<form><input value="type=submit"></form> and open the Web Inspector Console. You’ll find that there’s a warning message: “HTML parse error (recovered gracefully)”. There’s nothing wrong with this markup though, so it shouldn’t throw a warning. This used to work fine. The latest stable Safari release, for example (version 5.0.3 / 6533.19.4) didn’t have this problem. 356735 1 mathias 2011-02-24 00:49:33 -0800 Same goes for data:text/html,<form><input name="action|method|enctype"></form> 357342 2 ap 2011-02-24 13:39:13 -0800 This document obviously isn't valid HTML, but I cannot tell what exactly the parser complains about. The warning printed to Web Inspector console is not helpful. 357383 3 abarth 2011-02-24 14:11:40 -0800 Please feel free to remove the warnings. I added them because folks complained about the warnings being missing. 357423 4 mathias 2011-02-24 14:58:32 -0800 (In reply to comment #2) > This document obviously isn't valid HTML, but I cannot tell what exactly the parser complains about. The warning printed to Web Inspector console is not helpful. If you prefix them with <!doctype html><title></title> both documents are perfectly valid. 357427 5 abarth 2011-02-24 15:01:34 -0800 Surely you need <html>, <head>, and <body> tags somewhere. 357433 6 eoconnor 2011-02-24 15:09:18 -0800 Adam: no, Mathias is right; adding the doctype and <title> will do the trick. <html>, <head>, and <body> have optional start and end tags. 357442 7 abarth 2011-02-24 15:14:06 -0800 Ah, ok. 357483 8 ap 2011-02-24 15:44:33 -0800 I think that there are two issues here: 1) What error does our parser think that it sees? No amount of boilerplate around this example seem to make the error go away. 2) The warning message should be improved or removed - it seems unlikely that it can help anyone in its current state (the only bit of information it has is a line number, which doesn't seem sufficient). 357487 9 abarth 2011-02-24 15:46:46 -0800 > 1) What error does our parser think that it sees? No amount of boilerplate around this example seem to make the error go away. If you set a breakpoint in HTMLTreeBuilder::parseError, you'll see the stack that generates the message. From the stack, you can look at the spec to see the instruction to emit a parse error. That will let us diagnose whether the bug is in the spec or in the code. > 2) The warning message should be improved or removed - it seems unlikely that it can help anyone in its current state (the only bit of information it has is a line number, which doesn't seem sufficient). I definitely agree. 357524 10 ap 2011-02-24 16:04:37 -0800 > If you set a breakpoint in HTMLTreeBuilder::parseError, you'll see the stack that generates the message. The stack is: #0 0x1038072c3 in WebCore::HTMLTreeBuilder::parseError at HTMLTreeBuilder.cpp:2809 #1 0x103808345 in WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody at HTMLTreeBuilder.cpp:1563 #2 0x103811e93 in WebCore::HTMLTreeBuilder::processEndTagForInBody at HTMLTreeBuilder.cpp:1991 #3 0x10380eb79 in WebCore::HTMLTreeBuilder::processEndTag at HTMLTreeBuilder.cpp:2103 #4 0x10380e551 in WebCore::HTMLTreeBuilder::processToken at HTMLTreeBuilder.cpp:472 #5 0x103813108 in WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken at HTMLTreeBuilder.cpp:450 #6 0x1038134a2 in WebCore::HTMLTreeBuilder::constructTreeFromToken at HTMLTreeBuilder.cpp:445 #7 0x103796c9e in WebCore::HTMLDocumentParser::pumpTokenizer at HTMLDocumentParser.cpp:269 The node in question is a <body>. It is not easy enough for me to read the spec to see if the code follows it here. 357644 11 abarth 2011-02-24 18:55:53 -0800 That code should match up with <http://www.whatwg.org/specs/web-apps/current-work/#parsing-main-inbody> under "Any other end tag." Specifically: "Otherwise, if node is in the special category, then this is a parse error; ignore the token, and abort these steps." if (isSpecialNode(node)) { parseError(token); return; } From this list <http://www.whatwg.org/specs/web-apps/current-work/#special>, body is a special tag. 357645 12 abarth 2011-02-24 18:56:31 -0800 The bug appears to be that we incorrect omit the "Otherwise" in the spec. 357647 13 83760 abarth 2011-02-24 19:00:20 -0800 Created attachment 83760 Patch 357648 14 83760 abarth 2011-02-24 19:02:25 -0800 Comment on attachment 83760 Patch Nope. That's not it. There's no control flow from the previous if-block that reaches that line. 358638 15 83965 abarth 2011-02-26 22:13:29 -0800 Created attachment 83965 Patch 358639 16 abarth 2011-02-26 22:14:09 -0800 These parse error messages aren't ready for prime time. This patch just nukes them from obit. 358640 17 83965 eric 2011-02-26 22:33:44 -0800 Comment on attachment 83965 Patch Someone recently posted a patch which plumbed all console messages up to the client. That would make these testable. 358642 18 83965 commit-queue 2011-02-26 22:53:37 -0800 Comment on attachment 83965 Patch Clearing flags on attachment: 83965 Committed r79816: <http://trac.webkit.org/changeset/79816> 1889378 19 ahmad.saleem792 2022-08-06 07:45:05 -0700 This was landed as per Comment 18 and never backed-out, I checked by typing bug number in Webkit Github repo. I am going to mark this as "RESOLVED FIXED", if I am incorrect, please mark it accordingly with updated comments. Thanks! 1889379 20 webkit-bug-importer 2022-08-06 07:46:16 -0700 <rdar://problem/98242250> 83760 2011-02-24 19:00:20 -0800 2011-02-24 19:02:25 -0800 Patch bug-55120-20110224190019.patch text/plain 1456 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5NjU3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMjQgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICA8aW5wdXQgdmFsdWU9InR5cGU9c3VibWl0Ij4gdGhyb3dzIGEgd2Fy bmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUx MjAKKworICAgICAgICBXZSdyZSBtaXNzaW5nIGFuICJvdGhlcndpc2UiIGluIHRoZSBzcGVjLCB3 aGljaCBtZWFucyB3ZSBvdXRwdXQgYW4KKyAgICAgICAgZXJyb3IgbWVzc2FnZSB0b28gb2Z0ZW4u ICBUaGUgb25seSBjb25zZXF1ZW5jZSBvZiB0aGlzIGNoYW5nZSBpcyB3aGVuCisgICAgICAgIHdl IG91dHB1dCBlcnJvciBtZXNzYWdlcyBmb3IgcGFyc2luZywgYnV0IHdlIGRvbid0IGhhdmUgYW55 CisgICAgICAgIGluZnJhc3RydWN0dXJlIGZvciB0ZXN0aW5nIHRoZXNlIGVycm9yIG1lc3NhZ2Vz LiAgOigKKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NBbnlPdGhlckVuZFRhZ0Zvcklu Qm9keSk6CisKIDIwMTEtMDItMjQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAJKHJldmlzaW9uIDc5NjU3KQorKysg U291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTU1OCw4ICsxNTU4LDcgQEAgdm9pZCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NB bnlPdGhlckVuZAogICAgICAgICAgICAgfQogICAgICAgICAgICAgbV90cmVlLm9wZW5FbGVtZW50 cygpLT5wb3BVbnRpbFBvcHBlZChub2RlKTsKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAg fQotICAgICAgICBpZiAoaXNTcGVjaWFsTm9kZShub2RlKSkgeworICAgICAgICB9IGVsc2UgaWYg KGlzU3BlY2lhbE5vZGUobm9kZSkpIHsKICAgICAgICAgICAgIHBhcnNlRXJyb3IodG9rZW4pOwog ICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9Cg== 83965 2011-02-26 22:13:29 -0800 2011-02-26 22:53:37 -0800 Patch bug-55120-20110226221328.patch text/plain 1707 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5ODE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMjYgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICA8aW5wdXQgdmFsdWU9InR5cGU9c3VibWl0Ij4gdGhyb3dzIGEgd2Fy bmluZyAo4oCcSFRNTCBwYXJzZSBlcnJvcuKAnSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MTIwCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVz IHBhcnNlIGVycm9yIG1lc3NhZ2VzIGZyb20gdGhlIEhUTUwgcGFyc2VyLiAgVGhlc2UKKyAgICAg ICAgbWVzc2FnZXMgYXJlIGRpc3BsYXllZCBhdCB0aGUgd3JvbmcgdGltZXMsIGFyZW4ndCB0ZXN0 ZWQsIGFuZCBhcmVuJ3QKKyAgICAgICAgaGVscGZ1bC4gIFdlJ2xsIHRyeSBhZ2FpbiB3aXRoIHNv bWUgbW9yZSBpbmZvcm1hdGl2ZSBtZXNzYWdlcyBhbmQKKyAgICAgICAgYmV0dGVyIHRlc3Rpbmcu CisKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVyOjpwYXJzZUVycm9yKToKKwogMjAxMS0wMi0yNiAgUGF0 cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbGV4ZXkgUHJvc2t1cnlha292LgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIv SFRNTFRyZWVCdWlsZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3Bh cnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwCShyZXZpc2lvbiA3OTgxMikKKysrIFNvdXJjZS9XZWJD b3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4 MDYsMTYgKzI4MDYsNiBAQCB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6ZmluaXNoZWQoKQogCiB2b2lk IEhUTUxUcmVlQnVpbGRlcjo6cGFyc2VFcnJvcihBdG9taWNIVE1MVG9rZW4mKQogewotICAgIERF RklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBwYXJzZUVycm9yTWVzc2FnZSwgKCJIVE1MIHBhcnNl IGVycm9yIChyZWNvdmVyZWQgZ3JhY2VmdWxseSkiKSk7Ci0KLSAgICBpZiAoIW1fcmVwb3J0RXJy b3JzKQotICAgICAgICByZXR1cm47Ci0KLSAgICBET01XaW5kb3cqIGRvbVdpbmRvdyA9IG1fZG9j dW1lbnQtPmRvbVdpbmRvdygpOwotICAgIGlmICghZG9tV2luZG93KQotICAgICAgICByZXR1cm47 Ci0KLSAgICBkb21XaW5kb3ctPmNvbnNvbGUoKS0+YWRkTWVzc2FnZShIVE1MTWVzc2FnZVNvdXJj ZSwgTG9nTWVzc2FnZVR5cGUsIFdhcm5pbmdNZXNzYWdlTGV2ZWwsIHBhcnNlRXJyb3JNZXNzYWdl LCBtX3BhcnNlci0+bGluZU51bWJlcigpLCBtX2RvY3VtZW50LT51cmwoKS5zdHJpbmcoKSk7CiB9 CiAKIGJvb2wgSFRNTFRyZWVCdWlsZGVyOjpzY3JpcHRFbmFibGVkKEZyYW1lKiBmcmFtZSkK