55103 2011-02-23 16:42:53 -0800 Clipping layer doesn't resize when FrameView changes size 2011-02-25 11:00:04 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 vangelis vangelis cmarrin simon.fraser oldest_to_newest 356545 0 vangelis 2011-02-23 16:42:53 -0800 The size of the m_clipLayer created by RenderLayerCompositor doesn't get updated when the layoutWidth of the associated frameView changes. This can happen if for example the content of the page changes and the scrollbar is removed. It's fairly easy to reproduce the problem in Chromium by visiting: http://www.youtube.com/watch?v=PEZiZ9G-gNs and switching the video over to full screen mode (note that in this case the video doesn't expand to cover the entire screen, it just stretches to use the entire window size). You'll notice that the video doesn't render in the area that used to be occupied by the scroll bar. What happens here is that in non-fullscreen mode the page has a scrollbar whereas in fullscreen mode it doesn't. Switching between the two modes effectively changes the layoutWidth of the FrameView. If you change the window size the problem goes away. (Safari on mac doesn't exhibit the issue in this particular case as it handles scrolling differently and the RenderLayerCompositor doesn't create a clip or scroll layer) The problem appears to be that when RenderLayerCompositor::rebuildCompositingLayerTree() is called, even though the size of m_rootPlayerformLayer is set correctly, the clip layer size doesn't get updated. The most natural place to update the clip layer size appears to be in RenderLayerCompositor::updateRootLayerPosition. 356549 1 83577 vangelis 2011-02-23 16:48:31 -0800 Created attachment 83577 Patch 356557 2 83577 simon.fraser 2011-02-23 16:55:42 -0800 Comment on attachment 83577 Patch Is it possible to make a layout test with pixel results that test this? 356708 3 vangelis 2011-02-23 23:42:13 -0800 (In reply to comment #2) > (From update of attachment 83577 [details]) > Is it possible to make a layout test with pixel results that test this? A layout test would be useful here. Ideally I'd like to find a way to programmatically change the frame's layout width that doesn't involve scrollbars. This would make the test useful for safari mac as well. Any ideas? 358042 4 vangelis 2011-02-25 11:00:04 -0800 Committed r79699: <http://trac.webkit.org/changeset/79699> 83577 2011-02-23 16:48:31 -0800 2011-02-23 16:55:42 -0800 Patch bug-55103-20110223164829.patch text/plain 1534 vangelis SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5NTA0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMjMgIFZhbmdlbGlz IEtva2tldmlzICA8dmFuZ2VsaXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB0aGUgY2xpcCBsYXllciBzaXplIHdo ZW5ldmVyIHRoZSByb290IGxheWVyJ3Mgc2l6ZSBhbmQgcG9zaXRpb24KKyAgICAgICAgaXMgdXBk YXRlZC4gVGhpcyBvbmx5IGFmZmVjdHMgdGhlIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIHBhdGgu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTEwMwor CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnVwZGF0ZVJvb3RMYXllclBvc2l0aW9u KToKKwogMjAxMS0wMi0xNyAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAJKHJldmlzaW9uIDc5MzYx KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTExMDIsNiArMTEwMiwxMCBAQCB2b2lkIFJlbmRlckxheWVyQ29t cG9zaXRvcjo6dXBkYXRlUm9vdExhCiAgICAgICAgIG1fcm9vdFBsYXRmb3JtTGF5ZXItPnNldFNp emUoRmxvYXRTaXplKG1fcmVuZGVyVmlldy0+ZG9jV2lkdGgoKSwgbV9yZW5kZXJWaWV3LT5kb2NI ZWlnaHQoKSkpOwogICAgICAgICBtX3Jvb3RQbGF0Zm9ybUxheWVyLT5zZXRQb3NpdGlvbihGbG9h dFBvaW50KG1fcmVuZGVyVmlldy0+ZG9jTGVmdCgpLCBtX3JlbmRlclZpZXctPmRvY1RvcCgpKSk7 CiAgICAgfQorICAgIGlmIChtX2NsaXBMYXllcikgeworICAgICAgICBGcmFtZVZpZXcqIGZyYW1l VmlldyA9IG1fcmVuZGVyVmlldy0+ZnJhbWVWaWV3KCk7CisgICAgICAgIG1fY2xpcExheWVyLT5z ZXRTaXplKEZsb2F0U2l6ZShmcmFtZVZpZXctPmxheW91dFdpZHRoKCksIGZyYW1lVmlldy0+bGF5 b3V0SGVpZ2h0KCkpKTsKKyAgICB9CiB9CiAKIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpk aWRTdGFydEFjY2VsZXJhdGVkQW5pbWF0aW9uKENTU1Byb3BlcnR5SUQgcHJvcGVydHkpCg==