55073 2011-02-23 12:47:07 -0800 [Chromium] Add WebKitClient::cryptographicallyRandomValues 2011-02-23 14:08:40 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned dglazkov webkit.review.bot oldest_to_newest 356325 0 abarth 2011-02-23 12:47:07 -0800 We need this to get random values into WTF while inside the sandbox. 356327 1 83527 abarth 2011-02-23 12:47:49 -0800 Created attachment 83527 Patch (will add ChangeLog before landing) 356335 2 webkit.review.bot 2011-02-23 12:54:18 -0800 Attachment 83527 did not build on chromium: Build output: http://queues.webkit.org/results/7987213 356380 3 83540 abarth 2011-02-23 13:44:14 -0800 Created attachment 83540 Patch 356384 4 83540 fishd 2011-02-23 13:48:48 -0800 Comment on attachment 83540 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83540&action=review > Source/WebKit/chromium/public/WebKitClient.h:270 > + volatile char* nullPointer = 0; high there, please let me introduce you to my friend, WEBKIT_ASSERT_NOT_REACHED() 356387 5 83542 abarth 2011-02-23 13:50:55 -0800 Created attachment 83542 Patch 356405 6 abarth 2011-02-23 14:08:40 -0800 Committed r79487: <http://trac.webkit.org/changeset/79487> 83527 2011-02-23 12:47:49 -0800 2011-02-23 13:44:11 -0800 Patch (will add ChangeLog before landing) patch text/plain 651 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5oCShy ZXZpc2lvbiA3Nzk2NykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENs aWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNjMsNiArMjYzLDggQEAKICAgICAvLyBXYWxsIGNs b2NrIHRpbWUgaW4gc2Vjb25kcyBzaW5jZSB0aGUgZXBvY2guCiAgICAgdmlydHVhbCBkb3VibGUg Y3VycmVudFRpbWUoKSB7IHJldHVybiAwOyB9CiAKKyAgICB2aXJ0dWFsIHZvaWQgY3J5cHRvZ3Jh cGhpY2FsbHlSYW5kb21WYWx1ZXModW5zaWduZWQgY2hhciogYnVmZmVyLCBzaXplX3QgbGVuZ3Ro KSB7IENSQVNIKCk7IH0KKwogICAgIC8vIERlbGF5ZWQgd29yayBpcyBkcml2ZW4gYnkgYSBzaGFy ZWQgdGltZXIuCiAgICAgdmlydHVhbCB2b2lkIHNldFNoYXJlZFRpbWVyRmlyZWRGdW5jdGlvbih2 b2lkICgqZnVuYykoKSkgeyB9CiAgICAgdmlydHVhbCB2b2lkIHNldFNoYXJlZFRpbWVyRmlyZVRp bWUoZG91YmxlIGZpcmVUaW1lKSB7IH0K 83540 2011-02-23 13:44:14 -0800 2011-02-23 13:50:53 -0800 Patch bug-55073-20110223134413.patch text/plain 1614 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3OTQ4MykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDItMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIEFkZCBX ZWJLaXRDbGllbnQ6OmNyeXB0b2dyYXBoaWNhbGx5UmFuZG9tVmFsdWVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTA3MworCisgICAgICAgIFRoaXMg cGF0Y2ggYWRkcyBhIFdlYktpdCBjbGllbnQgQVBJIHRvIGdldCBjcnlwdG9ncmFwaGljIHJhbmRv bW5lc3MuCisgICAgICAgIFdlJ2xsIHVzZSB0aGlzIEFQSSB0byBnYXRoZXIgc2VlZCByYW5kb21u ZXNzIHdoaWxlIGluc2lkZSB0aGUgc2FuZGJveC4KKworICAgICAgICAqIHB1YmxpYy9XZWJLaXRD bGllbnQuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViS2l0Q2xpZW50OjpjcnlwdG9ncmFwaGljYWxs eVJhbmRvbVZhbHVlcyk6CisKIDIwMTEtMDItMjMgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29n bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3OTM4Ny4KSW5kZXg6 IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5oCShyZXZpc2lv biA3OTQ4MikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5o CSh3b3JraW5nIGNvcHkpCkBAIC0yNjQsNiArMjY0LDEzIEBAIHB1YmxpYzoKICAgICAvLyBXYWxs IGNsb2NrIHRpbWUgaW4gc2Vjb25kcyBzaW5jZSB0aGUgZXBvY2guCiAgICAgdmlydHVhbCBkb3Vi bGUgY3VycmVudFRpbWUoKSB7IHJldHVybiAwOyB9CiAKKyAgICB2aXJ0dWFsIHZvaWQgY3J5cHRv Z3JhcGhpY2FsbHlSYW5kb21WYWx1ZXModW5zaWduZWQgY2hhciogYnVmZmVyLCBzaXplX3QgbGVu Z3RoKQorICAgIHsKKyAgICAgICAgLy8gV2ViS2l0IGNsaWVudHMgbXVzdCBpbXBsZW1lbnQgdGhp cyBmdW5jaW9uIGlmIHRoZXkgdXNlIGNyeXB0b2dyYXBoaWMgcmFuZG9tbmVzcy4KKyAgICAgICAg dm9sYXRpbGUgY2hhciogbnVsbFBvaW50ZXIgPSAwOworICAgICAgICAqbnVsbFBvaW50ZXIgPSAw OworICAgIH0KKwogICAgIC8vIERlbGF5ZWQgd29yayBpcyBkcml2ZW4gYnkgYSBzaGFyZWQgdGlt ZXIuCiAgICAgdmlydHVhbCB2b2lkIHNldFNoYXJlZFRpbWVyRmlyZWRGdW5jdGlvbih2b2lkICgq ZnVuYykoKSkgeyB9CiAgICAgdmlydHVhbCB2b2lkIHNldFNoYXJlZFRpbWVyRmlyZVRpbWUoZG91 YmxlIGZpcmVUaW1lKSB7IH0K 83542 2011-02-23 13:50:55 -0800 2011-02-23 13:55:13 -0800 Patch bug-55073-20110223135054.patch text/plain 1582 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3OTQ4MykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDItMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCisKKyAgICAgICAgW0Nocm9taXVtXSBBZGQgV2Vi S2l0Q2xpZW50OjpjcnlwdG9ncmFwaGljYWxseVJhbmRvbVZhbHVlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUwNzMKKworICAgICAgICBUaGlzIHBh dGNoIGFkZHMgYSBXZWJLaXQgY2xpZW50IEFQSSB0byBnZXQgY3J5cHRvZ3JhcGhpYyByYW5kb21u ZXNzLgorICAgICAgICBXZSdsbCB1c2UgdGhpcyBBUEkgdG8gZ2F0aGVyIHNlZWQgcmFuZG9tbmVz cyB3aGlsZSBpbnNpZGUgdGhlIHNhbmRib3guCisKKyAgICAgICAgKiBwdWJsaWMvV2ViS2l0Q2xp ZW50Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYktpdENsaWVudDo6Y3J5cHRvZ3JhcGhpY2FsbHlS YW5kb21WYWx1ZXMpOgorCiAyMDExLTAyLTIzICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNzkzODcuCkluZGV4OiBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXRDbGllbnQuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXRDbGllbnQuaAkocmV2aXNpb24g Nzk0ODIpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXRDbGllbnQuaAko d29ya2luZyBjb3B5KQpAQCAtMjY0LDYgKzI2NCwxMiBAQCBwdWJsaWM6CiAgICAgLy8gV2FsbCBj bG9jayB0aW1lIGluIHNlY29uZHMgc2luY2UgdGhlIGVwb2NoLgogICAgIHZpcnR1YWwgZG91Ymxl IGN1cnJlbnRUaW1lKCkgeyByZXR1cm4gMDsgfQogCisgICAgdmlydHVhbCB2b2lkIGNyeXB0b2dy YXBoaWNhbGx5UmFuZG9tVmFsdWVzKHVuc2lnbmVkIGNoYXIqIGJ1ZmZlciwgc2l6ZV90IGxlbmd0 aCkKKyAgICB7CisgICAgICAgIC8vIFdlYktpdCBjbGllbnRzIG11c3QgaW1wbGVtZW50IHRoaXMg ZnVuY2lvbiBpZiB0aGV5IHVzZSBjcnlwdG9ncmFwaGljIHJhbmRvbW5lc3MuCisgICAgICAgIFdF QktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICB9CisKICAgICAvLyBEZWxheWVkIHdvcmsg aXMgZHJpdmVuIGJ5IGEgc2hhcmVkIHRpbWVyLgogICAgIHZpcnR1YWwgdm9pZCBzZXRTaGFyZWRU aW1lckZpcmVkRnVuY3Rpb24odm9pZCAoKmZ1bmMpKCkpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBz ZXRTaGFyZWRUaW1lckZpcmVUaW1lKGRvdWJsZSBmaXJlVGltZSkgeyB9Cg==