55065 2011-02-23 11:17:37 -0800 Setting shadow host should also attach and set inDocument, just like appending/inserting a child. 2011-02-23 12:07:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 53020 1 dglazkov dglazkov commit-queue darin oldest_to_newest 356232 0 dglazkov 2011-02-23 11:17:37 -0800 Setting shadow host should also attach and set inDocument, just like appending/inserting a child. 356235 1 83507 dglazkov 2011-02-23 11:19:38 -0800 Created attachment 83507 Patch 356238 2 83507 darin 2011-02-23 11:22:49 -0800 Comment on attachment 83507 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83507&action=review > Source/WebCore/dom/Element.cpp:1143 > + if (inDocument()) > + newRoot->insertedIntoDocument(); Is there a case where newRoot was already in a document? 356241 3 dglazkov 2011-02-23 11:25:15 -0800 (In reply to comment #2) > (From update of attachment 83507 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=83507&action=review > > > Source/WebCore/dom/Element.cpp:1143 > > + if (inDocument()) > > + newRoot->insertedIntoDocument(); > > Is there a case where newRoot was already in a document? Not currently, but we will have to defend against this once script is allowed to set shadowHost. I have a FIXME at the top of the method to not forget. 356288 4 83507 commit-queue 2011-02-23 12:07:05 -0800 Comment on attachment 83507 Patch Clearing flags on attachment: 83507 Committed r79468: <http://trac.webkit.org/changeset/79468> 356289 5 commit-queue 2011-02-23 12:07:10 -0800 All reviewed patches have been landed. Closing bug. 83507 2011-02-23 11:19:38 -0800 2011-02-23 12:07:05 -0800 Patch bug-55065-20110223111937.patch text/plain 1444 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogNzk0NjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ODY2MTcyNDQyYTkxYTQ4 NWUyOGQ3YWU1ODdlMWUzMDExM2RiNjI2Li4yNGM1MTAwZTU4ZTk2Y2RjYzNiY2IxNTRmNDJjZmU3 MDVhZTg1ZWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMjMgIERpbWl0 cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXR0aW5nIHNoYWRvdyBob3N0IHNob3VsZCBh bHNvIGF0dGFjaCBhbmQgc2V0IGluRG9jdW1lbnQsIGp1c3QgbGlrZQorICAgICAgICBhcHBlbmRp bmcvaW5zZXJ0aW5nIGEgY2hpbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NTA2NQorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVjYXVzZSBmdW5j dGlvbmFsaXR5IGlzIG5vdCB5ZXQgdXNlZC4KKworICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnNldFNoYWRvd1Jvb3QpOiBBZGQgYXR0YWNoaW5n IGFuZCBzZXR0aW5nIGluRG9jdW1lbnQKKyAgICAgICAgICAgIGZvciB0aGUgc2hhZG93IERPTSBz dWJ0cmVlLCBsaWtlIHRoZSBob3N0LgorCiAyMDExLTAyLTIzICBBYmhpc2hlayBBcnlhICA8aW5m ZXJub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9FbGVtZW50LmNwcAppbmRleCA4YzA5Mzg2ZjkwMTRiZGNhMmRhZGY3NzY2NWFhZTY2NDc4 ZDZiMWRmLi5lOGQ5ZjU4YjBjYjNhMTI1NmQwMDJkYjA0MmQ1N2M2NTU4NmNjZjhlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL0VsZW1lbnQuY3BwCkBAIC0xMTM5LDYgKzExMzksMTAgQEAgdm9pZCBFbGVtZW50OjpzZXRT aGFkb3dSb290KFBhc3NSZWZQdHI8Tm9kZT4gbm9kZSkKIAogICAgIGVuc3VyZVJhcmVEYXRhKCkt Pm1fc2hhZG93Um9vdCA9IG5ld1Jvb3QuZ2V0KCk7CiAgICAgbmV3Um9vdC0+c2V0U2hhZG93SG9z dCh0aGlzKTsKKyAgICBpZiAoaW5Eb2N1bWVudCgpKQorICAgICAgICBuZXdSb290LT5pbnNlcnRl ZEludG9Eb2N1bWVudCgpOworICAgIGlmIChhdHRhY2hlZCgpICYmICFuZXdSb290LT5hdHRhY2hl ZCgpKQorICAgICAgICBuZXdSb290LT5sYXp5QXR0YWNoKCk7CiB9CiAKIHZvaWQgRWxlbWVudDo6 cmVtb3ZlU2hhZG93Um9vdCgpCg==