55059 2011-02-23 10:44:05 -0800 WKBundleNavigationAction.h should be exposed as a public header 2011-02-23 11:43:48 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.6 RESOLVED FIXED P2 Normal --- 1 mthole mthole abarth eric webkit.review.bot oldest_to_newest 356185 0 mthole 2011-02-23 10:44:05 -0800 WKBundleNavigationAction.h should be exposed as a public header, so that it can be used in the injected bundle. 356189 1 83502 mthole 2011-02-23 10:45:47 -0800 Created attachment 83502 Proposed patch 356193 2 83502 darin 2011-02-23 10:47:34 -0800 Comment on attachment 83502 Proposed patch Correct to change this from project. But I believe it should be private, not public, because WebKit2 is Mac OS X SPI, not API, at this time. 356196 3 mthole 2011-02-23 10:50:44 -0800 Committed revision 79459. 356203 4 mthole 2011-02-23 10:54:09 -0800 I left it as 'Public', which matches equivalent headers (e.g. WKBundleNodeHandle.h, WKBundlePage.h) in WK2. I think the system-level API vs. SPI issue is handled by putting all of WebKit2.framework in the /System/Library/PrivateFrameworks, rather than /System/Library/Frameworks. 356258 5 webkit.review.bot 2011-02-23 11:43:48 -0800 http://trac.webkit.org/changeset/79459 might have broken Qt Linux Release The following tests are not passing: fast/overflow/overflow-height-float-not-removed-crash3.html 83502 2011-02-23 10:45:47 -0800 2011-02-23 10:47:34 -0800 Proposed patch textmate stdin mw2kDo.txt text/plain 2306 mthole SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5NDU4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMjMgIE1pa2UgVGhv bGUgIDxtdGhvbGVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdLQnVuZGxlTmF2aWdhdGlvbkFjdGlvbi5oIHNob3VsZCBiZSBleHBv c2VkIGFzIGEgcHVibGljIGhlYWRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTUwNTkKKworICAgICAgICAqIFdlYktpdDIueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvajoKKyAgICAgICAgQ2hhbmdlZCBXS0J1bmRsZU5hdmlnYXRpb25BY3Rpb24uaCBm cm9tICdwcm9qZWN0JyB0byAncHVibGljJy4KKwogMjAxMS0wMi0yMyAgU2lkZGhhcnRoIE1hdGh1 ciAgPHNpZGRoYXJ0aC5tYXRodXJAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IExh c3psbyBHb21ib3MuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJLaXQyLnhjb2RlcHJvai9wcm9q ZWN0LnBieHByb2oKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViS2l0Mi54Y29kZXBy b2ovcHJvamVjdC5wYnhwcm9qCShyZXZpc2lvbiA3OTQ1OCkKKysrIFNvdXJjZS9XZWJLaXQyL1dl YktpdDIueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagkod29ya2luZyBjb3B5KQpAQCAtNTMzLDcg KzUzMyw3IEBACiAJCUJDNjQ2QzFDMTFERDM5OUYwMDY0NTVCMCAvKiBXS0JhY2tGb3J3YXJkTGlz dEl0ZW0uY3BwIGluIFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0g QkM2NDZDMTgxMUREMzk5RjAwNjQ1NUIwIC8qIFdLQmFja0ZvcndhcmRMaXN0SXRlbS5jcHAgKi87 IH07CiAJCUJDNjQ2QzFEMTFERDM5OUYwMDY0NTVCMCAvKiBXS0JhY2tGb3J3YXJkTGlzdEl0ZW0u aCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEJDNjQ2QzE5 MTFERDM5OUYwMDY0NTVCMCAvKiBXS0JhY2tGb3J3YXJkTGlzdEl0ZW0uaCAqLzsgc2V0dGluZ3Mg PSB7QVRUUklCVVRFUyA9IChQdWJsaWMsICk7IH07IH07CiAJCUJDNkVEQUE2MTExMjcxQzYwMEU3 Njc4QiAvKiBQYWdlQ2xpZW50LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7 IGZpbGVSZWYgPSBCQzZFREFBNTExMTI3MUM2MDBFNzY3OEIgLyogUGFnZUNsaWVudC5oICovOyB9 OwotCQlCQzcwNDNDQzEyRjc1RUUwMDA2NDcyQjkgLyogV0tCdW5kbGVOYXZpZ2F0aW9uQWN0aW9u LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBCQzcwNDND QTEyRjc1RUUwMDA2NDcyQjkgLyogV0tCdW5kbGVOYXZpZ2F0aW9uQWN0aW9uLmggKi87IH07CisJ CUJDNzA0M0NDMTJGNzVFRTAwMDY0NzJCOSAvKiBXS0J1bmRsZU5hdmlnYXRpb25BY3Rpb24uaCBp biBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEJDNzA0M0NBMTJG NzVFRTAwMDY0NzJCOSAvKiBXS0J1bmRsZU5hdmlnYXRpb25BY3Rpb24uaCAqLzsgc2V0dGluZ3Mg PSB7QVRUUklCVVRFUyA9IChQdWJsaWMsICk7IH07IH07CiAJCUJDNzA0M0NEMTJGNzVFRTAwMDY0 NzJCOSAvKiBXS0J1bmRsZU5hdmlnYXRpb25BY3Rpb24uY3BwIGluIFNvdXJjZXMgKi8gPSB7aXNh ID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gQkM3MDQzQ0IxMkY3NUVFMDAwNjQ3MkI5IC8qIFdL QnVuZGxlTmF2aWdhdGlvbkFjdGlvbi5jcHAgKi87IH07CiAJCUJDNzJCOUZBMTFFNjQ3NkIwMDFF QjRFQSAvKiBXZWJCYWNrRm9yd2FyZExpc3RQcm94eS5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2Eg PSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBCQzcyQjlGODExRTY0NzZCMDAxRUI0RUEgLyogV2Vi QmFja0ZvcndhcmRMaXN0UHJveHkuY3BwICovOyB9OwogCQlCQzcyQjlGQjExRTY0NzZCMDAxRUI0 RUEgLyogV2ViQmFja0ZvcndhcmRMaXN0UHJveHkuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBC WEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEJDNzJCOUY5MTFFNjQ3NkIwMDFFQjRFQSAvKiBXZWJCYWNr Rm9yd2FyZExpc3RQcm94eS5oICovOyB9Owo=