55040 2011-02-23 04:56:52 -0800 RegExp constructor returns the argument regexp instead of a new object 2011-06-28 11:36:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kent.hansen webkit-unassigned barraclough cmarcelo webkit.review.bot oldest_to_newest 356030 0 kent.hansen 2011-02-23 04:56:52 -0800 In the following script, the last comparison r = new RegExp; r2 = new RegExp(r); r == r2; should produce false; however, with JSC it produces true. I.e., the "copy-constructing" call to RegExp doesn't return a new object. In both V8 and SpiderMonkey, a new object is returned, as per ECMA-262 5th edition, section 15.10.4. 429013 1 98947 barraclough 2011-06-28 11:22:09 -0700 Created attachment 98947 Thepatch 429021 2 webkit.review.bot 2011-06-28 11:24:11 -0700 Attachment 98947 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/JavaScriptCore/runtime/RegExpConstructor.cpp:305: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 429036 3 barraclough 2011-06-28 11:36:06 -0700 fixed in r89946 98947 2011-06-28 11:22:09 -0700 2011-06-28 11:23:34 -0700 Thepatch 55040.patch text/plain 6186 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODk5NDApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK KzIwMTEtMDYtMjggIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTA0MAorICAgICAgICBSZWdFeHAgY29u c3RydWN0b3IgcmV0dXJucyB0aGUgYXJndW1lbnQgcmVnZXhwIGluc3RlYWQgb2YgYSBuZXcgb2Jq ZWN0CisKKyAgICAgICAgUGVyIDE1LjEwLjMuMSwgb3VyIGN1cnJlbnQgYmVoYXZpb3VyIGlzIGNv cnJlY3QgaWYgY2FsbGVkIGFzIGEgZnVuY3Rpb24sCisgICAgICAgIGJ1dCBpbmNvcnJlY3Qgd2hl biBjYWxsZWQgYXMgYSBjb25zdHJ1Y3Rvci4KKworICAgICAgICAqIHJ1bnRpbWUvUmVnRXhwQ29u c3RydWN0b3IuY3BwOgorICAgICAgICAoSlNDOjpjb25zdHJ1Y3RSZWdFeHApOgorICAgICAgICAo SlNDOjpjb25zdHJ1Y3RXaXRoUmVnRXhwQ29uc3RydWN0b3IpOgorICAgICAgICAqIHJ1bnRpbWUv UmVnRXhwQ29uc3RydWN0b3IuaDoKKwogMjAxMS0wNi0yOCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBh cHBsZS5jb20+CiAKICAgICAgICAgV2luZG93cyBEZWJ1ZyBidWlsZCBmaXggYWZ0ZXIgcjg5ODg1 CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBDb25zdHJ1Y3Rvci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwQ29u c3RydWN0b3IuY3BwCShyZXZpc2lvbiA4OTg5NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1JlZ0V4cENvbnN0cnVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjkzLDcgKzI5 Myw3IEBAIHZvaWQgc2V0UmVnRXhwQ29uc3RydWN0b3JNdWx0aWxpbmUoRXhlY1MKIH0KIAogLy8g RUNNQSAxNS4xMC40Ci1KU09iamVjdCogY29uc3RydWN0UmVnRXhwKEV4ZWNTdGF0ZSogZXhlYywg SlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgY29uc3QgQXJnTGlzdCYgYXJncykKK0pTT2Jq ZWN0KiBjb25zdHJ1Y3RSZWdFeHAoRXhlY1N0YXRlKiBleGVjLCBKU0dsb2JhbE9iamVjdCogZ2xv YmFsT2JqZWN0LCBjb25zdCBBcmdMaXN0JiBhcmdzLCBib29sIGNhbGxBc0NvbnN0cnVjdG9yKQog ewogICAgIEpTVmFsdWUgYXJnMCA9IGFyZ3MuYXQoMCk7CiAgICAgSlNWYWx1ZSBhcmcxID0gYXJn cy5hdCgxKTsKQEAgLTMwMSw3ICszMDEsMTIgQEAgSlNPYmplY3QqIGNvbnN0cnVjdFJlZ0V4cChF eGVjU3RhdGUqIGV4ZQogICAgIGlmIChhcmcwLmluaGVyaXRzKCZSZWdFeHBPYmplY3Q6OnNfaW5m bykpIHsKICAgICAgICAgaWYgKCFhcmcxLmlzVW5kZWZpbmVkKCkpCiAgICAgICAgICAgICByZXR1 cm4gdGhyb3dFcnJvcihleGVjLCBjcmVhdGVUeXBlRXJyb3IoZXhlYywgIkNhbm5vdCBzdXBwbHkg ZmxhZ3Mgd2hlbiBjb25zdHJ1Y3Rpbmcgb25lIFJlZ0V4cCBmcm9tIGFub3RoZXIuIikpOwotICAg ICAgICByZXR1cm4gYXNPYmplY3QoYXJnMCk7CisgICAgICAgIC8vIElmIGNhbGxlZCBhcyBhIGZ1 bmN0aW9uLCB0aGlzIGp1c3QgcmV0dXJucyB0aGUgZmlyc3QgYXJndW1lbnQgKHNlZSAxNS4xMC4z LjEpLgorICAgICAgICBpZiAoY2FsbEFzQ29uc3RydWN0b3IpIHsKKyAgICAgICAgICAgIFJlZ0V4 cCogcmVnRXhwID0gc3RhdGljX2Nhc3Q8UmVnRXhwT2JqZWN0Kj4oYXNPYmplY3QoYXJnMCkpLT5y ZWdFeHAoKTsKKyAgICAgICAgICAgIHJldHVybiBuZXcgKGV4ZWMpIFJlZ0V4cE9iamVjdChnbG9i YWxPYmplY3QsIGdsb2JhbE9iamVjdC0+cmVnRXhwU3RydWN0dXJlKCksIHJlZ0V4cCk7CisgICAg ICAgIH0gZWxzZQorICAgICAgICAgICAgcmV0dXJuIGFzT2JqZWN0KGFyZzApOwogICAgIH0KIAog ICAgIFVTdHJpbmcgcGF0dGVybiA9IGFyZzAuaXNVbmRlZmluZWQoKSA/IFVTdHJpbmcoIiIpIDog YXJnMC50b1N0cmluZyhleGVjKTsKQEAgLTMyNiw3ICszMzEsNyBAQCBKU09iamVjdCogY29uc3Ry dWN0UmVnRXhwKEV4ZWNTdGF0ZSogZXhlCiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1Rf Q0FMTCBjb25zdHJ1Y3RXaXRoUmVnRXhwQ29uc3RydWN0b3IoRXhlY1N0YXRlKiBleGVjKQogewog ICAgIEFyZ0xpc3QgYXJncyhleGVjKTsKLSAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGNvbnN0 cnVjdFJlZ0V4cChleGVjLCBhc0ludGVybmFsRnVuY3Rpb24oZXhlYy0+Y2FsbGVlKCkpLT5nbG9i YWxPYmplY3QoKSwgYXJncykpOworICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoY29uc3RydWN0 UmVnRXhwKGV4ZWMsIGFzSW50ZXJuYWxGdW5jdGlvbihleGVjLT5jYWxsZWUoKSktPmdsb2JhbE9i amVjdCgpLCBhcmdzLCB0cnVlKSk7CiB9CiAKIENvbnN0cnVjdFR5cGUgUmVnRXhwQ29uc3RydWN0 b3I6OmdldENvbnN0cnVjdERhdGEoQ29uc3RydWN0RGF0YSYgY29uc3RydWN0RGF0YSkKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cENvbnN0cnVjdG9yLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwQ29uc3RydWN0b3Iu aAkocmV2aXNpb24gODk4OTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdF eHBDb25zdHJ1Y3Rvci5oCSh3b3JraW5nIGNvcHkpCkBAIC05Niw3ICs5Niw3IEBAIG5hbWVzcGFj ZSBKU0MgewogCiAgICAgUmVnRXhwQ29uc3RydWN0b3IqIGFzUmVnRXhwQ29uc3RydWN0b3IoSlNW YWx1ZSk7CiAKLSAgICBKU09iamVjdCogY29uc3RydWN0UmVnRXhwKEV4ZWNTdGF0ZSosIEpTR2xv YmFsT2JqZWN0KiwgY29uc3QgQXJnTGlzdCYpOworICAgIEpTT2JqZWN0KiBjb25zdHJ1Y3RSZWdF eHAoRXhlY1N0YXRlKiwgSlNHbG9iYWxPYmplY3QqLCBjb25zdCBBcmdMaXN0JiwgYm9vbCBjYWxs QXNDb25zdHJ1Y3RvciA9IGZhbHNlKTsKIAogICAgIGlubGluZSBSZWdFeHBDb25zdHJ1Y3Rvciog YXNSZWdFeHBDb25zdHJ1Y3RvcihKU1ZhbHVlIHZhbHVlKQogICAgIHsKSW5kZXg6IExheW91dFRl c3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlz aW9uIDg5OTQwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTEtMDYtMjggIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTA0MAorICAgICAg ICBSZWdFeHAgY29uc3RydWN0b3IgcmV0dXJucyB0aGUgYXJndW1lbnQgcmVnZXhwIGluc3RlYWQg b2YgYSBuZXcgb2JqZWN0CisKKyAgICAgICAgUGVyIDE1LjEwLjMuMSwgb3VyIGN1cnJlbnQgYmVo YXZpb3VyIGlzIGNvcnJlY3QgaWYgY2FsbGVkIGFzIGEgZnVuY3Rpb24sCisgICAgICAgIGJ1dCBp bmNvcnJlY3Qgd2hlbiBjYWxsZWQgYXMgYSBjb25zdHJ1Y3Rvci4KKworICAgICAgICAqIGZhc3Qv cmVnZXgvY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3Jl Z2V4L2NvbnN0cnVjdG9yLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcmVnZXgvc2NyaXB0 LXRlc3RzL2NvbnN0cnVjdG9yLmpzOiBBZGRlZC4KKwogMjAxMS0wNi0yOCAgSmVzc2llIEJlcmxp biAgPGpiZXJsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEJldHRlciBXaW5kb3dzIHJlYmFzZWxp bmUgZm9yIHRoZSBjaGFuZ2VzIGluIHI4OTg2NCwgd2l0aCBwaXhlbCByZXN1bHRzLCB0byBnZXQg dGhlIGJvdHMKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY29uc3RydWN0b3ItZXhwZWN0 ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY29uc3RydWN0b3It ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9jb25z dHJ1Y3Rvci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKK1RoaXMg dGVzdCBjaGVja3MgdXNlIG9mIHRoZSByZWdleHAgY29uc3RydWN0b3IuCisKK09uIHN1Y2Nlc3Ms IHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJU RVNUIENPTVBMRVRFIi4KKworCitQQVNTIHJlID09PSBSZWdFeHAocmUpIGlzIHRydWUKK1BBU1Mg cmUgIT09IG5ldyBSZWdFeHAocmUpIGlzIHRydWUKK1BBU1MgcmUgPT09IFJlZ0V4cChyZSwnaScp IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IENhbm5vdCBzdXBwbHkgZmxhZ3Mgd2hlbiBjb25z dHJ1Y3Rpbmcgb25lIFJlZ0V4cCBmcm9tIGFub3RoZXIuLgorUEFTUyByZSAhPT0gbmV3IFJlZ0V4 cChyZSwnaScpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IENhbm5vdCBzdXBwbHkgZmxhZ3Mg d2hlbiBjb25zdHJ1Y3Rpbmcgb25lIFJlZ0V4cCBmcm9tIGFub3RoZXIuLgorUEFTUyBzdWNjZXNz ZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvcmVnZXgvY29uc3RydWN0b3IuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L3JlZ2V4L2NvbnN0cnVjdG9yLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L3JlZ2V4L2NvbnN0cnVjdG9yLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAK KzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgor PGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+ Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvY29u c3RydWN0b3IuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9yZWdleC9zY3JpcHQtdGVzdHMvY29uc3RydWN0b3IuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZmFzdC9yZWdleC9zY3JpcHQtdGVzdHMvY29uc3RydWN0b3IuanMJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3NjcmlwdC10ZXN0cy9jb25zdHJ1Y3Rv ci5qcwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBAQAorZGVzY3JpcHRpb24oIlRoaXMgdGVz dCBjaGVja3MgdXNlIG9mIHRoZSByZWdleHAgY29uc3RydWN0b3IuIik7CisKK3ZhciByZSA9IC9h YmMvOworCitzaG91bGRCZVRydWUoInJlID09PSBSZWdFeHAocmUpIik7CitzaG91bGRCZVRydWUo InJlICE9PSBuZXcgUmVnRXhwKHJlKSIpOworc2hvdWxkVGhyb3coInJlID09PSBSZWdFeHAocmUs J2knKSIpOworc2hvdWxkVGhyb3coInJlICE9PSBuZXcgUmVnRXhwKHJlLCdpJykiKTsKKwordmFy IHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7CisK