55035 2011-02-23 04:13:04 -0800 Non-latin friendly default GUI fallback font for Chromium 2013-04-11 13:19:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 57825 0 kochi webkit-unassigned abarth commit-queue eric evan jshin kochi ojan schenney tony webkit.review.bot oldest_to_newest 356014 0 kochi 2011-02-23 04:13:04 -0800 Currently WebCore/rendering/RenderThemeChromiumSkia.cpp defins 'Arial' as the default GUI font, but this is not suitable for languages that use non-latin characters, like CJK. I'd like to propose that we would use "Arial, sans-serif" so that some proper fallback sans-serif font could be selected for non-latin characters. Index: WebCore/rendering/RenderThemeChromiumSkia.cpp =================================================================== --- WebCore/rendering/RenderThemeChromiumSkia.cpp (revision 79111) +++ WebCore/rendering/RenderThemeChromiumSkia.cpp (working copy) @@ -79,7 +79,7 @@ // sizes (e.g. 15px). So, for now we just use Arial. const String& RenderThemeChromiumSkia::defaultGUIFont() { - DEFINE_STATIC_LOCAL(String, fontFace, ("Arial")); + DEFINE_STATIC_LOCAL(String, fontFace, ("Arial, sans-serif")); return fontFace; } 359776 1 84206 kochi 2011-03-01 03:03:48 -0800 Created attachment 84206 Change the default fallback font-family from arial to arial, sans-serif 360006 2 tony 2011-03-01 10:31:49 -0800 If this brings us closer to IE's behavior, I think that's a good thing. Does this change the results of any layout tests? Can we add some layouts tests that illustrate the change? The comment mentions that IE uses a font based on the encoding. How hard is that to do (might not be worth the effort)? The FIXME mentions that we don't match IE for ANSI encodings. Is that still the case? I thought Arial had CJK characters, or is that only Arial Unicode? 360594 3 kochi 2011-03-01 22:41:02 -0800 Thanks for the comment. I don't have IE/Windows handy now, so I'll check later today. Arial doesn't have CJK characters, but "Arial Unicode MS" does (but a lot bigger). http://en.wikipedia.org/wiki/Arial_Unicode_MS (I'll also check if IE falls back "Arial" to "Arial Unicode MS" when it needs to render any CJK characters.) 377523 4 jshin 2011-03-31 16:11:28 -0700 I believe that IE (I'm not sure about IE 9) uses different fonts even for controls like 'buttons' depending on the language ('lang' specified per element/page), the page encoding (as an indirect indicator of lang) and the UI language of IE. The same is true of Firefox, IIRC. In the past, Chrome used to have https://bugs.webkit.org/show_bug.cgi?id=18085 and Ojan's patch (that relied on it) to emulate Firefox and IE. Anyway, I believe adding 'sans-serif' here will certainly help at least as long as the UI language of Chrome matches that of the intended language of a page in current view. 377554 5 tony 2011-03-31 17:06:32 -0700 BTW, I think this code change is fine. You need to include a ChangeLog and set the r? flag if you want it reviewed. Also, if it's not testable, please say why this change isn't testable. I suspect you can create a manual test in WebCore/manual-tests if you're unable to make a layout test. 379053 6 88122 kochi 2011-04-04 14:02:22 -0700 Created attachment 88122 Added a ChangeLog entry and a comment on the source code. 379054 7 88123 kochi 2011-04-04 14:04:02 -0700 Created attachment 88123 Fixed a tab in ChangeLog. 379060 8 88126 kochi 2011-04-04 14:06:42 -0700 Created attachment 88126 Clarify the wording of ChangeLog statement. 379064 9 webkit.review.bot 2011-04-04 14:10:46 -0700 Attachment 88126 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1 Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:79: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 379110 10 88138 kochi 2011-04-04 15:03:18 -0700 Created attachment 88138 Fix comment style. 379392 11 88138 commit-queue 2011-04-05 02:18:18 -0700 Comment on attachment 88138 Fix comment style. Clearing flags on attachment: 88138 Committed r82915: <http://trac.webkit.org/changeset/82915> 379393 12 commit-queue 2011-04-05 02:18:23 -0700 All reviewed patches have been landed. Closing bug. 379428 13 webkit.review.bot 2011-04-05 03:50:40 -0700 http://trac.webkit.org/changeset/82915 might have broken GTK Linux 32-bit Debug 379660 14 tony 2011-04-05 09:44:36 -0700 Reopening. This caused a bunch of tests to change results: https://bugs.webkit.org/show_bug.cgi?id=57825 They will need rebaselining if the change is expected and correct. 380952 15 kochi 2011-04-06 16:23:26 -0700 (In reply to comment #14) Sorry for the trouble, and for this naive question: where can I find the information which 270 tests failed for this? 380961 16 tony 2011-04-06 16:38:20 -0700 (In reply to comment #15) > (In reply to comment #14) > > Sorry for the trouble, and for this naive question: > where can I find the information which 270 tests failed for this? It's on the waterfall. Specifically: http://chromegw.corp.google.com/i/chromium.webkit/builders/Webkit%20Win/builds/3321 380965 17 kochi 2011-04-06 16:39:58 -0700 Thanks for the info! I'll look into the failures and get back to you once everything is resolved. (In reply to comment #16) > (In reply to comment #15) > > (In reply to comment #14) > > > > Sorry for the trouble, and for this naive question: > > where can I find the information which 270 tests failed for this? > > It's on the waterfall. Specifically: > http://chromegw.corp.google.com/i/chromium.webkit/builders/Webkit%20Win/builds/3321 84206 2011-03-01 03:03:48 -0800 2011-04-04 14:02:22 -0700 Change the default fallback font-family from arial to arial, sans-serif WebKit-chromium-linux-font-sansserif.patch text/plain 534 kochi SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAJ KHJldmlzaW9uIDc5NzU3KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1 bVNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OSw3ICs3OSw3IEBACiAvLyBzaXplcyAoZS5n LiAxNXB4KS4gU28sIGZvciBub3cgd2UganVzdCB1c2UgQXJpYWwuCiBjb25zdCBTdHJpbmcmIFJl bmRlclRoZW1lQ2hyb21pdW1Ta2lhOjpkZWZhdWx0R1VJRm9udCgpCiB7Ci0gICAgREVGSU5FX1NU QVRJQ19MT0NBTChTdHJpbmcsIGZvbnRGYWNlLCAoIkFyaWFsIikpOworICAgIERFRklORV9TVEFU SUNfTE9DQUwoU3RyaW5nLCBmb250RmFjZSwgKCJBcmlhbCwgc2Fucy1zZXJpZiIpKTsKICAgICBy ZXR1cm4gZm9udEZhY2U7CiB9CiAK 88122 2011-04-04 14:02:22 -0700 2011-04-04 14:04:02 -0700 Added a ChangeLog entry and a comment on the source code. WebKit-chromium-linux-font-sansserif2.patch text/plain 1696 kochi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyODQyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDQgIFRha2F5b3No aSBLb2NoaSA8a29jaGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gU3BlY2lmeSAnc2Fucy1zZXJpZicgYXMg YSBmYWxsYmFjayB0byB0aGUgZGVmYXVsdCBVSSBmb250CisgICAgICAgICdBcmlhbCcgZm9yIG5v bi1sYXRpbiBVSSBzY3JpcHRzIChlLmcuIENKSykuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTAzNQorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVj YXVzZSBpdCBtYXkgc3RpbGwgZmFpbCBpZiB0aGUgc3lzdGVtIGlzIG5vdCBjb25maWd1cmVkCisg ICAgICAgIHByb3Blcmx5IGFuZCBldmVuIG1hbnVhbCB0ZXN0IGlzIGhhcmQgdG8gc3lzdGVtYXRp Y2FsbHkgdGVsbCBpdCBpcworICAgICAgICB3b3JraW5nIHByb3Blcmx5LgorCisJKiByZW5kZXJp bmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCisKIDIwMTEtMDQtMDQgIFNlcmdpbyBWaWxs YXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFy dGluIFJvYmluc29uLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l Q2hyb21pdW1Ta2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCShyZXZpc2lvbiA4Mjg0MikKKysrIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTc2LDEwICs3NiwxMiBAQAogLy8KIC8vIEZJWE1FOiBUaGUgb25seSBjYXNlIHdoZXJl IHdlIGtub3cgd2UgZG9uJ3QgbWF0Y2ggSUUgaXMgZm9yIEFOU0kgZW5jb2RpbmdzLgogLy8gSUUg dXNlcyBNUyBTaGVsbCBEbGcgdGhlcmUsIHdoaWNoIHdlIHJlbmRlciBpbmNvcnJlY3RseSBhdCBj ZXJ0YWluIHBpeGVsCi0vLyBzaXplcyAoZS5nLiAxNXB4KS4gU28sIGZvciBub3cgd2UganVzdCB1 c2UgQXJpYWwuCisvLyBzaXplcyAoZS5nLiAxNXB4KS4gU28sIGZvciBub3cgd2UganVzdCB1c2Ug QXJpYWwuICBGb3Igb3RoZXIgbm9uLWxhdGluCisvLyBzY3JpcHRzIChlLmcuIENKSykgdGhhdCBB cmlhbCBkb2VzIG5vdCBjb3Zlciwgd2Ugc3BlY2lmeSBzYW5zLXNlcmlmIGFzIGEKKy8vIGZhbGxi YWNrLgogY29uc3QgU3RyaW5nJiBSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6ZGVmYXVsdEdVSUZv bnQoKQogewotICAgIERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBmb250RmFjZSwgKCJBcmlh bCIpKTsKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgZm9udEZhY2UsICgiQXJpYWws IHNhbnMtc2VyaWYiKSk7CiAgICAgcmV0dXJuIGZvbnRGYWNlOwogfQogCg== 88123 2011-04-04 14:04:02 -0700 2011-04-04 14:06:42 -0700 Fixed a tab in ChangeLog. WebKit-chromium-linux-font-sansserif2.patch text/plain 1703 kochi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyODQyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDQgIFRha2F5b3No aSBLb2NoaSA8a29jaGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gU3BlY2lmeSAnc2Fucy1zZXJpZicgYXMg YSBmYWxsYmFjayB0byB0aGUgZGVmYXVsdCBVSSBmb250CisgICAgICAgICdBcmlhbCcgZm9yIG5v bi1sYXRpbiBVSSBzY3JpcHRzIChlLmcuIENKSykuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTAzNQorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVj YXVzZSBpdCBtYXkgc3RpbGwgZmFpbCBpZiB0aGUgc3lzdGVtIGlzIG5vdCBjb25maWd1cmVkCisg ICAgICAgIHByb3Blcmx5IGFuZCBldmVuIG1hbnVhbCB0ZXN0IGlzIGhhcmQgdG8gc3lzdGVtYXRp Y2FsbHkgdGVsbCBpdCBpcworICAgICAgICB3b3JraW5nIHByb3Blcmx5LgorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcAorCiAyMDExLTA0LTA0ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE1hcnRpbiBSb2JpbnNvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZUNocm9taXVtU2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcAkocmV2aXNpb24gODI4NDIpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC03NiwxMCArNzYsMTIgQEAKIC8vCiAvLyBGSVhNRTogVGhlIG9ubHkgY2Fz ZSB3aGVyZSB3ZSBrbm93IHdlIGRvbid0IG1hdGNoIElFIGlzIGZvciBBTlNJIGVuY29kaW5ncy4K IC8vIElFIHVzZXMgTVMgU2hlbGwgRGxnIHRoZXJlLCB3aGljaCB3ZSByZW5kZXIgaW5jb3JyZWN0 bHkgYXQgY2VydGFpbiBwaXhlbAotLy8gc2l6ZXMgKGUuZy4gMTVweCkuIFNvLCBmb3Igbm93IHdl IGp1c3QgdXNlIEFyaWFsLgorLy8gc2l6ZXMgKGUuZy4gMTVweCkuIFNvLCBmb3Igbm93IHdlIGp1 c3QgdXNlIEFyaWFsLiAgRm9yIG90aGVyIG5vbi1sYXRpbgorLy8gc2NyaXB0cyAoZS5nLiBDSksp IHRoYXQgQXJpYWwgZG9lcyBub3QgY292ZXIsIHdlIHNwZWNpZnkgc2Fucy1zZXJpZiBhcyBhCisv LyBmYWxsYmFjay4KIGNvbnN0IFN0cmluZyYgUmVuZGVyVGhlbWVDaHJvbWl1bVNraWE6OmRlZmF1 bHRHVUlGb250KCkKIHsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgZm9udEZhY2Us ICgiQXJpYWwiKSk7CisgICAgREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIGZvbnRGYWNlLCAo IkFyaWFsLCBzYW5zLXNlcmlmIikpOwogICAgIHJldHVybiBmb250RmFjZTsKIH0KIAo= 88126 2011-04-04 14:06:42 -0700 2011-04-04 15:03:18 -0700 Clarify the wording of ChangeLog statement. WebKit-chromium-linux-font-sansserif2.patch text/plain 1756 kochi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyODQyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDQgIFRha2F5b3No aSBLb2NoaSA8a29jaGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gU3BlY2lmeSAnc2Fucy1zZXJpZicgYXMg YSBmYWxsYmFjayB0byB0aGUgZGVmYXVsdCBVSSBmb250CisgICAgICAgICdBcmlhbCcgZm9yIG5v bi1sYXRpbiBVSSBzY3JpcHRzIChlLmcuIENKSykuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTAzNQorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVj YXVzZSBpdCBtYXkgc3RpbGwgZmFpbCBpZiB0aGUgc3lzdGVtIGlzIG5vdCBjb25maWd1cmVkCisg ICAgICAgIHByb3Blcmx5IHRvIHJlc29sdmUgJ3NhbnMtc2VyaWYnIHRvIGV4aXN0aW5nIHJlYWwg Zm9udCBmaWxlLCB0aHVzIGV2ZW4KKyAgICAgICAgbWFudWFsIHRlc3QgaXMgaGFyZCB0byBzeXN0 ZW1hdGljYWxseSB0ZWxsIGl0IGlzIHdvcmtpbmcgcHJvcGVybHkuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCisKIDIwMTEtMDQtMDQgIFNlcmdpbyBW aWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWFydGluIFJvYmluc29uLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lQ2hyb21pdW1Ta2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCShyZXZpc2lvbiA4Mjg0MikKKysrIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTc2LDEwICs3NiwxMiBAQAogLy8KIC8vIEZJWE1FOiBUaGUgb25seSBjYXNlIHdo ZXJlIHdlIGtub3cgd2UgZG9uJ3QgbWF0Y2ggSUUgaXMgZm9yIEFOU0kgZW5jb2RpbmdzLgogLy8g SUUgdXNlcyBNUyBTaGVsbCBEbGcgdGhlcmUsIHdoaWNoIHdlIHJlbmRlciBpbmNvcnJlY3RseSBh dCBjZXJ0YWluIHBpeGVsCi0vLyBzaXplcyAoZS5nLiAxNXB4KS4gU28sIGZvciBub3cgd2UganVz dCB1c2UgQXJpYWwuCisvLyBzaXplcyAoZS5nLiAxNXB4KS4gU28sIGZvciBub3cgd2UganVzdCB1 c2UgQXJpYWwuICBGb3Igb3RoZXIgbm9uLWxhdGluCisvLyBzY3JpcHRzIChlLmcuIENKSykgdGhh dCBBcmlhbCBkb2VzIG5vdCBjb3Zlciwgd2Ugc3BlY2lmeSBzYW5zLXNlcmlmIGFzIGEKKy8vIGZh bGxiYWNrLgogY29uc3QgU3RyaW5nJiBSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6ZGVmYXVsdEdV SUZvbnQoKQogewotICAgIERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBmb250RmFjZSwgKCJB cmlhbCIpKTsKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgZm9udEZhY2UsICgiQXJp YWwsIHNhbnMtc2VyaWYiKSk7CiAgICAgcmV0dXJuIGZvbnRGYWNlOwogfQogCg== 88138 2011-04-04 15:03:18 -0700 2011-04-05 02:18:18 -0700 Fix comment style. WebKit-chromium-linux-font-sansserif2.patch text/plain 1755 kochi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgyODQyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMDQgIFRha2F5b3No aSBLb2NoaSA8a29jaGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gU3BlY2lmeSAnc2Fucy1zZXJpZicgYXMg YSBmYWxsYmFjayB0byB0aGUgZGVmYXVsdCBVSSBmb250CisgICAgICAgICdBcmlhbCcgZm9yIG5v bi1sYXRpbiBVSSBzY3JpcHRzIChlLmcuIENKSykuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTAzNQorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVj YXVzZSBpdCBtYXkgc3RpbGwgZmFpbCBpZiB0aGUgc3lzdGVtIGlzIG5vdCBjb25maWd1cmVkCisg ICAgICAgIHByb3Blcmx5IHRvIHJlc29sdmUgJ3NhbnMtc2VyaWYnIHRvIGV4aXN0aW5nIHJlYWwg Zm9udCBmaWxlLCB0aHVzIGV2ZW4KKyAgICAgICAgbWFudWFsIHRlc3QgaXMgaGFyZCB0byBzeXN0 ZW1hdGljYWxseSB0ZWxsIGl0IGlzIHdvcmtpbmcgcHJvcGVybHkuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCisKIDIwMTEtMDQtMDQgIFNlcmdpbyBW aWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWFydGluIFJvYmluc29uLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lQ2hyb21pdW1Ta2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCShyZXZpc2lvbiA4Mjg0MikKKysrIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTc2LDEwICs3NiwxMiBAQAogLy8KIC8vIEZJWE1FOiBUaGUgb25seSBjYXNlIHdo ZXJlIHdlIGtub3cgd2UgZG9uJ3QgbWF0Y2ggSUUgaXMgZm9yIEFOU0kgZW5jb2RpbmdzLgogLy8g SUUgdXNlcyBNUyBTaGVsbCBEbGcgdGhlcmUsIHdoaWNoIHdlIHJlbmRlciBpbmNvcnJlY3RseSBh dCBjZXJ0YWluIHBpeGVsCi0vLyBzaXplcyAoZS5nLiAxNXB4KS4gU28sIGZvciBub3cgd2UganVz dCB1c2UgQXJpYWwuCisvLyBzaXplcyAoZS5nLiAxNXB4KS4gU28sIGZvciBub3cgd2UganVzdCB1 c2UgQXJpYWwuIEZvciBvdGhlciBub24tbGF0aW4KKy8vIHNjcmlwdHMgKGUuZy4gQ0pLKSB0aGF0 IEFyaWFsIGRvZXMgbm90IGNvdmVyLCB3ZSBzcGVjaWZ5IHNhbnMtc2VyaWYgYXMgYQorLy8gZmFs bGJhY2suCiBjb25zdCBTdHJpbmcmIFJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhOjpkZWZhdWx0R1VJ Rm9udCgpCiB7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIGZvbnRGYWNlLCAoIkFy aWFsIikpOworICAgIERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBmb250RmFjZSwgKCJBcmlh bCwgc2Fucy1zZXJpZiIpKTsKICAgICByZXR1cm4gZm9udEZhY2U7CiB9CiAK