55031 2011-02-23 03:46:18 -0800 Database: Data race: should only touch the transaction queue inside the lock. 2011-02-26 01:16:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cevans cevans commit-queue oldest_to_newest 355996 0 cevans 2011-02-23 03:46:18 -0800 Patch forthcoming. 356007 1 83468 cevans 2011-02-23 03:57:10 -0800 Created attachment 83468 Patch 356463 2 83468 abarth 2011-02-23 15:08:26 -0800 Comment on attachment 83468 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83468&action=review > Source/WebCore/storage/Database.cpp:264 > + m_transactionQueue.append(transaction); presumably transaction.release() > Source/WebCore/storage/Database.cpp:285 > + m_transactionQueue.append(transaction); ditto 356844 3 83629 cevans 2011-02-24 03:22:13 -0800 Created attachment 83629 Patch 356851 4 83630 cevans 2011-02-24 03:30:01 -0800 Created attachment 83630 Patch 358430 5 83630 commit-queue 2011-02-26 01:16:19 -0800 Comment on attachment 83630 Patch Clearing flags on attachment: 83630 Committed r79769: <http://trac.webkit.org/changeset/79769> 358431 6 commit-queue 2011-02-26 01:16:22 -0800 All reviewed patches have been landed. Closing bug. 83468 2011-02-23 03:57:10 -0800 2011-02-24 03:22:13 -0800 Patch 55031_1.diff text/plain 2349 cevans SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2UuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2UuY3BwCShyZXZpc2lvbiA3OTMyOCkKKysr IFNvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y NTgsOCArMjU4LDEwIEBACiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBhc3NSZWZQdHI8 U1FMVHJhbnNhY3Rpb25DYWxsYmFjaz4gY2FsbGJhY2ssIFBhc3NSZWZQdHI8U1FMVHJhbnNhY3Rp b25FcnJvckNhbGxiYWNrPiBlcnJvckNhbGxiYWNrLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBQYXNzUmVmUHRyPFZvaWRDYWxsYmFjaz4gc3VjY2Vzc0NhbGxiYWNrKQogewotICAgIG1f dHJhbnNhY3Rpb25RdWV1ZS5hcHBlbmQoU1FMVHJhbnNhY3Rpb246OmNyZWF0ZSh0aGlzLCBjYWxs YmFjaywgZXJyb3JDYWxsYmFjaywgc3VjY2Vzc0NhbGxiYWNrLCBDaGFuZ2VWZXJzaW9uV3JhcHBl cjo6Y3JlYXRlKG9sZFZlcnNpb24sIG5ld1ZlcnNpb24pKSk7CisgICAgUmVmUHRyPFNRTFRyYW5z YWN0aW9uPiB0cmFuc2FjdGlvbiA9CisgICAgICAgIFNRTFRyYW5zYWN0aW9uOjpjcmVhdGUodGhp cywgY2FsbGJhY2ssIGVycm9yQ2FsbGJhY2ssIHN1Y2Nlc3NDYWxsYmFjaywgQ2hhbmdlVmVyc2lv bldyYXBwZXI6OmNyZWF0ZShvbGRWZXJzaW9uLCBuZXdWZXJzaW9uKSk7CiAgICAgTXV0ZXhMb2Nr ZXIgbG9ja2VyKG1fdHJhbnNhY3Rpb25JblByb2dyZXNzTXV0ZXgpOworICAgIG1fdHJhbnNhY3Rp b25RdWV1ZS5hcHBlbmQodHJhbnNhY3Rpb24pOwogICAgIGlmICghbV90cmFuc2FjdGlvbkluUHJv Z3Jlc3MpCiAgICAgICAgIHNjaGVkdWxlVHJhbnNhY3Rpb24oKTsKIH0KQEAgLTI3Nyw4ICsyNzks MTAgQEAKIHZvaWQgRGF0YWJhc2U6OnJ1blRyYW5zYWN0aW9uKFBhc3NSZWZQdHI8U1FMVHJhbnNh Y3Rpb25DYWxsYmFjaz4gY2FsbGJhY2ssIFBhc3NSZWZQdHI8U1FMVHJhbnNhY3Rpb25FcnJvckNh bGxiYWNrPiBlcnJvckNhbGxiYWNrLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUGFz c1JlZlB0cjxWb2lkQ2FsbGJhY2s+IHN1Y2Nlc3NDYWxsYmFjaywgYm9vbCByZWFkT25seSkKIHsK LSAgICBtX3RyYW5zYWN0aW9uUXVldWUuYXBwZW5kKFNRTFRyYW5zYWN0aW9uOjpjcmVhdGUodGhp cywgY2FsbGJhY2ssIGVycm9yQ2FsbGJhY2ssIHN1Y2Nlc3NDYWxsYmFjaywgMCwgcmVhZE9ubHkp KTsKKyAgICBSZWZQdHI8U1FMVHJhbnNhY3Rpb24+IHRyYW5zYWN0aW9uID0KKyAgICAgICAgU1FM VHJhbnNhY3Rpb246OmNyZWF0ZSh0aGlzLCBjYWxsYmFjaywgZXJyb3JDYWxsYmFjaywgc3VjY2Vz c0NhbGxiYWNrLCAwLCByZWFkT25seSk7CiAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fdHJhbnNh Y3Rpb25JblByb2dyZXNzTXV0ZXgpOworICAgIG1fdHJhbnNhY3Rpb25RdWV1ZS5hcHBlbmQodHJh bnNhY3Rpb24pOwogICAgIGlmICghbV90cmFuc2FjdGlvbkluUHJvZ3Jlc3MpCiAgICAgICAgIHNj aGVkdWxlVHJhbnNhY3Rpb24oKTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5MzI4KQor KysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDItMjMgIENocmlzIEV2YW5zICA8Y2V2YW5zQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEYXRhYmFzZTogRGF0 YSByYWNlOiBzaG91bGQgb25seSB0b3VjaCB0aGUgdHJhbnNhY3Rpb24gcXVldWUgaW5zaWRlIHRo ZQorICAgICAgICBsb2NrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTUwMzEKKworICAgICAgICAqIHN0b3JhZ2UvRGF0YWJhc2UuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RGF0YWJhc2U6OmNoYW5nZVZlcnNpb24pOiBvbmx5IHRvdWNoIHF1ZXVlIGlu c2lkZSBsb2NrLgorICAgICAgICAoV2ViQ29yZTo6RGF0YWJhc2U6OnJ1blRyYW5zYWN0aW9uKTog b25seSB0b3VjaCBxdWV1ZSBpbnNpZGUgbG9jay4KKwogMjAxMS0wMi0yMiAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBT ZW1pa2hhdHNreS4K 83629 2011-02-24 03:22:13 -0800 2011-02-24 03:30:01 -0800 Patch 55031_2.diff text/plain 2369 cevans SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2UuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2UuY3BwCShyZXZpc2lvbiA3OTMyOCkKKysr IFNvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y NTgsOCArMjU4LDEwIEBACiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBhc3NSZWZQdHI8 U1FMVHJhbnNhY3Rpb25DYWxsYmFjaz4gY2FsbGJhY2ssIFBhc3NSZWZQdHI8U1FMVHJhbnNhY3Rp b25FcnJvckNhbGxiYWNrPiBlcnJvckNhbGxiYWNrLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBQYXNzUmVmUHRyPFZvaWRDYWxsYmFjaz4gc3VjY2Vzc0NhbGxiYWNrKQogewotICAgIG1f dHJhbnNhY3Rpb25RdWV1ZS5hcHBlbmQoU1FMVHJhbnNhY3Rpb246OmNyZWF0ZSh0aGlzLCBjYWxs YmFjaywgZXJyb3JDYWxsYmFjaywgc3VjY2Vzc0NhbGxiYWNrLCBDaGFuZ2VWZXJzaW9uV3JhcHBl cjo6Y3JlYXRlKG9sZFZlcnNpb24sIG5ld1ZlcnNpb24pKSk7CisgICAgUmVmUHRyPFNRTFRyYW5z YWN0aW9uPiB0cmFuc2FjdGlvbiA9CisgICAgICAgIFNRTFRyYW5zYWN0aW9uOjpjcmVhdGUodGhp cywgY2FsbGJhY2ssIGVycm9yQ2FsbGJhY2ssIHN1Y2Nlc3NDYWxsYmFjaywgQ2hhbmdlVmVyc2lv bldyYXBwZXI6OmNyZWF0ZShvbGRWZXJzaW9uLCBuZXdWZXJzaW9uKSk7CiAgICAgTXV0ZXhMb2Nr ZXIgbG9ja2VyKG1fdHJhbnNhY3Rpb25JblByb2dyZXNzTXV0ZXgpOworICAgIG1fdHJhbnNhY3Rp b25RdWV1ZS5hcHBlbmQodHJhbnNhY3Rpb24ucmVsZWFzZSgpKTsKICAgICBpZiAoIW1fdHJhbnNh Y3Rpb25JblByb2dyZXNzKQogICAgICAgICBzY2hlZHVsZVRyYW5zYWN0aW9uKCk7CiB9CkBAIC0y NzcsOCArMjc5LDEwIEBACiB2b2lkIERhdGFiYXNlOjpydW5UcmFuc2FjdGlvbihQYXNzUmVmUHRy PFNRTFRyYW5zYWN0aW9uQ2FsbGJhY2s+IGNhbGxiYWNrLCBQYXNzUmVmUHRyPFNRTFRyYW5zYWN0 aW9uRXJyb3JDYWxsYmFjaz4gZXJyb3JDYWxsYmFjaywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFBhc3NSZWZQdHI8Vm9pZENhbGxiYWNrPiBzdWNjZXNzQ2FsbGJhY2ssIGJvb2wgcmVh ZE9ubHkpCiB7Ci0gICAgbV90cmFuc2FjdGlvblF1ZXVlLmFwcGVuZChTUUxUcmFuc2FjdGlvbjo6 Y3JlYXRlKHRoaXMsIGNhbGxiYWNrLCBlcnJvckNhbGxiYWNrLCBzdWNjZXNzQ2FsbGJhY2ssIDAs IHJlYWRPbmx5KSk7CisgICAgUmVmUHRyPFNRTFRyYW5zYWN0aW9uPiB0cmFuc2FjdGlvbiA9Cisg ICAgICAgIFNRTFRyYW5zYWN0aW9uOjpjcmVhdGUodGhpcywgY2FsbGJhY2ssIGVycm9yQ2FsbGJh Y2ssIHN1Y2Nlc3NDYWxsYmFjaywgMCwgcmVhZE9ubHkpOwogICAgIE11dGV4TG9ja2VyIGxvY2tl cihtX3RyYW5zYWN0aW9uSW5Qcm9ncmVzc011dGV4KTsKKyAgICBtX3RyYW5zYWN0aW9uUXVldWUu YXBwZW5kKHRyYW5zYWN0aW9uLnJlbGVhc2UoKSk7CiAgICAgaWYgKCFtX3RyYW5zYWN0aW9uSW5Q cm9ncmVzcykKICAgICAgICAgc2NoZWR1bGVUcmFuc2FjdGlvbigpOwogfQpJbmRleDogU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwkocmV2aXNpb24gNzkzMjgpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMi0yNCAgQ2hyaXMgRXZhbnMgIDxjZXZhbnNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIERhdGFiYXNlOiBEYXRhIHJhY2U6IHNob3VsZCBvbmx5IHRvdWNoIHRoZSB0cmFuc2Fj dGlvbiBxdWV1ZSBpbnNpZGUgdGhlCisgICAgICAgIGxvY2suCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTAzMQorCisgICAgICAgICogc3RvcmFnZS9E YXRhYmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZTo6Y2hhbmdlVmVyc2lvbik6 IG9ubHkgdG91Y2ggcXVldWUgaW5zaWRlIGxvY2suCisgICAgICAgIChXZWJDb3JlOjpEYXRhYmFz ZTo6cnVuVHJhbnNhY3Rpb24pOiBvbmx5IHRvdWNoIHF1ZXVlIGluc2lkZSBsb2NrLgorCiAyMDEx LTAyLTIyICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5Lgo= 83630 2011-02-24 03:30:01 -0800 2011-02-26 01:16:19 -0800 Patch 55031_3.diff text/plain 2365 cevans SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2UuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2UuY3BwCShyZXZpc2lvbiA3OTMyOCkKKysr IFNvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y NTgsOCArMjU4LDEwIEBACiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBhc3NSZWZQdHI8 U1FMVHJhbnNhY3Rpb25DYWxsYmFjaz4gY2FsbGJhY2ssIFBhc3NSZWZQdHI8U1FMVHJhbnNhY3Rp b25FcnJvckNhbGxiYWNrPiBlcnJvckNhbGxiYWNrLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBQYXNzUmVmUHRyPFZvaWRDYWxsYmFjaz4gc3VjY2Vzc0NhbGxiYWNrKQogewotICAgIG1f dHJhbnNhY3Rpb25RdWV1ZS5hcHBlbmQoU1FMVHJhbnNhY3Rpb246OmNyZWF0ZSh0aGlzLCBjYWxs YmFjaywgZXJyb3JDYWxsYmFjaywgc3VjY2Vzc0NhbGxiYWNrLCBDaGFuZ2VWZXJzaW9uV3JhcHBl cjo6Y3JlYXRlKG9sZFZlcnNpb24sIG5ld1ZlcnNpb24pKSk7CisgICAgUmVmUHRyPFNRTFRyYW5z YWN0aW9uPiB0cmFuc2FjdGlvbiA9CisgICAgICAgIFNRTFRyYW5zYWN0aW9uOjpjcmVhdGUodGhp cywgY2FsbGJhY2ssIGVycm9yQ2FsbGJhY2ssIHN1Y2Nlc3NDYWxsYmFjaywgQ2hhbmdlVmVyc2lv bldyYXBwZXI6OmNyZWF0ZShvbGRWZXJzaW9uLCBuZXdWZXJzaW9uKSk7CiAgICAgTXV0ZXhMb2Nr ZXIgbG9ja2VyKG1fdHJhbnNhY3Rpb25JblByb2dyZXNzTXV0ZXgpOworICAgIG1fdHJhbnNhY3Rp b25RdWV1ZS5hcHBlbmQodHJhbnNhY3Rpb24ucmVsZWFzZSgpKTsKICAgICBpZiAoIW1fdHJhbnNh Y3Rpb25JblByb2dyZXNzKQogICAgICAgICBzY2hlZHVsZVRyYW5zYWN0aW9uKCk7CiB9CkBAIC0y NzcsOCArMjc5LDEwIEBACiB2b2lkIERhdGFiYXNlOjpydW5UcmFuc2FjdGlvbihQYXNzUmVmUHRy PFNRTFRyYW5zYWN0aW9uQ2FsbGJhY2s+IGNhbGxiYWNrLCBQYXNzUmVmUHRyPFNRTFRyYW5zYWN0 aW9uRXJyb3JDYWxsYmFjaz4gZXJyb3JDYWxsYmFjaywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFBhc3NSZWZQdHI8Vm9pZENhbGxiYWNrPiBzdWNjZXNzQ2FsbGJhY2ssIGJvb2wgcmVh ZE9ubHkpCiB7Ci0gICAgbV90cmFuc2FjdGlvblF1ZXVlLmFwcGVuZChTUUxUcmFuc2FjdGlvbjo6 Y3JlYXRlKHRoaXMsIGNhbGxiYWNrLCBlcnJvckNhbGxiYWNrLCBzdWNjZXNzQ2FsbGJhY2ssIDAs IHJlYWRPbmx5KSk7CisgICAgUmVmUHRyPFNRTFRyYW5zYWN0aW9uPiB0cmFuc2FjdGlvbiA9Cisg ICAgICAgIFNRTFRyYW5zYWN0aW9uOjpjcmVhdGUodGhpcywgY2FsbGJhY2ssIGVycm9yQ2FsbGJh Y2ssIHN1Y2Nlc3NDYWxsYmFjaywgMCwgcmVhZE9ubHkpOwogICAgIE11dGV4TG9ja2VyIGxvY2tl cihtX3RyYW5zYWN0aW9uSW5Qcm9ncmVzc011dGV4KTsKKyAgICBtX3RyYW5zYWN0aW9uUXVldWUu YXBwZW5kKHRyYW5zYWN0aW9uLnJlbGVhc2UoKSk7CiAgICAgaWYgKCFtX3RyYW5zYWN0aW9uSW5Q cm9ncmVzcykKICAgICAgICAgc2NoZWR1bGVUcmFuc2FjdGlvbigpOwogfQpJbmRleDogU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwkocmV2aXNpb24gNzkzMjgpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMi0yNCAgQ2hyaXMgRXZhbnMgIDxjZXZhbnNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCisKKyAgICAg ICAgRGF0YWJhc2U6IERhdGEgcmFjZTogc2hvdWxkIG9ubHkgdG91Y2ggdGhlIHRyYW5zYWN0aW9u IHF1ZXVlIGluc2lkZSB0aGUKKyAgICAgICAgbG9jay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MDMxCisKKyAgICAgICAgKiBzdG9yYWdlL0RhdGFi YXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFiYXNlOjpjaGFuZ2VWZXJzaW9uKTogb25s eSB0b3VjaCBxdWV1ZSBpbnNpZGUgbG9jay4KKyAgICAgICAgKFdlYkNvcmU6OkRhdGFiYXNlOjpy dW5UcmFuc2FjdGlvbik6IG9ubHkgdG91Y2ggcXVldWUgaW5zaWRlIGxvY2suCisKIDIwMTEtMDIt MjIgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCg==