55029 2011-02-23 03:17:14 -0800 [Qt] tst_QWebView::setPalette(activeFG) fails 2011-02-24 05:44:43 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 31742 1 ossy menard commit-queue kling menard oldest_to_newest 355974 0 ossy 2011-02-23 03:17:14 -0800 FAIL! : tst_QWebView::setPalette(activeBG) 'img1 != img2' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp(426)] FAIL! : tst_QWebView::setPalette(activeFG) 'img1 != img2' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp(426)] 355976 1 menard 2011-02-23 03:23:47 -0800 It's not a regression, the tests were added with the patch :). 355978 2 ossy 2011-02-23 03:25:22 -0800 (In reply to comment #1) > It's not a regression, the tests were added with the patch :). OK, it's not a regression. :) But tests introduced in r79409 still fail. 355983 3 menard 2011-02-23 03:29:37 -0800 But I'm on it :) 355986 4 ossy 2011-02-23 03:30:57 -0800 (In reply to comment #3) > But I'm on it :) Cool, thanks. ;) 356150 5 83491 menard 2011-02-23 09:37:40 -0800 Created attachment 83491 Patch to improve the auto-test. 356186 6 83491 ariya.hidayat 2011-02-23 10:45:00 -0800 Comment on attachment 83491 Patch to improve the auto-test. LGTM. re=me. 356214 7 83491 commit-queue 2011-02-23 11:03:50 -0800 Comment on attachment 83491 Patch to improve the auto-test. Clearing flags on attachment: 83491 Committed r79463: <http://trac.webkit.org/changeset/79463> 356215 8 commit-queue 2011-02-23 11:03:55 -0800 All reviewed patches have been landed. Closing bug. 356917 9 kling 2011-02-24 05:44:43 -0800 Committed r79552: <http://trac.webkit.org/changeset/79552> 83491 2011-02-23 09:37:40 -0800 2011-02-23 11:03:50 -0800 Patch to improve the auto-test. patch2.diff text/plain 2252 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggYzIxMTc3Zi4uMzI4MmM1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMS0wMi0yMyAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3Bl bmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbUXRdIHRzdF9RV2ViVmlldzo6c2V0UGFsZXR0ZShhY3RpdmVGRykgZmFpbHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MDI5CisKKyAgICAg ICAgQXR0ZW1wdCB0byBtYWtlIHRoZSB0ZXN0IG1vcmUgcm9idXN0LiBCeSBpbnZlc3RpZ2F0aW5n IHdpdGggdGhlIGJvdCB2aXJ0dWFsIG1hY2hpbmUKKyAgICAgICAgSSBkaXNjb3ZlcmVkIHRoYXQg dGhlIGFjdGl2YXRpb24gY2FuIHRha2Ugc29tZSB0aW1lLiBJbiB0aGlzIHBhdGNoIHdlIG1ha2Ug c3VyZSB0aGF0CisgICAgICAgIHRoZSBhY3RpdmUgd2luZG93IHdlIHdhbnQgdG8gaGF2ZSBpcyB0 aGUgc2FtZSBhcyB0aGUgUUFwcGxpY2F0aW9uLgorCisgICAgICAgICogdGVzdHMvcXdlYnZpZXcv dHN0X3F3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHRzdF9RV2ViVmlldzo6c2V0UGFsZXR0ZSk6CisK IDIwMTEtMDItMjIgIEZhYnJpemlvIE1hY2hhZG8gIDxmYWJyaXppby5tYWNoYWRvQG5va2lhLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9zLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9xdC90ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcuY3BwIGIvU291cmNlL1dl YktpdC9xdC90ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcuY3BwCmluZGV4IDY2NTc3MWIuLjBh MjhkMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnZpZXcvdHN0X3F3 ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJ2aWV3L3RzdF9xd2Vi dmlldy5jcHAKQEAgLTMzMyw2ICszMzMsOCBAQCB2b2lkIHRzdF9RV2ViVmlldzo6c2V0UGFsZXR0 ZSgpCiAgICAgUUZFVENIKGJvb2wsIGFjdGl2ZSk7CiAgICAgUUZFVENIKGJvb2wsIGJhY2tncm91 bmQpOwogCisgICAgUVdpZGdldCogYWN0aXZlVmlldyA9IDA7CisKICAgICAvLyBVc2UgY29udHJv bFZpZXcgdG8gbWFuYWdlIGFjdGl2ZS9pbmFjdGl2ZSBzdGF0ZSBvZiB0ZXN0IHZpZXdzIGJ5IHJh aXNpbmcKICAgICAvLyBvciBsb3dlcmluZyB0aGVpciBwb3NpdGlvbiBpbiB0aGUgd2luZG93IHN0 YWNrLgogICAgIFFXZWJWaWV3IGNvbnRyb2xWaWV3OwpAQCAtMzY4LDggKzM3MCwxMyBAQCB2b2lk IHRzdF9RV2ViVmlldzo6c2V0UGFsZXR0ZSgpCiAgICAgICAgIGNvbnRyb2xWaWV3LnNob3coKTsK ICAgICAgICAgY29udHJvbFZpZXcuYWN0aXZhdGVXaW5kb3coKTsKICAgICAgICAgUVRlc3Q6OnFX YWl0Rm9yV2luZG93U2hvd24oJmNvbnRyb2xWaWV3KTsKLSAgICB9IGVsc2UKKyAgICAgICAgYWN0 aXZlVmlldyA9ICZjb250cm9sVmlldzsKKyAgICB9IGVsc2UgewogICAgICAgICB2aWV3MS5hY3Rp dmF0ZVdpbmRvdygpOworICAgICAgICBhY3RpdmVWaWV3ID0gJnZpZXcxOworICAgIH0KKworICAg IFFUUllfQ09NUEFSRShRQXBwbGljYXRpb246OmFjdGl2ZVdpbmRvdygpLCBhY3RpdmVWaWV3KTsK IAogICAgIHZpZXcxLnBhZ2UoKS0+dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6U2VsZWN0QWxsKTsK IApAQCAtNDEwLDggKzQxNywxMyBAQCB2b2lkIHRzdF9RV2ViVmlldzo6c2V0UGFsZXR0ZSgpCiAg ICAgICAgIGNvbnRyb2xWaWV3LnNob3coKTsKICAgICAgICAgY29udHJvbFZpZXcuYWN0aXZhdGVX aW5kb3coKTsKICAgICAgICAgUVRlc3Q6OnFXYWl0Rm9yV2luZG93U2hvd24oJmNvbnRyb2xWaWV3 KTsKLSAgICB9IGVsc2UKKyAgICAgICAgYWN0aXZlVmlldyA9ICZjb250cm9sVmlldzsKKyAgICB9 IGVsc2UgewogICAgICAgICB2aWV3Mi5hY3RpdmF0ZVdpbmRvdygpOworICAgICAgICBhY3RpdmVW aWV3ID0gJnZpZXcyOworICAgIH0KKworICAgIFFUUllfQ09NUEFSRShRQXBwbGljYXRpb246OmFj dGl2ZVdpbmRvdygpLCBhY3RpdmVWaWV3KTsKIAogICAgIHZpZXcyLnBhZ2UoKS0+dHJpZ2dlckFj dGlvbihRV2ViUGFnZTo6U2VsZWN0QWxsKTsKIAo=