<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>55021</bug_id>
          
          <creation_ts>2011-02-22 21:03:08 -0800</creation_ts>
          <short_desc>[EFL] Scroll doesn&apos;t work on tiled backing store</short_desc>
          <delta_ts>2011-04-21 10:46:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>58802</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eunsol Park">eunsol47.park</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>antognolli+webkit</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>k.blank</cc>
    
    <cc>kenneth</cc>
    
    <cc>kling</cc>
    
    <cc>leandro</cc>
    
    <cc>l.slachciak</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>355815</commentid>
    <comment_count>0</comment_count>
    <who name="Eunsol Park">eunsol47.park</who>
    <bug_when>2011-02-22 21:03:08 -0800</bug_when>
    <thetext>Scroll doesn&apos;t work on tiled backing store, but it works on single.
There is no Scroll bar when receiving mouse wheel event, because paintsEntireContents() set TRUE.
paintsEntireContents() is set on Tiled backing store in QT port and EFL port. 
I analyzed that it wouldn&apos;t be needed on EFL port, because tiled backing store process is different from QT.

Patch will be uploaded after more analysis.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>365811</commentid>
    <comment_count>1</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2011-03-10 21:29:47 -0800</bug_when>
    <thetext>Now, EWebLauncher starts to use single backing store instead of tiled&apos;s because of some problems. When you test a patch for this bug, please reference to this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>385479</commentid>
    <comment_count>2</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2011-04-13 20:38:09 -0700</bug_when>
    <thetext>Eunsol, when do you upload your patch ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387620</commentid>
    <comment_count>3</comment_count>
      <attachid>90013</attachid>
    <who name="Eunsol Park">eunsol47.park</who>
    <bug_when>2011-04-18 03:56:08 -0700</bug_when>
    <thetext>Created attachment 90013
proposed patch

I uploaded patch, please review this.
If ewk_frame_paint_full_set() set True, view size return content size and scroll can&apos;t be made. 
Calling ewk_frame_paint_full_set() is removed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387621</commentid>
    <comment_count>4</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2011-04-18 03:59:42 -0700</bug_when>
    <thetext>Demarchi, my colleague makes a patch for this bug. Please review this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387677</commentid>
    <comment_count>5</comment_count>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-04-18 06:48:57 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Demarchi, my colleague makes a patch for this bug. Please review this.

CC&apos;ing Antognolli, who knows more about the tiled backing store</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387765</commentid>
    <comment_count>6</comment_count>
      <attachid>90013</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-04-18 09:09:43 -0700</bug_when>
    <thetext>Comment on attachment 90013
proposed patch

How do we test this?  I&apos;m not sure the EFL port if far enough along to even run the tests, so maybe it doesn&apos;t matter.  But all changes required layout tests if possible in WebKit. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387830</commentid>
    <comment_count>7</comment_count>
      <attachid>90013</attachid>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-04-18 10:12:52 -0700</bug_when>
    <thetext>Comment on attachment 90013
proposed patch

I prefer to wait for Antognolli reviewing this. I think it&apos;s plain wrong.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387831</commentid>
    <comment_count>8</comment_count>
      <attachid>90013</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-18 10:13:25 -0700</bug_when>
    <thetext>Comment on attachment 90013
proposed patch

Clearing flags on attachment: 90013

Committed r84155: &lt;http://trac.webkit.org/changeset/84155&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387832</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-18 10:13:31 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387840</commentid>
    <comment_count>10</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-04-18 10:19:11 -0700</bug_when>
    <thetext>My appologies.  Feel free to roll out.

sheriff-bot rollout 84155 REASON
 on IRC.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387843</commentid>
    <comment_count>11</comment_count>
    <who name="Rafael Antognolli">antognolli+webkit</who>
    <bug_when>2011-04-18 10:26:47 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; Scroll doesn&apos;t work on tiled backing store, but it works on single.
&gt; There is no Scroll bar when receiving mouse wheel event, because paintsEntireContents() set TRUE.
&gt; paintsEntireContents() is set on Tiled backing store in QT port and EFL port. 
&gt; I analyzed that it wouldn&apos;t be needed on EFL port, because tiled backing store process is different from QT.
&gt; 
&gt; Patch will be uploaded after more analysis.

Eunsol,

I&apos;ve made the first patch for adding the paintEntireContents flag, and I made it because the EFL port required it. The Qt port also started using it at the same time, because they were also implementing a tiled backing store (the one that is inside WebCore now).

This flag needs to be set if you want to paint anything outside of the screen, otherwise the paint area will be clipped to the viewport and no pre-rendering can be made. So just disabling it will probably break the tiled backing store anyway (I can&apos;t check it right now).

The view size returns the content size instead of viewport size when the paintEntireContents is set because of this change: http://trac.webkit.org/changeset/72242/trunk/WebCore/platform/ScrollView.cpp

I believe that the Qt port has a good reason for this change, but it just broke us. So we need to fix this on some other way.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387932</commentid>
    <comment_count>12</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-18 12:21:08 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/84155 might have broken GTK Linux 32-bit Debug</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>388152</commentid>
    <comment_count>13</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2011-04-18 16:19:27 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 90013 [details])
&gt; How do we test this?  I&apos;m not sure the EFL port if far enough along to even run the tests, so maybe it doesn&apos;t matter.  But all changes required layout tests if possible in WebKit. :)


Bug 44500 is a patch for EFL Layout Test. My colleagues will revise the patch as soon as they finish current work. :-)
 
Bug 44500 - [EFL] API for Dump Render Tree application</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>388430</commentid>
    <comment_count>14</comment_count>
      <attachid>90184</attachid>
    <who name="Eunsol Park">eunsol47.park</who>
    <bug_when>2011-04-19 05:39:51 -0700</bug_when>
    <thetext>Created attachment 90184
proposed patch

Scrolling in QT tiled backing store works using delegatedScrollRequested() in webcore.
EFL can&apos;t use this function, because it depends on some other functions for QT tiled backing store.
As you know, EFL is implemented differently, so it&apos;s difficult to modify as similar to QT backing store. 
So, I want to change Veiw size in ScrollView.

I removed the change below and test, and I checked it worked fine.
http://trac.webkit.org/changeset/72242/trunk/WebCore/platform/ScrollView.cpp

So, this patch is the defence of the change in only EFL port.
akrekde</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>388436</commentid>
    <comment_count>15</comment_count>
      <attachid>90184</attachid>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-04-19 05:58:20 -0700</bug_when>
    <thetext>Comment on attachment 90184
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90184&amp;action=review

&gt; Source/WebCore/platform/ScrollView.cpp:240
&gt; +// FIXME:EFL does not work scrolling with tiled backing store.
&gt; +// https://bugs.webkit.org/show_bug.cgi?id=55021
&gt; +#if !PLATFORM(EFL)
&gt;      if (paintsEntireContents())
&gt;          return IntRect(IntPoint(0, 0), contentsSize());
&gt; +#endif

LGTM, but there&apos;s no need to keep this comment in code. Antognolli, what do you think?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>388440</commentid>
    <comment_count>16</comment_count>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-04-19 06:02:45 -0700</bug_when>
    <thetext>Reopen for the evaluation of a new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>388507</commentid>
    <comment_count>17</comment_count>
    <who name="Rafael Antognolli">antognolli+webkit</who>
    <bug_when>2011-04-19 07:51:00 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; (From update of attachment 90184 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=90184&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/platform/ScrollView.cpp:240
&gt; &gt; +// FIXME:EFL does not work scrolling with tiled backing store.
&gt; &gt; +// https://bugs.webkit.org/show_bug.cgi?id=55021
&gt; &gt; +#if !PLATFORM(EFL)
&gt; &gt;      if (paintsEntireContents())
&gt; &gt;          return IntRect(IntPoint(0, 0), contentsSize());
&gt; &gt; +#endif
&gt; 
&gt; LGTM, but there&apos;s no need to keep this comment in code. Antognolli, what do you think?

LGTM too, and the comment could also be removed. I&apos;m adding Andreas Kling, since he&apos;s the one who made the patch that changed this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>388939</commentid>
    <comment_count>18</comment_count>
    <who name="Eunsol Park">eunsol47.park</who>
    <bug_when>2011-04-19 17:31:31 -0700</bug_when>
    <thetext>OK, I will remove the comment and upload patch again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>388958</commentid>
    <comment_count>19</comment_count>
      <attachid>90284</attachid>
    <who name="Eunsol Park">eunsol47.park</who>
    <bug_when>2011-04-19 17:55:47 -0700</bug_when>
    <thetext>Created attachment 90284
proposed patch

The comment was removed in this patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>389292</commentid>
    <comment_count>20</comment_count>
      <attachid>90284</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2011-04-20 09:42:26 -0700</bug_when>
    <thetext>Comment on attachment 90284
proposed patch

Would not it be clearer if from FrameLoaderClientEFL::transitionToCommittedForNewPage (when frame view is created) you do:

...
m_frame-&gt;createView(blablabla);
...
m_frame-&gt;view()-&gt;setPaintsEntireContents(false);
}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>389304</commentid>
    <comment_count>21</comment_count>
    <who name="Rafael Antognolli">antognolli+webkit</who>
    <bug_when>2011-04-20 09:56:26 -0700</bug_when>
    <thetext>(In reply to comment #20)
&gt; (From update of attachment 90284 [details])
&gt; Would not it be clearer if from FrameLoaderClientEFL::transitionToCommittedForNewPage (when frame view is created) you do:
&gt; 
&gt; ...
&gt; m_frame-&gt;createView(blablabla);
&gt; ...
&gt; m_frame-&gt;view()-&gt;setPaintsEntireContents(false);
&gt; }

But we need paintEntireContents set to True in order to make our tiled backing store work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>389320</commentid>
    <comment_count>22</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2011-04-20 10:15:43 -0700</bug_when>
    <thetext>(In reply to comment #21)
&gt; (In reply to comment #20)
&gt; &gt; (From update of attachment 90284 [details] [details])
&gt; &gt; Would not it be clearer if from FrameLoaderClientEFL::transitionToCommittedForNewPage (when frame view is created) you do:
&gt; &gt; 
&gt; &gt; ...
&gt; &gt; m_frame-&gt;createView(blablabla);
&gt; &gt; ...
&gt; &gt; m_frame-&gt;view()-&gt;setPaintsEntireContents(false);
&gt; &gt; }
&gt; 
&gt; But we need paintEntireContents set to True in order to make our tiled backing store work.

so it needs to be true, but you still need it to clip painting to the viewport? I did not understood the problem, I think ... :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>389323</commentid>
    <comment_count>23</comment_count>
    <who name="Rafael Antognolli">antognolli+webkit</who>
    <bug_when>2011-04-20 10:19:18 -0700</bug_when>
    <thetext>(In reply to comment #22)
&gt; (In reply to comment #21)
&gt; &gt; (In reply to comment #20)
&gt; &gt; &gt; (From update of attachment 90284 [details] [details] [details])
&gt; &gt; &gt; Would not it be clearer if from FrameLoaderClientEFL::transitionToCommittedForNewPage (when frame view is created) you do:
&gt; &gt; &gt; 
&gt; &gt; &gt; ...
&gt; &gt; &gt; m_frame-&gt;createView(blablabla);
&gt; &gt; &gt; ...
&gt; &gt; &gt; m_frame-&gt;view()-&gt;setPaintsEntireContents(false);
&gt; &gt; &gt; }
&gt; &gt; 
&gt; &gt; But we need paintEntireContents set to True in order to make our tiled backing store work.
&gt; 
&gt; so it needs to be true, but you still need it to clip painting to the viewport? I did not understood the problem, I think ... :(

hmm... sorry, maybe I wasn&apos;t clear. But we need it to be true because we *don&apos;t want* to clip painting to the viewport. We need to be able to paint things outside of the viewport too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>389853</commentid>
    <comment_count>24</comment_count>
    <who name="Eunsol Park">eunsol47.park</who>
    <bug_when>2011-04-20 22:46:51 -0700</bug_when>
    <thetext>(In reply to comment #23)
&gt; (In reply to comment #22)
&gt; &gt; (In reply to comment #21)
&gt; &gt; &gt; (In reply to comment #20)
&gt; &gt; &gt; &gt; (From update of attachment 90284 [details] [details] [details] [details])
&gt; &gt; &gt; &gt; Would not it be clearer if from FrameLoaderClientEFL::transitionToCommittedForNewPage (when frame view is created) you do:
&gt; &gt; &gt; &gt; 
&gt; &gt; &gt; &gt; ...
&gt; &gt; &gt; &gt; m_frame-&gt;createView(blablabla);
&gt; &gt; &gt; &gt; ...
&gt; &gt; &gt; &gt; m_frame-&gt;view()-&gt;setPaintsEntireContents(false);
&gt; &gt; &gt; &gt; }
&gt; &gt; &gt; 
&gt; &gt; &gt; But we need paintEntireContents set to True in order to make our tiled backing store work.
&gt; &gt; 
&gt; &gt; so it needs to be true, but you still need it to clip painting to the viewport? I did not understood the problem, I think ... :(
&gt; 
&gt; hmm... sorry, maybe I wasn&apos;t clear. But we need it to be true because we *don&apos;t want* to clip painting to the viewport. We need to be able to paint things outside of the viewport too.

Dear,Antonio Gomes

1st patch I uploaded was modified like your opinion, 
because ewk_frame_paint_full_set() calls setPaintsEntireContents().
I removed ewk_frame_paint_full_set() in 1st patch.

But 1st one had error to paint out of the viewport, so I modified to 2nd patch.
I checked it solved in 2nd patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390063</commentid>
    <comment_count>25</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-21 08:55:06 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 90284:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390067</commentid>
    <comment_count>26</comment_count>
      <attachid>90284</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-21 08:58:31 -0700</bug_when>
    <thetext>Comment on attachment 90284
proposed patch

Clearing flags on attachment: 90284

Committed r84505: &lt;http://trac.webkit.org/changeset/84505&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390068</commentid>
    <comment_count>27</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-21 08:58:36 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>390149</commentid>
    <comment_count>28</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-21 10:46:03 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/84505 might have broken GTK Linux 32-bit Release</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90013</attachid>
            <date>2011-04-18 03:56:08 -0700</date>
            <delta_ts>2011-04-19 05:39:51 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>scroll.patch</filename>
            <type>text/plain</type>
            <size>1454</size>
            <attacher name="Eunsol Park">eunsol47.park</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv
ZWZsL0NoYW5nZUxvZwpvbGQgbW9kZSAxMDA2NDQKbmV3IG1vZGUgMTAwNzU1CmluZGV4IDI0ZmU1
NWEuLjQ1YTM0ZTgKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTA0LTE4ICBFdW5z
b2wgUGFyayAgPGV1bnNvbDQ3LnBhcmtAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0VGTF0gU2Nyb2xsIGRvZXNuJ3Qgd29yayBv
biB0aWxlZCBiYWNraW5nIHN0b3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD01NTAyMQorCisgICAgICAgIFNjcm9sbCBkb2Vzbid0IHdvcmsgb24gdGls
ZWQgYmFja2luZyBzdG9yZSwgYnV0IGl0IHdvcmtzIG9uIHNpbmdsZS4KKyAgICAgICAgSWYgZXdr
X2ZyYW1lX3BhaW50X2Z1bGxfc2V0KCkgc2V0IFRydWUsIHZpZXcgc2l6ZSByZXR1cm4gY29udGVu
dCBzaXplIGFuZCBzY3JvbGwgY2FuJ3QgYmUgbWFkZS4gCisgICAgICAgIHNvLCBld2tfZnJhbWVf
cGFpbnRfZnVsbF9zZXQoKSBpcyByZW1vdmVkIGZyb20gZXdrX3RpbGVkX3NtYXJ0X2FkZCgpLgor
CisgICAgICAgICogZXdrL2V3a192aWV3X3RpbGVkLmM6CisgICAgICAgIChfZXdrX3ZpZXdfdGls
ZWRfc21hcnRfYWRkKToKKwogMjAxMS0wNC0xNCAgR3J6ZWdvcnogQ3phamtvd3NraSAgPGcuY3ph
amtvd3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVz
LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3RpbGVkLmMgYi9T
b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfdGlsZWQuYwpvbGQgbW9kZSAxMDA2NDQKbmV3
IG1vZGUgMTAwNzU1CmluZGV4IGQzODBlOGUuLjRkOWI4MmIKLS0tIGEvU291cmNlL1dlYktpdC9l
ZmwvZXdrL2V3a192aWV3X3RpbGVkLmMKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192
aWV3X3RpbGVkLmMKQEAgLTc0LDcgKzc0LDYgQEAgc3RhdGljIHZvaWQgX2V3a192aWV3X3RpbGVk
X3NtYXJ0X2FkZChFdmFzX09iamVjdCAqbykKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFj
a19hZGQoCiAgICAgICAgIHNkLT5tYWluX2ZyYW1lLCAiY29udGVudHMsc2l6ZSxjaGFuZ2VkIiwK
ICAgICAgICAgX2V3a192aWV3X3RpbGVkX2NvbnRlbnRzX3NpemVfY2hhbmdlZF9jYiwgc2QpOwot
ICAgIGV3a19mcmFtZV9wYWludF9mdWxsX3NldChzZC0+bWFpbl9mcmFtZSwgRUlOQV9UUlVFKTsK
IH0KIAogc3RhdGljIEVpbmFfQm9vbCBfZXdrX3ZpZXdfdGlsZWRfc21hcnRfc2Nyb2xsc19wcm9j
ZXNzKEV3a19WaWV3X1NtYXJ0X0RhdGEgKnNkKQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90184</attachid>
            <date>2011-04-19 05:39:51 -0700</date>
            <delta_ts>2011-04-19 17:55:47 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>scroll_2nd.patch</filename>
            <type>text/plain</type>
            <size>1551</size>
            <attacher name="Eunsol Park">eunsol47.park</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxZWYwMTU4Li5mMjVkNzAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTEtMDQtMTkgIEV1bnNvbCBQYXJrICA8ZXVuc29sNDcucGFya0BzYW1zdW5nLmNvbT4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBT
Y3JvbGwgZG9lc24ndCB3b3JrIG9uIHRpbGVkIGJhY2tpbmcgc3RvcmUuCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTAyMQorCisgICAgICAgIEl0IHdh
cyBhZGRlZCBmcm9tIENoYW5nZXNldCA3MjI0MiwgYnV0IGl0IG1hZGUgYSBzY3JvbGwgcHJvYmxl
bSBpbiBFRkwgcG9ydC4KKyAgICAgICAgVGhlIHZpc2libGUgcmVjdCBzaG91bGQgbm90IGJlIHJl
dHVybmVkIGFzIGNvbnRlbnQgcmVjdCBmb3Igc2Nyb2xsaW5nIGluIEVGTCB0aWxlZCBiYWNraW5n
IHN0b3JlLgorCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OlNjcm9sbFZpZXc6OnZpc2libGVDb250ZW50UmVjdCk6CisKIDIwMTEtMDQtMTkg
IEpvaG4gR3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg
RGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xs
Vmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAppbmRleCA3
Y2FmODIwLi4wNzgxM2Y4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3Jv
bGxWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcApA
QCAtMjMyLDggKzIzMiwxMiBAQCBJbnRSZWN0IFNjcm9sbFZpZXc6OnZpc2libGVDb250ZW50UmVj
dChib29sIGluY2x1ZGVTY3JvbGxiYXJzKSBjb25zdAogICAgIGlmIChwbGF0Zm9ybVdpZGdldCgp
KQogICAgICAgICByZXR1cm4gcGxhdGZvcm1WaXNpYmxlQ29udGVudFJlY3QoaW5jbHVkZVNjcm9s
bGJhcnMpOwogCisvLyBGSVhNRTpFRkwgZG9lcyBub3Qgd29yayBzY3JvbGxpbmcgd2l0aCB0aWxl
ZCBiYWNraW5nIHN0b3JlLgorLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTU1MDIxCisjaWYgIVBMQVRGT1JNKEVGTCkKICAgICBpZiAocGFpbnRzRW50aXJlQ29udGVu
dHMoKSkKICAgICAgICAgcmV0dXJuIEludFJlY3QoSW50UG9pbnQoMCwgMCksIGNvbnRlbnRzU2l6
ZSgpKTsKKyNlbmRpZgogCiAgICAgaW50IHZlcnRpY2FsU2Nyb2xsYmFyV2lkdGggPSB2ZXJ0aWNh
bFNjcm9sbGJhcigpICYmICF2ZXJ0aWNhbFNjcm9sbGJhcigpLT5pc092ZXJsYXlTY3JvbGxiYXIo
KQogICAgICAgICAmJiAhaW5jbHVkZVNjcm9sbGJhcnMgPyB2ZXJ0aWNhbFNjcm9sbGJhcigpLT53
aWR0aCgpIDogMDsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90284</attachid>
            <date>2011-04-19 17:55:47 -0700</date>
            <delta_ts>2011-04-21 08:58:30 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>scroll_3rd.patch</filename>
            <type>text/plain</type>
            <size>1472</size>
            <attacher name="Eunsol Park">eunsol47.park</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAzMzFkYWFhLi41YWVhMjA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTEtMDQtMTkgIEV1bnNvbCBQYXJrICA8ZXVuc29sNDcucGFya0BzYW1zdW5nLmNvbT4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBT
Y3JvbGwgZG9lc24ndCB3b3JrIG9uIHRpbGVkIGJhY2tpbmcgc3RvcmUuCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTAyMQorCisgICAgICAgIEl0IHdh
cyBhZGRlZCBmcm9tIENoYW5nZXNldCA3MjI0MiwgYnV0IGl0IHdvcmtlZCB3cm9uZyBpbiBFRkwg
cG9ydC4KKyAgICAgICAgVGhlIHZpc2libGUgcmVjdCBzaG91bGQgbm90IGJlIHJldHVybmVkIGFz
IGNvbnRlbnQgcmVjdCBmb3Igc2Nyb2xsaW5nIGluIEVGTCB0aWxlZCBiYWNraW5nIHN0b3JlLCAK
KyAgICAgICAgYmVjYXVzZSBpdCB3b3JrcyBkaWZmZXJlbnRseSBmcm9tIFFULgorCisgICAgICAg
ICogcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3
Ojp2aXNpYmxlQ29udGVudFJlY3QpOgorCiAyMDExLTA0LTE5ICBSeW9zdWtlIE5pd2EgIDxybml3
YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCBiL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IDdjYWY4MjAuLmQ5NDZlZjIgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBAIC0yMzIsOCArMjMyLDEwIEBAIElu
dFJlY3QgU2Nyb2xsVmlldzo6dmlzaWJsZUNvbnRlbnRSZWN0KGJvb2wgaW5jbHVkZVNjcm9sbGJh
cnMpIGNvbnN0CiAgICAgaWYgKHBsYXRmb3JtV2lkZ2V0KCkpCiAgICAgICAgIHJldHVybiBwbGF0
Zm9ybVZpc2libGVDb250ZW50UmVjdChpbmNsdWRlU2Nyb2xsYmFycyk7CiAKKyNpZiAhUExBVEZP
Uk0oRUZMKQogICAgIGlmIChwYWludHNFbnRpcmVDb250ZW50cygpKQogICAgICAgICByZXR1cm4g
SW50UmVjdChJbnRQb2ludCgwLCAwKSwgY29udGVudHNTaXplKCkpOworI2VuZGlmCiAKICAgICBp
bnQgdmVydGljYWxTY3JvbGxiYXJXaWR0aCA9IHZlcnRpY2FsU2Nyb2xsYmFyKCkgJiYgIXZlcnRp
Y2FsU2Nyb2xsYmFyKCktPmlzT3ZlcmxheVNjcm9sbGJhcigpCiAgICAgICAgICYmICFpbmNsdWRl
U2Nyb2xsYmFycyA/IHZlcnRpY2FsU2Nyb2xsYmFyKCktPndpZHRoKCkgOiAwOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>