55014 2011-02-22 19:20:59 -0800 Per-page minimum DOMTimer interval broken for repeating timers 2011-02-23 10:00:29 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 54312 1 kbr kbr fishd jamesr simon.fraser oldest_to_newest 355769 0 kbr 2011-02-22 19:20:59 -0800 The logic added in https://bugs.webkit.org/show_bug.cgi?id=54312 is broken for the case of repeating timers, i.e., those set via setInterval() rather than setTimeout(). The error occurs when the minimum interval is decreased and the timer's repeat interval has already been clamped to the larger value. The current code fails to decrease the repeat interval, leaving the timer running at the slower rate. 355788 1 83433 kbr 2011-02-22 19:42:55 -0800 Created attachment 83433 Patch 356161 2 kbr 2011-02-23 10:00:29 -0800 Committed r79455: <http://trac.webkit.org/changeset/79455> 83433 2011-02-22 19:42:55 -0800 2011-02-22 22:50:21 -0800 Patch bug-55014-20110222194254.patch text/plain 7664 kbr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5MzkxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMjIgIEtlbm5ldGgg UnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFBlci1wYWdlIG1pbmltdW0gRE9NVGltZXIgaW50ZXJ2YWwgYnJv a2VuIGZvciByZXBlYXRpbmcgdGltZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01NTAxNAorCisgICAgICAgIFdoZW4gdGhlIG1pbmltdW0gdGltZXIg aW50ZXJ2YWwgaXMgYWRqdXN0ZWQsIGlmIHRoZSB0aW1lciBpcworICAgICAgICByZXBlYXRpbmcs IGNhdXNlIGl0cyByZXBlYXQgaW50ZXJ2YWwgdG8gYmUgc2V0IHRvIGl0cyBvcmlnaW5hbAorICAg ICAgICB0aW1lb3V0IGNsYW1wZWQgdG8gdGhlIG5ldyBtaW5pbXVtIGludGVydmFsLgorCisgICAg ICAgIFRlc3RzOiBmYXN0L2RvbS90aW1lci1pbmNyZWFzZS1taW4taW50ZXJ2YWwtcmVwZWF0aW5n Lmh0bWwKKyAgICAgICAgICAgICAgIGZhc3QvZG9tL3RpbWVyLWluY3JlYXNlLXRoZW4tZGVjcmVh c2UtbWluLWludGVydmFsLXJlcGVhdGluZy5odG1sCisKKyAgICAgICAgKiBwYWdlL0RPTVRpbWVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVRpbWVyOjphZGp1c3RNaW5pbXVtVGltZXJJbnRl cnZhbCk6CisKIDIwMTEtMDItMjIgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21h aWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI3OTM2Ny4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NVGltZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BhZ2UvRE9NVGltZXIuY3BwCShyZXZpc2lvbiA3OTM4NCkKKysrIFNvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NVGltZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTMsOCArMTUzLDE2IEBA IHZvaWQgRE9NVGltZXI6OmFkanVzdE1pbmltdW1UaW1lckludGVydmEKIHsKICAgICBpZiAobV9u ZXN0aW5nTGV2ZWwgPCBtYXhUaW1lck5lc3RpbmdMZXZlbCkKICAgICAgICAgcmV0dXJuOworCisg ICAgZG91YmxlIG5ld01pbmltdW1JbnRlcnZhbCA9IHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+ bWluaW11bVRpbWVySW50ZXJ2YWwoKTsKKyAgICBkb3VibGUgbmV3Q2xhbXBlZEludGVydmFsID0g aW50ZXJ2YWxDbGFtcGVkVG9NaW5pbXVtKG1fb3JpZ2luYWxUaW1lb3V0LCBuZXdNaW5pbXVtSW50 ZXJ2YWwpOworCisgICAgaWYgKHJlcGVhdEludGVydmFsKCkpIHsKKyAgICAgICAgYXVnbWVudFJl cGVhdEludGVydmFsKG5ld0NsYW1wZWRJbnRlcnZhbCAtIHJlcGVhdEludGVydmFsKCkpOworICAg ICAgICByZXR1cm47CisgICAgfQorCiAgICAgZG91YmxlIHByZXZpb3VzQ2xhbXBlZEludGVydmFs ID0gaW50ZXJ2YWxDbGFtcGVkVG9NaW5pbXVtKG1fb3JpZ2luYWxUaW1lb3V0LCBvbGRNaW5pbXVt VGltZXJJbnRlcnZhbCk7Ci0gICAgZG91YmxlIG5ld0NsYW1wZWRJbnRlcnZhbCA9IGludGVydmFs Q2xhbXBlZFRvTWluaW11bShtX29yaWdpbmFsVGltZW91dCwgc2NyaXB0RXhlY3V0aW9uQ29udGV4 dCgpLT5taW5pbXVtVGltZXJJbnRlcnZhbCgpKTsKICAgICBhdWdtZW50RmlyZUludGVydmFsKG5l d0NsYW1wZWRJbnRlcnZhbCAtIHByZXZpb3VzQ2xhbXBlZEludGVydmFsKTsKIH0KIApJbmRleDog TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxv ZwkocmV2aXNpb24gNzkzOTEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwyMCBAQAorMjAxMS0wMi0yMiAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdv b2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUGVyLXBhZ2UgbWluaW11bSBET01UaW1lciBpbnRlcnZhbCBicm9rZW4gZm9yIHJlcGVhdGlu ZyB0aW1lcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU1MDE0CisKKyAgICAgICAgQWRkIHRlc3RzIHVzaW5nIHNldEludGVydmFsIHJhdGhlciB0aGFu IHNldFRpbWVvdXQuCisgICAgICAgIHRpbWVyLWluY3JlYXNlLXRoZW4tZGVjcmVhc2UtbWluLWlu dGVydmFsLXJlcGVhdGluZy5odG1sIGNhdGNoZXMKKyAgICAgICAgdGhlIGJ1Zy4KKworICAgICAg ICAqIGZhc3QvZG9tL3RpbWVyLWluY3JlYXNlLW1pbi1pbnRlcnZhbC1yZXBlYXRpbmctZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS90aW1lci1pbmNyZWFzZS1taW4taW50 ZXJ2YWwtcmVwZWF0aW5nLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL3RpbWVyLWlu Y3JlYXNlLXRoZW4tZGVjcmVhc2UtbWluLWludGVydmFsLXJlcGVhdGluZy1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL3RpbWVyLWluY3JlYXNlLXRoZW4tZGVjcmVhc2Ut bWluLWludGVydmFsLXJlcGVhdGluZy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9t YWMtd2syL1NraXBwZWQ6CisKIDIwMTEtMDItMjIgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBDaHJvbWl1bSBleHBlY3RhdGlvbnMg dXBkYXRlLiBVbmNvbW1lbnQgU05PV0xFT1BBUkQKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9t L3RpbWVyLWluY3JlYXNlLW1pbi1pbnRlcnZhbC1yZXBlYXRpbmctZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL3RpbWVyLWluY3JlYXNlLW1pbi1pbnRlcnZh bC1yZXBlYXRpbmctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFz dC9kb20vdGltZXItaW5jcmVhc2UtbWluLWludGVydmFsLXJlcGVhdGluZy1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMyBAQAorUEFTUworCisKSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvZG9tL3RpbWVyLWluY3JlYXNlLW1pbi1pbnRlcnZhbC1yZXBlYXRpbmcuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS90aW1lci1pbmNyZWFzZS1taW4taW50ZXJ2 YWwtcmVwZWF0aW5nLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS90 aW1lci1pbmNyZWFzZS1taW4taW50ZXJ2YWwtcmVwZWF0aW5nLmh0bWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsNDUgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgorZnVuY3Rpb24gbG9nKG1z ZykgeworICAgIHZhciBlbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7Cisg ICAgZWxlbWVudC50ZXh0Q29udGVudCA9IG1zZzsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENo aWxkKGVsZW1lbnQpOworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgiYnIiKSk7Cit9CisKK3ZhciBjb3VudCA9IDA7CitmdW5jdGlvbiBmYXN0VGlt ZW91dEhhbmRsZXIoKSB7CisgICAgKytjb3VudDsKK30KKworZnVuY3Rpb24gc2xvd1RpbWVvdXRI YW5kbGVyKCkgeworICAgIC8vIE5vdGU6IHRoZSBjb3VudCB0aHJlc2hvbGQgaXMgdGllZCBzb21l d2hhdCB0byB0aGUKKyAgICAvLyBtYXhUaW1lck5lc3RpbmdMZXZlbCBpbiBET01UaW1lci5jcHAu CisgICAgaWYgKGNvdW50IDwgMTApCisgICAgICAgIGxvZygiUEFTUyIpOworICAgIGVsc2UKKyAg ICAgICAgbG9nKCJGQUlMIC0tIHRpbWVvdXQgcmFuICIgKyBjb3VudCArICIgdGltZXMiKTsKKyAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Cit9CisKK2Z1bmN0aW9uIHJ1blRl c3QoKSB7CisgICAgaWYgKCF3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAg bG9nKCJUaGlzIHRlc3QgcmVxdWlyZXMgdGhlIExheW91dFRlc3RDb250cm9sbGVyIik7CisgICAg ICAgIHJldHVybjsKKyAgICB9CisKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworCisgICAgLy8g TWFrZSB0aW1lcnMgcnVuIG5vIG1vcmUgb2Z0ZW4gdGhhbiB0d2ljZSBhIHNlY29uZC4KKyAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5zZXRNaW5pbXVtVGltZXJJbnRlcnZhbCgwLjUpOworCisgICAg c2V0SW50ZXJ2YWwoc2xvd1RpbWVvdXRIYW5kbGVyLCAxMDAwKTsKKyAgICBzZXRJbnRlcnZhbChm YXN0VGltZW91dEhhbmRsZXIsIDEpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxv YWQ9InJ1blRlc3QoKSI+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2RvbS90aW1lci1pbmNyZWFzZS10aGVuLWRlY3JlYXNlLW1pbi1pbnRlcnZhbC1yZXBlYXRpbmct ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL3RpbWVyLWlu Y3JlYXNlLXRoZW4tZGVjcmVhc2UtbWluLWludGVydmFsLXJlcGVhdGluZy1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS90aW1lci1pbmNyZWFzZS10aGVu LWRlY3JlYXNlLW1pbi1pbnRlcnZhbC1yZXBlYXRpbmctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDMgQEAKK1BBU1MKKworCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS90 aW1lci1pbmNyZWFzZS10aGVuLWRlY3JlYXNlLW1pbi1pbnRlcnZhbC1yZXBlYXRpbmcuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS90aW1lci1pbmNyZWFzZS10aGVuLWRl Y3JlYXNlLW1pbi1pbnRlcnZhbC1yZXBlYXRpbmcuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2Zhc3QvZG9tL3RpbWVyLWluY3JlYXNlLXRoZW4tZGVjcmVhc2UtbWluLWludGVydmFs LXJlcGVhdGluZy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUxIEBACis8aHRtbD4KKzxo ZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIGxvZyhtc2cpIHsKKyAgICB2YXIgZWxlbWVudCA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworICAgIGVsZW1lbnQudGV4dENvbnRlbnQgPSBt c2c7CisgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChlbGVtZW50KTsKKyAgICBkb2N1bWVu dC5ib2R5LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImJyIikpOworfQorCit2 YXIgY291bnQgPSAwOworZnVuY3Rpb24gZmFzdFRpbWVvdXRIYW5kbGVyKCkgeworICAgICsrY291 bnQ7Cit9CisKK2Z1bmN0aW9uIHNsb3dUaW1lb3V0SGFuZGxlcigpIHsKKyAgICAvLyBOb3RlOiB0 aGUgY291bnQgdGhyZXNob2xkIGlzIHRpZWQgc29tZXdoYXQgdG8gdGhlCisgICAgLy8gbWF4VGlt ZXJOZXN0aW5nTGV2ZWwgaW4gRE9NVGltZXIuY3BwLgorICAgIGlmIChjb3VudCA+IDEwKQorICAg ICAgICBsb2coIlBBU1MiKTsKKyAgICBlbHNlCisgICAgICAgIGxvZygiRkFJTCAtLSB0aW1lb3V0 IHJhbiAiICsgY291bnQgKyAiIHRpbWVzIik7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90 aWZ5RG9uZSgpOworfQorCitmdW5jdGlvbiBydW5UZXN0KCkgeworICAgIGlmICghd2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgIGxvZygiVGhpcyB0ZXN0IHJlcXVpcmVzIHRo ZSBMYXlvdXRUZXN0Q29udHJvbGxlciIpOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGxheW91dFRlc3RDb250cm9s bGVyLndhaXRVbnRpbERvbmUoKTsKKworICAgIC8vIE1ha2UgdGltZXJzIHJ1biBubyBtb3JlIG9m dGVuIHRoYW4gb25jZSBwZXIgc2Vjb25kLgorICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNldE1p bmltdW1UaW1lckludGVydmFsKDEuMCk7CisKKyAgICBzZXRJbnRlcnZhbChzbG93VGltZW91dEhh bmRsZXIsIDUwMCk7CisgICAgc2V0SW50ZXJ2YWwoZmFzdFRpbWVvdXRIYW5kbGVyLCAxKTsKKwor ICAgIC8vIEFsbG93IHRpbWVycyB0byBydW4gcXVpY2tseSBhZ2Fpbi4KKyAgICAvLyBJZiB0aGlz IGRvZXNuJ3QgY2F1c2UgdGltZXJzIHRvIGdldCByZS1ldmFsdWF0ZWQgaW1tZWRpYXRlbHksCisg ICAgLy8gdGhlIGZhc3QgdGltZW91dCBoYW5kbGVyIHdvbid0IGdldCBjYWxsZWQgZm9yIHVwIHRv IGEgc2Vjb25kLAorICAgIC8vIHdoaWNoIHdvdWxkIGxlYWQgdG8gcG9vciByZXNwb25zaXZlbmVz cy4KKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRNaW5pbXVtVGltZXJJbnRlcnZhbCgwLjAw NCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKzwv Ym9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvU2tpcHBl ZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQJKHJl dmlzaW9uIDc5Mzg0KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9Ta2lwcGVkCSh3 b3JraW5nIGNvcHkpCkBAIC0xOTY2LDcgKzE5NjYsOSBAQCBwbHVnaW5zL2ludmFsaWRhdGVfcmVj dC5odG1sCiAjIFdlYktpdFRlc3RSdW5uZXIgbmVlZHMgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0 TWluaW11bVRpbWVySW50ZXJ2YWwKIGZhc3QvZG9tL3RpbWVyLWluY3JlYXNlLW1pbi1pbnRlcnZh bC1hbmQtcmVzZXQtcGFydC0xLmh0bWwKIGZhc3QvZG9tL3RpbWVyLWluY3JlYXNlLW1pbi1pbnRl cnZhbC1hbmQtcmVzZXQtcGFydC0yLmh0bWwKK2Zhc3QvZG9tL3RpbWVyLWluY3JlYXNlLW1pbi1p bnRlcnZhbC1yZXBlYXRpbmcuaHRtbAogZmFzdC9kb20vdGltZXItaW5jcmVhc2UtbWluLWludGVy dmFsLmh0bWwKK2Zhc3QvZG9tL3RpbWVyLWluY3JlYXNlLXRoZW4tZGVjcmVhc2UtbWluLWludGVy dmFsLXJlcGVhdGluZy5odG1sCiBmYXN0L2RvbS90aW1lci1pbmNyZWFzZS10aGVuLWRlY3JlYXNl LW1pbi1pbnRlcnZhbC5odG1sCiAKICMjIyBFTkQgT0YgKDIpIENsYXNzaWZpZWQgZmFpbHVyZXMg d2l0aG91dCBidWcgcmVwb3J0cyAoeWV0KQo=