55009 2011-02-22 17:07:57 -0800 nrwt: --platform chromium-gpu doesn't work with --worker-model=processes 2011-02-22 18:09:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke jamesr mihaip ojan tony oldest_to_newest 355712 0 dpranke 2011-02-22 17:07:57 -0800 nrwt: --platform chromium-gpu doesn't work with --worker-model=processes 355714 1 83417 dpranke 2011-02-22 17:10:08 -0800 Created attachment 83417 Patch 355716 2 dpranke 2011-02-22 17:11:54 -0800 Note that there's no unit tests for this ... I have a bunch of patches pending that will revamp how we do versioning and clean up this code, so writing unit tests specifically for this patch will be wasted effort. I tested it by hand on the Mac and it should be fine. 355717 3 83417 jamesr 2011-02-22 17:12:20 -0800 Comment on attachment 83417 Patch R=me 355728 4 83420 dpranke 2011-02-22 17:37:06 -0800 Created attachment 83420 fix baseline_path() to point to the unversioned directory, add tests 355729 5 dpranke 2011-02-22 17:37:36 -0800 so much for thinking testing wasn't worth it ... the first patch didn't work right. The second one adds tests :). 355730 6 83420 jamesr 2011-02-22 17:38:15 -0800 Comment on attachment 83420 fix baseline_path() to point to the unversioned directory, add tests Ahoy! 355741 7 dpranke 2011-02-22 18:09:30 -0800 Committed r79380: <http://trac.webkit.org/changeset/79380> 83417 2011-02-22 17:10:08 -0800 2011-02-22 17:37:03 -0800 Patch bug-55009-20110222171007.patch text/plain 1682 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzkyODMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlOWE2MzhhNTdlNGNiZmE4YmViZDAwNDEwNTU5OGMyODEz YWU4ODUyLi5jYWMwOWRiMmU3ZTk2YWI3NjJkNjQ5YzJiMTM0MDc3NjQ3ZmYyNDk1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDItMjIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbnJ3dDogLS1wbGF0 Zm9ybSBjaHJvbWl1bS1ncHUgZG9lc24ndCB3b3JrIHdpdGggLS13b3JrZXItbW9kZWw9cHJvY2Vz c2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTAw OQorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1 bV9ncHUucHk6CisKIDIwMTEtMDItMjEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5Cmlu ZGV4IGU4Yzc1YzQ0MTIzZGU2YmFjYjNjYTQ1MjY4ZWMxN2Q2Mzk1YzNiY2EuLjQyMDMzMjY3NjNk NTYyMTlkNDYzOGU4ODhiNmFjM2EyNzQzZDAwN2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5CkBAIC00OCwx MSArNDgsMTEgQEAgZGVmIGdldChwbGF0Zm9ybT1Ob25lLCBwb3J0X25hbWU9J2Nocm9taXVtLWdw dScsICoqa3dhcmdzKToKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHJhaXNlIE5vdEltcGxl bWVudGVkRXJyb3IoJ3Vuc3VwcG9ydGVkIHBsYXRmb3JtOiAlcycgJSBwbGF0Zm9ybSkKIAotICAg IGlmIHBvcnRfbmFtZSA9PSAnY2hyb21pdW0tZ3B1LWxpbnV4JzoKKyAgICBpZiBwb3J0X25hbWUu c3RhcnRzd2l0aCgnY2hyb21pdW0tZ3B1LWxpbnV4Jyk6CiAgICAgICAgIHJldHVybiBDaHJvbWl1 bUdwdUxpbnV4UG9ydChwb3J0X25hbWU9cG9ydF9uYW1lLCAqKmt3YXJncykKLSAgICBpZiBwb3J0 X25hbWUgPT0gJ2Nocm9taXVtLWdwdS1tYWMnOgorICAgIGlmIHBvcnRfbmFtZS5zdGFydHN3aXRo KCdjaHJvbWl1bS1ncHUtbWFjJyk6CiAgICAgICAgIHJldHVybiBDaHJvbWl1bUdwdU1hY1BvcnQo cG9ydF9uYW1lPXBvcnRfbmFtZSwgKiprd2FyZ3MpCi0gICAgaWYgcG9ydF9uYW1lID09ICdjaHJv bWl1bS1ncHUtd2luJzoKKyAgICBpZiBwb3J0X25hbWUuc3RhcnRzd2l0aCgnY2hyb21pdW0tZ3B1 LXdpbicpOgogICAgICAgICByZXR1cm4gQ2hyb21pdW1HcHVXaW5Qb3J0KHBvcnRfbmFtZT1wb3J0 X25hbWUsICoqa3dhcmdzKQogICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IoJ3Vuc3VwcG9y dGVkIHBvcnQ6ICVzJyAlIHBvcnRfbmFtZSkKIAo= 83420 2011-02-22 17:37:06 -0800 2011-02-22 17:38:15 -0800 fix baseline_path() to point to the unversioned directory, add tests bug-55009-20110222173705.patch text/plain 5486 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzkyODMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlOWE2MzhhNTdlNGNiZmE4YmViZDAwNDEwNTU5OGMyODEz YWU4ODUyLi5jYWMwOWRiMmU3ZTk2YWI3NjJkNjQ5YzJiMTM0MDc3NjQ3ZmYyNDk1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDItMjIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbnJ3dDogLS1wbGF0 Zm9ybSBjaHJvbWl1bS1ncHUgZG9lc24ndCB3b3JrIHdpdGggLS13b3JrZXItbW9kZWw9cHJvY2Vz c2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTAw OQorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1 bV9ncHUucHk6CisKIDIwMTEtMDItMjEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5Cmlu ZGV4IGU4Yzc1YzQ0MTIzZGU2YmFjYjNjYTQ1MjY4ZWMxN2Q2Mzk1YzNiY2EuLmRiMzNkNTA2MjM0 MzY0NTMxNGRmNDY4MGY2MmMzYWNiNzI3ODU3YjIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5CkBAIC00OCwx MSArNDgsMTEgQEAgZGVmIGdldChwbGF0Zm9ybT1Ob25lLCBwb3J0X25hbWU9J2Nocm9taXVtLWdw dScsICoqa3dhcmdzKToKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHJhaXNlIE5vdEltcGxl bWVudGVkRXJyb3IoJ3Vuc3VwcG9ydGVkIHBsYXRmb3JtOiAlcycgJSBwbGF0Zm9ybSkKIAotICAg IGlmIHBvcnRfbmFtZSA9PSAnY2hyb21pdW0tZ3B1LWxpbnV4JzoKKyAgICBpZiBwb3J0X25hbWUu c3RhcnRzd2l0aCgnY2hyb21pdW0tZ3B1LWxpbnV4Jyk6CiAgICAgICAgIHJldHVybiBDaHJvbWl1 bUdwdUxpbnV4UG9ydChwb3J0X25hbWU9cG9ydF9uYW1lLCAqKmt3YXJncykKLSAgICBpZiBwb3J0 X25hbWUgPT0gJ2Nocm9taXVtLWdwdS1tYWMnOgorICAgIGlmIHBvcnRfbmFtZS5zdGFydHN3aXRo KCdjaHJvbWl1bS1ncHUtbWFjJyk6CiAgICAgICAgIHJldHVybiBDaHJvbWl1bUdwdU1hY1BvcnQo cG9ydF9uYW1lPXBvcnRfbmFtZSwgKiprd2FyZ3MpCi0gICAgaWYgcG9ydF9uYW1lID09ICdjaHJv bWl1bS1ncHUtd2luJzoKKyAgICBpZiBwb3J0X25hbWUuc3RhcnRzd2l0aCgnY2hyb21pdW0tZ3B1 LXdpbicpOgogICAgICAgICByZXR1cm4gQ2hyb21pdW1HcHVXaW5Qb3J0KHBvcnRfbmFtZT1wb3J0 X25hbWUsICoqa3dhcmdzKQogICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IoJ3Vuc3VwcG9y dGVkIHBvcnQ6ICVzJyAlIHBvcnRfbmFtZSkKIApAQCAtODksNiArODksMTAgQEAgY2xhc3MgQ2hy b21pdW1HcHVMaW51eFBvcnQoY2hyb21pdW1fbGludXguQ2hyb21pdW1MaW51eFBvcnQpOgogICAg ICAgICBjaHJvbWl1bV9saW51eC5DaHJvbWl1bUxpbnV4UG9ydC5fX2luaXRfXyhzZWxmLCBwb3J0 X25hbWU9cG9ydF9uYW1lLCAqKmt3YXJncykKICAgICAgICAgX3NldF9ncHVfb3B0aW9ucyhzZWxm KQogCisgICAgZGVmIGJhc2VsaW5lX3BhdGgoc2VsZik6CisgICAgICAgICMgR1BVIGJhc2VsaW5l cyBhcmVuJ3QgeWV0IHZlcnNpb25lZC4KKyAgICAgICAgcmV0dXJuIHNlbGYuX3dlYmtpdF9iYXNl bGluZV9wYXRoKCdjaHJvbWl1bS1ncHUtbGludXgnKQorCiAgICAgZGVmIGJhc2VsaW5lX3NlYXJj aF9wYXRoKHNlbGYpOgogICAgICAgICAjIE1pbWljIHRoZSBMaW51eCAtPiBXaW4gZXhwZWN0YXRp b25zIGZhbGxiYWNrIGluIHRoZSBvcmRpbmFyeSBDaHJvbWl1bSBwb3J0LgogICAgICAgICByZXR1 cm4gKG1hcChzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCwgWydjaHJvbWl1bS1ncHUtbGludXgn LCAnY2hyb21pdW0tZ3B1LXdpbicsICdjaHJvbWl1bS1ncHUnXSkgKwpAQCAtMTEwLDYgKzExNCwx MCBAQCBjbGFzcyBDaHJvbWl1bUdwdU1hY1BvcnQoY2hyb21pdW1fbWFjLkNocm9taXVtTWFjUG9y dCk6CiAgICAgICAgIGNocm9taXVtX21hYy5DaHJvbWl1bU1hY1BvcnQuX19pbml0X18oc2VsZiwg cG9ydF9uYW1lPXBvcnRfbmFtZSwgKiprd2FyZ3MpCiAgICAgICAgIF9zZXRfZ3B1X29wdGlvbnMo c2VsZikKIAorICAgIGRlZiBiYXNlbGluZV9wYXRoKHNlbGYpOgorICAgICAgICAjIEdQVSBiYXNl bGluZXMgYXJlbid0IHlldCB2ZXJzaW9uZWQuCisgICAgICAgIHJldHVybiBzZWxmLl93ZWJraXRf YmFzZWxpbmVfcGF0aCgnY2hyb21pdW0tZ3B1LW1hYycpCisKICAgICBkZWYgYmFzZWxpbmVfc2Vh cmNoX3BhdGgoc2VsZik6CiAgICAgICAgIHJldHVybiAobWFwKHNlbGYuX3dlYmtpdF9iYXNlbGlu ZV9wYXRoLCBbJ2Nocm9taXVtLWdwdS1tYWMnLCAnY2hyb21pdW0tZ3B1J10pICsKICAgICAgICAg ICAgICAgICBjaHJvbWl1bV9tYWMuQ2hyb21pdW1NYWNQb3J0LmJhc2VsaW5lX3NlYXJjaF9wYXRo KHNlbGYpKQpAQCAtMTMwLDYgKzEzOCwxMCBAQCBjbGFzcyBDaHJvbWl1bUdwdVdpblBvcnQoY2hy b21pdW1fd2luLkNocm9taXVtV2luUG9ydCk6CiAgICAgICAgIGNocm9taXVtX3dpbi5DaHJvbWl1 bVdpblBvcnQuX19pbml0X18oc2VsZiwgcG9ydF9uYW1lPXBvcnRfbmFtZSwgKiprd2FyZ3MpCiAg ICAgICAgIF9zZXRfZ3B1X29wdGlvbnMoc2VsZikKIAorICAgIGRlZiBiYXNlbGluZV9wYXRoKHNl bGYpOgorICAgICAgICAjIEdQVSBiYXNlbGluZXMgYXJlbid0IHlldCB2ZXJzaW9uZWQuCisgICAg ICAgIHJldHVybiBzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCgnY2hyb21pdW0tZ3B1LXdpbicp CisKICAgICBkZWYgYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6CiAgICAgICAgIHJldHVybiAo bWFwKHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoLCBbJ2Nocm9taXVtLWdwdS13aW4nLCAnY2hy b21pdW0tZ3B1J10pICsKICAgICAgICAgICAgICAgICBjaHJvbWl1bV93aW4uQ2hyb21pdW1XaW5Q b3J0LmJhc2VsaW5lX3NlYXJjaF9wYXRoKHNlbGYpKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9ncHVfdW5pdHRlc3QucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdV91bml0 dGVzdC5weQppbmRleCBiNzJiMWU2MTE4MGU5NDA5YzllNGIyNzIyMTljZmMzYmMxODBjMzczLi45 YzVkYWU3ZjRkNTEwOGRjZTk0MjJmNTFlOTk1N2JiMzQ1OGMyYWI3IDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdV91bml0dGVz dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9t aXVtX2dwdV91bml0dGVzdC5weQpAQCAtMjksNiArMjksNyBAQCBpbXBvcnQgdW5pdHRlc3QKIGZy b20gd2Via2l0cHkudG9vbCBpbXBvcnQgbW9ja3Rvb2wKIGltcG9ydCBjaHJvbWl1bV9ncHUKIAor ZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydCBpbXBvcnQgZmFjdG9yeQogCiBjbGFzcyBD aHJvbWl1bUdwdVRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiB0ZXN0X2dldF9jaHJv bWl1bV9ncHVfbGludXgoc2VsZik6CkBAIC05NSw2ICs5NiwzMSBAQCBjbGFzcyBDaHJvbWl1bUdw dVRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHBv cnQuX2ZpbGVzeXN0ZW0uZXhpc3RzKHBhdGgpKQogICAgICAgICAgICAgc2VsZi5hc3NlcnRGYWxz ZShwYXRoIGluIGZpbGVzKQogCisgICAgZGVmIHRlc3RfY2hyb21pdW1fZ3B1X192aXN0YShzZWxm KToKKyAgICAgICAgcG9ydCA9IGZhY3RvcnkuZ2V0KCdjaHJvbWl1bS1ncHUtd2luLXZpc3RhJykK KyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMocG9ydC5uYW1lKCksICdjaHJvbWl1bS1ncHUtd2lu LXZpc3RhJykKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMocG9ydC5iYXNlbGluZV9wYXRoKCks IHBvcnQuX3dlYmtpdF9iYXNlbGluZV9wYXRoKCdjaHJvbWl1bS1ncHUtd2luJykpCisKKyAgICBk ZWYgdGVzdF9jaHJvbWl1bV9ncHVfX3hwKHNlbGYpOgorICAgICAgICBwb3J0ID0gZmFjdG9yeS5n ZXQoJ2Nocm9taXVtLWdwdS13aW4teHAnKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhwb3J0 Lm5hbWUoKSwgJ2Nocm9taXVtLWdwdS13aW4teHAnKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFs cyhwb3J0LmJhc2VsaW5lX3BhdGgoKSwgcG9ydC5fd2Via2l0X2Jhc2VsaW5lX3BhdGgoJ2Nocm9t aXVtLWdwdS13aW4nKSkKKworICAgIGRlZiB0ZXN0X2Nocm9taXVtX2dwdV9fd2luNyhzZWxmKToK KyAgICAgICAgcG9ydCA9IGZhY3RvcnkuZ2V0KCdjaHJvbWl1bS1ncHUtd2luLXdpbjcnKQorICAg ICAgICBzZWxmLmFzc2VydEVxdWFscyhwb3J0Lm5hbWUoKSwgJ2Nocm9taXVtLWdwdS13aW4td2lu NycpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuYmFzZWxpbmVfcGF0aCgpLCBwb3J0 Ll93ZWJraXRfYmFzZWxpbmVfcGF0aCgnY2hyb21pdW0tZ3B1LXdpbicpKQorCisgICAgZGVmIHRl c3RfY2hyb21pdW1fZ3B1X19sZW9wYXJkKHNlbGYpOgorICAgICAgICBwb3J0ID0gZmFjdG9yeS5n ZXQoJ2Nocm9taXVtLWdwdS1tYWMtbGVvcGFyZCcpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxz KHBvcnQubmFtZSgpLCAnY2hyb21pdW0tZ3B1LW1hYy1sZW9wYXJkJykKKyAgICAgICAgc2VsZi5h c3NlcnRFcXVhbHMocG9ydC5iYXNlbGluZV9wYXRoKCksIHBvcnQuX3dlYmtpdF9iYXNlbGluZV9w YXRoKCdjaHJvbWl1bS1ncHUtbWFjJykpCisKKyAgICBkZWYgdGVzdF9jaHJvbWl1bV9ncHVfX3Nu b3dsZW9wYXJkKHNlbGYpOgorICAgICAgICBwb3J0ID0gZmFjdG9yeS5nZXQoJ2Nocm9taXVtLWdw dS1tYWMtc25vd2xlb3BhcmQnKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhwb3J0Lm5hbWUo KSwgJ2Nocm9taXVtLWdwdS1tYWMtc25vd2xlb3BhcmQnKQorICAgICAgICBzZWxmLmFzc2VydEVx dWFscyhwb3J0LmJhc2VsaW5lX3BhdGgoKSwgcG9ydC5fd2Via2l0X2Jhc2VsaW5lX3BhdGgoJ2No cm9taXVtLWdwdS1tYWMnKSkKKwogCiBpZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgogICAgIHVu aXR0ZXN0Lm1haW4oKQo=